Index: lams_central/src/java/org/lamsfoundation/lams/gradebook/service/GradeBookService.java
===================================================================
RCS file: /usr/local/cvsroot/lams_central/src/java/org/lamsfoundation/lams/gradebook/service/Attic/GradeBookService.java,v
diff -u -r1.6 -r1.7
--- lams_central/src/java/org/lamsfoundation/lams/gradebook/service/GradeBookService.java 25 Mar 2009 03:05:25 -0000 1.6
+++ lams_central/src/java/org/lamsfoundation/lams/gradebook/service/GradeBookService.java 25 Mar 2009 04:26:45 -0000 1.7
@@ -468,7 +468,7 @@
status = "";
} else if (learnerProgress.getAttemptedActivities() != null
&& learnerProgress.getAttemptedActivities().size() > 0) {
- status = "
";
+ status = "
";
}
}
return status;
@@ -486,7 +486,7 @@
if (learnerProgress != null) {
byte statusByte = learnerProgress.getProgressState(activity);
if (statusByte == LearnerProgress.ACTIVITY_ATTEMPTED) {
- return "
";
+ return "
";
} else if (statusByte == LearnerProgress.ACTIVITY_COMPLETED) {
return "
";
}
Index: lams_central/src/java/org/lamsfoundation/lams/gradebook/web/action/GradeBookAction.java
===================================================================
RCS file: /usr/local/cvsroot/lams_central/src/java/org/lamsfoundation/lams/gradebook/web/action/Attic/GradeBookAction.java,v
diff -u -r1.4 -r1.5
--- lams_central/src/java/org/lamsfoundation/lams/gradebook/web/action/GradeBookAction.java 25 Mar 2009 03:05:25 -0000 1.4
+++ lams_central/src/java/org/lamsfoundation/lams/gradebook/web/action/GradeBookAction.java 25 Mar 2009 04:26:45 -0000 1.5
@@ -129,7 +129,9 @@
if (learner != null) {
gradeBookActivityDTOs = gradeBookService.getGBActivityRowsForLearner(lesson, learner);
} else {
- // TODO: handle error
+ // return null and the grid will report the error
+ logger.error("No learner found for: " + login);
+ return null;
}
} else if (method.equals("activityView")) {
gradeBookActivityDTOs = gradeBookService.getGBActivityRowsForLesson(lesson);
@@ -164,7 +166,7 @@
PrintWriter out = response.getWriter();
out.print(ret);
} else {
- // TODO: handle error
+ logger.error("No lesson could be found for: " + lessonID);
}
return null;
@@ -216,7 +218,9 @@
if(activity != null) {
gradeBookUserDTOs = gradeBookService.getGBUserRowsForActivity(lesson, activity);
} else {
- // TODO: handle error
+ // return null and the grid will report an error
+ logger.error("No activity found for: " + activityID);
+ return null;
}
}
@@ -267,7 +271,7 @@
PrintWriter out = response.getWriter();
out.print(ret);
} else {
- // TODO: handle error
+ logger.error("No lesson could be found for: " + lessonID);
}
return null;
Index: lams_central/src/java/org/lamsfoundation/lams/gradebook/web/action/GradeBookMonitoringAction.java
===================================================================
RCS file: /usr/local/cvsroot/lams_central/src/java/org/lamsfoundation/lams/gradebook/web/action/Attic/GradeBookMonitoringAction.java,v
diff -u -r1.6 -r1.7
--- lams_central/src/java/org/lamsfoundation/lams/gradebook/web/action/GradeBookMonitoringAction.java 25 Mar 2009 03:05:25 -0000 1.6
+++ lams_central/src/java/org/lamsfoundation/lams/gradebook/web/action/GradeBookMonitoringAction.java 25 Mar 2009 04:26:45 -0000 1.7
@@ -143,7 +143,7 @@
}
} else {
- // TODO: handle error
+ logger.error("No lesson could be found for: " + lessonID);
}
return null;
}
@@ -197,7 +197,7 @@
}
} else {
- // TODO: handle error
+ logger.error("Lesson or activity missing for lesson: " + lessonID + "and activity: " + activityID);
}
return null;
}
Index: lams_central/web/gradebook/gradeBookMonitor.jsp
===================================================================
RCS file: /usr/local/cvsroot/lams_central/web/gradebook/Attic/gradeBookMonitor.jsp,v
diff -u -r1.5 -r1.6
--- lams_central/web/gradebook/gradeBookMonitor.jsp 24 Mar 2009 23:35:32 -0000 1.5
+++ lams_central/web/gradebook/gradeBookMonitor.jsp 25 Mar 2009 04:26:45 -0000 1.6
@@ -25,9 +25,10 @@
jQuery("#userView").jqGrid({
caption: "Learner View",
datatype: "xml",
- url: "