Index: lams_central/src/java/org/lamsfoundation/lams/gradebook/web/action/GradeBookAction.java =================================================================== RCS file: /usr/local/cvsroot/lams_central/src/java/org/lamsfoundation/lams/gradebook/web/action/Attic/GradeBookAction.java,v diff -u -r1.11 -r1.12 --- lams_central/src/java/org/lamsfoundation/lams/gradebook/web/action/GradeBookAction.java 3 Apr 2009 04:57:45 -0000 1.11 +++ lams_central/src/java/org/lamsfoundation/lams/gradebook/web/action/GradeBookAction.java 3 Apr 2009 06:35:48 -0000 1.12 @@ -131,7 +131,7 @@ // Get the user gradebook list from the db // A slightly different list is needed for userview or activity view if (view.equals("userView")) { - Integer userID = WebUtil.readIntParam(request, GradeBookConstants.PARAM_LOGIN); + Integer userID = WebUtil.readIntParam(request, "userID"); User learner = (User) userService.findById(User.class, userID); if (learner != null) { gradeBookActivityDTOs = gradeBookService.getGBActivityRowsForLearner(lesson, learner); Index: lams_central/src/java/org/lamsfoundation/lams/gradebook/web/action/GradeBookMonitoringAction.java =================================================================== RCS file: /usr/local/cvsroot/lams_central/src/java/org/lamsfoundation/lams/gradebook/web/action/Attic/GradeBookMonitoringAction.java,v diff -u -r1.9 -r1.10 --- lams_central/src/java/org/lamsfoundation/lams/gradebook/web/action/GradeBookMonitoringAction.java 30 Mar 2009 05:28:06 -0000 1.9 +++ lams_central/src/java/org/lamsfoundation/lams/gradebook/web/action/GradeBookMonitoringAction.java 3 Apr 2009 06:35:48 -0000 1.10 @@ -173,13 +173,13 @@ HttpServletRequest request, HttpServletResponse response) throws Exception { initServices(); Long lessonID = WebUtil.readLongParam(request, AttributeNames.PARAM_LESSON_ID); - String login = WebUtil.readStrParam(request, "id"); + Integer userID = WebUtil.readIntParam(request, "id"); String markStr = WebUtil.readStrParam(request, "mark", true); String feedback = WebUtil.readStrParam(request, "feedback", true); Lesson lesson = lessonService.getLesson(lessonID); - User learner = userService.getUserByLogin(login); + User learner = (User)userService.findById(User.class, userID); - if (lesson != null && learner != null) { + if (lesson != null || learner != null) { if (markStr != null && !markStr.equals("")) { Double mark = Double.parseDouble(markStr); @@ -215,22 +215,22 @@ String method = WebUtil.readStrParam(request, "method"); Long activityID = null; - String login = null; + Integer userID = null; // Fetch the id based on which grid it came from if (method.equals("activityView")) { activityID = WebUtil.readLongParam(request, AttributeNames.PARAM_ACTIVITY_ID); - login = WebUtil.readStrParam(request, "id"); + userID = WebUtil.readIntParam(request, "id"); } else if (method.equals("userView")) { activityID = WebUtil.readLongParam(request, "id"); - login = WebUtil.readStrParam(request, GradeBookConstants.PARAM_LOGIN); + userID = WebUtil.readIntParam(request, "userID"); } String markStr = WebUtil.readStrParam(request, "mark", true); String feedback = WebUtil.readStrParam(request, "feedback", true); Activity activity = monitoringService.getActivityById(activityID); - User learner = userService.getUserByLogin(login); + User learner = (User)userService.findById(User.class, userID); Lesson lesson = lessonService.getLesson(lessonID); if (lesson != null && activity != null && learner != null && activity.isToolActivity()) { Index: lams_central/web/gradebook/gradeBookMonitor.jsp =================================================================== RCS file: /usr/local/cvsroot/lams_central/web/gradebook/Attic/gradeBookMonitor.jsp,v diff -u -r1.14 -r1.15 --- lams_central/web/gradebook/gradeBookMonitor.jsp 3 Apr 2009 06:08:06 -0000 1.14 +++ lams_central/web/gradebook/gradeBookMonitor.jsp 3 Apr 2009 06:35:48 -0000 1.15 @@ -56,7 +56,7 @@ jQuery("#"+subgrid_id).html("
"); jQuery("#"+subgrid_table_id).jqGrid({ datatype: "xml", - url: "/gradebook/gradebook.do?dispatch=getActivityGridData&lessonID=${lessonDetails.lessonID}&method=userView&login=" + userID, + url: "/gradebook/gradebook.do?dispatch=getActivityGridData&lessonID=${lessonDetails.lessonID}&method=userView&userID=" + userID, height: "100%", width: 920, cellEdit:true, @@ -65,7 +65,7 @@ pager: subgrid_table_id + "_pager", rowList:[5,10,20,30], rowNum:10, - cellurl: "/gradebook/gradebookMonitoring.do?dispatch=updateUserActivityGradeBookData&lessonID=${lessonDetails.lessonID}&method=userView&login=" + userID, + cellurl: "/gradebook/gradebookMonitoring.do?dispatch=updateUserActivityGradeBookData&lessonID=${lessonDetails.lessonID}&method=userView&userID=" + userID, colNames: ['Id','Activity','Progress','Outputs', 'Competences', 'Time Taken', 'Activity FeedBack', 'Mark'], colModel: [ {name:'id', width:10, index:'id', sortable:false, hidden:true, hidedlg:true},