Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/action/TimezoneManagementAction.java =================================================================== RCS file: /usr/local/cvsroot/lams_admin/src/java/org/lamsfoundation/lams/admin/web/action/TimezoneManagementAction.java,v diff -u -r1.1.2.2 -r1.1.2.3 --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/action/TimezoneManagementAction.java 31 Mar 2010 19:15:40 -0000 1.1.2.2 +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/action/TimezoneManagementAction.java 1 Apr 2010 20:13:45 -0000 1.1.2.3 @@ -43,7 +43,7 @@ import org.lamsfoundation.lams.web.action.LamsDispatchAction; /** - * Timezone manager. + * Implements time zone manager. * * @author Andrey Balan * @@ -60,7 +60,7 @@ private static ITimezoneService timezoneService; /** - * displays list of all JRE available timezones + * Displays list of all JRE available timezones. */ public ActionForward unspecified(ActionMapping mapping, ActionForm form, HttpServletRequest request, HttpServletResponse response) throws Exception { Index: lams_common/src/java/org/lamsfoundation/lams/timezone/Timezone.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/timezone/Timezone.java,v diff -u -r1.1.2.2 -r1.1.2.3 --- lams_common/src/java/org/lamsfoundation/lams/timezone/Timezone.java 31 Mar 2010 19:15:34 -0000 1.1.2.2 +++ lams_common/src/java/org/lamsfoundation/lams/timezone/Timezone.java 1 Apr 2010 20:13:48 -0000 1.1.2.3 @@ -26,12 +26,18 @@ import java.io.Serializable; /** - * @author Andrey Balan + * Contains timezone id. * + * @author Andrey Balan + * @see java.util.TimeZone + * * @hibernate.class table="lams_timezone" */ public class Timezone implements Serializable { + /** + * Link on Lams wiki timezone help page. + */ public static String TIMEZONE_HELP_PAGE = "LAMS+Configuration"; private static final long serialVersionUID = 6736816209131888523L; @@ -49,6 +55,8 @@ } /** + * Timezone id. This value is a copy of java.util.TimeZone ID. + * * @hibernate.id generator-class="assigned" type="java.lang.String" column="id" */ public String getId() { Index: lams_common/src/java/org/lamsfoundation/lams/timezone/dao/ITimezoneDAO.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/timezone/dao/ITimezoneDAO.java,v diff -u -r1.1.2.1 -r1.1.2.2 --- lams_common/src/java/org/lamsfoundation/lams/timezone/dao/ITimezoneDAO.java 30 Mar 2010 23:50:13 -0000 1.1.2.1 +++ lams_common/src/java/org/lamsfoundation/lams/timezone/dao/ITimezoneDAO.java 1 Apr 2010 20:13:48 -0000 1.1.2.2 @@ -29,16 +29,32 @@ import org.lamsfoundation.lams.timezone.Timezone; /** + * DAO interface for Timezone. * * @author Andrey Balan - * + * @see org.lamsfoundation.lams.timezone.Timezone */ public interface ITimezoneDAO { + /** + * Returns all timezones stored in database. + * + * @return all timezones + */ List getAllTimezones(); + /** + * Removes specified time zone from database. + * + * @param timezone time zone to remove + */ void removeTimezone(Timezone timezone); + /** + * Adds specified time zone to database. + * + * @param timezone time zone to add + */ void addTimezone(Timezone timezone); } Index: lams_common/src/java/org/lamsfoundation/lams/timezone/dao/hibernate/TimezoneDAO.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/timezone/dao/hibernate/TimezoneDAO.java,v diff -u -r1.1.2.1 -r1.1.2.2 --- lams_common/src/java/org/lamsfoundation/lams/timezone/dao/hibernate/TimezoneDAO.java 30 Mar 2010 23:50:14 -0000 1.1.2.1 +++ lams_common/src/java/org/lamsfoundation/lams/timezone/dao/hibernate/TimezoneDAO.java 1 Apr 2010 20:13:48 -0000 1.1.2.2 @@ -35,9 +35,10 @@ import org.springframework.orm.hibernate3.HibernateCallback; /** + * Hibernate implementation of ITimezoneDAO. * * @author Andrey Balan - * + * @see org.lamsfoundation.lams.timezone.dao.ITimezoneDAO */ public class TimezoneDAO extends BaseDAO implements ITimezoneDAO { Index: lams_common/src/java/org/lamsfoundation/lams/timezone/dto/TimezoneDTO.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/timezone/dto/TimezoneDTO.java,v diff -u -r1.1.2.2 -r1.1.2.3 --- lams_common/src/java/org/lamsfoundation/lams/timezone/dto/TimezoneDTO.java 31 Mar 2010 19:15:33 -0000 1.1.2.2 +++ lams_common/src/java/org/lamsfoundation/lams/timezone/dto/TimezoneDTO.java 1 Apr 2010 20:13:48 -0000 1.1.2.3 @@ -38,15 +38,33 @@ */ public class TimezoneDTO { + /** + * timezone id. + */ private String timeZoneId; + /** + * time zone raw offset + */ private Date rawOffset; + /** + * if raw offset is negative + */ private boolean isRawOffsetNegative; + /** + * time zone dst offset + */ private int dstOffset; + /** + * timezone human readable name + */ private String displayName; + /** + * If this timezone is selected. + */ private boolean selected; /** - * Returns new Timezone object with set values. + * Returns new Timezone object with populated values. * * @param timeZone * @param selected Index: lams_common/src/java/org/lamsfoundation/lams/timezone/service/ITimezoneService.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/timezone/service/ITimezoneService.java,v diff -u -r1.1.2.1 -r1.1.2.2 --- lams_common/src/java/org/lamsfoundation/lams/timezone/service/ITimezoneService.java 30 Mar 2010 23:50:13 -0000 1.1.2.1 +++ lams_common/src/java/org/lamsfoundation/lams/timezone/service/ITimezoneService.java 1 Apr 2010 20:13:48 -0000 1.1.2.2 @@ -28,10 +28,25 @@ import org.lamsfoundation.lams.timezone.Timezone; +/** + * Manages Timezones. + * + * @author Andrey Balan + */ public interface ITimezoneService { + /** + * Returns list of default time zones. This list is shown to user on his profile page to choose one of those. + * + * @return list of default time zones + */ List getAllTimezones(); + /** + * Updates list of default time zones. Thus adds new ones and removes ones that are not in specified list. + * + * @param timezones new full list of time zones + */ void updateTimezones(Collection timezones); } Index: lams_common/src/java/org/lamsfoundation/lams/timezone/service/TimezoneService.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/timezone/service/TimezoneService.java,v diff -u -r1.1.2.1 -r1.1.2.2 --- lams_common/src/java/org/lamsfoundation/lams/timezone/service/TimezoneService.java 30 Mar 2010 23:50:13 -0000 1.1.2.1 +++ lams_common/src/java/org/lamsfoundation/lams/timezone/service/TimezoneService.java 1 Apr 2010 20:13:48 -0000 1.1.2.2 @@ -34,8 +34,10 @@ import org.lamsfoundation.lams.timezone.dao.hibernate.TimezoneDAO; /** + * Class implements ITimezoneService. + * * @author Andrey Balan - * + * @see org.lamsfoundation.lams.timezone.service.ITimezoneService */ public class TimezoneService implements ITimezoneService{ Index: lams_common/src/java/org/lamsfoundation/lams/timezone/util/TimezoneComparator.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/timezone/util/TimezoneComparator.java,v diff -u -r1.1.2.1 -r1.1.2.2 --- lams_common/src/java/org/lamsfoundation/lams/timezone/util/TimezoneComparator.java 31 Mar 2010 19:15:34 -0000 1.1.2.1 +++ lams_common/src/java/org/lamsfoundation/lams/timezone/util/TimezoneComparator.java 1 Apr 2010 20:13:48 -0000 1.1.2.2 @@ -32,7 +32,7 @@ /** * * @author Andrey Balan - * + * @see org.lamsfoundation.lams.timezone.Timezone */ public class TimezoneComparator implements Comparator { Index: lams_common/src/java/org/lamsfoundation/lams/timezone/util/TimezoneDTOComparator.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/timezone/util/TimezoneDTOComparator.java,v diff -u -r1.1.2.2 -r1.1.2.3 --- lams_common/src/java/org/lamsfoundation/lams/timezone/util/TimezoneDTOComparator.java 31 Mar 2010 19:15:34 -0000 1.1.2.2 +++ lams_common/src/java/org/lamsfoundation/lams/timezone/util/TimezoneDTOComparator.java 1 Apr 2010 20:13:48 -0000 1.1.2.3 @@ -31,7 +31,7 @@ /** * * @author Andrey Balan - * + * @see org.lamsfoundation.lams.timezone.dto.TimezoneDTO */ public class TimezoneDTOComparator implements Comparator { Index: lams_common/src/java/org/lamsfoundation/lams/usermanagement/User.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/usermanagement/User.java,v diff -u -r1.36.4.5.2.5 -r1.36.4.5.2.6 --- lams_common/src/java/org/lamsfoundation/lams/usermanagement/User.java 30 Mar 2010 23:50:13 -0000 1.36.4.5.2.5 +++ lams_common/src/java/org/lamsfoundation/lams/usermanagement/User.java 1 Apr 2010 20:13:48 -0000 1.36.4.5.2.6 @@ -812,7 +812,7 @@ /** * Returns user's time zone. If NULL, returns server default time zone. * - * @hibernate.property column="timezone" length="64" + * @hibernate.property column="timezone" length="255" * */ public String getTimeZone() {