Index: lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/actions/AuthoringAction.java =================================================================== RCS file: /usr/local/cvsroot/lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/actions/AuthoringAction.java,v diff -u -r1.71.4.2.2.2 -r1.71.4.2.2.3 --- lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/actions/AuthoringAction.java 5 Apr 2010 17:19:18 -0000 1.71.4.2.2.2 +++ lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/actions/AuthoringAction.java 6 Apr 2010 10:15:40 -0000 1.71.4.2.2.3 @@ -207,10 +207,9 @@ forumService = getForumManager(); List topics = null; - Forum forum = null; - try { - forum = forumService.getForumByContentId(contentId); - // if forum does not exist, try to use default content instead. + Forum forum = forumService.getForumByContentId(contentId); + + // if forum does not exist, try to use default content instead. if (forum == null) { forum = forumService.getDefaultContent(contentId); if (forum.getMessages() != null) { @@ -251,16 +250,12 @@ } } } - // initialize attachmentList - List attachmentList = getAttachmentList(sessionMap); - attachmentList.addAll(forum.getAttachments()); + // initialize attachmentList + List attachmentList = getAttachmentList(sessionMap); + attachmentList.addAll(forum.getAttachments()); - // tear down PO to normal object using clone() method - forumForm.setForum((Forum) forum.clone()); - } catch (Exception e) { - AuthoringAction.log.error(e); - return mapping.findForward("error"); - } + // tear down PO to normal object using clone() method + forumForm.setForum((Forum) forum.clone()); // set back STRUTS component value // init it to avoid null exception in following handling @@ -1029,7 +1024,6 @@ ActionMessages errors = new ActionMessages(); SessionMap sessionMap = (SessionMap) request.getSession().getAttribute(form.getSessionMapID()); - ActionMessage ae; try { String modeStr = request.getParameter(AttributeNames.ATTR_MODE); // if (StringUtils.isBlank(form.getForum().getTitle())) {