Fisheye: Tag 1.1.2.1 refers to a dead (removed) revision in file `lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/dbupdates/patch20150731.sql'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/model/AssessmentQuestion.java =================================================================== RCS file: /usr/local/cvsroot/lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/model/AssessmentQuestion.java,v diff -u -r1.23.2.2 -r1.23.2.3 --- lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/model/AssessmentQuestion.java 14 Jul 2015 14:16:36 -0000 1.23.2.2 +++ lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/model/AssessmentQuestion.java 31 Jul 2015 08:05:33 -0000 1.23.2.3 @@ -99,6 +99,9 @@ //only for essay type of question private int minWordsLimit; + //only for hedging mark type of question + private boolean hedgingJustificationEnabled; + // DTO fields: private String answerString; @@ -548,6 +551,18 @@ this.minWordsLimit = minWordsLimit; } + /** + * @hibernate.property column="hedging_justification_enabled" + * @return + */ + public boolean isHedgingJustificationEnabled() { + return hedgingJustificationEnabled; + } + + public void setHedgingJustificationEnabled(boolean hedgingJustificationEnabled) { + this.hedgingJustificationEnabled = hedgingJustificationEnabled; + } + public String getAnswerString() { return answerString; } Index: lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/action/AuthoringAction.java =================================================================== RCS file: /usr/local/cvsroot/lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/action/AuthoringAction.java,v diff -u -r1.36.2.3 -r1.36.2.4 --- lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/action/AuthoringAction.java 14 Jul 2015 14:16:37 -0000 1.36.2.3 +++ lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/action/AuthoringAction.java 31 Jul 2015 08:05:33 -0000 1.36.2.4 @@ -1758,6 +1758,7 @@ form.setAllowRichEditor(question.isAllowRichEditor()); form.setMaxWordsLimit(question.getMaxWordsLimit()); form.setMinWordsLimit(question.getMinWordsLimit()); + form.setHedgingJustificationEnabled(question.isHedgingJustificationEnabled()); if (questionIdx >= 0) { form.setQuestionIndex(new Integer(questionIdx).toString()); } @@ -1858,6 +1859,7 @@ question.setFeedbackOnCorrect(questionForm.getFeedbackOnCorrect()); question.setFeedbackOnPartiallyCorrect(questionForm.getFeedbackOnPartiallyCorrect()); question.setFeedbackOnIncorrect(questionForm.getFeedbackOnIncorrect()); + question.setHedgingJustificationEnabled(questionForm.isHedgingJustificationEnabled()); } // set options Index: lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/action/LearningAction.java =================================================================== RCS file: /usr/local/cvsroot/lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/action/LearningAction.java,v diff -u -r1.42.2.7 -r1.42.2.8 --- lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/action/LearningAction.java 30 Jul 2015 20:53:32 -0000 1.42.2.7 +++ lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/action/LearningAction.java 31 Jul 2015 08:05:33 -0000 1.42.2.8 @@ -802,10 +802,12 @@ } } - //store justificaion of hedging - String answerString = request.getParameter(AssessmentConstants.ATTR_QUESTION_PREFIX + i); - answerString = answerString.replaceAll("[\n\r\f]", ""); - question.setAnswerString(answerString); + //store justification of hedging if enabled + if (question.isHedgingJustificationEnabled()) { + String answerString = request.getParameter(AssessmentConstants.ATTR_QUESTION_PREFIX + i); + answerString = answerString.replaceAll("[\n\r\f]", ""); + question.setAnswerString(answerString); + } } } } @@ -866,8 +868,10 @@ } isAnswered = sumMarkHedging == question.getGrade(); - //verify justification of hedging is provided - isAnswered &= StringUtils.isNotBlank(question.getAnswerString()); + //verify justification of hedging is provided if it was enabled + if (question.isHedgingJustificationEnabled()) { + isAnswered &= StringUtils.isNotBlank(question.getAnswerString()); + } } // check all questions were answered Index: lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/form/AssessmentQuestionForm.java =================================================================== RCS file: /usr/local/cvsroot/lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/form/AssessmentQuestionForm.java,v diff -u -r1.7.2.1 -r1.7.2.2 --- lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/form/AssessmentQuestionForm.java 14 Jul 2015 14:16:37 -0000 1.7.2.1 +++ lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/form/AssessmentQuestionForm.java 31 Jul 2015 08:05:33 -0000 1.7.2.2 @@ -60,6 +60,7 @@ private boolean allowRichEditor; private int maxWordsLimit; private int minWordsLimit; + private boolean hedgingJustificationEnabled; public String getSessionMapID() { return sessionMapID; @@ -245,4 +246,11 @@ this.minWordsLimit = minWordsLimit; } + public boolean isHedgingJustificationEnabled() { + return hedgingJustificationEnabled; + } + + public void setHedgingJustificationEnabled(boolean hedgingJustificationEnabled) { + this.hedgingJustificationEnabled = hedgingJustificationEnabled; + } } Index: lams_tool_assessment/web/pages/authoring/basic.jsp =================================================================== RCS file: /usr/local/cvsroot/lams_tool_assessment/web/pages/authoring/basic.jsp,v diff -u -r1.19.2.1 -r1.19.2.2 --- lams_tool_assessment/web/pages/authoring/basic.jsp 3 Jul 2015 16:36:02 -0000 1.19.2.1 +++ lams_tool_assessment/web/pages/authoring/basic.jsp 31 Jul 2015 08:05:33 -0000 1.19.2.2 @@ -115,7 +115,7 @@ // alert("using clientHeight"); } // alert("doc height "+height); - height -= document.getElementById('TB_iframeContent').offsetTop + 60; + height -= document.getElementById('TB_iframeContent').offsetTop + 140; document.getElementById('TB_iframeContent').style.height = height +"px"; TB_HEIGHT = height + 28; Index: lams_tool_assessment/web/pages/authoring/parts/addmarkhedging.jsp =================================================================== RCS file: /usr/local/cvsroot/lams_tool_assessment/web/pages/authoring/parts/addmarkhedging.jsp,v diff -u -r1.1.2.2 -r1.1.2.3 --- lams_tool_assessment/web/pages/authoring/parts/addmarkhedging.jsp 3 Jul 2015 16:36:02 -0000 1.1.2.2 +++ lams_tool_assessment/web/pages/authoring/parts/addmarkhedging.jsp 31 Jul 2015 08:05:33 -0000 1.1.2.3 @@ -160,6 +160,13 @@ +
+ + +
+
Index: lams_tool_assessment/web/pages/learning/learning.jsp =================================================================== RCS file: /usr/local/cvsroot/lams_tool_assessment/web/pages/learning/learning.jsp,v diff -u -r1.37.2.5 -r1.37.2.6 --- lams_tool_assessment/web/pages/learning/learning.jsp 30 Jul 2015 17:01:51 -0000 1.37.2.5 +++ lams_tool_assessment/web/pages/learning/learning.jsp 31 Jul 2015 08:05:33 -0000 1.37.2.6 @@ -97,10 +97,15 @@ var grade = selects.length == 0 ? 0 : eval(selects.first().find('option:last-child').val()) var totalSelected = countHedgeQuestionSelectTotal(questionIndex); - var textareaValue = $("#question" + questionIndex + "__lamstextarea").val(); - var isButtonEnabled = (totalSelected == grade) && $.trim(textareaValue); + var isButtonEnabled = (totalSelected == grade); + //check if hedging justification is enabled + var justificationTextarea = $("#question" + questionIndex + "__lamstextarea"); + if( justificationTextarea.length) { + isButtonEnabled = isButtonEnabled && $.trim(justificationTextarea.val()); + } + //if totalSelected equals to question's grade - show button if (isButtonEnabled) { $("[type=button][name=submit-hedging-question" + questionIndex + "]").prop("disabled", "").removeClass("button-disabled"); @@ -450,12 +455,10 @@ } else { var grade = ${question.grade}; var totalSelected = countHedgeQuestionSelectTotal(questionIndex); - - var justificationTextareaValue = $("#question" + questionIndex + "__lamstextarea").val(); //if totalSelected not equals to question's grade OR textarea is empty or contains only white-space - show warning if (totalSelected != grade - || !$.trim(justificationTextareaValue)) { + || ${question.hedgingJustificationEnabled} && !$.trim($("#question" + questionIndex + "__lamstextarea").val())) { markHedgingWrongTotalQuestions.push("${status.index}"); } } Index: lams_tool_assessment/web/pages/learning/parts/markhedging.jsp =================================================================== RCS file: /usr/local/cvsroot/lams_tool_assessment/web/pages/learning/parts/markhedging.jsp,v diff -u -r1.2.2.3 -r1.2.2.4 --- lams_tool_assessment/web/pages/learning/parts/markhedging.jsp 30 Jul 2015 17:01:51 -0000 1.2.2.3 +++ lams_tool_assessment/web/pages/learning/parts/markhedging.jsp 31 Jul 2015 08:05:33 -0000 1.2.2.4 @@ -62,19 +62,21 @@ - - - -
- -
- - - - - + + + + +
+ +
+ + + + + + Index: lams_tool_assessment/web/pages/monitoring/parts/userresponse.jsp =================================================================== RCS file: /usr/local/cvsroot/lams_tool_assessment/web/pages/monitoring/parts/userresponse.jsp,v diff -u -r1.7.2.2 -r1.7.2.3 --- lams_tool_assessment/web/pages/monitoring/parts/userresponse.jsp 30 Jul 2015 17:01:51 -0000 1.7.2.2 +++ lams_tool_assessment/web/pages/monitoring/parts/userresponse.jsp 31 Jul 2015 08:05:33 -0000 1.7.2.3 @@ -84,7 +84,9 @@ responseStr +='
'; - responseStr +="${questionResult.answerStringEscaped}"; + + responseStr +="${questionResult.answerStringEscaped}"; + \ No newline at end of file