Index: lams_admin/conf/language/lams/ApplicationResources_en_AU.properties =================================================================== RCS file: /usr/local/cvsroot/lams_admin/conf/language/lams/ApplicationResources_en_AU.properties,v diff -u -r1.92.2.15 -r1.92.2.16 --- lams_admin/conf/language/lams/ApplicationResources_en_AU.properties 31 Jan 2017 23:43:49 -0000 1.92.2.15 +++ lams_admin/conf/language/lams/ApplicationResources_en_AU.properties 8 Feb 2017 19:18:27 -0000 1.92.2.16 @@ -137,7 +137,6 @@ admin.search =Search admin.enable =Enable admin.disable =Disable -admin.register =Register sysadmin.maintain =Maintain LAMS sysadmin.maintain.loginpage =Maintain login page sysadmin.maintain.external.servers =Maintain integrated servers @@ -162,7 +161,6 @@ sysadmin.batch.temp.file.delete =Delete old temporary files sysadmin.job.list =Job list sysadmin.list.job =List scheduled jobs in Quartz queue -sysadmin.register.server =Register server sysadmin.edit.default.tool.content =Edit default tool content cache.maintain =Maintain LAMS cache cache.title =Cache management @@ -173,19 +171,6 @@ cache.button.remove =Remove admin.config.key =Key admin.config.value =Value -admin.register.sitename =Full sitename -admin.register.orgname =Organisation -admin.register.directory =Enable public directory -admin.register.directory.public =Public -admin.register.directory.private =Private -admin.register.heading.title =Register your server with the LAMS Community -admin.register.server.config.title =Server configuration -admin.register.server.stats.title =Server statistics -admin.register.server.config.url =Server URL -admin.register.server.config.version =Server version -admin.register.server.config.build =Server build no. -admin.register.server.config.locale =Server language (Locale) -admin.register.server.config.langdate =Language date label.show.all.users =Show all users msg.group.organisation_id =The organisation_id of this course is msg.subgroup.organisation_id =The organisation_id of this subcourse is @@ -197,7 +182,6 @@ msg.import.2 =Download the user template to create users. msg.import.conclusion =Click the help icon above for more information. label.results.per.page =Results per page -admin.register.server.stats.total.users =Total # of users msg.import.3 =Download the roles template to add users to course/subcourse and assign their roles. error.user.does.not.exist =User does not exist {0} msg.users.created ={0} users were created successfully. @@ -278,7 +262,6 @@ config.xmpp.admin =Chat server admin username config.xmpp.password =Chat server admin password config.allow.direct.lesson.launch =Allow direct lesson launch -config.community.enable =Enable LAMS community config.allow.live.edit =Allow Live Edit config.ldap.provisioning.enabled =Enable provisioning config.ldap.provider.url =LDAP server URL @@ -344,12 +327,6 @@ admin.user.authentication.method =Authentication method config.smtp.user =SMTP user config.smtp.password =SMTP password -admin.register.enableLamsCommunity =Enable lamscommunity.org integration -register.error.field =Required field -register.error.emailRequiredValid =Email is required in valid format -register.success =Your server has successfully been registered with lamscommunity.org. -register.error.noResponseFromLamsCommunity =Did not get a response from lamscommunity.org. -register.error.registrationFailed =Registration has failed. config.header.red5 =Media server config.red5.server.url =Media server URL config.red5.recordings.url =Media server recordings URL Fisheye: Tag 1.11.2.5 refers to a dead (removed) revision in file `lams_admin/src/java/org/lamsfoundation/lams/admin/web/RegisterAction.java'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 1.1.10.2 refers to a dead (removed) revision in file `lams_admin/src/java/org/lamsfoundation/lams/admin/web/RegisterDTO.java'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 1.1.10.4 refers to a dead (removed) revision in file `lams_admin/src/java/org/lamsfoundation/lams/admin/web/RegisterForm.java'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/action/StatisticsAction.java =================================================================== RCS file: /usr/local/cvsroot/lams_admin/src/java/org/lamsfoundation/lams/admin/web/action/StatisticsAction.java,v diff -u -r1.2.2.2 -r1.2.2.3 --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/action/StatisticsAction.java 5 May 2016 07:41:16 -0000 1.2.2.2 +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/action/StatisticsAction.java 8 Feb 2017 19:18:27 -0000 1.2.2.3 @@ -39,15 +39,9 @@ import org.lamsfoundation.lams.web.action.LamsDispatchAction; /** + * Gives the overall statistics for a LAMS server + * * @author Luke Foxton - * - * Gives the overall statistics for a LAMS server - * - * - * - * - * - * */ public class StatisticsAction extends LamsDispatchAction { @@ -59,7 +53,7 @@ // check permission if (!request.isUserInRole(Role.SYSADMIN)) { - request.setAttribute("errorName", "RegisterAction"); + request.setAttribute("errorName", "StatisticsAction"); request.setAttribute("errorMessage", AdminServiceProxy.getMessageService(getServlet().getServletContext()) .getMessage("error.authorisation")); return mapping.findForward("error"); @@ -85,7 +79,7 @@ // check permission if (!request.isUserInRole(Role.SYSADMIN)) { - request.setAttribute("errorName", "RegisterAction"); + request.setAttribute("errorName", "StatisticsAction"); request.setAttribute("errorMessage", AdminServiceProxy.getMessageService(getServlet().getServletContext()) .getMessage("error.authorisation")); return mapping.findForward("error"); Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/action/SysAdminStartAction.java =================================================================== RCS file: /usr/local/cvsroot/lams_admin/src/java/org/lamsfoundation/lams/admin/web/action/SysAdminStartAction.java,v diff -u -r1.17.2.9 -r1.17.2.10 --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/action/SysAdminStartAction.java 27 Sep 2016 06:18:50 -0000 1.17.2.9 +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/action/SysAdminStartAction.java 8 Feb 2017 19:18:27 -0000 1.17.2.10 @@ -61,7 +61,6 @@ links.add(new LinkBean("signupManagement.do", "admin.signup.title")); links.add(new LinkBean("serverlist.do", "sysadmin.maintain.external.servers")); links.add(new LinkBean("ltiConsumerManagement.do", "label.manage.tool.consumers")); - links.add(new LinkBean("register.do", "sysadmin.register.server")); links.add(new LinkBean("toolcontentlist.do", "sysadmin.tool.management")); links.add(new LinkBean("themeManagement.do", "admin.themes.title")); groupedLinks.add(new Object[]{AdminConstants.START_CONFIG_LINKS,links}); Index: lams_admin/src/java/org/lamsfoundation/lams/admin/web/action/ThemeManagementAction.java =================================================================== RCS file: /usr/local/cvsroot/lams_admin/src/java/org/lamsfoundation/lams/admin/web/action/ThemeManagementAction.java,v diff -u -r1.2.4.4 -r1.2.4.5 --- lams_admin/src/java/org/lamsfoundation/lams/admin/web/action/ThemeManagementAction.java 16 Jun 2016 03:10:21 -0000 1.2.4.4 +++ lams_admin/src/java/org/lamsfoundation/lams/admin/web/action/ThemeManagementAction.java 8 Feb 2017 19:18:27 -0000 1.2.4.5 @@ -43,14 +43,9 @@ import org.springframework.web.context.support.WebApplicationContextUtils; /** + * Actions for maintaining and altering system themes + * * @author Luke Foxton - * - * Actions for maintaining and altering system themes - * - * - * - * - * */ public class ThemeManagementAction extends LamsDispatchAction { @@ -63,7 +58,7 @@ // check permission if (!request.isUserInRole(Role.SYSADMIN)) { - request.setAttribute("errorName", "RegisterAction"); + request.setAttribute("errorName", "ThemeManagementAction"); request.setAttribute("errorMessage", AdminServiceProxy.getMessageService(getServlet().getServletContext()) .getMessage("error.authorisation")); return mapping.findForward("error"); Fisheye: Tag 1.14.2.4 refers to a dead (removed) revision in file `lams_admin/web/register.jsp'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_admin/web/WEB-INF/struts-config.xml =================================================================== RCS file: /usr/local/cvsroot/lams_admin/web/WEB-INF/Attic/struts-config.xml,v diff -u -r1.1.2.9 -r1.1.2.10 --- lams_admin/web/WEB-INF/struts-config.xml 30 Nov 2016 01:59:57 -0000 1.1.2.9 +++ lams_admin/web/WEB-INF/struts-config.xml 8 Feb 2017 19:18:26 -0000 1.1.2.10 @@ -18,10 +18,6 @@ type="org.lamsfoundation.lams.admin.web.form.OrgManageForm" /> - @@ -595,37 +591,6 @@ /> - - - - - - - - - - - Index: lams_central/src/java/org/lamsfoundation/lams/authoring/web/ExportToolContentAction.java =================================================================== RCS file: /usr/local/cvsroot/lams_central/src/java/org/lamsfoundation/lams/authoring/web/ExportToolContentAction.java,v diff -u -r1.15.10.4 -r1.15.10.5 --- lams_central/src/java/org/lamsfoundation/lams/authoring/web/ExportToolContentAction.java 11 May 2016 07:07:56 -0000 1.15.10.4 +++ lams_central/src/java/org/lamsfoundation/lams/authoring/web/ExportToolContentAction.java 8 Feb 2017 19:18:23 -0000 1.15.10.5 @@ -49,16 +49,9 @@ import org.springframework.web.context.support.WebApplicationContextUtils; /** - * - * - * - * - * - * * Export tool content action. It needs learingDesignID as input parameter. * * @author Steve.Ni - * @version $Revision$ */ public class ExportToolContentAction extends LamsAction { Index: lams_central/src/java/org/lamsfoundation/lams/authoring/web/ImportToolContentAction.java =================================================================== RCS file: /usr/local/cvsroot/lams_central/src/java/org/lamsfoundation/lams/authoring/web/ImportToolContentAction.java,v diff -u -r1.12.4.3 -r1.12.4.4 --- lams_central/src/java/org/lamsfoundation/lams/authoring/web/ImportToolContentAction.java 11 May 2016 07:07:56 -0000 1.12.4.3 +++ lams_central/src/java/org/lamsfoundation/lams/authoring/web/ImportToolContentAction.java 8 Feb 2017 19:18:23 -0000 1.12.4.4 @@ -24,11 +24,7 @@ package org.lamsfoundation.lams.authoring.web; -import java.io.BufferedOutputStream; import java.io.File; -import java.io.FileOutputStream; -import java.io.InputStream; -import java.io.OutputStream; import java.util.ArrayList; import java.util.HashMap; import java.util.Iterator; @@ -47,32 +43,20 @@ import org.apache.struts.action.ActionForm; import org.apache.struts.action.ActionForward; import org.apache.struts.action.ActionMapping; -import org.lamsfoundation.lams.config.Registration; import org.lamsfoundation.lams.learningdesign.service.IExportToolContentService; import org.lamsfoundation.lams.usermanagement.User; import org.lamsfoundation.lams.usermanagement.dto.UserDTO; import org.lamsfoundation.lams.usermanagement.service.IUserManagementService; -import org.lamsfoundation.lams.util.Configuration; import org.lamsfoundation.lams.util.FileUtil; import org.lamsfoundation.lams.util.MessageService; import org.lamsfoundation.lams.util.WebUtil; import org.lamsfoundation.lams.web.action.LamsAction; -import org.lamsfoundation.lams.web.lamscommunity.LamsCommunityUtil; import org.lamsfoundation.lams.web.session.SessionManager; import org.lamsfoundation.lams.web.util.AttributeNames; import org.springframework.web.context.WebApplicationContext; import org.springframework.web.context.support.WebApplicationContextUtils; /** - * * - * - * - * - * - * - * - * - * * Import tool content servlet. It needs an uploaded learning design zip file. * * @author Steve.Ni @@ -83,7 +67,6 @@ public static final String USER_SERVICE_BEAN_NAME = "userManagementService"; public static final String MESSAGE_SERVICE_BEAN_NAME = "authoringMessageService"; public static final String PARAM_LEARING_DESIGN_ID = "learningDesignID"; - public static final String PARAM_LEARNING_DESIGN_LOCATION = "ldLocation"; public static final String PARAM_LEARNING_FILE_NAME = "fileName"; public static final String ATTR_TOOLS_ERROR_MESSAGE = "toolsErrorMessages"; public static final String ATTR_LD_ERROR_MESSAGE = "ldErrorMessages"; @@ -106,29 +89,6 @@ } //display initial page for upload return mapping.findForward("upload"); - } else if (StringUtils.equals(param, "importLC")) { - // Checking the server is registered - Registration reg = Configuration.getRegistration(); - if (reg == null || reg.isEnableLamsCommunityIntegration() == false) { - request.setAttribute("registered", Boolean.FALSE); - } else { - request.setAttribute("registered", Boolean.TRUE); - } - - // import from lams community, redirect to sso page - if (customCSV != null) { - request.setAttribute(AttributeNames.PARAM_CUSTOM_CSV, customCSV); - } - //display initial lamscommunity import - return mapping.findForward("importLC"); - } else if (StringUtils.equals(param, "importLCFinish")) { - - // uploading the file from lams commmunity, have to feed the - // location from the request - String learningDesignLocation = WebUtil.readStrParam(request, PARAM_LEARNING_DESIGN_LOCATION); - - importLDFromURL(request, learningDesignLocation, customCSV); - return mapping.findForward("successLC"); } else { importLD(request); return mapping.findForward("success"); @@ -221,92 +181,6 @@ } - /** - * Import a LD from a url. - * - * @param request - */ - @SuppressWarnings("unchecked") - private void importLDFromURL(HttpServletRequest request, String learningDesignLocation, String customCSV) { - - List ldErrorMsgs = new ArrayList(); - List toolsErrorMsgs = new ArrayList(); - Long ldId = null; - - String fileExt = WebUtil.readStrParam(request, "ext"); - String fileName = FileUtil.generateUniqueContentFolderID() + "." + fileExt; - - try { - //get shared session - HttpSession ss = SessionManager.getSession(); - //get back login user DTO - UserDTO userDto = (UserDTO) ss.getAttribute(AttributeNames.USER); - User user = (User) getUserService().findById(User.class, userDto.getUserID()); - - // append the lams community auth info - learningDesignLocation = LamsCommunityUtil.appendAuthInfoToURL(learningDesignLocation, user); - - Integer workspaceFolderUid = null; - - File designFile = null; - String uploadPath = FileUtil.createTempDirectory("_uploaded_learningdesign") + File.separator - + FileUtil.getFileName(fileName); - - // get the ld input stream form the location - InputStream is = WebUtil.getResponseInputStreamFromExternalServer(learningDesignLocation, - new HashMap()); - - // Get the output stream to write the file for export - OutputStream out = new BufferedOutputStream(new FileOutputStream(uploadPath)); - - byte[] buffer = new byte[1024]; - int numRead; - long numWritten = 0; - while ((numRead = is.read(buffer)) != -1) { - out.write(buffer, 0, numRead); - numWritten += numRead; - } - log.debug("Path to ld import file: " + uploadPath); - - out.flush(); - out.close(); - is.close(); - - designFile = new File(uploadPath); - - if (designFile == null) { - MessageService msgService = getMessageService(); - log.error("Upload file missing. Filename was " + fileName); - String msg = msgService.getMessage(KEY_MSG_IMPORT_FILE_NOT_FOUND); - ldErrorMsgs.add(msg != null ? msg : "Upload file missing"); - - } else { - - IExportToolContentService service = getExportService(); - Object[] ldResults = service.importLearningDesign(designFile, user, workspaceFolderUid, toolsErrorMsgs, - customCSV); - ldId = (Long) ldResults[0]; - ldErrorMsgs = (List) ldResults[1]; - toolsErrorMsgs = (List) ldResults[2]; - } - } catch (Exception e) { - log.error("Error occured during import", e); - ldErrorMsgs.add(e.getClass().getName() + " " + e.getMessage()); - } - - request.setAttribute(ATTR_LD_ID, ldId); - if ((ldId == null || ldId.longValue() == -1) && ldErrorMsgs.size() == 0) { - MessageService msgService = getMessageService(); - ldErrorMsgs.add(msgService.getMessage(KEY_MSG_IMPORT_FAILED_UNKNOWN_REASON)); - } - if (ldErrorMsgs.size() > 0) { - request.setAttribute(ATTR_LD_ERROR_MESSAGE, ldErrorMsgs); - } - if (toolsErrorMsgs.size() > 0) { - request.setAttribute(ATTR_TOOLS_ERROR_MESSAGE, toolsErrorMsgs); - } - } - //*************************************************************************************** // Private method //*************************************************************************************** Index: lams_central/src/java/org/lamsfoundation/lams/web/HomeAction.java =================================================================== RCS file: /usr/local/cvsroot/lams_central/src/java/org/lamsfoundation/lams/web/HomeAction.java,v diff -u -r1.60.2.28 -r1.60.2.29 --- lams_central/src/java/org/lamsfoundation/lams/web/HomeAction.java 7 Nov 2016 11:13:51 -0000 1.60.2.28 +++ lams_central/src/java/org/lamsfoundation/lams/web/HomeAction.java 8 Feb 2017 19:18:23 -0000 1.60.2.29 @@ -356,20 +356,8 @@ public ActionForward logout(ActionMapping mapping, ActionForm form, HttpServletRequest req, HttpServletResponse res) throws IOException, ServletException { - UserDTO userDTO = (UserDTO) SessionManager.getSession().getAttribute(AttributeNames.USER); - if ((userDTO.getLoggedIntoLamsCommunity() != null) && userDTO.getLoggedIntoLamsCommunity()) { - HomeAction.log.debug("Need to log out user from lamscoomunity"); - req.getSession().invalidate(); - - // redirect to lamscommunity logout servlet to log out. - String url = "http://lamscommunity.org/register/logout?return_url="; - url += URLEncoder.encode(Configuration.get(ConfigurationKeys.SERVER_URL), "UTF8"); - res.sendRedirect(url); - return null; - } else { - req.getSession().invalidate(); - return mapping.findForward("index"); - } + req.getSession().invalidate(); + return mapping.findForward("index"); } private ActionForward displayMessage(ActionMapping mapping, HttpServletRequest req, String messageKey) { Index: lams_central/src/java/org/lamsfoundation/lams/web/IndexAction.java =================================================================== RCS file: /usr/local/cvsroot/lams_central/src/java/org/lamsfoundation/lams/web/IndexAction.java,v diff -u -r1.54.2.14 -r1.54.2.15 --- lams_central/src/java/org/lamsfoundation/lams/web/IndexAction.java 20 Dec 2016 06:03:53 -0000 1.54.2.14 +++ lams_central/src/java/org/lamsfoundation/lams/web/IndexAction.java 8 Feb 2017 19:18:23 -0000 1.54.2.15 @@ -41,7 +41,6 @@ import org.apache.tomcat.util.json.JSONArray; import org.apache.tomcat.util.json.JSONException; import org.apache.tomcat.util.json.JSONObject; -import org.lamsfoundation.lams.config.Registration; import org.lamsfoundation.lams.index.IndexLinkBean; import org.lamsfoundation.lams.usermanagement.Organisation; import org.lamsfoundation.lams.usermanagement.Role; @@ -117,11 +116,6 @@ } else if (StringUtils.equals(method, "lessons")) { return mapping.findForward("lessons"); } - - Registration reg = Configuration.getRegistration(); - if (reg != null) { - request.setAttribute("lamsCommunityEnabled", reg.isEnableLamsCommunityIntegration()); - } // only show the growl warning the first time after a user has logged in & if turned on in configuration Boolean tzWarning = Configuration.getAsBoolean(ConfigurationKeys.SHOW_TIMEZONE_WARNING); Index: lams_central/src/java/org/lamsfoundation/lams/web/ProfileAction.java =================================================================== RCS file: /usr/local/cvsroot/lams_central/src/java/org/lamsfoundation/lams/web/ProfileAction.java,v diff -u -r1.25.2.5 -r1.25.2.6 --- lams_central/src/java/org/lamsfoundation/lams/web/ProfileAction.java 24 Oct 2016 14:55:28 -0000 1.25.2.5 +++ lams_central/src/java/org/lamsfoundation/lams/web/ProfileAction.java 8 Feb 2017 19:18:23 -0000 1.25.2.6 @@ -215,9 +215,6 @@ request.setAttribute("sharedSecret", requestor.getTwoFactorAuthenticationSecret()); } - boolean hasLamsCommunityToken = requestor.getLamsCommunityToken() != null; - request.setAttribute("hasLamsCommunityToken", hasLamsCommunityToken); - themeService = getThemeService(); // Get all the css themes Index: lams_central/src/java/org/lamsfoundation/lams/web/ProfileSaveAction.java =================================================================== RCS file: /usr/local/cvsroot/lams_central/src/java/org/lamsfoundation/lams/web/ProfileSaveAction.java,v diff -u -r1.18.2.7 -r1.18.2.8 --- lams_central/src/java/org/lamsfoundation/lams/web/ProfileSaveAction.java 29 Nov 2016 10:23:21 -0000 1.18.2.7 +++ lams_central/src/java/org/lamsfoundation/lams/web/ProfileSaveAction.java 8 Feb 2017 19:18:23 -0000 1.18.2.8 @@ -133,12 +133,6 @@ Theme cssTheme = (Theme) getService().findById(Theme.class, (Long) userForm.get("userTheme")); requestor.setTheme(cssTheme); - - if ((userForm.get("disableLamsCommunityUsername") != null) - && (Boolean) userForm.get("disableLamsCommunityUsername")) { - requestor.setLamsCommunityToken(null); - requestor.setLamsCommunityUsername(null); - } } getService().saveUser(requestor); Fisheye: Tag 1.3.4.6 refers to a dead (removed) revision in file `lams_central/src/java/org/lamsfoundation/lams/web/lamscommunity/LamsCommunityLoginAction.java'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 1.3.4.4 refers to a dead (removed) revision in file `lams_central/src/java/org/lamsfoundation/lams/web/lamscommunity/LamsCommunityLoginForm.java'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 1.5.2.3 refers to a dead (removed) revision in file `lams_central/src/java/org/lamsfoundation/lams/web/lamscommunity/LamsCommunityUtil.java'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_central/web/editprofile.jsp =================================================================== RCS file: /usr/local/cvsroot/lams_central/web/editprofile.jsp,v diff -u -r1.23.2.12 -r1.23.2.13 --- lams_central/web/editprofile.jsp 8 Dec 2016 04:08:28 -0000 1.23.2.12 +++ lams_central/web/editprofile.jsp 8 Feb 2017 19:18:23 -0000 1.23.2.13 @@ -77,12 +77,6 @@ <%=AuthenticationMethod.DB%> - - - - - -
@@ -237,18 +231,6 @@ ${sharedSecret}
- - -
- - -
-
Index: lams_central/web/index.jsp =================================================================== RCS file: /usr/local/cvsroot/lams_central/web/index.jsp,v diff -u -r1.31.2.3 -r1.31.2.4 --- lams_central/web/index.jsp 27 Jun 2016 10:51:29 -0000 1.31.2.3 +++ lams_central/web/index.jsp 8 Feb 2017 19:18:23 -0000 1.31.2.4 @@ -28,9 +28,4 @@ - - - - - \ No newline at end of file + \ No newline at end of file Index: lams_central/web/WEB-INF/struts-config.xml =================================================================== RCS file: /usr/local/cvsroot/lams_central/web/WEB-INF/Attic/struts-config.xml,v diff -u -r1.1.2.8 -r1.1.2.9 --- lams_central/web/WEB-INF/struts-config.xml 23 Nov 2016 15:28:08 -0000 1.1.2.8 +++ lams_central/web/WEB-INF/struts-config.xml 8 Feb 2017 19:18:23 -0000 1.1.2.9 @@ -18,10 +18,6 @@ type="org.lamsfoundation.lams.web.TextSearchActionForm" /> - @@ -43,11 +39,6 @@ type="org.lamsfoundation.lams.web.planner.PedagogicalPlannerSequenceNodeForm" /> - - @@ -69,9 +60,6 @@ - - - @@ -125,11 +113,6 @@ redirect="false" /> - - - - - - - - - - Fisheye: Tag 1.2.2.3 refers to a dead (removed) revision in file `lams_common/conf/hibernate/mappings/org/lamsfoundation/lams/config/Registration.hbm.xml'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_common/conf/hibernate/mappings/org/lamsfoundation/lams/usermanagement/User.hbm.xml =================================================================== RCS file: /usr/local/cvsroot/lams_common/conf/hibernate/mappings/org/lamsfoundation/lams/usermanagement/User.hbm.xml,v diff -u -r1.35.2.12 -r1.35.2.13 --- lams_common/conf/hibernate/mappings/org/lamsfoundation/lams/usermanagement/User.hbm.xml 29 Nov 2016 09:00:47 -0000 1.35.2.12 +++ lams_common/conf/hibernate/mappings/org/lamsfoundation/lams/usermanagement/User.hbm.xml 8 Feb 2017 19:18:30 -0000 1.35.2.13 @@ -359,27 +359,6 @@ - - true - - @hibernate.property - column="lams_community_token" - length="255" - not-null="false" - - - - - true - - @hibernate.property - column="lams_community_username" - length="255" - not-null="false" - - Index: lams_common/src/java/org/lamsfoundation/lams/commonContext.xml =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/commonContext.xml,v diff -u -r1.100.2.31 -r1.100.2.32 --- lams_common/src/java/org/lamsfoundation/lams/commonContext.xml 8 Dec 2016 10:08:23 -0000 1.100.2.31 +++ lams_common/src/java/org/lamsfoundation/lams/commonContext.xml 8 Feb 2017 19:18:31 -0000 1.100.2.32 @@ -430,7 +430,6 @@ - @@ -587,9 +586,6 @@ - - - Fisheye: Tag 1.1.12.4 refers to a dead (removed) revision in file `lams_common/src/java/org/lamsfoundation/lams/config/Registration.java'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 1.1.12.3 refers to a dead (removed) revision in file `lams_common/src/java/org/lamsfoundation/lams/config/dao/IRegistrationDAO.java'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 1.4.12.4 refers to a dead (removed) revision in file `lams_common/src/java/org/lamsfoundation/lams/config/dao/hibernate/RegistrationDAO.java'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 1.1 refers to a dead (removed) revision in file `lams_common/src/java/org/lamsfoundation/lams/dbupdates/patch2040085.sql'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_common/src/java/org/lamsfoundation/lams/usermanagement/User.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/usermanagement/User.java,v diff -u -r1.50.2.12 -r1.50.2.13 --- lams_common/src/java/org/lamsfoundation/lams/usermanagement/User.java 8 Dec 2016 04:07:52 -0000 1.50.2.12 +++ lams_common/src/java/org/lamsfoundation/lams/usermanagement/User.java 8 Feb 2017 19:18:31 -0000 1.50.2.13 @@ -160,12 +160,6 @@ private Boolean changePassword; /** persistent field */ - private String lamsCommunityToken; - - /** persistent field */ - private String lamsCommunityUsername; - - /** persistent field */ private Boolean tutorialsDisabled; /** persistent field */ @@ -506,8 +500,7 @@ return new UserDTO(userId, firstName, lastName, login, languageIsoCode, countryIsoCode, direction, email, theme != null ? new ThemeDTO(theme) : null, // TimeZone.getTimeZone("Australia/Sydney"), - timeZone, authenticationMethod.getAuthenticationMethodId(), fckLanguageMapping, lamsCommunityToken, - lamsCommunityUsername, + timeZone, authenticationMethod.getAuthenticationMethodId(), fckLanguageMapping, (tutorialsDisabled == null ? false : true), // assume tutorials enabled if not set tutorialPages, (firstLogin == null ? true : false), // assume no firstLogin value means they haven't logged in @@ -596,22 +589,6 @@ this.changePassword = changePassword; } - public String getLamsCommunityToken() { - return lamsCommunityToken; - } - - public void setLamsCommunityToken(String lamsCommunityToken) { - this.lamsCommunityToken = lamsCommunityToken; - } - - public String getLamsCommunityUsername() { - return lamsCommunityUsername; - } - - public void setLamsCommunityUsername(String lamsCommunityUsername) { - this.lamsCommunityUsername = lamsCommunityUsername; - } - public String getTimeZone() { if (timeZone == null) { timeZone = TimeZone.getDefault().getID(); Index: lams_common/src/java/org/lamsfoundation/lams/usermanagement/dao/IRoleDAO.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/usermanagement/dao/IRoleDAO.java,v diff -u -r1.9.14.3 -r1.9.14.4 --- lams_common/src/java/org/lamsfoundation/lams/usermanagement/dao/IRoleDAO.java 11 May 2016 07:07:24 -0000 1.9.14.3 +++ lams_common/src/java/org/lamsfoundation/lams/usermanagement/dao/IRoleDAO.java 8 Feb 2017 19:18:30 -0000 1.9.14.4 @@ -33,7 +33,5 @@ public interface IRoleDAO extends IBaseDAO { User getUserByOrganisationAndRole(Integer userId, Integer roleId, Organisation organisation); - Integer getCountRoleForSystem(final Integer roleId); - Integer getCountRoleForOrg(Integer roleId, Integer orgId, String searchPhrase); } \ No newline at end of file Index: lams_common/src/java/org/lamsfoundation/lams/usermanagement/dao/hibernate/RoleDAO.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/usermanagement/dao/hibernate/RoleDAO.java,v diff -u -r1.12.14.5 -r1.12.14.6 --- lams_common/src/java/org/lamsfoundation/lams/usermanagement/dao/hibernate/RoleDAO.java 11 May 2016 07:07:29 -0000 1.12.14.5 +++ lams_common/src/java/org/lamsfoundation/lams/usermanagement/dao/hibernate/RoleDAO.java 8 Feb 2017 19:18:30 -0000 1.12.14.6 @@ -44,10 +44,6 @@ + "u.id = uo.user.id and " + "uo.organisation = :org and " + "uor.userOrganisation.id = uo.id and " + "uor.role.id = :roleId"; - private final static String COUNT_ROLE = "select count(distinct userOrganisationRole.userOrganisation.user)" - + " from " + UserOrganisationRole.class.getName() + " userOrganisationRole" - + " where userOrganisationRole.role.roleId = :roleId"; - private final static String COUNT_ROLE_FOR_ORG = "select count(distinct uor.userOrganisation.user) from " + UserOrganisationRole.class.getName() + " uor where uor.role.roleId = :roleId" + " and uor.userOrganisation.organisation.organisationId = :orgId"; @@ -59,15 +55,6 @@ } @Override - public Integer getCountRoleForSystem(Integer roleId) { - - Query query = getSession().createQuery(RoleDAO.COUNT_ROLE); - query.setInteger("roleId", roleId.intValue()); - Object value = query.uniqueResult(); - return new Integer(((Number) value).intValue()); - } - - @Override public Integer getCountRoleForOrg(Integer roleId, Integer orgId, String searchPhrase) { StringBuilder queryTextBuilder = new StringBuilder(RoleDAO.COUNT_ROLE_FOR_ORG); if (!StringUtils.isBlank(searchPhrase)) { Index: lams_common/src/java/org/lamsfoundation/lams/usermanagement/dao/hibernate/UserDAO.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/usermanagement/dao/hibernate/UserDAO.java,v diff -u -r1.8.2.7 -r1.8.2.8 --- lams_common/src/java/org/lamsfoundation/lams/usermanagement/dao/hibernate/UserDAO.java 11 Nov 2016 08:48:13 -0000 1.8.2.7 +++ lams_common/src/java/org/lamsfoundation/lams/usermanagement/dao/hibernate/UserDAO.java 8 Feb 2017 19:18:30 -0000 1.8.2.8 @@ -60,7 +60,7 @@ String email = (String) element[4]; UserDTO userDto = new UserDTO(userId, firstName, lastName, login, null, null, null, email, null, null, null, - null, null, null, true, null, false, null); + null, true, null, false, null); userDtos.add(userDto); } Index: lams_common/src/java/org/lamsfoundation/lams/usermanagement/dto/UserDTO.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/usermanagement/dto/UserDTO.java,v diff -u -r1.23.2.6 -r1.23.2.7 --- lams_common/src/java/org/lamsfoundation/lams/usermanagement/dto/UserDTO.java 27 Oct 2016 16:00:52 -0000 1.23.2.6 +++ lams_common/src/java/org/lamsfoundation/lams/usermanagement/dto/UserDTO.java 8 Feb 2017 19:18:31 -0000 1.23.2.7 @@ -49,19 +49,15 @@ private ThemeDTO theme; private TimeZone timeZone; private Integer authenticationMethodId; - private String lamsCommunityToken; - private String lamsCommunityUsername; - private Boolean loggedIntoLamsCommunity; private Boolean tutorialsDisabled; private Set pagesWithDisabledTutorials; private Boolean firstLogin; private Integer lastVisitedOrganisationId; public UserDTO(Integer userID, String firstName, String lastName, String login, String localeLanguage, String localeCountry, String direction, String email, ThemeDTO htmlTheme, TimeZone timezone, - Integer authenticationMethodId, String fckLanguageMapping, String lamsCommunityToken, - String lamsCommunityUsername, Boolean tutorialsDisabled, Set pagesWithDisabledTutorials, - Boolean firstLogin, Integer lastVisitedOrganisationId) { + Integer authenticationMethodId, String fckLanguageMapping, Boolean tutorialsDisabled, + Set pagesWithDisabledTutorials, Boolean firstLogin, Integer lastVisitedOrganisationId) { this.userID = userID; this.firstName = firstName; this.lastName = lastName; @@ -74,8 +70,6 @@ timeZone = timezone; this.authenticationMethodId = authenticationMethodId; this.fckLanguageMapping = fckLanguageMapping; - this.lamsCommunityToken = lamsCommunityToken; - this.lamsCommunityUsername = lamsCommunityUsername; this.tutorialsDisabled = tutorialsDisabled; this.pagesWithDisabledTutorials = pagesWithDisabledTutorials; this.firstLogin = firstLogin; @@ -174,40 +168,13 @@ .append("direction", getDirection()).append("email", getEmail()).append("htmlTheme", getTheme()) .append("timeZone", getTimeZone()).append("authenticationMethodId", getAuthenticationMethodId()) .append("fckLanguageMapping", getFckLanguageMapping()) - .append("lamsCommunityUser", this.getLamsCommunityUsername()) - .append("lamsCommunityToken", this.getLamsCommunityToken()) - .append("loggedIntoLamsCommunity", "" + this.getLoggedIntoLamsCommunity()) .append("tutorialsDisabled", "" + getTutorialsDisabled()).toString(); } public String getFckLanguageMapping() { return fckLanguageMapping; } - public String getLamsCommunityToken() { - return lamsCommunityToken; - } - - public void setLamsCommunityToken(String lamsCommunityToken) { - this.lamsCommunityToken = lamsCommunityToken; - } - - public String getLamsCommunityUsername() { - return lamsCommunityUsername; - } - - public void setLamsCommunityUsername(String lamsCommunityUsername) { - this.lamsCommunityUsername = lamsCommunityUsername; - } - - public Boolean getLoggedIntoLamsCommunity() { - return loggedIntoLamsCommunity; - } - - public void setLoggedIntoLamsCommunity(Boolean loggedIntoLamsCommunity) { - this.loggedIntoLamsCommunity = loggedIntoLamsCommunity; - } - public Boolean getTutorialsDisabled() { return tutorialsDisabled; } Index: lams_common/src/java/org/lamsfoundation/lams/usermanagement/service/IUserManagementService.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/usermanagement/service/IUserManagementService.java,v diff -u -r1.65.2.13 -r1.65.2.14 --- lams_common/src/java/org/lamsfoundation/lams/usermanagement/service/IUserManagementService.java 29 Nov 2016 10:23:23 -0000 1.65.2.13 +++ lams_common/src/java/org/lamsfoundation/lams/usermanagement/service/IUserManagementService.java 8 Feb 2017 19:18:30 -0000 1.65.2.14 @@ -356,14 +356,6 @@ boolean isUserSysAdmin(); /** - * Count the number of unique (distinct) users with a particular role in the system. - * - * @param roleId - * Role ID - */ - Integer getCountRoleForSystem(Integer roleId); - - /** * Count then umber of users with a particular role in a given org. * * @param orgId Index: lams_common/src/java/org/lamsfoundation/lams/usermanagement/service/UserManagementService.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/usermanagement/service/UserManagementService.java,v diff -u -r1.115.2.21 -r1.115.2.22 --- lams_common/src/java/org/lamsfoundation/lams/usermanagement/service/UserManagementService.java 1 Dec 2016 07:43:38 -0000 1.115.2.21 +++ lams_common/src/java/org/lamsfoundation/lams/usermanagement/service/UserManagementService.java 8 Feb 2017 19:18:30 -0000 1.115.2.22 @@ -837,16 +837,6 @@ } @Override - public Integer getCountRoleForSystem(Integer roleId) { - Integer count = roleDAO.getCountRoleForSystem(roleId); - if (count != null) { - return count; - } else { - return new Integer(0); - } - } - - @Override public Integer getCountRoleForOrg(Integer orgId, Integer roleId, String searchPhrase) { Integer count = roleDAO.getCountRoleForOrg(roleId, orgId, searchPhrase); if (count != null) { Index: lams_common/src/java/org/lamsfoundation/lams/util/Configuration.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/util/Configuration.java,v diff -u -r1.24.2.8 -r1.24.2.9 --- lams_common/src/java/org/lamsfoundation/lams/util/Configuration.java 8 Dec 2016 08:54:38 -0000 1.24.2.8 +++ lams_common/src/java/org/lamsfoundation/lams/util/Configuration.java 8 Feb 2017 19:18:30 -0000 1.24.2.9 @@ -40,9 +40,7 @@ import org.jboss.as.controller.client.helpers.Operations; import org.jboss.dmr.ModelNode; import org.lamsfoundation.lams.config.ConfigurationItem; -import org.lamsfoundation.lams.config.Registration; import org.lamsfoundation.lams.config.dao.IConfigurationDAO; -import org.lamsfoundation.lams.config.dao.IRegistrationDAO; import org.lamsfoundation.lams.usermanagement.WorkspaceFolder; import org.quartz.JobBuilder; import org.quartz.JobDetail; @@ -74,7 +72,6 @@ private static Map items = null; protected static IConfigurationDAO configurationDAO; - protected static IRegistrationDAO registrationDAO; protected static MessageService messageService; protected static Scheduler scheduler; @@ -118,10 +115,6 @@ return null; } - public static Registration getRegistration() { - return Configuration.registrationDAO.get(); - } - public static void refreshCache() { Map itemMap = Collections .synchronizedMap(new LinkedHashMap()); @@ -188,10 +181,6 @@ } } - public static void saveOrUpdateRegistration(Registration reg) { - Configuration.registrationDAO.saveOrUpdate(reg); - } - public static void setItemValue(Object obj, String value) { ConfigurationItem item = (ConfigurationItem) obj; item.setValue(value); @@ -315,10 +304,6 @@ return Configuration.messageService; } - public IRegistrationDAO getRegistrationDAO() { - return Configuration.registrationDAO; - } - public void persistUpdate() { updatePublicFolderName(); Configuration.configurationDAO.insertOrUpdateAll(Configuration.items.values()); @@ -336,10 +321,6 @@ Configuration.messageService = messageService; } - public void setRegistrationDAO(IRegistrationDAO registrationDAO) { - Configuration.registrationDAO = registrationDAO; - } - public void setScheduler(Scheduler scheduler) { Configuration.scheduler = scheduler; } Index: lams_common/src/java/org/lamsfoundation/lams/util/ConfigurationKeys.java =================================================================== RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/util/ConfigurationKeys.java,v diff -u -r1.53.2.15 -r1.53.2.16 --- lams_common/src/java/org/lamsfoundation/lams/util/ConfigurationKeys.java 20 Dec 2016 06:03:27 -0000 1.53.2.15 +++ lams_common/src/java/org/lamsfoundation/lams/util/ConfigurationKeys.java 8 Feb 2017 19:18:31 -0000 1.53.2.16 @@ -116,8 +116,6 @@ public static String ALLOW_DIRECT_LESSON_LAUNCH = "AllowDirectLessonLaunch"; - public static String LAMS_COMMUNITY_ENABLE = "LAMS_Community_enable"; - public static String ALLOW_EDIT_ON_FLY = "AllowLiveEdit"; public static String SHOW_ALL_MY_LESSON_LINK = "ShowAllMyLessonLink";