Index: lams_tool_preview/conf/language/lams/ApplicationResources.properties
===================================================================
RCS file: /usr/local/cvsroot/lams_tool_preview/conf/language/lams/ApplicationResources.properties,v
diff -u -r1.7.2.9 -r1.7.2.10
--- lams_tool_preview/conf/language/lams/ApplicationResources.properties 26 Oct 2016 04:18:48 -0000 1.7.2.9
+++ lams_tool_preview/conf/language/lams/ApplicationResources.properties 13 Nov 2016 13:19:19 -0000 1.7.2.10
@@ -61,7 +61,8 @@
label.rating.criterias =Rating criteria
label.add.criteria =Add Criterion
label.your.rating =Your rating is {0} Avg rating {1} out of {2} votes
-label.rate.limits.reminder =Rating limitation: Minimum {0} and Maximum {1}.
+label.rate.limits.reminder =Rate a minimum of {0} and a maximum of {1} users.
+label.rate.all.users =Rate All Users
label.rate.limits.topic.reminder =You have rated {0} users already.
label.rate.limits.reminder.min = You must rate at least {0} users.
label.rate.limits.reminder.max = You can only rate up to {0} users.
Index: lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/web/action/LearningAction.java
===================================================================
RCS file: /usr/local/cvsroot/lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/web/action/LearningAction.java,v
diff -u -r1.5.2.5 -r1.5.2.6
--- lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/web/action/LearningAction.java 21 Oct 2016 03:40:48 -0000 1.5.2.5
+++ lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/web/action/LearningAction.java 13 Nov 2016 13:19:19 -0000 1.5.2.6
@@ -537,13 +537,23 @@
(criteria.isCommentRating() || criteria.isStarStyleRating()), PeerreviewConstants.SORT_BY_USERNAME_ASC, null,
peerreview.isSelfReview(), true );
- // override the min/max for stars based on old settings if needed (original Peer Review kept one setting for all criteria )
- if ( ( peerreview.getMinimumRates() > 0 || peerreview.getMaximumRates() > 0 ) &&
- ( dto.getRatingCriteria().getMinimumRates() == 0 && dto.getRatingCriteria().getMaximumRates() == 0 ) ) {
- dto.getRatingCriteria().setMinimumRates(peerreview.getMinimumRates());
- dto.getRatingCriteria().setMaximumRates(peerreview.getMaximumRates());
+ // Send the number of users to rate in rateAll, or send 0. Do not want to modify the criteria min/max as it is originally
+ // a Hibernate object and don't want to risk updating it in the db. Need to send a flag so why not make flag double as the
+ // runtime min/max value while leaving min/max as the original criteria definition.
+ int rateAllUsers = 0;
+ if ( ( criteria.isRankingStyleRating() && criteria.getMaxRating() == RatingCriteria.RATING_RANK_ALL ) ||
+ ( criteria.isStarStyleRating() && criteria.getMinimumRates() == RatingCriteria.RATING_RANK_ALL ) ) {
+ rateAllUsers = service.getCountUsersBySession(toolSessionId, peerreview.isSelfReview() ? -1 : userId);
+ } else if ( criteria.isStarStyleRating() &&
+ ( peerreview.getMinimumRates() > 0 || peerreview.getMaximumRates() > 0 ) &&
+ ( dto.getRatingCriteria().getMinimumRates() == 0 && dto.getRatingCriteria().getMaximumRates() == 0 ) ) {
+ // override the min/max for stars based on old settings if needed (original Peer Review kept one setting for all criteria )
+ // does not matter if this change gets persisted to database.
+ criteria.setMinimumRates(peerreview.getMinimumRates());
+ criteria.setMaximumRates(peerreview.getMaximumRates());
}
+ request.setAttribute("rateAllUsers",rateAllUsers);
request.setAttribute("criteriaRatings", dto);
return mapping.findForward(PeerreviewConstants.SUCCESS);
}
Index: lams_tool_preview/web/WEB-INF/tags/AuthoringRatingAllStyleCriteria.tag
===================================================================
RCS file: /usr/local/cvsroot/lams_tool_preview/web/WEB-INF/tags/Attic/AuthoringRatingAllStyleCriteria.tag,v
diff -u -r1.1.2.4 -r1.1.2.5
--- lams_tool_preview/web/WEB-INF/tags/AuthoringRatingAllStyleCriteria.tag 11 Nov 2016 03:38:04 -0000 1.1.2.4
+++ lams_tool_preview/web/WEB-INF/tags/AuthoringRatingAllStyleCriteria.tag 13 Nov 2016 13:19:19 -0000 1.1.2.5
@@ -196,9 +196,15 @@
reactivateArrows();
}
- function generateSelect(id, validate, zeroDescription, orderId, currentValue) {
- var str = '