Index: lams_common/.classpath
===================================================================
RCS file: /usr/local/cvsroot/lams_common/.classpath,v
diff -u -r1.25.2.31 -r1.25.2.32
--- lams_common/.classpath 23 Nov 2016 20:14:11 -0000 1.25.2.31
+++ lams_common/.classpath 11 Feb 2017 03:32:39 -0000 1.25.2.32
@@ -3,7 +3,6 @@
-
@@ -26,7 +25,7 @@
-
+
@@ -46,6 +45,7 @@
+
Fisheye: Tag 1.1.2.2 refers to a dead (removed) revision in file `lams_common/.settings/org.jboss.ide.eclipse.as.core.prefs'.
Fisheye: No comparison available. Pass `N' to diff?
Index: lams_common/src/java/org/lamsfoundation/lams/rating/service/RatingService.java
===================================================================
RCS file: /usr/local/cvsroot/lams_common/src/java/org/lamsfoundation/lams/rating/service/RatingService.java,v
diff -u -r1.1.2.12 -r1.1.2.13
--- lams_common/src/java/org/lamsfoundation/lams/rating/service/RatingService.java 8 Dec 2016 00:15:30 -0000 1.1.2.12
+++ lams_common/src/java/org/lamsfoundation/lams/rating/service/RatingService.java 11 Feb 2017 03:32:39 -0000 1.1.2.13
@@ -378,9 +378,9 @@
mapOrderIdToRatingCriteria.put(ratingCriteriaIter.getOrderId(), ratingCriteriaIter);
}
- for ( Map.Entry entry : request.getParameterMap().entrySet()) {
- log.debug("entry: "+entry.getKey()+" "+entry.getValue());
- }
+// for ( Map.Entry entry : request.getParameterMap().entrySet()) {
+// log.debug("entry: "+entry.getKey()+" "+entry.getValue());
+// }
int criteriaMaxOrderId = WebUtil.readIntParam(request, "criteriaMaxOrderId");
// i is equal to an old orderId
@@ -415,13 +415,14 @@
maxRatings = WebUtil.readIntParam(request, "maximumRates" + i, true);
}
- if ( ratingStyle == RatingCriteria.RATING_STYLE_COMMENT ) {
- explicitCommentTypeFound = true;
- }
boolean commentsEnabled = ( ratingStyle != RatingCriteria.RATING_STYLE_COMMENT ? WebUtil.readBooleanParam(request, "enableComments" + i, false) : true );
RatingCriteria ratingCriteria = mapOrderIdToRatingCriteria.get(i);
+ if ( ratingStyle == RatingCriteria.RATING_STYLE_COMMENT || (ratingCriteria != null && ratingCriteria.isCommentRating()) ) {
+ explicitCommentTypeFound = true;
+ }
+
if (StringUtils.isNotBlank(criteriaTitle)) {
int newCriteriaOrderId = WebUtil.readIntParam(request, "criteriaOrderId" + i);