Index: lams_tool_daco/conf/language/lams/ApplicationResources.properties
===================================================================
RCS file: /usr/local/cvsroot/lams_tool_daco/conf/language/lams/ApplicationResources.properties,v
diff -u -r1.24.2.6 -r1.24.2.7
--- lams_tool_daco/conf/language/lams/ApplicationResources.properties	4 Dec 2016 01:00:02 -0000	1.24.2.6
+++ lams_tool_daco/conf/language/lams/ApplicationResources.properties	28 Feb 2017 11:20:15 -0000	1.24.2.7
@@ -252,6 +252,9 @@
 label.monitoring.average.number.records.heading  =Average Number of Records
 label.activity.completion  =End of activity
 label.notifications  =Notifications
+errors.maxfilesize  =Uploaded file exceeded maximum size: {0}
+error.attachment.executable  =Uploaded file is executable
+error.attachment.must.be.image  =Allowed file formats: JPG, GIF or PNG.
+label.upload.info  =Uploaded file must not be executable and not exceed size of {0}
 
-
 #======= End labels: Exported 246 labels for en AU =====
Index: lams_tool_daco/web/WEB-INF/tags/AuthoringButton.tag
===================================================================
RCS file: /usr/local/cvsroot/lams_tool_daco/web/WEB-INF/tags/AuthoringButton.tag,v
diff -u -r1.12.2.3 -r1.12.2.4
--- lams_tool_daco/web/WEB-INF/tags/AuthoringButton.tag	13 Dec 2016 04:19:05 -0000	1.12.2.3
+++ lams_tool_daco/web/WEB-INF/tags/AuthoringButton.tag	28 Feb 2017 11:21:28 -0000	1.12.2.4
@@ -123,10 +123,10 @@
     }  				
 </script>	
 <div id="saveCancelButtons" >
-		<html:link href="javascript:doSubmit_Form_Only();" property="submit" styleId="saveButton" styleClass="btn btn-primary pull-right">
+		<html:link href="javascript:doSubmit_Form_Only();" styleId="saveButton" property="submit" styleClass="btn btn-primary pull-right">
 			<span class="okIcon"><fmt:message key="${saveButtonLabelKey}" /></span>
 		</html:link>
-		<html:link href="javascript:;" property="cancel" onclick="javascript:doCancel()" styleId="cancelButton" styleClass="btn btn-default roffset5 pull-right">
+		<html:link href="javascript:;" property="cancel" styleId="cancelButton" onclick="javascript:doCancel()" styleClass="btn btn-default roffset5 pull-right">
 			<span class="cancelIcon"><fmt:message key="${cancelButtonLabelKey}" /></span>
 		</html:link>
 </div>
Fisheye: Tag 1.1 refers to a dead (removed) revision in file `lams_tool_daco/web/WEB-INF/tags/FileUpload.tag'.
Fisheye: No comparison available.  Pass `N' to diff?
Fisheye: Tag 1.1 refers to a dead (removed) revision in file `lams_tool_daco/web/WEB-INF/tags/WaitingSpinner.tag'.
Fisheye: No comparison available.  Pass `N' to diff?
Index: lams_tool_daco/web/WEB-INF/tlds/lams/lams.tld
===================================================================
RCS file: /usr/local/cvsroot/lams_tool_daco/web/WEB-INF/tlds/lams/lams.tld,v
diff -u -r1.6.2.10 -r1.6.2.11
--- lams_tool_daco/web/WEB-INF/tlds/lams/lams.tld	25 Nov 2016 17:08:57 -0000	1.6.2.10
+++ lams_tool_daco/web/WEB-INF/tlds/lams/lams.tld	28 Feb 2017 11:21:28 -0000	1.6.2.11
@@ -529,5 +529,13 @@
        <name>CommentsAuthor</name>
        <path>/WEB-INF/tags/CommentsAuthor.tag</path>
    	</tag-file>
+   	<tag-file>
+       <name>FileUpload</name>
+       <path>/WEB-INF/tags/FileUpload.tag</path>
+   	</tag-file>
+   	<tag-file>
+       <name>WaitingSpinner</name>
+       <path>/WEB-INF/tags/WaitingSpinner.tag</path>
+   	</tag-file>
 
 </taglib>
Index: lams_tool_daco/web/includes/css/daco.css
===================================================================
RCS file: /usr/local/cvsroot/lams_tool_daco/web/includes/css/daco.css,v
diff -u -r1.9.2.2 -r1.9.2.3
--- lams_tool_daco/web/includes/css/daco.css	27 Apr 2016 13:07:07 -0000	1.9.2.2
+++ lams_tool_daco/web/includes/css/daco.css	28 Feb 2017 11:21:28 -0000	1.9.2.3
@@ -44,6 +44,10 @@
 form#recordForm input, form#recordForm textarea, form#recordForm select{
 	margin-top: 6px;
 }
+/* overrides form#recordForm input for file input */
+form#recordForm input.file-input-name{ 
+	margin-top: 0px;
+}
 div.bigNumber{
 	font-weight: bold;
 	font-size: larger;
Index: lams_tool_daco/web/includes/javascript/dacoLearning.js
===================================================================
RCS file: /usr/local/cvsroot/lams_tool_daco/web/includes/javascript/dacoLearning.js,v
diff -u -r1.5.12.4 -r1.5.12.5
--- lams_tool_daco/web/includes/javascript/dacoLearning.js	15 Feb 2017 05:29:07 -0000	1.5.12.4
+++ lams_tool_daco/web/includes/javascript/dacoLearning.js	28 Feb 2017 11:21:28 -0000	1.5.12.5
@@ -18,11 +18,52 @@
 		$('.btn-disable-on-submit').prop('disabled', true);
 		document.location.href=continueReflectUrl;
 	}
+
+	function getFile(errorId) {
+		var arr = errorId.split('-');
+		if ( arr.length > 1 ) {
+			var filenum = arr[1];
+			var fileSelect = document.getElementById('file-'+filenum);
+			if ( fileSelect ) {
+				var files = fileSelect.files;
+				if (files.length > 0) {
+					return files[0];
+				}
+			}
+		}
+		return null;
+	}
 	
 	function saveOrUpdateRecord()	{
-		$('.btn-disable-on-submit').prop('disabled', true);
-		setHiddenFormValues();
-		document.getElementById("recordForm").submit();
+		var valid = true;
+		
+		$('[id^=fileerror-]').each(function(index, element) {
+			console.log(element);
+			var file = getFile(element.id);
+			if ( file ) { 
+				if ( ! validateShowErrorNotExecutable(file, LABEL_NOT_ALLOWED_EXE, false, EXE_STRING, element.id ) || 
+						! validateShowErrorFileSize(file, UPLOAD_FILE_MAX_SIZE, LABEL_MAX_FILE_SIZE, false, element.id) ) {
+					valid = false;
+				}
+			}
+		});
+		$('[id^=imageerror-]').each(function(index, element) {
+			console.log(element);
+			var file = getFile(element.id);
+			if ( file ) { 
+				if ( ! validateShowErrorImageType(file, LABEL_NOT_ALLOWED_FORMAT, false, element.id ) ||
+						! validateShowErrorFileSize(file, UPLOAD_FILE_MAX_SIZE, LABEL_MAX_FILE_SIZE, false, element.id) ) {
+					valid = false;
+				}
+			}
+		});
+		
+		if ( valid ) {
+			$('.btn-disable-on-submit').prop('disabled', true);
+			setHiddenFormValues();
+			document.getElementById("recordForm").submit();
+		}
+		return valid;
 	}
 	
 	function setHiddenFormValues(){
Index: lams_tool_daco/web/pages/learning/addRecord.jsp
===================================================================
RCS file: /usr/local/cvsroot/lams_tool_daco/web/pages/learning/addRecord.jsp,v
diff -u -r1.9.2.4 -r1.9.2.5
--- lams_tool_daco/web/pages/learning/addRecord.jsp	15 Feb 2017 05:29:07 -0000	1.9.2.4
+++ lams_tool_daco/web/pages/learning/addRecord.jsp	28 Feb 2017 11:21:28 -0000	1.9.2.5
@@ -159,15 +159,19 @@
 							<c:if test="${horizontal}">
 								</td><td style="vertical-align: middle;">
 							</c:if>
-							<html:file styleId="file-${fileNumber+1}" property="file[${fileNumber}]" size="50"/>
+							<lams:FileUpload fileFieldId="file-${fileNumber+1}" fileFieldname="file[${fileNumber}]" 
+								fileInputMessageKey="label.authoring.basic.file" maxFileSize="${UPLOAD_FILE_MAX_SIZE_AS_USER_STRING}"
+								fileButtonBrowse="fileButtonBrowse-${fileNumber+1}" fileInputNameFieldname="fileInputName-${fileNumber+1}" errorMsgDiv="fileerror-${fileNumber+1}"/>
 							<c:set var="fileNumber" value="${fileNumber+1}" />
 						</c:when>
-						<c:when test="${question.type==6}"><%-- Image --%>
+						<c:when test="${question.type==6}"><%-- Image --%>  
 							<div class="hint"><fmt:message key="label.learning.image.hint" /></div>
 							<c:if test="${horizontal}">
 								</td><td style="vertical-align: middle;">
 							</c:if>
-							<html:file styleId="file-${fileNumber+1}" property="file[${fileNumber}]" size="50" />
+							<lams:FileUpload fileFieldId="file-${fileNumber+1}" fileFieldname="file[${fileNumber}]" 
+								fileInputMessageKey="label.authoring.basic.image" maxFileSize="${UPLOAD_FILE_MAX_SIZE_AS_USER_STRING}"
+								fileButtonBrowse="fileButtonBrowse-${fileNumber+1}" fileInputNameFieldname="fileInputName-${fileNumber+1}" errorMsgDiv="imageerror-${fileNumber+1}"/>
 							<c:set var="fileNumber" value="${fileNumber+1}" />
 						</c:when>
 						<c:when test="${question.type==7}"><%-- Radio buttons  --%>
@@ -246,7 +250,7 @@
 		</table>
 
 		<c:if test="${mode != 'teacher'}">
-			<button onclick="javascript:saveOrUpdateRecord()" class="btn btn-sm btn-default btn-disable-on-submit voffset5 pull-left"><i class="fa fa-plus"></i> <fmt:message key="label.learning.add" /></button>
+			<button type="submit" onclick="return saveOrUpdateRecord();" class="btn btn-sm btn-default btn-disable-on-submit voffset5 pull-left"><i class="fa fa-plus"></i> <fmt:message key="label.learning.add" /></button>
 		</c:if>
 	</html:form>
 </div>
Index: lams_tool_daco/web/pages/learning/learning.jsp
===================================================================
RCS file: /usr/local/cvsroot/lams_tool_daco/web/pages/learning/learning.jsp,v
diff -u -r1.12.2.10 -r1.12.2.11
--- lams_tool_daco/web/pages/learning/learning.jsp	15 Feb 2017 05:29:07 -0000	1.12.2.10
+++ lams_tool_daco/web/pages/learning/learning.jsp	28 Feb 2017 11:21:28 -0000	1.12.2.11
@@ -1,12 +1,18 @@
 <!DOCTYPE html>
-        
-
 <%@ include file="/common/taglibs.jsp"%>
 <%@ page import="org.lamsfoundation.lams.tool.daco.DacoConstants"%>
+<%@ page import="org.lamsfoundation.lams.util.Configuration" %>
+<%@ page import="org.lamsfoundation.lams.util.ConfigurationKeys" %>
+<%@ page import="org.lamsfoundation.lams.util.FileValidatorUtil" %>
+<c:set var="UPLOAD_FILE_MAX_SIZE"><%=Configuration.get(ConfigurationKeys.UPLOAD_FILE_MAX_SIZE)%></c:set>
+<c:set var="UPLOAD_FILE_MAX_SIZE_AS_USER_STRING" scope="request"><%=FileValidatorUtil.formatSize(Configuration.getAsInt(ConfigurationKeys.UPLOAD_FILE_MAX_SIZE))%></c:set>
+<c:set var="EXE_STRING"><%=Configuration.get(ConfigurationKeys.EXE_EXTENSIONS)%></c:set>
+
 <lams:html>
 <lams:head>
 	<title><fmt:message key="label.learning.title" /></title>
 	<%@ include file="/common/header.jsp"%>
+	<script type="text/javascript" src="${lams}includes/javascript/upload.js"></script>		
 	
 	<c:if test="${not empty param.sessionMapID}">
 		<c:set var="sessionMapID" value="${param.sessionMapID}" />
@@ -37,6 +43,18 @@
 	 	var finishUrl = '<c:url value="/learning/finish.do?sessionMapID=${sessionMapID}&displayedRecordNumber=${displayedRecordNumber}"/>';
 	 	var continueReflectUrl = '<c:url value="/learning/startReflection.do?sessionMapID=${sessionMapID}&displayedRecordNumber=${displayedRecordNumber}"/>';
 	 	var refreshQuestionSummariesUrl = '<c:url value="/learning/refreshQuestionSummaries.do"/>';
+		var UPLOAD_FILE_MAX_SIZE = '${UPLOAD_FILE_MAX_SIZE}';
+	 	var EXE_STRING = '${EXE_STRING}';
+	 	
+		<fmt:message key="errors.maxfilesize" var="LABEL_MAX_FILE_SIZE_VAR"><param>{0}</param></fmt:message>
+		var LABEL_MAX_FILE_SIZE = '<c:out value="${LABEL_MAX_FILE_SIZE_VAR}" />';
+		
+		<fmt:message key="error.attachment.executable" var="LABEL_NOT_ALLOWED_EXE_VAR"/>
+		var LABEL_NOT_ALLOWED_EXE = '<c:out value="${LABEL_NOT_ALLOWED_EXE_VAR}" />';	
+
+		<fmt:message key="error.attachment.must.be.image" var="LABEL_NOT_ALLOWED_FORMAT_VAR"/>
+		var LABEL_NOT_ALLOWED_FORMAT = '<c:out value="${LABEL_NOT_ALLOWED_FORMAT_VAR}" />';	
+
     </script>
     <script type="text/javascript" src="<html:rewrite page='/includes/javascript/dacoLearning.js'/>"></script>
 </lams:head>