Index: lams_tool_task/conf/language/lams/ApplicationResources.properties =================================================================== RCS file: /usr/local/cvsroot/lams_tool_task/conf/language/lams/ApplicationResources.properties,v diff -u -r1.44.2.5 -r1.44.2.6 --- lams_tool_task/conf/language/lams/ApplicationResources.properties 17 Feb 2017 06:17:43 -0000 1.44.2.5 +++ lams_tool_task/conf/language/lams/ApplicationResources.properties 1 Mar 2017 04:54:46 -0000 1.44.2.6 @@ -40,7 +40,7 @@ label.authoring.basic.resource.delete =Delete label.authoring.basic.resource.title.input =Title label.authoring.basic.resource.description.input =Description -label.authoring.choosefile.button =Choose file +label.authoring.choosefile.button =File label.authoring.advance.allow.contribute.tasks =Allow Learners to contribute tasks label.authoring.advance.lock.on.finished =Lock when finished label.authoring.advance.monitor.verification.required =Monitor needs to verify these tasks before letting Learners to complete activity @@ -167,7 +167,8 @@ label.confirm =Confirm label.task.options =Task options label.activity.completion =End of activity -errors.maxfilesize =The uploaded file has exceeded the maximum file size limit of {0} bytes. +errors.maxfilesize =Uploaded file exceeded maximum size: {0} +error.attachment.executable =Uploaded file is executable +label.upload.info =Uploaded file must not be executable and not exceed size of {0} - #======= End labels: Exported 162 labels for en AU ===== Index: lams_tool_task/conf/language/lams/ApplicationResources_en_AU.properties =================================================================== RCS file: /usr/local/cvsroot/lams_tool_task/conf/language/lams/ApplicationResources_en_AU.properties,v diff -u -r1.41.2.4 -r1.41.2.5 --- lams_tool_task/conf/language/lams/ApplicationResources_en_AU.properties 17 Feb 2017 06:17:44 -0000 1.41.2.4 +++ lams_tool_task/conf/language/lams/ApplicationResources_en_AU.properties 1 Mar 2017 04:54:46 -0000 1.41.2.5 @@ -40,7 +40,7 @@ label.authoring.basic.resource.delete =Delete label.authoring.basic.resource.title.input =Title label.authoring.basic.resource.description.input =Description -label.authoring.choosefile.button =Choose file +label.authoring.choosefile.button =File label.authoring.advance.allow.contribute.tasks =Allow Learners to contribute tasks label.authoring.advance.lock.on.finished =Lock when finished label.authoring.advance.monitor.verification.required =Monitor needs to verify these tasks before letting Learners to complete activity Index: lams_tool_task/web/WEB-INF/tags/AuthoringButton.tag =================================================================== RCS file: /usr/local/cvsroot/lams_tool_task/web/WEB-INF/tags/AuthoringButton.tag,v diff -u -r1.13.2.2 -r1.13.2.3 --- lams_tool_task/web/WEB-INF/tags/AuthoringButton.tag 13 Dec 2016 04:39:19 -0000 1.13.2.2 +++ lams_tool_task/web/WEB-INF/tags/AuthoringButton.tag 1 Mar 2017 04:54:46 -0000 1.13.2.3 @@ -123,7 +123,7 @@ }
- + Fisheye: Tag 1.1 refers to a dead (removed) revision in file `lams_tool_task/web/WEB-INF/tags/FileUpload.tag'. Fisheye: No comparison available. Pass `N' to diff? Fisheye: Tag 1.1 refers to a dead (removed) revision in file `lams_tool_task/web/WEB-INF/tags/WaitingSpinner.tag'. Fisheye: No comparison available. Pass `N' to diff? Index: lams_tool_task/web/WEB-INF/tlds/lams/lams.tld =================================================================== RCS file: /usr/local/cvsroot/lams_tool_task/web/WEB-INF/tlds/lams/lams.tld,v diff -u -r1.11.2.7 -r1.11.2.8 --- lams_tool_task/web/WEB-INF/tlds/lams/lams.tld 25 Nov 2016 17:08:51 -0000 1.11.2.7 +++ lams_tool_task/web/WEB-INF/tlds/lams/lams.tld 1 Mar 2017 04:54:46 -0000 1.11.2.8 @@ -529,5 +529,13 @@ CommentsAuthor /WEB-INF/tags/CommentsAuthor.tag + + FileUpload + /WEB-INF/tags/FileUpload.tag + + + WaitingSpinner + /WEB-INF/tags/WaitingSpinner.tag + Index: lams_tool_task/web/pages/learning/learning.jsp =================================================================== RCS file: /usr/local/cvsroot/lams_tool_task/web/pages/learning/learning.jsp,v diff -u -r1.25.2.5 -r1.25.2.6 --- lams_tool_task/web/pages/learning/learning.jsp 17 Feb 2017 08:43:55 -0000 1.25.2.5 +++ lams_tool_task/web/pages/learning/learning.jsp 1 Mar 2017 04:54:46 -0000 1.25.2.6 @@ -1,5 +1,9 @@ <%@ include file="/common/taglibs.jsp"%> +<%@ page import="org.lamsfoundation.lams.util.Configuration" %> +<%@ page import="org.lamsfoundation.lams.util.ConfigurationKeys" %> +<%@ page import="org.lamsfoundation.lams.util.FileValidatorUtil" %> + @@ -9,6 +13,10 @@ +<%=Configuration.get(ConfigurationKeys.UPLOAD_FILE_MAX_SIZE)%> +<%=FileValidatorUtil.formatSize(Configuration.getAsInt(ConfigurationKeys.UPLOAD_FILE_MAX_SIZE))%> +<%=Configuration.get(ConfigurationKeys.EXE_EXTENSIONS)%> + <fmt:message key="label.learning.title" /> @@ -24,9 +32,31 @@ if ( addTaskArea && addTaskArea.contentWindow.disableButtons ) { addTaskArea.contentWindow.disableButtons(); } + + // show the waiting area during the upload + var div = document.getElementById("attachmentArea_Busy"); + if(div != null){ + div.style.display = ''; + } } catch(err) {} } + function validateFiles() { + var fileSelect = document.getElementById('uploadButton'); + var files = fileSelect.files; + if (files.length == 0) { + return false; + } else { + var file = files[0]; + if ( ! validateShowErrorNotExecutable(file, '', false, '${EXE_FILE_TYPES}') + || ! validateShowErrorFileSize(file, '${UPLOAD_FILE_MAX_SIZE}', '') ) { + return false; + } + } + disableButtons(); + return true; + } + function checkNew() { document.location.href = "?mode=${mode}&toolSessionID=${toolSessionID}"; return false; Index: lams_tool_task/web/pages/learning/parts/itemdetails.jsp =================================================================== RCS file: /usr/local/cvsroot/lams_tool_task/web/pages/learning/parts/itemdetails.jsp,v diff -u -r1.7.2.2 -r1.7.2.3 --- lams_tool_task/web/pages/learning/parts/itemdetails.jsp 16 Feb 2017 11:46:09 -0000 1.7.2.2 +++ lams_tool_task/web/pages/learning/parts/itemdetails.jsp 1 Mar 2017 04:54:46 -0000 1.7.2.3 @@ -23,7 +23,7 @@ + class="btn btn-default btn-disable-on-submit voffset5" />
@@ -32,8 +32,9 @@ +
+ method="post" enctype="multipart/form-data" onsubmit="return validateFiles();"> @@ -44,20 +45,19 @@ +
+ +
<%@ include file="filelist.jsp"%> - -
- -
- - - - + + class="btn btn-default btn-disable-on-submit voffset5" />
+ +
Index: lams_tool_task/web/pages/learning/parts/itemlist.jsp =================================================================== RCS file: /usr/local/cvsroot/lams_tool_task/web/pages/learning/parts/itemlist.jsp,v diff -u -r1.15.2.1 -r1.15.2.2 --- lams_tool_task/web/pages/learning/parts/itemlist.jsp 29 Feb 2016 10:51:51 -0000 1.15.2.1 +++ lams_tool_task/web/pages/learning/parts/itemlist.jsp 1 Mar 2017 04:54:46 -0000 1.15.2.2 @@ -2,12 +2,8 @@ + - -