lams-github / lams_common / src / java / org

lamsfoundation

Clone Tools

Stats

Commits this week: 0
Total Committers: 32
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 22 Nov 2021
8:07 pm

Marcin Cieslak

LDEV-5257 Add LD and activity title validation also on backend

Options
    • -8
    • +13
    ./lams/util/ValidationUtil.java
  2. … 1 more file in changeset.
Saturday 20 Nov 2021
9:37 pm

Marcin Cieslak

LDEV-5258 Retrieve correct time zone offset

Options
    • -1
    • +9
    ./lams/usermanagement/dto/UserDTO.java
  2. … 1 more file in changeset.
Thursday 11 Nov 2021
2:36 am

Marcin Cieslak

LDEV-5257 Secure fileDownloadToken cookie

Options
    • -0
    • +10
    ./lams/util/WebUtil.java
  2. … 9 more files in changeset.
Wednesday 10 Nov 2021
5:20 pm

Marcin Cieslak

LDEV-5257 Escape formulas in LAMS-generated spreadsheets

Options
    • -1
    • +3
    ./lams/util/excel/ExcelUtil.java
Tuesday 02 Nov 2021
9:39 pm

Marcin Cieslak

LDEV-5256 Sanitise jqGrid sorting options before using them in queries

Options
    • -4
    • +5
    ./lams/dao/hibernate/LAMSBaseDAO.java
    • -2
    • +3
    ./lams/qb/dao/hibernate/QbDAO.java
  3. … 2 more files in changeset.
9:20 pm

Marcin Cieslak

LDEV-4411 Reintroduce eager fetching and caching of QB options and units

There are several places in LAMS code where we need to detach QB

question entity from session to do copying and comparison. While another

approach can be found, it requires a lot of effort to rewrite now.

Fetching options from a detached question causes lazy initialisation

exceptions. We had to make them eagerly fetched again.

Collection caching is introduced too to address numerous queries run

with every question fetch.

Options
    • -4
    • +11
    ./lams/qb/model/QbQuestion.java
5:59 am

Marcin Cieslak

LDEV-5256 Prevent SQL injection for results order

Options
    • -1
    • +9
    ./lams/dao/hibernate/LAMSBaseDAO.java
    • -0
    • +3
    ./lams/qb/dao/hibernate/QbDAO.java
  3. … 2 more files in changeset.
Wednesday 27 Oct 2021
6:54 pm

Marcin Cieslak

LDEV-4411 Do not fetch groups eagerly

Options
    • -2
    • +1
    ./lams/learningdesign/Grouping.java
Monday 25 Oct 2021
10:19 pm

Marcin Cieslak

LDEV-5253 Sysadmin Login As feature to be configurable

Options
    • -0
    • +17
    ./lams/dbupdates/patch20211025.sql
    • -0
    • +3
    ./lams/util/ConfigurationKeys.java
  3. … 3 more files in changeset.
Monday 18 Oct 2021
10:42 pm

Marcin Cieslak

LDEV-4411 Allow Hibernate to choose fetch type by itself

Options
    • -5
    • +3
    ./lams/lesson/Lesson.java
10:42 pm

Marcin Cieslak

LDEV-4411 Make relation from Lesson to LessonClass unidirectional

Hibernate can not lazy load properties connected with OneToOne

relationship.

Options
    • -13
    • +6
    ./lams/lesson/LessonClass.java
  2. … 1 more file in changeset.
10:32 pm

Marcin Cieslak

LDEV-4411 Make relation from Evaluation to ToolActivity unidirectional

Hibernate can not lazy load properties connected with OneToOne

relationship. It means that with every fetch of ToolActivity its

ActivityEvaluation was also fetched, whether is was needed or not. It

made up even 10% of all queries sent to DB during a lesson.

By having the relationship unidirectional and fetching

ActivityEvaluation via DAO we ensure that it is fetched only when it is

needed. The code is not as nice, though.

Options
    • -12
    • +10
    ./lams/learningdesign/ToolActivity.java
    • -2
    • +4
    ./lams/learningdesign/dao/IActivityDAO.java
    • -1
    • +7
    ./lams/learningdesign/dao/hibernate/ActivityDAO.java
    • -2
    • +4
    ./lams/learningdesign/dto/AuthoringActivityDTO.java
    • -3
    • +4
    ./lams/learningdesign/service/ExportToolContentService.java
    • -26
    • +32
    ./lams/tool/service/LamsCoreToolService.java
    • -4
    • +2
    ./lams/tool/service/LamsToolService.java
    • -1
    • +23
    ./lams/usermanagement/service/UserManagementService.java
  9. … 6 more files in changeset.
10:29 pm

Marcin Cieslak

LDEV-4411 Do not cache native SQL queries as it causes exceptions

Options
    • -1
    • +1
    ./lams/security/SecurityDAO.java
6:31 pm

Marcin Cieslak

LDEV-3656 Clean up invalidated session from internal tracking mapping

These session should have been removed from the mapping when

SessionListener is called. Sometimes the listener is not called due to

WildFly internal bugs. We are left with a long list of stale sessions.

We should periodically clean up the mapping. Making it happen on runtime

stats fetch is as place as any other, plus it happens periodically.

Options
    • -0
    • +14
    ./lams/web/session/SessionManager.java
  2. … 1 more file in changeset.
Sunday 17 Oct 2021
11:46 pm

Marcin Cieslak

LDEV-4411 Remove FetchMode as it seems to trigger excessive queries

Options
    • -7
    • +0
    ./lams/qb/model/QbQuestion.java
11:36 pm

Marcin Cieslak

LDEV-4411 Make cacheable queries for checking user roles

Options
    • -5
    • +5
    ./lams/security/SecurityDAO.java
    • -1
    • +1
    ./lams/usermanagement/service/UserManagementService.java
11:01 pm

Marcin Cieslak

LDEV-4411 Make Tool -> ExtServerToolAdapterMap collection lazy

Options
    • -2
    • +1
    ./lams/tool/Tool.java
10:53 pm

Marcin Cieslak

LDEV-5250 Remove Pedagogical Planner integration with core LAMS

Options
    • -1
    • +0
    ./lams/commonContext.xml
    • -0
    • +19
    ./lams/dbupdates/patch20211017.sql
    • -19
    • +0
    ./lams/learningdesign/ToolActivity.java
    • -14
    • +0
    ./lams/learningdesign/dto/AuthoringActivityDTO.java
    • -118
    • +0
    ./lams/learningdesign/dto/PlannerActivityMetadataDTO.java
    • -11
    • +1
    ./lams/learningdesign/service/ExportToolContentService.java
    • -145
    • +0
    ./lams/planner/PedagogicalPlannerActivityMetadata.java
    • -110
    • +0
    ./lams/planner/PedagogicalPlannerActivitySpringForm.java
    • -11
    • +0
    ./lams/tool/SystemTool.java
    • -15
    • +2
    ./lams/tool/Tool.java
    • -14
    • +0
    ./lams/usermanagement/User.java
  12. … 57 more files in changeset.
Thursday 07 Oct 2021
4:44 pm

Marcin Cieslak

LDEV-4411 Stop using collection cache for now

Cache annotations were commented out so we can come back to them easily

in the future.

Collection cache is not detecting changes made to entities. When a new

entity is added, collection cache does not see the change.

Properly tweaking concurrency strategy does not seem possible at the

moment, so we just turn it off.

Options
    • -2
    • +2
    ./lams/learningdesign/Activity.java
    • -1
    • +1
    ./lams/learningdesign/ComplexActivity.java
    • -5
    • +5
    ./lams/learningdesign/LearningDesign.java
    • -1
    • +1
    ./lams/learningdesign/LearningLibrary.java
    • -1
    • +1
    ./lams/learningdesign/SequenceActivity.java
    • -2
    • +2
    ./lams/lesson/Lesson.java
    • -2
    • +2
    ./lams/qb/model/QbQuestion.java
    • -1
    • +1
    ./lams/tool/Tool.java
    • -4
    • +4
    ./lams/usermanagement/Organisation.java
  10. … 21 more files in changeset.
Wednesday 06 Oct 2021
2:10 am

Marcin Cieslak

LDEV-5174 Allow MCQ as iRAT in TBL monitoring Teams tab

Options
    • -4
    • +1
    ./lams/tool/service/ICommonAssessmentService.java
  2. … 4 more files in changeset.
12:56 am

Marcin Cieslak

LDEV-5248 Get query cache stats directly from Session Factory

Options
    • -0
    • +1
    ./lams/applicationContext.xml
    • -0
    • +5
    ./lams/util/hibernate/HibernateSessionManager.java
  3. … 1 more file in changeset.
Thursday 30 Sep 2021
5:16 am

Marcin Cieslak

LDEV-4411 Use WF provided entity cache configuration

Options
    • -11
    • +8
    ./lams/applicationContext.xml
  2. … 4 more files in changeset.
Monday 27 Sep 2021
4:42 pm

Marcin Cieslak

LDEV-4411 Add configuration for collection cache on multinode env

Options
    • -0
    • +3
    ./lams/applicationContext.xml
4:16 pm

Marcin Cieslak

LDEV-4411 Native SQL queries are not cacheable by default

There seems to be a bug in Hibernate

https://hibernate.atlassian.net/browse/HHH-9111

There is a way to make native queries cacheable, but since there are so

few of them in LAMS, it is not worth the effort.

Options
    • -3
    • +0
    ./lams/policies/dao/hibernate/PolicyDAO.java
4:12 pm

Marcin Cieslak

LDEV-4411 Fix cacheable API method

Options
    • -1
    • +1
    ./lams/dao/hibernate/LAMSBaseDAO.java
3:56 pm

Marcin Cieslak

LDEV-4288 Prevent duplicate entries in Gradebook activity table

Unique key allows us to track situations in which duplicate entries get

created in the table.

There is no point in copying Gradebook entries on tool content copy - we

never copy live lessons, only template Learning Designs which should not

have any gradebook entries set.

Options
    • -0
    • +16
    ./lams/dbupdates/patch20210927.sql
    • -12
    • +0
    ./lams/learningdesign/ToolActivity.java
3:45 pm

Marcin Cieslak

LDEV-5248, LDEV-4411 Mark some collections as cacheable

Similar to query cache, the collection cache makes sense if the table

which collection elements map to do not change often. Each modification

to table content invalidates the given collection cache.

Options
    • -2
    • +5
    ./lams/learningdesign/Activity.java
    • -2
    • +5
    ./lams/learningdesign/ComplexActivity.java
    • -1
    • +4
    ./lams/learningdesign/LearningDesign.java
    • -0
    • +3
    ./lams/learningdesign/LearningLibrary.java
    • -3
    • +6
    ./lams/learningdesign/SequenceActivity.java
    • -1
    • +4
    ./lams/lesson/Lesson.java
    • -0
    • +3
    ./lams/tool/Tool.java
    • -4
    • +10
    ./lams/usermanagement/Organisation.java
  9. … 24 more files in changeset.
Friday 24 Sep 2021
3:50 pm

Marcin Cieslak

LDEV-5248, LDEV-4411 Mark some queries as cacheable

Query cache makes sense if tables which the query reference does not

change often. Each modification to table content invalidates the given

query's cache. Also each set of query parameters is a different cache

entry, so if there are various parameter values the cache overhead can

generate more load than benefit.

Options
    • -1
    • +1
    ./lams/config/dao/hibernate/ConfigurationDAO.java
    • -0
    • +4
    ./lams/dao/IBaseDAO.java
    • -17
    • +23
    ./lams/dao/hibernate/LAMSBaseDAO.java
    • -10
    • +9
    ./lams/integration/service/IntegrationService.java
    • -1
    • +0
    ./lams/learningdesign/Activity.java
    • -1
    • +0
    ./lams/learningdesign/LearningDesign.java
    • -5
    • +0
    ./lams/learningdesign/dao/IActivityDAO.java
    • -14
    • +7
    ./lams/learningdesign/dao/hibernate/ActivityDAO.java
    • -5
    • +2
    ./lams/learningdesign/dao/hibernate/BranchActivityEntryDAO.java
    • -13
    • +14
    ./lams/learningdesign/dao/hibernate/LearningDesignDAO.java
    • -2
    • +2
    ./lams/learningdesign/dao/hibernate/LearningLibraryDAO.java
    • -2
    • +2
    ./lams/learningdesign/dao/hibernate/LicenseDAO.java
    • -1
    • +0
    ./lams/lesson/Lesson.java
    • -4
    • +4
    ./lams/lesson/dao/hibernate/LearnerProgressDAO.java
    • -9
    • +11
    ./lams/lesson/dao/hibernate/LessonDAO.java
  16. … 82 more files in changeset.
3:52 am

Marcin Cieslak

LDEV-4411 Set up default and immutable 2nd level cache configuration

Options
    • -16
    • +43
    ./lams/applicationContext.xml
  2. … 1 more file in changeset.
Tuesday 21 Sep 2021
8:25 pm

Marcin Cieslak

LDEV-5248 Fix exception when exporting LD

Options
    • -1
    • +1
    ./lams/qb/service/QbService.java