lams-github / lams_tool_assessment

src

Clone Tools

Stats

Commits this week: 0
Total Committers: 16
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 30 Nov 2021
6:57 am

Marcin Cieslak

LDEV-5260 Initial implementation of EventSource-powered chart

Options
    • -3
    • +50
    ./java/org/lamsfoundation/lams/tool/assessment/web/controller/MonitoringController.java
  2. … 2 more files in changeset.
12:41 am

Marcin Cieslak

LDEV-4762 Fix saving option order in ordering question

TreeSet.addAll() seems not to work correctly in some cases

https://bugs.java.com/bugdatabase/view_bug.do?bug_id=6385838

Options
    • -4
    • +4
    ./java/org/lamsfoundation/lams/tool/assessment/web/controller/LearningController.java
Wednesday 24 Nov 2021
2:24 am

Marcin Cieslak

LDEV-5125 Improve support for VSA questions import from Word file

VSA questions should have 2 options if they are going to be TBL

compatible. When importing from Word document only correct answers

option is required. The other one, incorrect answers option, now gets

added automatically. Also incorrect answers option does not get deleted

after editing via QB interface.

Options
    • -2
    • +3
    ./java/org/lamsfoundation/lams/tool/assessment/util/AssessmentEscapeUtils.java
  2. … 3 more files in changeset.
Thursday 11 Nov 2021
2:36 am

Marcin Cieslak

LDEV-5257 Secure fileDownloadToken cookie

Options
    • -4
    • +1
    ./java/org/lamsfoundation/lams/tool/assessment/web/controller/MonitoringController.java
  2. … 9 more files in changeset.
Saturday 06 Nov 2021
11:32 pm

Marcin Cieslak

LDEV-3224 Prevent exceptions when modifying live Assessment question

Options
    • -20
    • +31
    ./java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java
Wednesday 03 Nov 2021
10:53 pm

Marcin Cieslak

LDEV-5142 Do not copy stale absolute time limit on activity clone

Options
    • -2
    • +3
    ./java/org/lamsfoundation/lams/tool/assessment/model/Assessment.java
  2. … 3 more files in changeset.
7:45 pm

Marcin Cieslak

LDEV-4506 Get rid of non-cache results fetch in Assessment

Changes made for LDEV-4411 made these changes obsolete.

Options
    • -16
    • +0
    ./java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java
    • -10
    • +0
    ./java/org/lamsfoundation/lams/tool/assessment/service/IAssessmentService.java
    • -2
    • +1
    ./java/org/lamsfoundation/lams/tool/assessment/web/controller/LearningController.java
Tuesday 02 Nov 2021
9:39 pm

Marcin Cieslak

LDEV-5256 Sanitise jqGrid sorting options before using them in queries

Options
    • -2
    • +2
    ./java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentUserDAOHibernate.java
  2. … 3 more files in changeset.
5:59 am

Marcin Cieslak

LDEV-5256 Prevent SQL injection for results order

Options
    • -0
    • +4
    ./java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentUserDAOHibernate.java
  2. … 3 more files in changeset.
Monday 25 Oct 2021
7:21 pm

Marcin Cieslak

LDEV-5251 Add proper tooltip for leader-based Assessments

Options
    • -7
    • +7
    ./java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentResultDAOHibernate.java
  2. … 1 more file in changeset.
7:10 pm

Marcin Cieslak

LDEV-5251 Fix query finding number of answered questions by students

Options
    • -1
    • +1
    ./java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentResultDAOHibernate.java
Friday 22 Oct 2021
11:54 pm

Marcin Cieslak

LDEV-5251 Add tooltip with list of students in answered questions chart

Options
    • -1
    • +1
    ./java/org/lamsfoundation/lams/tool/assessment/dao/AssessmentResultDAO.java
    • -21
    • +22
    ./java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentResultDAOHibernate.java
    • -4
    • +4
    ./java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java
    • -1
    • +1
    ./java/org/lamsfoundation/lams/tool/assessment/service/IAssessmentService.java
    • -1
    • +4
    ./java/org/lamsfoundation/lams/tool/assessment/web/controller/MonitoringController.java
  6. … 2 more files in changeset.
Monday 11 Oct 2021
10:52 pm

Marcin Cieslak

LDEV-4540 Never copy Assessment question disclose status

Assessment questions can be disclosed on lesson level only. If they are

cloned or exported, their disclose status should be always the default,

i.e. not disclosed.

Options
    • -1
    • +2
    ./java/org/lamsfoundation/lams/tool/assessment/model/AssessmentQuestion.java
    • -0
    • +3
    ./java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java
Thursday 07 Oct 2021
4:44 pm

Marcin Cieslak

LDEV-4411 Stop using collection cache for now

Cache annotations were commented out so we can come back to them easily

in the future.

Collection cache is not detecting changes made to entities. When a new

entity is added, collection cache does not see the change.

Properly tweaking concurrency strategy does not seem possible at the

moment, so we just turn it off.

Options
    • -3
    • +3
    ./java/org/lamsfoundation/lams/tool/assessment/model/Assessment.java
  2. … 29 more files in changeset.
Wednesday 06 Oct 2021
6:25 pm

Marcin Cieslak

Merge branch 'v4.5' into LDEV-5248

Options
    • -1
    • +0
    ./java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java
2:10 am

Marcin Cieslak

LDEV-5174 Allow MCQ as iRAT in TBL monitoring Teams tab

Options
    • -1
    • +0
    ./java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java
  2. … 4 more files in changeset.
Tuesday 05 Oct 2021
3:38 pm

Marcin Cieslak

Merge remote-tracking branch 'origin/v4.5' into LDEV-5248

Conflicts:

lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentQuestionResultDAOHibernate.java

Options
    • -5
    • +4
    ./java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentQuestionResultDAOHibernate.java
    • -5
    • +18
    ./java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java
12:59 am

Marcin Cieslak

LDEV-5130 Add "Allocate VSAs" screen to TBL Assessment monitoring

Options
    • -3
    • +1
    ./java/org/lamsfoundation/lams/tool/assessment/web/controller/MonitoringController.java
    • -0
    • +6
    ./java/org/lamsfoundation/lams/tool/assessment/web/controller/TblMonitoringController.java
  3. … 3 more files in changeset.
12:30 am

Marcin Cieslak

LDEV-5130 Add "Allocate VSAs" screen to regular Assessment monitoring

Options
    • -2
    • +27
    ./java/org/lamsfoundation/lams/tool/assessment/web/controller/MonitoringController.java
  2. … 3 more files in changeset.
Saturday 02 Oct 2021
6:56 pm

Marcin Cieslak

LDEV-5131 For monitoring update student VSA suggestions on autosave

Options
    • -2
    • +2
    ./java/org/lamsfoundation/lams/tool/assessment/dao/AssessmentQuestionResultDAO.java
    • -6
    • +7
    ./java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentQuestionResultDAOHibernate.java
    • -3
    • +7
    ./java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java
6:15 pm

Marcin Cieslak

LDEV-4875 Skip repetitive students' suggestions in VSA questions

Options
    • -2
    • +11
    ./java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java
Monday 27 Sep 2021
3:45 pm

Marcin Cieslak

LDEV-5248, LDEV-4411 Mark some collections as cacheable

Similar to query cache, the collection cache makes sense if the table

which collection elements map to do not change often. Each modification

to table content invalidates the given collection cache.

Options
    • -1
    • +2
    ./java/org/lamsfoundation/lams/tool/assessment/model/Assessment.java
    • -4
    • +0
    ./java/org/lamsfoundation/lams/tool/assessment/model/AssessmentQuestionResult.java
    • -4
    • +0
    ./java/org/lamsfoundation/lams/tool/assessment/model/AssessmentResult.java
  4. … 29 more files in changeset.
Friday 24 Sep 2021
3:50 pm

Marcin Cieslak

LDEV-5248, LDEV-4411 Mark some queries as cacheable

Query cache makes sense if tables which the query reference does not

change often. Each modification to table content invalidates the given

query's cache. Also each set of query parameters is a different cache

entry, so if there are various parameter values the cache overhead can

generate more load than benefit.

Options
    • -1
    • +1
    ./java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentDAOHibernate.java
    • -1
    • +1
    ./java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentQuestionResultDAOHibernate.java
    • -3
    • +2
    ./java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentResultDAOHibernate.java
    • -3
    • +3
    ./java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentSessionDAOHibernate.java
    • -1
    • +0
    ./java/org/lamsfoundation/lams/tool/assessment/model/Assessment.java
    • -1
    • +0
    ./java/org/lamsfoundation/lams/tool/assessment/model/AssessmentOptionAnswer.java
    • -1
    • +0
    ./java/org/lamsfoundation/lams/tool/assessment/model/AssessmentQuestion.java
    • -1
    • +0
    ./java/org/lamsfoundation/lams/tool/assessment/model/AssessmentQuestionResult.java
    • -1
    • +0
    ./java/org/lamsfoundation/lams/tool/assessment/model/AssessmentResult.java
    • -1
    • +0
    ./java/org/lamsfoundation/lams/tool/assessment/model/AssessmentSession.java
  11. … 87 more files in changeset.
Tuesday 21 Sep 2021
8:23 pm

Marcin Cieslak

LDEV-5248 Fix exception when processing QB units lazy collection

Options
    • -1
    • +3
    ./java/org/lamsfoundation/lams/tool/assessment/dto/QuestionDTO.java
4:35 pm

Marcin Cieslak

Merge branch 'v4.5' into LDEV-5248

Options
    • -1
    • +1
    ./java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentResultDAOHibernate.java
4:31 pm

Marcin Cieslak

LDEV-4944 Fix mark recalculation query

Options
    • -1
    • +1
    ./java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentResultDAOHibernate.java
4:07 pm

Marcin Cieslak

LDEV-5248 Fix exception when processing Assessment overall feedback

Options
    • -2
    • +2
    ./java/org/lamsfoundation/lams/tool/assessment/web/controller/AuthoringController.java
12:34 am

Marcin Cieslak

LDEV-5248, LDEV-4411 Add 2nd level cache to selected elements

Displaying Assessment results is too DB-intense for multiple learners.

We can enable a short-lived query cache for some entities which have

most impact on the results page. This way multiple requests can reuse

same objects from cache and there is little danger of inconsistency.

Options
    • -6
    • +8
    ./java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentQuestionResultDAOHibernate.java
    • -2
    • +3
    ./java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentResultDAOHibernate.java
    • -3
    • +4
    ./java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentSessionDAOHibernate.java
    • -0
    • +5
    ./java/org/lamsfoundation/lams/tool/assessment/model/Assessment.java
    • -0
    • +2
    ./java/org/lamsfoundation/lams/tool/assessment/model/AssessmentOptionAnswer.java
    • -0
    • +2
    ./java/org/lamsfoundation/lams/tool/assessment/model/AssessmentQuestion.java
    • -0
    • +5
    ./java/org/lamsfoundation/lams/tool/assessment/model/AssessmentQuestionResult.java
    • -0
    • +5
    ./java/org/lamsfoundation/lams/tool/assessment/model/AssessmentResult.java
    • -0
    • +2
    ./java/org/lamsfoundation/lams/tool/assessment/model/AssessmentSession.java
  10. … 11 more files in changeset.
12:32 am

Marcin Cieslak

LDEV-5248 Refresh Assessment object from DB instead of from form

We should not keep objects in form at all. If we do and a new request is

processed, we need to fetch the original object from DB.

Options
    • -1
    • +1
    ./java/org/lamsfoundation/lams/tool/assessment/web/controller/AuthoringController.java
Friday 17 Sep 2021
11:47 pm

Marcin Cieslak

LDEV-5248 Switch collections to lazy loading

No need to fetch all data straight away.

Options
    • -1
    • +1
    ./java/org/lamsfoundation/lams/tool/assessment/model/Assessment.java
    • -1
    • +1
    ./java/org/lamsfoundation/lams/tool/assessment/model/AssessmentQuestionResult.java
    • -1
    • +1
    ./java/org/lamsfoundation/lams/tool/assessment/model/AssessmentResult.java
  4. … 1 more file in changeset.