lams-github

Clone Tools

Stats

Commits this week: 0
Total Committers: 50
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 04 Oct 2018
7:35 pm

Andrey Balan

LDEV-4440 Switch controllers to use @Autowired service beans

Also in cases when service bean in Controller has the same name as in

applicationContext, @Qualifier(..) can be removed. Which was done almost

in all cases, except for messageService due to "messageService" name

seems to be more preferable than adminMessageService,

centralMessageService and so on. Thus they were kept as before:

@Autowired

@Qualifier("centralMessageService")

private MessageService messageService;

Options
    • -44
    • +13
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/CleanupPreviewLessonsController.java
    • -13
    • +4
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/CleanupTempFilesController.java
    • -29
    • +15
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/CloneLessonsController.java
    • -31
    • +12
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/ConfigController.java
    • -16
    • +3
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/DisabledUserManageController.java
    • -21
    • +13
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/ImportExcelSaveController.java
    • -16
    • +3
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/ImportGroupsController.java
    • -11
    • +5
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/ImportUserResultController.java
    • -55
    • +22
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/LdapConfigController.java
    • -29
    • +8
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/LogEventController.java
    • -33
    • +7
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/LtiConsumerManagementController.java
    • -26
    • +7
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/OrgManageController.java
    • -19
    • +17
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/OrgPasswordChangeController.java
    • -34
    • +15
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/OrgSaveController.java
    • -38
    • +31
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/OrganisationController.java
  16. … 168 more files in changeset.
7:09 pm

Marcin Cieslak

LDEV-4440, LDEV-3275 Update XStream source code

Options
    • -1
    • +1
    /3rdParty_sources/versions.txt
    • -2
    • +2
    /3rdParty_sources/xstream/com/thoughtworks/xstream/InitializationException.java
    • -33
    • +3
    /3rdParty_sources/xstream/com/thoughtworks/xstream/MarshallingStrategy.java
    • -630
    • +1130
    /3rdParty_sources/xstream/com/thoughtworks/xstream/XStream.java
    • -3
    • +5
    /3rdParty_sources/xstream/com/thoughtworks/xstream/XStreamException.java
    • -49
    • +57
    /3rdParty_sources/xstream/com/thoughtworks/xstream/XStreamer.java
    • -0
    • +39
    /3rdParty_sources/xstream/com/thoughtworks/xstream/annotations/AnnotationProvider.java
    • -0
    • +115
    /3rdParty_sources/xstream/com/thoughtworks/xstream/annotations/AnnotationReflectionConverter.java
    • -0
    • +50
    /3rdParty_sources/xstream/com/thoughtworks/xstream/annotations/Annotations.java
    • -0
    • +32
    /3rdParty_sources/xstream/com/thoughtworks/xstream/annotations/XStreamContainedType.java
    • -1
    • +9
    /3rdParty_sources/xstream/com/thoughtworks/xstream/annotations/XStreamConverter.java
    • -0
    • +29
    /3rdParty_sources/xstream/com/thoughtworks/xstream/annotations/XStreamImplicitCollection.java
    • -90
    • +13
    /3rdParty_sources/xstream/com/thoughtworks/xstream/converters/ConversionException.java
    • -31
    • +30
    /3rdParty_sources/xstream/com/thoughtworks/xstream/converters/Converter.java
    • -5
    • +5
    /3rdParty_sources/xstream/com/thoughtworks/xstream/converters/ConverterLookup.java
  16. … 317 more files in changeset.
7:09 pm

Marcin Cieslak

LDEV-4440, LDEV-3275 Update XStream binaries

Version 1.4.10 is more up to date than 1.5.0 which has been released

unofficially.

Options
    • -1
    • +1
    /lams_build/3rdParty.userlibraries
    • binary
    /lams_build/lib/xstream/xstream-1.5.0-SNAPSHOT.jar
    • -1
    • +1
    /lams_build/lib/xstream/xstream.module.xml
    • -1
    • +1
    /lams_build/liblist.txt
    • -20
    • +20
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/service/ExportToolContentService.java
6:03 pm

Marcin Cieslak

LDEV-4440 Add necessary qualifiers for service injection

Options
    • -3
    • +6
    /lams_central/src/java/org/lamsfoundation/lams/authoring/template/web/LdTemplateController.java
    • -1
    • +1
    /lams_central/src/java/org/lamsfoundation/lams/workspace/web/WorkspaceController.java
12:02 pm

Fiona Malikoff <Fiona.Malikoff@gmail.com>

LDEV-4440 Ensure all wiki body updates go via the obsfucation method

Options
    • -1
    • +10
    /lams_tool_wiki/web/pages/authoring/authoring.jsp
    • -1
    • +0
    /lams_tool_wiki/web/pages/authoring/basic.jsp
    • -1
    • +0
    /lams_tool_wiki/web/pages/learning/wiki.jsp
    • -1
    • +0
    /lams_tool_wiki/web/pages/monitoring/wikiDisplay.jsp
6:21 am

Andrey Balan

LDEV-4440 also look for comments and workspace controllers

Options
    • -1
    • +2
    /lams_central/web/WEB-INF/spring-servlet.xml
Wednesday 03 Oct 2018
4:26 am

Andrey Balan

LDEV-4440 Remove reference to the deleted AuthoringConstants

Options
    • -2
    • +0
    /lams_central/src/java/org/lamsfoundation/lams/authoring/template/web/LdTemplateController.java
Tuesday 02 Oct 2018
10:14 pm

Andrey Balan

LDEV-4440 Switch servlets to using autowired service beans

Besides, RegisterAction was renamed to RegisterServlet. And one

remaining constant was moved from AuthoringConstants to CentralConstants

with subsequent removal of AuthoringConstants.java.

Options
    • -36
    • +0
    /lams_central/src/java/org/lamsfoundation/lams/authoring/web/AuthoringConstants.java
    • -1
    • +1
    /lams_central/src/java/org/lamsfoundation/lams/rest/LearningDesignRestServlet.java
    • -58
    • +29
    /lams_central/src/java/org/lamsfoundation/lams/rest/RestServlet.java
    • -3
    • +3
    /lams_central/src/java/org/lamsfoundation/lams/rest/ToolContentRestServlet.java
    • -0
    • +2
    /lams_central/src/java/org/lamsfoundation/lams/util/CentralConstants.java
    • -27
    • +33
    /lams_central/src/java/org/lamsfoundation/lams/web/ForgotPasswordServlet.java
    • -25
    • +18
    /lams_central/src/java/org/lamsfoundation/lams/web/GradebookServlet.java
    • -7
    • +16
    /lams_central/src/java/org/lamsfoundation/lams/web/LAMSConnectorServlet.java
    • -9
    • +14
    /lams_central/src/java/org/lamsfoundation/lams/web/LAMSUploadServlet.java
    • -8
    • +2
    /lams_central/src/java/org/lamsfoundation/lams/web/LamsStartupServlet.java
    • -15
    • +15
    /lams_central/src/java/org/lamsfoundation/lams/web/LaunchLearnerUrlServlet.java
    • -10
    • +20
    /lams_central/src/java/org/lamsfoundation/lams/web/LessonOrderServlet.java
    • -23
    • +17
    /lams_central/src/java/org/lamsfoundation/lams/web/LoginRequestLtiServlet.java
    • -14
    • +19
    /lams_central/src/java/org/lamsfoundation/lams/web/LoginRequestServlet.java
    • -91
    • +81
    /lams_central/src/java/org/lamsfoundation/lams/web/OrganisationGroupServlet.java
  16. … 15 more files in changeset.
10:09 pm

Andrey Balan

LDEV-4440 Fix paths to ForgotPasswordServlet

Options
    • -2
    • +2
    /lams_central/web/forgotPassword.jsp
    • -56
    • +53
    /lams_central/web/forgotPasswordChange.jsp
    • -7
    • +1
    /lams_central/web/forgotPasswordProc.jsp
12:59 pm

Marcin Cieslak

LDEV-4440 Fix Pixlr edited image update

Options
    • -5
    • +4
    /lams_tool_pixlr/src/java/org/lamsfoundation/lams/tool/pixlr/web/controller/LearningController.java
    • -1
    • +1
    /lams_tool_pixlr/web/pages/monitoring/summary.jsp
10:51 am

Fiona Malikoff <Fiona.Malikoff@gmail.com>

Merge branch 'LDEV-4440' of https://github.com/lamsfoundation/lams into LDEV-4440

Options
10:50 am

Fiona Malikoff <Fiona.Malikoff@gmail.com>

LDEV-4676 Confidence levels work with One Question Per Page

Monitoring page now shows blank results when no learner attempt exists.

Options
    • -0
    • +1
    /lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/McAppConstants.java
    • -7
    • +53
    /lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/web/controller/McLearningController.java
    • -1
    • +1
    /lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/web/controller/McMonitoringController.java
7:46 am

Fiona Malikoff <Fiona.Malikoff@gmail.com>

LDEV-4667 Forum ratings turn on but optional - no min or max required

Options
    • -17
    • +1
    /lams_tool_forum/web/jsps/authoring/authoring.jsp
    • -1
    • +1
    /lams_tool_forum/web/jsps/learning/reply.jsp
    • -1
    • +3
    /lams_tool_forum/web/jsps/learning/viewforum.jsp
6:39 am

Andrey Balan

LDEV-4440 Fix Spring MVC related issues with signup pages

Options
    • -0
    • +2
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/SignupManagementController.java
    • binary
    /lams_build/lib/lams/lams.jar
    • -29
    • +22
    /lams_central/src/java/org/lamsfoundation/lams/web/controller/SignupController.java
    • -1
    • +1
    /lams_central/web/WEB-INF/urlrewrite.xml
    • -4
    • +7
    /lams_central/web/signup/loginTab.jsp
    • -1
    • +1
    /lams_central/web/signup/signup.jsp
    • -5
    • +0
    /lams_central/web/signup/singupTab.jsp
    • -2
    • +3
    /lams_common/src/java/org/lamsfoundation/lams/signup/dao/ISignupDAO.java
    • -3
    • +4
    /lams_common/src/java/org/lamsfoundation/lams/signup/dao/hibernate/SignupDAO.java
    • -2
    • +3
    /lams_common/src/java/org/lamsfoundation/lams/signup/service/ISignupService.java
    • -2
    • +3
    /lams_common/src/java/org/lamsfoundation/lams/signup/service/SignupService.java
Monday 01 Oct 2018
10:41 pm

Marcin Cieslak

LDEV-4440 Fix Q&A remaining question counting

Options
    • -1
    • +1
    /lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/web/controller/QaLearningController.java
10:32 pm

Marcin Cieslak

LDEV-4440 Select widgets are single value only in Wiki tool

Options
    • -2
    • +2
    /lams_tool_wiki/web/pages/authoring/advanced.jsp
7:17 pm

Marcin Cieslak

LDEV-4440 Fix checkboxes for boolean instead of String values

Options
    • -2
    • +4
    /lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/web/controller/QaAuthoringController.java
6:43 pm

Marcin Cieslak

LDEV-4440 Use a text in button body and not as value attribute

Options
    • -5
    • +1
    /lams_tool_vote/web/learning/IndividualLearnerResults.jsp
6:33 pm

Marcin Cieslak

LDEV-4440 Fix converstion from array to collection

Storing checkboxes result in an array works differently in Struts form

and in Spring forms.

Options
    • -3
    • +5
    /lams_tool_vote/src/java/org/lamsfoundation/lams/tool/vote/web/form/VoteLearningForm.java
4:50 pm

Marcin Cieslak

LDEV-4440 Make a path to file absolute

References to requestURL can come from various controllers and contexts,

leading to errors.

Options
    • -1
    • +1
    /lams_learning/src/java/org/lamsfoundation/lams/learning/web/util/ActivityMapping.java
4:37 pm

Marcin Cieslak

LDEV-4440 Fix a link for redoing Q&A questions

Options
    • -2
    • +2
    /lams_tool_laqa/web/learning/RevisitedLearnerRep.jsp
4:35 pm

Marcin Cieslak

LDEV-4440 Create conditions after questions are parsed

In the previous version conditions were referring to questions which

were not parsed yet and they could not be matched.

Options
    • -13
    • +13
    /lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/web/controller/QaAuthoringController.java
4:30 pm

Marcin Cieslak

LDEV-4545 Prevent exception when gate is the last activity in sequence

Options
    • -0
    • +3
    /lams_central/web/includes/javascript/authoring/authoringGeneral.js
3:40 pm

Marcin Cieslak

LDEV-4440 Fix file uploads in Daco

Options
    • -4
    • +4
    /lams_tool_daco/src/java/org/lamsfoundation/lams/tool/daco/service/DacoServiceImpl.java
    • -1
    • +1
    /lams_tool_daco/src/java/org/lamsfoundation/lams/tool/daco/web/controller/LearningController.java
    • -0
    • +9
    /lams_tool_daco/src/java/org/lamsfoundation/lams/tool/daco/web/form/RecordForm.java
Saturday 29 Sep 2018
3:36 am

Andrey Balan

LDEV-4440 fix various Spring MVC related issues

Options
    • -52
    • +14
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/SignupManagementController.java
    • -0
    • +10
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/form/SignupManagementForm.java
    • -1
    • +2
    /lams_admin/web/cleanupPreviewLessons.jsp
    • -11
    • +19
    /lams_admin/web/remove.jsp
    • -5
    • +7
    /lams_admin/web/signupmanagement/add.jsp
    • -1
    • +1
    /lams_admin/web/user.jsp
    • -1
    • +1
    /lams_admin/web/usersearchlist.jsp
Friday 28 Sep 2018
11:14 pm

Andrey Balan

LDEV-4440 Fix Policies and consents' Spring MVC related issues

Options
    • -1
    • +1
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/PolicyManagementController.java
    • -11
    • +11
    /lams_admin/web/policies/editPolicy.jsp
    • -1
    • +1
    /lams_admin/web/policies/policies.jsp
    • -1
    • +1
    /lams_admin/web/policies/policyTable.jsp
    • -1
    • +1
    /lams_admin/web/policies/userConsents.jsp
    • -7
    • +5
    /lams_central/web/policyConsents.jsp
    • -4
    • +0
    /lams_central/web/profile/policyDetails.jsp
    • -1
    • +1
    /lams_central/web/profile/profilePolicyConsents.jsp
8:50 pm

Marcin Cieslak

LDEV-4440 Add default lesson parameters to ext servers

Options
    • -3
    • +3
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/ServerMaintainController.java
    • -3
    • +1
    /lams_admin/web/servermaintain.jsp
8:50 pm

Marcin Cieslak

LDEV-4440 Use forwards instead of redirects to keep Struts behaviour

Options
    • -2
    • +2
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/ImportExcelSaveController.java
    • -6
    • +0
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/LoginSaveController.java
    • -1
    • +1
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/OrgSaveController.java
    • -1
    • +1
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/ServerSaveController.java
    • -5
    • +0
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/TimezoneManagementController.java
    • -3
    • +3
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/ToolContentListController.java
    • -2
    • +2
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserController.java
    • -0
    • +80
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/form/ExtServerForm.java
    • -8
    • +8
    /lams_central/src/java/org/lamsfoundation/lams/web/IndexController.java
    • -1
    • +1
    /lams_central/src/java/org/lamsfoundation/lams/web/LoginAsController.java
    • -6
    • +3
    /lams_central/src/java/org/lamsfoundation/lams/web/PortraitSaveController.java
8:44 pm

Fiona Malikoff <Fiona.Malikoff@gmail.com>

LDEV4440 Forum message body keeps newlines and counts correctly.

Options
    • -9
    • +6
    /lams_tool_forum/web/jsps/learning/message/bodyarea.jsp
7:29 pm

Marcin Cieslak

LDEV-4440, LDEV-4020 Prevent dragging on dialog control buttons

Options
    • -2
    • +2
    /lams_central/web/includes/javascript/dialog.js