lams / lams_central / src / java

org

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 16
Last Commit:
Commits this week: 0
Total Lines of Code (LoC): 35,480
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 28 Nov 2014
1:11 pm

Marcin Cieslak

LDEV-3383: Remove Web authentication method.

Options
    • -5
    • +1
    ./lamsfoundation/lams/security/UniversalLoginModule.java
    • -42
    • +0
    ./lamsfoundation/lams/security/WebAuthAuthenticator.java
    • -86
    • +0
    ./lamsfoundation/lams/security/WebAuthServlet.java
  4. … 3 more files in changeset.
Thursday 27 Nov 2014
1:25 pm

Andrey Balan

LDEV-3382

*Add datetime parameter check to LoginRequest.

*Introduced getServerTime method available for 3rd party servers

Options
    • -7
    • +6
    ./lamsfoundation/lams/web/LoginRequestServlet.java
    • -0
    • +69
    ./lamsfoundation/lams/webservice/GetServerTimeServlet.java
Wednesday 26 Nov 2014
11:00 pm

marek

LDEV-3316: change DAO references from implementations to corresponding interfaces.

Options
    • -39
    • +39
    ./lamsfoundation/lams/authoring/service/AuthoringService.java
  2. … 2 more files in changeset.
12:32 am

Andrey Balan

file GetServerTimeServlet.java was added on branch lams2_head_wildfly on 2014-11-27 12:25:40 +0000

Options
    • -0
    • +0
    ./lamsfoundation/lams/webservice/GetServerTimeServlet.java
12:32 am

Andrey Balan

LDEV-3382

*Add datetime parameter check to LoginRequest.

*Introduced getServerTime method available for 3rd party servers

Options
    • -5
    • +4
    ./lamsfoundation/lams/web/LoginRequestServlet.java
    • -0
    • +69
    ./lamsfoundation/lams/webservice/GetServerTimeServlet.java
  3. … 1 more file in changeset.
Tuesday 25 Nov 2014
10:39 am

Marcin Cieslak

LDEV-3335, LDEV-3340: Make SessionManager a storage for servlet context, so it can be accesses by other classes at any time. Remove obsolete SSO classes.

Options
    • -3
    • +3
    ./lamsfoundation/lams/security/LDAPAuthenticator.java
    • -3
    • +2
    ./lamsfoundation/lams/security/UniversalLoginModule.java
    • -2
    • +2
    ./lamsfoundation/lams/security/WebAuthServlet.java
    • -2
    • +2
    ./lamsfoundation/lams/web/LessonOrderServlet.java
    • -14
    • +31
    ./lamsfoundation/lams/web/SessionListener.java
    • -2
    • +2
    ./lamsfoundation/lams/web/UpdateCollapsedGroupServlet.java
    • -1
    • +1
    ./lamsfoundation/lams/webservice/PresenceChatAction.java
  8. … 9 more files in changeset.
9:43 am

Marcin Cieslak

LDEV-3335, LDEV-3340: Remove or simplify SSO components. Fix sysadmin LoginAs functionality.

Options
    • -116
    • +0
    ./lamsfoundation/lams/security/JspRedirectStrategy.java
    • -30
    • +31
    ./lamsfoundation/lams/security/LDAPAuthenticator.java
    • -3
    • +4
    ./lamsfoundation/lams/security/UniversalLoginModule.java
    • -3
    • +3
    ./lamsfoundation/lams/web/LessonOrderServlet.java
    • -8
    • +8
    ./lamsfoundation/lams/web/LoginAsAction.java
    • -85
    • +11
    ./lamsfoundation/lams/web/LoginRequestServlet.java
    • -21
    • +15
    ./lamsfoundation/lams/web/SessionListener.java
    • -37
    • +38
    ./lamsfoundation/lams/web/UpdateCollapsedGroupServlet.java
    • -6
    • +6
    ./lamsfoundation/lams/webservice/PresenceChatAction.java
  10. … 9 more files in changeset.
Tuesday 18 Nov 2014
5:20 pm

Marcin Cieslak

LDEV-3335, LDEV-3334: Use SSO mechanism introduced in WildFly 9.

Do not create web.xml files with XDoclet as it can not produce them based on 3.1 schema. Use static ones instead.

Make SessionManager just a proxy to webserver's HTTP session. Remov custom shared sessions and JSESSIONIDSSO cookie as they are obsolete. Remove own session monitoring as the container should take care of invalidation.

Move injecting UserDTO into session to SsoHandler intead of UniversalLoginModule as an authentication request may not reach the latter due to WildFly credentials caching.

Options
    • -311
    • +285
    ./lamsfoundation/lams/security/UniversalLoginModule.java
    • -8
    • +1
    ./lamsfoundation/lams/web/HomeAction.java
    • -1
    • +1
    ./lamsfoundation/lams/webservice/xml/LessonManagerServlet.java
  4. … 224 more files in changeset.
Tuesday 11 Nov 2014
1:41 pm

Marcin Cieslak

LDEV-3275: Make XStream use enhanced mode in which it can instantinate classes without no-arg constructors.

This requires Oracle's JVM to be used, but it is a requirement of LAMS anyway.

Otherwise multiple LAMS classes (mainly DTOs) would have to be given no-arg constructors or implement Serializable.

Options
    • -2
    • +3
    ./lamsfoundation/lams/web/planner/PedagogicalPlannerAction.java
  2. … 11 more files in changeset.
Tuesday 04 Nov 2014
12:13 pm

Marcin Cieslak

LDEV-3373: Set current and next activity for learners who finished a lesson, when the activity was added in Live Edit.

Options
    • -6
    • +8
    ./lamsfoundation/lams/authoring/service/AuthoringService.java
    • -13
    • +9
    ./lamsfoundation/lams/authoring/service/EditOnFlyProcessor.java
  3. … 3 more files in changeset.
12:08 pm

Marcin Cieslak

LDEV-3373: Set current and next activity for learners who finished a lesson, when the activity was added in Live Edit.

Options
    • -6
    • +8
    ./lamsfoundation/lams/authoring/service/AuthoringService.java
    • -13
    • +9
    ./lamsfoundation/lams/authoring/service/EditOnFlyProcessor.java
  3. … 3 more files in changeset.
Monday 03 Nov 2014
3:11 pm

Marcin Cieslak

LDEV-3315, LDEV-3367: Refactor SecurityService methods. Improve security in several places.

Options
    • -8
    • +8
    ./lamsfoundation/lams/authoring/web/AuthoringAction.java
    • -3
    • +3
    ./lamsfoundation/lams/web/DisplayGroupAction.java
    • -53
    • +54
    ./lamsfoundation/lams/web/FindUserLessonsAction.java
    • -135
    • +121
    ./lamsfoundation/lams/web/HomeAction.java
    • -36
    • +53
    ./lamsfoundation/lams/web/LessonConditionsAction.java
    • -26
    • +48
    ./lamsfoundation/lams/web/OrganisationGroupAction.java
  7. … 12 more files in changeset.
2:39 pm

Marcin Cieslak

LDEV-3315, LDEV-3367: Refactor SecurityService methods. Improve security in several places.

Options
    • -8
    • +8
    ./lamsfoundation/lams/authoring/web/AuthoringAction.java
    • -3
    • +3
    ./lamsfoundation/lams/web/DisplayGroupAction.java
    • -53
    • +54
    ./lamsfoundation/lams/web/FindUserLessonsAction.java
    • -135
    • +121
    ./lamsfoundation/lams/web/HomeAction.java
    • -36
    • +53
    ./lamsfoundation/lams/web/LessonConditionsAction.java
    • -26
    • +48
    ./lamsfoundation/lams/web/OrganisationGroupAction.java
  7. … 12 more files in changeset.
Wednesday 29 Oct 2014
1:03 pm

Marcin Cieslak

LDEV-3315, LDEV-3367: Refactor SecurityService methods. Replace Monitoring and Gradebook own security code with SecurityService checks.

Options
    • -9
    • +4
    ./lamsfoundation/lams/authoring/web/AuthoringAction.java
    • -8
    • +5
    ./lamsfoundation/lams/web/DisplayGroupAction.java
    • -7
    • +3
    ./lamsfoundation/lams/web/HomeAction.java
  4. … 15 more files in changeset.
12:58 pm

Marcin Cieslak

LDEV-3315, LDEV-3367: Refactor SecurityService methods. Replace Monitoring and Gradebook own security code with SecurityService checks.

Options
    • -9
    • +4
    ./lamsfoundation/lams/authoring/web/AuthoringAction.java
    • -8
    • +5
    ./lamsfoundation/lams/web/DisplayGroupAction.java
    • -7
    • +3
    ./lamsfoundation/lams/web/HomeAction.java
  4. … 17 more files in changeset.
Thursday 23 Oct 2014
3:18 pm

Marcin Cieslak

LDEV-3115: Copy tool content when copying an activity.

Options
    • -6
    • +3
    ./lamsfoundation/lams/authoring/service/AuthoringService.java
    • -5
    • +4
    ./lamsfoundation/lams/authoring/service/IAuthoringService.java
    • -5
    • +29
    ./lamsfoundation/lams/authoring/web/AuthoringAction.java
  4. … 2 more files in changeset.
3:16 pm

Marcin Cieslak

LDEV-3115: Copy tool content when copying an activity.

Options
    • -6
    • +3
    ./lamsfoundation/lams/authoring/service/AuthoringService.java
    • -5
    • +4
    ./lamsfoundation/lams/authoring/service/IAuthoringService.java
    • -5
    • +29
    ./lamsfoundation/lams/authoring/web/AuthoringAction.java
  4. … 2 more files in changeset.
1:11 pm

Marcin Cieslak

LDEV-3358: Fix attribute storing and loading for different grouping types.

Options
    • -2
    • +2
    ./lamsfoundation/lams/authoring/ObjectExtractor.java
  2. … 2 more files in changeset.
1:07 pm

Marcin Cieslak

LDEV-3358: Fix attribute storing and loading for different grouping types.

Options
    • -2
    • +2
    ./lamsfoundation/lams/authoring/ObjectExtractor.java
  2. … 2 more files in changeset.
Tuesday 21 Oct 2014
8:50 pm

Marcin Cieslak

LDEV-3331: Allow logging in via integrations. Allow redirecting to a given URL after log in. Adjust sysadmin "login as" functionality.

Options
    • -8
    • +8
    ./lamsfoundation/lams/web/LoginAsAction.java
    • -12
    • +17
    ./lamsfoundation/lams/web/LoginRequestServlet.java
  3. … 2 more files in changeset.
12:27 pm

Marcin Cieslak

LDEV-3315: Add security service and use it in vital entry points.

Options
    • -2
    • +23
    ./lamsfoundation/lams/authoring/web/AuthoringAction.java
    • -8
    • +30
    ./lamsfoundation/lams/web/DisplayGroupAction.java
    • -12
    • +33
    ./lamsfoundation/lams/web/HomeAction.java
  4. … 12 more files in changeset.
Monday 20 Oct 2014
11:27 am

Marcin Cieslak

LDEV-3315: Add utility methods for security. Use the new SecurityService in several places.

Options
    • -2
    • +23
    ./lamsfoundation/lams/authoring/web/AuthoringAction.java
  2. … 8 more files in changeset.
Sunday 19 Oct 2014
10:35 am

marek

LDEV-3332: revert spring-beans schema declaration in application context xml files. export spring meta-inf in jboss-deployment-structure.xml

It is way more elegant approach to fix an issue with spring-beans.xsd loading from internet.

Options
    • -1
    • +1
    ./lamsfoundation/lams/authoring/authoringApplicationContext.xml
    • -1
    • +1
    ./lamsfoundation/lams/web/webApplicationContext.xml
    • -1
    • +1
    ./lamsfoundation/lams/workspace/workspaceApplicationContext.xml
  4. … 75 more files in changeset.
Saturday 18 Oct 2014
10:28 pm

marek

LDEV-3332: fix spring contexts declaration to find spring-beans-4.0.xsd locally at classpath.

Having spring module defined as a set of spring jars (as we do have in Wildfly), it is impossible for spring to resolve xsd schema mapping file 'spring.schemas' correctly. With set of jars, we have 5 instances of this file (with different content) under the same path 'META-INF/spring.schemas'. This ended up in spring not beeing able to map spring-beans-4.0.xsd URL path to local resource location. Finally, this xsd was loaded from internet - and that significantly slowed Wildfly startup.

With this fix LAMS is way (depends on internet connection) faster to start.

Options
    • -1
    • +1
    ./lamsfoundation/lams/authoring/authoringApplicationContext.xml
    • -1
    • +1
    ./lamsfoundation/lams/web/webApplicationContext.xml
    • -1
    • +1
    ./lamsfoundation/lams/workspace/workspaceApplicationContext.xml
  4. … 74 more files in changeset.
Tuesday 14 Oct 2014
6:43 pm

Marcin Cieslak

LDEV-3275: Remove duplicate error log.

Options
    • -2
    • +1
    ./lamsfoundation/lams/security/UniversalLoginModule.java
2:49 pm

Marcin Cieslak

LDEV-3275: Add SsoConsumer in LAMS Central as requests (index.jsp, index.do) immediate after j_security_check are also being authenticated.

They also are considered an authentication attempt, but they bypass shared session creation in SsoProducer and it causes errors. This was addressed by a simple check - no shared session in UniversalLoginModule, no authentication attempt.

Options
    • -3
    • +3
    ./lamsfoundation/lams/security/UniversalLoginModule.java
  2. … 2 more files in changeset.
Tuesday 07 Oct 2014
6:47 pm

Marcin Cieslak

LDEV-3321: Use the "progressUser" to produce progress output, not the one being authenticated.

Options
    • -1
    • +1
    ./lamsfoundation/lams/webservice/xml/LessonManagerServlet.java
6:45 pm

Marcin Cieslak

LDEV-3321: Use the "progressUser" to produce progress output, not the one being authenticated.

Options
    • -1
    • +1
    ./lamsfoundation/lams/webservice/xml/LessonManagerServlet.java
Friday 03 Oct 2014
3:10 pm

Marcin Cieslak

LDEV-3315: Add security service and use it in vital entry points.

Options
    • -8
    • +30
    ./lamsfoundation/lams/web/DisplayGroupAction.java
    • -12
    • +33
    ./lamsfoundation/lams/web/HomeAction.java
  3. … 11 more files in changeset.
Tuesday 30 Sep 2014
3:10 pm

Marcin Cieslak

LDEV-3315: Clean up roles and paths to secured resources in all modules.

Remove AUTHOR ADMIN role.

Options
    • -290
    • +310
    ./lamsfoundation/lams/security/UniversalLoginModule.java
    • -4
    • +3
    ./lamsfoundation/lams/web/IndexAction.java
    • -9
    • +9
    ./lamsfoundation/lams/web/planner/PedagogicalPlannerAction.java
    • -4
    • +3
    ./lamsfoundation/lams/workspace/service/WorkspaceManagementService.java
  5. … 70 more files in changeset.