lams

lams_tool_dimdim

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 7
Last Commit:
Commits this week: 0
Total Lines of Code (LoC): 534
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 11 May 2012
5:29 pm

Marcin Cieslak

CNG-7: Add ISBN collections. Add buttons to manage them.

Allow going back to MindTap views from different LAMS screens, like Preview or Tool authoring.

Major clean up, split bloated code to MindappAction (request processing) and MindappService (helper methods).

Options
    • -0
    • +2
    ./web/WEB-INF/tags/AuthoringButton.tag
  2. … 31 more files in changeset.
Thursday 12 Apr 2012
1:07 am

Andrey Balan

LDEV-2329 fix for Chrome (as it doesn't execute location.href="bla-bla" command if window is going to be closed)

Options
    • -2
    • +3
    ./web/WEB-INF/tags/AuthoringButton.tag
  2. … 32 more files in changeset.
Wednesday 28 Mar 2012
3:13 am

Marcin Cieslak

LDEV-2839: Convert custom ExportPortOutput and ProgressOutput tags to plain JSP pages.

These tags call include themselves recursivly what causes errors in JSP precompilation process. This is a know bug (JBAS-7496) of JBoss 5.1, fixed in JBoss 7.

These tags were used only in lams_learning, so after conversion they were left only there. They were removed from all other projects.

Options
    • -9
    • +0
    ./web/WEB-INF/lams.tld
    • -59
    • +0
    ./web/WEB-INF/tags/ExportPortOutput.tag
    • -79
    • +0
    ./web/WEB-INF/tags/ProgressOutput.tag
  4. … 100 more files in changeset.
Tuesday 27 Mar 2012
6:37 pm

Marcin Cieslak

LDEV-2839: Make JSP precompilation task independent of schemaexport.classpath Ant variable which does not exist and is not needed in all projects.

Options
    • -1
    • +2
    ./build.xml
  2. … 26 more files in changeset.
6:25 pm

Marcin Cieslak

LDEV-2839: Simplify choosing files for WAR with precompiled JSPs. Current solution creates unnecessary tree of empty directories where JSPs were located. The advantage is that special directories in Tools like Wiki (wikiling plugin) or Videorecorder (previewImages and recordings) do not need to be listed explicitly for compilation which allows generic Ant task for Tools and other projects.

Options
    • -5
    • +3
    ./build.xml
  2. … 26 more files in changeset.
Friday 23 Mar 2012
6:41 pm

Marcin Cieslak

LDEV-2839: Create Java source folder if it was not created in previous step (Java files generation from JSPs) to prevent compilation errors.

Options
    • -0
    • +3
    ./build.xml
  2. … 6 more files in changeset.
6:11 pm

Marcin Cieslak

LDEV-2839: Add project libraries to WAR.

Options
    • -1
    • +13
    ./build.xml
  2. … 4 more files in changeset.
Thursday 22 Mar 2012
8:27 pm

Marcin Cieslak

LDEV-2839: Allow JSP precompilation in Dimdim Tool.

Options
    • -3
    • +5
    ./build.properties
    • -27
    • +103
    ./build.xml
8:26 pm

Marcin Cieslak

LDEV-2839: Dimdim Tool clean up: Remove duplicate MANIFEST.

Options
    • -5
    • +0
    ./web/META-INF/MANIFEST.MF
8:17 pm

Andrey Balan

LDEV-1737 Modified Define in Monitor so it doesn't show the "Re-Edit" or "Close" page

Options
    • -17
    • +35
    ./web/WEB-INF/tags/AuthoringButton.tag
  2. … 26 more files in changeset.
Tuesday 06 Mar 2012
7:15 pm

Marcin Cieslak

LDEV-2823: Add properties that select whether standalone or embedded MySQL should be used for LAMS run and/or build.

Make all Tools use MXJ connectors if needed.

Make Tool Deployer usage lighter - libraries are not copied to Tools but they are referenced from a single spot.

Copy MXJ connectors from "mysql_embedded" project if needed.

Options
    • -14
    • +14
    ./build.xml
  2. … 50 more files in changeset.
Friday 17 Feb 2012
3:34 am

Andrey Balan

LDEV-2799 Kaltura FCKEditor plugin: fix for IE9 (forces IE9 to behave as it is IE8)

Options
    • -1
    • +2
    ./web/WEB-INF/tags/Head.tag
  2. … 29 more files in changeset.
Monday 26 Dec 2011
7:40 pm

Marcin Cieslak

LDEV-2751: Change default width of CKEditor to "100%" so it is the same as in old FCKeditor.

Options
    • -1
    • +1
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 29 more files in changeset.
Monday 19 Dec 2011
3:29 pm

Marcin Cieslak

LDEV-2732: Copy the modified CKEditor tag to all Tools.

Options
    • -0
    • +13
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 28 more files in changeset.
Tuesday 06 Sep 2011
9:13 am

Marcin Cieslak

CNG-1: Single activity LD configuration opens authoring for only that activity instead of Planner with the whole LD. Parameter "notifyCloseURL" support has been added to each Tool's authoring saved page in order to redirect back to MindApp.

Options
    • -1
    • +14
    ./web/WEB-INF/tags/AuthoringButton.tag
  2. … 30 more files in changeset.
Friday 29 Jul 2011
10:55 pm

Andrey Balan

LDEV-2702 moving css properties from TabName.tag to .css files

merge from lams2_3_release

Options
    • -4
    • +3
    ./web/WEB-INF/tags/TabName.tag
  2. … 34 more files in changeset.
Monday 04 Jul 2011
7:59 pm

Andrey Balan

LDEV-2664 LearnerFlashEnabled.tag has been reimplemented as Java class

(this is done in order to prevent updating list of mobile devices in all modules )

*merged from lams2_3_release

Options
    • -4
    • +9
    ./web/WEB-INF/lams.tld
    • -45
    • +0
    ./web/WEB-INF/tags/LearnerFlashEnabled.tag
  3. … 59 more files in changeset.
Sunday 03 Jul 2011
3:30 am

Andrey Balan

LDEV-2664 LearnerFlashEnabled.tag has been reimplemented as Java class

(this is done in order to prevent updating list of mobile devices in all modules )

Options
    • -4
    • +9
    ./web/WEB-INF/lams.tld
    • -45
    • +0
    ./web/WEB-INF/tags/LearnerFlashEnabled.tag
  3. … 59 more files in changeset.
Friday 11 Feb 2011
6:29 am

Andrey Balan

LDEV-1730 If Tool is not group do now show the group reference

Options
    • -1
    • +5
    ./src/java/org/lamsfoundation/lams/tool/dimdim/service/DimdimService.java
    • -1
    • +9
    ./src/java/org/lamsfoundation/lams/tool/dimdim/service/IDimdimService.java
    • -1
    • +2
    ./src/java/org/lamsfoundation/lams/tool/dimdim/util/Constants.java
    • -2
    • +4
    ./src/java/org/lamsfoundation/lams/tool/dimdim/web/actions/MonitoringAction.java
    • -3
    • +5
    ./web/pages/monitoring/summary.jsp
  6. … 9 more files in changeset.
Sunday 12 Dec 2010
10:29 pm

Marcin Cieslak

LDEV-2577: Fixed a bug preventing multiple CKEditor instances on one page to be properly reinitialized after form submit.

Options
    • -7
    • +14
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 27 more files in changeset.
Monday 06 Dec 2010
4:48 am

Marcin Cieslak

LDEV-2577: Added extra safety measure preventing plain textarea from being show instead of CKEditor instance.

Options
    • -1
    • +1
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 27 more files in changeset.
Wednesday 24 Nov 2010
2:34 am

Marcin Cieslak

LDEV-2607: Hardcoded CKEditor width as a fix for Chrome inability to process "100%" width correctly.

Options
    • -1
    • +1
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 26 more files in changeset.
Monday 22 Nov 2010
3:11 pm

Marcin Cieslak

LDEV-2577: Set default height for CKEditor instances, as in IE it was minimal.

Options
    • -0
    • +4
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 27 more files in changeset.
Thursday 18 Nov 2010
6:19 am

Marcin Cieslak

LDEV-2595: As CSS parameter "display: none" does not work in IE, the initial textarea for CKEditor has height = 0px which does the trick instead.

Options
    • -1
    • +1
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 27 more files in changeset.
Friday 05 Nov 2010
4:22 am

Marcin Cieslak

LDEV-2596: Forcing CKEditor be reinitialized after AJAX form submit.

Options
    • -17
    • +27
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 28 more files in changeset.
Sunday 24 Oct 2010
9:36 pm

Marcin Cieslak

LDEV-2577: Readded videorecorder plugin. Readded missing contentFolderID parameter to CKEditor instances.

Options
    • -1
    • +2
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 36 more files in changeset.
Friday 22 Oct 2010
2:50 am

Marcin Cieslak

LDEV-2577, LDEV-2588:

Fixed names of buttons that have changed from FCKEditor.

CKEditor are hidden until they are completely initialized.

Options
    • -1
    • +1
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 25 more files in changeset.
Sunday 10 Oct 2010
7:46 pm

Marcin Cieslak

LDEV-2577: Removed quotation marks on "displayExpanded" option so it gets parsed correctly.

Options
    • -1
    • +1
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 27 more files in changeset.
Wednesday 06 Oct 2010
6:09 pm

Marcin Cieslak

LDEV-2577

The new CKEditor does not have Java Integration library (yet). We have been

using it to:

a) get the tag library to create our own tag <lams:FCKeditor>

But the new CKEditor uses AJAX to get the contents, so the library is

not needed anymore.

The references to it has been deleted from every tool.

FCKEditor.tag has been rewritten to use the new syntax.

b) get a FCKEditor internal file manager by a Connector from the jar

The new CKEditor does not provide a file manager - the license became

commercial and the whole thing became a separate project, CKFinder.

There were alternatives suggested on the web:

jasfinder - http://sourceforge.net/projects/jasfinder/support

kcfinder - http://kcfinder.sunhater.com/

some other - http://www.miguelmanchego.com/2009/gestor-de-archivos-ckeditor/

but we have already nicely integrated with the old file manager. This page:

http://jacek-kromski.jogger.pl/2009/09/25/integracja-ckeditor-z-przegladarka-plikow-z-fckeditor/

in polish says how to use the file manager from the old FCKEditor.

The steps that have to be done:

- download the new CKEditor

- download the old FCKEditor

- copy the filemanager to ckeditor directory

- in the file browser/default/frmresourceslist.html, line 92 (with SetUrl call) needs to be replaced to:

window.top.opener.CKEDITOR.tools.callFunction( window.top.document.CKEditorFuncNum, fileUrl, '' );

- in the file browser/default/browser.html add in line 80:

document.CKEditorFuncNum = GetUrlParam( 'CKEditorFuncNum');

FCKeditor has been used in version 2.6.6, the last one before switching to CKEditor project.

Changes required to use newer version of Java Integration library

for FCKEditor so it was upgraded to the latest (for FCKEditor, because one for CKEditor does not exist) version 2.6.

This also required the Prototype to be upgraded to the latest 1.6.1.

The CKEditor code also needed to be changed, so if another upgrade to a newer version occurs, we need to remember to repeat these steps:

http://cksource.com/forums/viewtopic.php?f=5&t=15750

It says:

/ckeditor/plugins/link/dialogs/link.js

Changes

label:a.lang.common.target,'default':'notSet' --> label:a.lang.common.target,'default':'_blank'

label:a.lang.link.targetFrameName,'default':'' --> label:a.lang.link.targetFrameName,'default':'_blank'

It is also worth mentioning that if you include the ckeditor.js file twice in the same page, sometimes it causes trouble, thus detection in the CKEditor.tag files.

Options
    • -1
    • +1
    ./conf/xdoclet/servlet-mappings.xml
    • -4
    • +0
    ./conf/xdoclet/taglibs.xml
    • -2
    • +2
    ./web/WEB-INF/lams.tld
    • -129
    • +0
    ./web/WEB-INF/fckeditor/tlds/FCKeditor.tld
    • -0
    • +53
    ./web/WEB-INF/tags/CKEditor.tag
    • -53
    • +0
    ./web/WEB-INF/tags/FCKEditor.tag
    • -1
    • +0
    ./web/common/taglibs.jsp
    • -2
    • +2
    ./web/pages/authoring/basic.jsp
  9. … 1089 more files in changeset.
Thursday 18 Mar 2010
8:58 pm

Andrey Balan

LDEV-2329 When editing in monitor if press the "Cancel" button, the define_later flag *does* get removed.

Options
    • -1
    • +1
    ./web/WEB-INF/tags/AuthoringButton.tag
  2. … 28 more files in changeset.