lams / lams_tool_sbmt

src

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 16
Last Commit:
Commits this week: 0
Total Lines of Code (LoC): 7,996
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 30 Dec 2015
9:39 pm

Marcin Cieslak

LDEV-3638: Remove lesson and all its resources on demand.

Files in content repository stay.

Clean up unnecessary code, format.

Options
    • -16
    • +14
    ./java/org/lamsfoundation/lams/tool/sbmt/service/SubmitFilesService.java
  2. … 47 more files in changeset.
9:38 pm

Marcin Cieslak

LDEV-3640: Add cascades in tool tables.

Options
    • binary
    ./java/org/lamsfoundation/lams/tool/sbmt/dbupdates/patch20151217.sql
  2. … 28 more files in changeset.
8:08 pm

Marcin Cieslak

LDEV-3638: Remove lesson and all its resources on demand.

Files in content repository stay.

Clean up unnecessary code, format.

Options
    • -78
    • +118
    ./java/org/lamsfoundation/lams/tool/sbmt/service/SubmitFilesService.java
  2. … 48 more files in changeset.
7:58 pm

Marcin Cieslak

file patch20151217.sql was added on branch lams2_head_wildfly on 2015-12-30 20:38:27 +0000

Options
    • binary
    ./java/org/lamsfoundation/lams/tool/sbmt/dbupdates/patch20151217.sql
7:57 pm

Marcin Cieslak

LDEV-3640: Add cascades in tool tables.

Options
    • binary
    ./java/org/lamsfoundation/lams/tool/sbmt/dbupdates/patch20151217.sql
  2. … 27 more files in changeset.
Friday 25 Sep 2015
3:27 pm

Marcin Cieslak

LDEV-3561: Initial implemntation of re-setting read-only flag of Activities on force uncomplete.

Each Tools' service has a method to report whether there is significant users' content left it the Activity. If so, it reports the Activity as read-only. Otherwise the flag can be re-set.

Grouping, Gate and Complex activities also have their way of checking their immutability.

Options
    • -63
    • +117
    ./java/org/lamsfoundation/lams/tool/sbmt/service/SubmitFilesService.java
  2. … 42 more files in changeset.
Monday 10 Aug 2015
5:24 pm

Marcin Cieslak

LDEV-3514: Use pretInterceptor instead of postInterceptor.

Create new transactions for service method retries.

Attach activity to Hibernate session in completeActivity() method.

Options
    • -1
    • +1
    ./java/org/lamsfoundation/lams/tool/sbmt/submitFilesApplicationContext.xml
  2. … 45 more files in changeset.
5:07 pm

Marcin Cieslak

LDEV-3514: Use pretInterceptor instead of postInterceptor.

Create new transactions for service method retries.

Attach activity to Hibernate session in completeActivity() method.

Options
    • -1
    • +1
    ./java/org/lamsfoundation/lams/tool/sbmt/submitFilesApplicationContext.xml
  2. … 43 more files in changeset.
Wednesday 05 Aug 2015
7:44 pm

Marcin Cieslak

LDEV-3514: Use postInterceptor instead of preInterceptor.

PreInterceptor apparently runs before Hibernate transaction gets created. When an exception in the proxied method occurs, the transaction is canceled and is not re-created when retry is attempted. This leads to "no session" or "read only transaction on write" errors.

PostInterceptor seems to work when the transaction is already created, so retries happen witin its scope.

Options
    • -1
    • +1
    ./java/org/lamsfoundation/lams/tool/sbmt/submitFilesApplicationContext.xml
  2. … 39 more files in changeset.
6:49 pm

Marcin Cieslak

LDEV-3514: Use postInterceptor instead of preInterceptor.

PreInterceptor apparently runs before Hibernate transaction gets created. When an exception in the proxied method occurs, the transaction is canceled and is not re-created when retry is attempted. This leads to "no session" or "read only transaction on write" errors.

PostInterceptor seems to work when the transaction is already created, so retries happen witin its scope.

Options
    • -1
    • +1
    ./java/org/lamsfoundation/lams/tool/sbmt/submitFilesApplicationContext.xml
  2. … 39 more files in changeset.
Wednesday 22 Jul 2015
10:46 am

Marcin Cieslak

LDEV-3514: Wrap all transactional methods with TransactionRetryInterceptor. Set number of attempts to 3.

Remove previous safety mechanism for completeActivity() method.

Options
    • -1
    • +5
    ./java/org/lamsfoundation/lams/tool/sbmt/submitFilesApplicationContext.xml
  2. … 41 more files in changeset.
9:59 am

Marcin Cieslak

LDEV-3514: Wrap all transactional methods with TransactionRetryInterceptor. Set number of attempts to 3.

Remove previous safety mechanism for completeActivity() method.

Options
    • -1
    • +5
    ./java/org/lamsfoundation/lams/tool/sbmt/submitFilesApplicationContext.xml
  2. … 42 more files in changeset.
Friday 17 Jul 2015
1:40 pm

Marcin Cieslak

LDEV-3507: Remove error message when Tool Content was not found. A simple getter method should not report errors.

Options
    • -5
    • +1
    ./java/org/lamsfoundation/lams/tool/sbmt/service/SubmitFilesService.java
  2. … 10 more files in changeset.
1:23 pm

Marcin Cieslak

LDEV-3507: Remove error message when Tool Content was not found. A simple getter method should not report errors.

Options
    • -4
    • +1
    ./java/org/lamsfoundation/lams/tool/sbmt/service/SubmitFilesService.java
  2. … 10 more files in changeset.
Friday 03 Jul 2015
10:34 pm

Andrey Balan

LDEV-3486 Assign marks to learner in leader aware tools when he gets force completed

Options
    • -72
    • +18
    ./java/org/lamsfoundation/lams/tool/sbmt/service/SubmitFilesService.java
  2. … 33 more files in changeset.
Friday 19 Jun 2015
3:57 pm

Andrey Balan

LDEV-3486 Assign marks to learner in leader aware tools when he gets force completed

Options
    • -73
    • +18
    ./java/org/lamsfoundation/lams/tool/sbmt/service/SubmitFilesService.java
  2. … 32 more files in changeset.
7:43 am

fionam

LDEV-3455: Removing submission entry that should not have been added the REST authoring.

Options
    • -2
    • +2
    ./java/org/lamsfoundation/lams/tool/sbmt/service/SubmitFilesService.java
  2. … 1 more file in changeset.
Tuesday 09 Jun 2015
1:36 pm

fionam

LDEV-3455: Submission deadline should not have been included in the REST authoring interface as it is set in monitoring. Removing.

Options
    • -2
    • +2
    ./java/org/lamsfoundation/lams/tool/sbmt/service/SubmitFilesService.java
  2. … 5 more files in changeset.
Wednesday 03 Jun 2015
2:33 am

fionam

LDEV-3455: Rest authoring support adde

Options
    • -2
    • +63
    ./java/org/lamsfoundation/lams/tool/sbmt/service/SubmitFilesService.java
1:59 am

fionam

LDEV-3455: Rest authoring support added

Options
    • -2
    • +63
    ./java/org/lamsfoundation/lams/tool/sbmt/service/SubmitFilesService.java
  2. … 1 more file in changeset.
Tuesday 17 Feb 2015
4:40 pm

Marcin Cieslak

LDEV-3432: Remove limitation for reflect instructions.

Options
    • binary
    ./java/org/lamsfoundation/lams/tool/sbmt/dbupdates/patch20150217.sql
  2. … 9 more files in changeset.
4:36 pm

Marcin Cieslak

file patch20150217.sql was added on branch lams2_head_wildfly on 2015-02-17 15:40:28 +0000

Options
    • binary
    ./java/org/lamsfoundation/lams/tool/sbmt/dbupdates/patch20150217.sql
4:36 pm

Marcin Cieslak

LDEV-3432: Remove limitation for reflect instructions.

Options
    • binary
    ./java/org/lamsfoundation/lams/tool/sbmt/dbupdates/patch20150217.sql
  2. … 10 more files in changeset.
Saturday 29 Nov 2014
10:41 pm

marek

LDEV-3316: Get rid of HibernateTemplate and HibernateDaoSupport usage in set of LAMS DAO types from lams_tool_sbmt

Options
    • -7
    • +8
    ./java/org/lamsfoundation/lams/tool/sbmt/dao/hibernate/SubmissionDetailsDAO.java
    • -4
    • +6
    ./java/org/lamsfoundation/lams/tool/sbmt/dao/hibernate/SubmitFilesContentDAO.java
    • -6
    • +7
    ./java/org/lamsfoundation/lams/tool/sbmt/dao/hibernate/SubmitFilesReportDAO.java
    • -4
    • +6
    ./java/org/lamsfoundation/lams/tool/sbmt/dao/hibernate/SubmitFilesSessionDAO.java
    • -7
    • +8
    ./java/org/lamsfoundation/lams/tool/sbmt/dao/hibernate/SubmitUserDAO.java
Sunday 19 Oct 2014
10:35 am

marek

LDEV-3332: revert spring-beans schema declaration in application context xml files. export spring meta-inf in jboss-deployment-structure.xml

It is way more elegant approach to fix an issue with spring-beans.xsd loading from internet.

Options
    • -1
    • +1
    ./java/org/lamsfoundation/lams/tool/sbmt/submitFilesApplicationContext.xml
    • -1
    • +1
    ./java/org/lamsfoundation/lams/tool/sbmt/dbupdates/autopatchContext.xml
  3. … 76 more files in changeset.
Saturday 18 Oct 2014
10:28 pm

marek

LDEV-3332: fix spring contexts declaration to find spring-beans-4.0.xsd locally at classpath.

Having spring module defined as a set of spring jars (as we do have in Wildfly), it is impossible for spring to resolve xsd schema mapping file 'spring.schemas' correctly. With set of jars, we have 5 instances of this file (with different content) under the same path 'META-INF/spring.schemas'. This ended up in spring not beeing able to map spring-beans-4.0.xsd URL path to local resource location. Finally, this xsd was loaded from internet - and that significantly slowed Wildfly startup.

With this fix LAMS is way (depends on internet connection) faster to start.

Options
    • -1
    • +1
    ./java/org/lamsfoundation/lams/tool/sbmt/submitFilesApplicationContext.xml
    • -1
    • +1
    ./java/org/lamsfoundation/lams/tool/sbmt/dbupdates/autopatchContext.xml
  3. … 75 more files in changeset.
Thursday 09 Oct 2014
11:55 am

Marcin Cieslak

LDEV-3319: Synchronize patch execution with an external monitor.

Modules in WildFly can be loaded in parallel. AutoPatch is not ready for this as it uses static methods with unsynchronized collections. Each AutoPatchService instance should be run sequentially.

Options
    • -1
    • +1
    ./java/org/lamsfoundation/lams/tool/sbmt/dbupdates/autopatchContext.xml
  2. … 32 more files in changeset.
Saturday 16 Aug 2014
1:20 pm

Marcin Cieslak

LDEV-3293: Rewrite Application Context configuration files for Spring 4.

Options
    • -4
    • +5
    ./java/org/lamsfoundation/lams/tool/sbmt/submitFilesApplicationContext.xml
    • -2
    • +5
    ./java/org/lamsfoundation/lams/tool/sbmt/dbupdates/autopatchContext.xml
  3. … 77 more files in changeset.
Friday 15 Aug 2014
11:57 am

Marcin Cieslak

LDEV-3293: Use the new Spring's support for Hibernate 4 instead of Hibernate 3. Switch from using HibernateDaoSupport.getSession() to its getSessionFactory().getSession(). The latter is sure to close the session automatically while a session returned by the first method should be closed manually. Theoritecally we do it in OpenSessionInViewFilter, but it may not be always the case, leading to open Hibernate session being left behind.

Options
    • -2
    • +2
    ./java/org/lamsfoundation/lams/tool/sbmt/dao/hibernate/SubmissionDetailsDAO.java
    • -2
    • +2
    ./java/org/lamsfoundation/lams/tool/sbmt/dao/hibernate/SubmitFilesSessionDAO.java
  3. … 86 more files in changeset.
11:30 am

Marcin Cieslak

LDEV-3293: Cast DAO methods' results to their return type.

Java 8 is more restrictive about generics. Hibernate find() methods returns List<?> and it can not be quietly cast to List<SomeClass>. Each occurence was explicitly casted and warnings about the type being unchecked were supressed.

Options
    • -2
    • +3
    ./java/org/lamsfoundation/lams/tool/sbmt/dao/hibernate/SubmissionDetailsDAO.java
    • -2
    • +3
    ./java/org/lamsfoundation/lams/tool/sbmt/dao/hibernate/SubmitUserDAO.java
  3. … 54 more files in changeset.