Clone
Tools

 

fmalikoff in lams-github

About

1,812 commits
  • Committer is not mapped to a user
  • First commit: 21 December 2004
  • Last commit: 24 November 2010
Last Week All Time
Commits: 0 1,812

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Wednesday 24 Nov 2010
10:11 pm

fmalikoff

LDEV-2611 Added import filter to remove the old isOptional field and correctly add the required field.

Options
    • -0
    • +6
    /lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/service/QaImportContentVersionFilter.java
Monday 01 Nov 2010
8:27 pm

fmalikoff

Merging changes from 2.3 release branch for LDEV-2524.

Options
    • -1
    • +1
    /lams_tool_laqa/conf/hibernate/mappings/org/lamsfoundation/lams/tool/qa/QaContent.hbm.xml
    • -0
    • +10
    /lams_tool_laqa/conf/hibernate/mappings/org/lamsfoundation/lams/tool/qa/QaQueContent.hbm.xml
    • -0
    • +1
    /lams_tool_laqa/db/sql/create_lams_tool_qa.sql
    • -0
    • +9
    /lams_tool_laqa/db/sql/updatescripts/updateTo20101022.sql
    • -21
    • +4
    /lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/GeneralLearnerFlowDTO.java
    • -15
    • +0
    /lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/GeneralMonitoringDTO.java
    • -1
    • +1
    /lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/QaAppConstants.java
    • -2
    • +2
    /lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/QaCondition.java
    • -1
    • +1
    /lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/QaConditionDTO.java
    • -17
    • +1
    /lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/QaGeneralAuthoringDTO.java
    • -26
    • +22
    /lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/QaQueContent.java
    • -1
    • +32
    /lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/QaQuestionContentDTO.java
    • -11
    • +0
    /lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/QaUtils.java
    • -102
    • +43
    /lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/web/AuthoringUtil.java
    • -11
    • +6
    /lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/web/LearningUtil.java
  16. … 15 more files in changeset.
8:19 pm

fmalikoff

Merging changes from 2.3 release branch. Working on bugs LDEV-2524, LDEV-2578, LDEV-2581

Options
    • -1
    • +1
    /lams_tool_laqa/build.properties
    • -32
    • +96
    /lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/web/QaLearningAction.java
Monday 14 Jul 2008
11:58 am

fmalikoff

LDEV-1662: Fixing up the advanced options in monitoring so that they look correct in RTL locales.

Options
    • -6
    • +6
    /lams_tool_task/conf/language/lams/ApplicationResources.properties
    • -6
    • +6
    /lams_tool_task/conf/language/lams/ApplicationResources_en_AU.properties
    • -8
    • +14
    /lams_tool_task/web/pages/monitoring/summary.jsp
11:33 am

fmalikoff

LDEV-1662: Adding new style to support the advanced options

Options
    • -12
    • +14
    /lams_tool_task/web/pages/monitoring/summary.jsp
11:32 am

fmalikoff

LDEV-1662: Entries for On and Off were not internationalised.

Options
    • -1
    • +2
    /lams_tool_task/conf/language/lams/ApplicationResources.properties
    • -0
    • +2
    /lams_tool_task/conf/language/lams/ApplicationResources_en_AU.properties
11:30 am

fmalikoff

LDEV-1662: Adding a new section to each monitoring summary screen, to show the advanced options.

Options
    • -0
    • +12
    /lams_central/web/css/defaultHTML.css
Wednesday 25 Jun 2008
2:40 pm

fmalikoff

LDEV-1208: Preview's special define later screen to update the Flash progress bar.

Options
    • -2
    • +3
    /lams_learning/src/java/org/lamsfoundation/lams/learning/web/action/LoadToolActivityAction.java
    • -0
    • +6
    /lams_learning/web/previewDefineLater.jsp
12:33 pm

fmalikoff

LDEV-1217: Check the length of the description so that it doesn't trigger a database error.

Options
    • -0
    • +1
    /lams_tool_sbmt/conf/language/lams/ApplicationResources.properties
    • -0
    • +2
    /lams_tool_sbmt/src/java/org/lamsfoundation/lams/tool/sbmt/form/LearnerForm.java
    • -0
    • +2
    /lams_tool_sbmt/src/java/org/lamsfoundation/lams/tool/sbmt/web/LearnerAction.java
Tuesday 24 Jun 2008
12:12 pm

fmalikoff

Updating project property for the correct version

Options
    • -1
    • +1
    /lams_build/common.properties
Wednesday 18 Jun 2008
10:01 am

fmalikoff

LDEV-1833: Was throwing exception if asked for the tool output for a user that has not answered the questions. Now returns null.

Options
    • -13
    • +24
    /lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/service/MCOutputFactory.java
Tuesday 17 Jun 2008
6:59 pm

fmalikoff

Updating scripts to call deploy.xml, rather than deploy.properties

Options
    • -1
    • +2
    /lams_build/deploy-tool/deploy.bat
    • -3
    • +2
    /lams_build/deploy-tool/deploy.sh
3:52 pm

fmalikoff

Version updated for 2.1 release

Options
    • -1
    • +1
    /lams_tool_nb/build.properties
Monday 16 Jun 2008
10:54 am

fmalikoff

LDEV-1825: When we copy a learning design, make sure any grouping details and associated mappings attached to a teacher chosen branching or a define later grouped branching are not copied. If we don't do this, we encounter problems when run a design that has been attached to a lesson. Otherwise we either throw an exception (as the grouping doesn't exist) or we use the groupings that were used in the previous lesson and they may not be wanted.

Options
    • -13
    • +27
    /lams_central/src/java/org/lamsfoundation/lams/authoring/service/AuthoringService.java
    • -0
    • +8
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/ChosenBranchingActivity.java
    • -1
    • +10
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/ToolBranchingActivity.java
Tuesday 10 Jun 2008
4:30 pm

fmalikoff

LI-161: Correcting constructors

Options
    • -2
    • +2
    /lams_tool_deploy/test/java/org/lamsfoundation/lams/tool/deploy/DeployToolConfigTest.java
    • -2
    • +2
    /lams_tool_deploy/test/java/org/lamsfoundation/lams/tool/deploy/libraryActivity/DeployLibraryConfigTest.java
    • -1
    • +1
    /lams_tool_deploy/test/java/org/lamsfoundation/lams/tool/deploy/libraryActivity/LibraryDBDeployTaskTest.java
3:48 pm

fmalikoff

LI-161: Replacing / in windows paths to \ to make all the paths consistent.

Options
    • binary
    /lams_build/deploy-tool/lib/lams-tool-deploy.jar
    • -0
    • +4
    /lams_tool_deploy/src/java/org/lamsfoundation/lams/tool/deploy/DeployToolConfig.java
3:01 pm

fmalikoff

LI-161: Added a new build task deploy-tools-for-upgrader that only run the tool deploy part, and not the combined activities.

Options
    • -0
    • +4
    /lams_build/build.xml
2:48 pm

fmalikoff

LI-161: Generate special version of deploy.xml for tools that has a generic parameter in the place of the drive paths. This is turned on in common.properties (generate for installer) in lams_build. Only use this option if you are writing an installer/updater.

Options
    • binary
    /lams_build/deploy-tool/lib/lams-tool-deploy.jar
    • -1
    • +1
    /lams_tool_deploy/src/java/org/lamsfoundation/lams/tool/deploy/libraryActivity/DeployLibrary.java
2:16 pm

fmalikoff

LI-161: Generate special version of deploy.xml for tools that has a generic parameter in the place of the drive paths. This is turned on in common.properties (generate for installer) in lams_build. Only use this option if you are writing an installer/updater.

Options
    • -0
    • +12
    /lams_build/build.xml
    • -0
    • +3
    /lams_build/common.properties
    • binary
    /lams_build/deploy-tool/lib/lams-tool-deploy.jar
    • -0
    • +1
    /lams_tool_chat/build.xml
    • -1
    • +4
    /lams_tool_deploy/src/java/org/lamsfoundation/lams/tool/deploy/CreateToolPackageTask.java
    • -2
    • +2
    /lams_tool_deploy/src/java/org/lamsfoundation/lams/tool/deploy/Deploy.java
    • -1
    • +24
    /lams_tool_deploy/src/java/org/lamsfoundation/lams/tool/deploy/DeployConfig.java
    • -9
    • +52
    /lams_tool_deploy/src/java/org/lamsfoundation/lams/tool/deploy/DeployToolConfig.java
    • -1
    • +1
    /lams_tool_deploy/src/java/org/lamsfoundation/lams/tool/deploy/libraryActivity/CreateLibraryPackageTask.java
    • -4
    • +11
    /lams_tool_deploy/src/java/org/lamsfoundation/lams/tool/deploy/libraryActivity/DeployLibraryConfig.java
    • -0
    • +1
    /lams_tool_forum/build.xml
    • -0
    • +1
    /lams_tool_lamc/build.xml
    • -0
    • +1
    /lams_tool_laqa/build.xml
    • -0
    • +1
    /lams_tool_larsrc/build.xml
    • -0
    • +1
    /lams_tool_nb/build.xml
  16. … 7 more files in changeset.
9:24 am

fmalikoff

LDEV-1819: Initialise branching activities properly after a live edit

Options
    • binary
    /lams_build/lib/lams/lams-monitoring.jar
    • -4
    • +5
    /lams_central/src/java/org/lamsfoundation/lams/authoring/service/AuthoringService.java
    • -0
    • +8
    /lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/IMonitoringService.java
    • -25
    • +37
    /lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/MonitoringService.java
Sunday 08 Jun 2008
1:20 pm

fmalikoff

LDEV-1818: Adding validation to check that a tool based branch always has at least one condition

Options
    • -2
    • +3
    /lams_common/conf/language/lams/ApplicationResources.properties
    • -1
    • +13
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/ToolBranchingActivity.java
    • -0
    • +2
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/dto/ValidationErrorDTO.java
1:16 pm

fmalikoff

LDEV-1817: Fixing up message on preview define later screen to be appropriate for branching.

Options
    • -0
    • +10
    /lams_learning/web/previewDefineLater.jsp
Friday 06 Jun 2008
2:17 pm

fmalikoff

LDEV-1820: Less than wasn't working as the BranchCondition was expecting start value to be 0, and it was null. Now accepts null.

Options
    • -1
    • +1
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/BranchCondition.java
11:40 am

fmalikoff

LDEV-1817: Fixing up message on preview define later screen to be appropriate for branching.

Options
    • -0
    • +1
    /lams_learning/conf/language/lams/ApplicationResources.properties
    • -0
    • +1
    /lams_learning/conf/language/lams/ApplicationResources_en_AU.properties
11:31 am

fmalikoff

LDEV-1817: Define later branching was breaking Preview. Now the preview hack allows it to be used with Random Grouping and this required regetting the grouping at one point to avoid a CGLIB class cast exception (hack on hack). Bleah.

The chosen grouping now works as I clear the number of groups before creating a group (and then allocating to a branch), otherwise I could run into the max number of branches test. Another hack.

Options
    • -5
    • +3
    /lams_common/src/java/org/lamsfoundation/lams/lesson/service/LessonService.java
    • -7
    • +26
    /lams_learning/src/java/org/lamsfoundation/lams/learning/service/LearnerService.java
    • -0
    • +2
    /lams_learning/src/java/org/lamsfoundation/lams/learning/web/action/LoadToolActivityAction.java
Wednesday 04 Jun 2008
12:29 pm

fmalikoff

LDEV-1804: Tool urls on the Optional Activity page were missing the tool part - all there was was the lams part.

Options
    • -2
    • +7
    /lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/ComplexLearnerProgressAction.java
Tuesday 03 Jun 2008
10:36 am

fmalikoff

LDEV-1753: Ajax based selection screens in monitoring were not indicating to the user if any exceptions thrown on the server. Added some javascript to check if the return value from the server was the general struts error message. If it is, it extracts the message and displays that in an alert box.

Options
    • -0
    • +2
    /lams_central/web/error.jsp
    • -0
    • +18
    /lams_central/web/includes/javascript/error.js
    • -0
    • +7
    /lams_monitoring/web/branching/chosenSelection.jsp
    • -1
    • +8
    /lams_monitoring/web/branching/groupedSelection.jsp
    • -1
    • +10
    /lams_monitoring/web/grouping/chosenGrouping.jsp
8:42 am

fmalikoff

LDEV-1763: Hiding the "Branching" and "Branch Blah" levels when the learner is in a branch.

Options
    • -7
    • +23
    /lams_learning/src/java/org/lamsfoundation/lams/learning/progress/ProgressBuilder.java
Monday 02 Jun 2008
2:25 pm

fmalikoff

LDEV-1786: On very rare occasions, we've had Hibernate try to save the branching entries before saving the branching activity which throws an exception as the branch_activity_id is null. So force any branching activities to save first.

Options
    • -0
    • +9
    /lams_central/src/java/org/lamsfoundation/lams/authoring/service/AuthoringService.java
Friday 30 May 2008
3:53 pm

fmalikoff

Tweaking some wording

Options
    • -6
    • +8
    /lams_tool_task/conf/language/lams/ApplicationResources.properties
    • -6
    • +6
    /lams_tool_task/conf/language/lams/ApplicationResources_en_AU.properties