Activity lams-github/

8:46 pm

erniegx <ernieg@gmail.com>

More
68279e6
changed 2 files

LDEV-3594: Prevent XSS injection

- -1
- +1
/lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/web/action/LearningAction.java
- History
- Source
- Diff
/lams_tool_preview/.../LearningAction.java
- -2
- +2
/lams_tool_preview/web/WEB-INF/tags/AuthoringRatingCriteria.tag
- History
- Source
- Diff
/lams_tool_preview/.../AuthoringRatingCriteria.tag

7:44 pm

LDEV-3578: Convert passwords from sha1 to sha256 with salt after successful authentication and on password change. Remove password hashing in browser. Change internal authentication mechanism for LoginRequestServlet and LoginAsAction.

- -620
- +624
/lams_admin/src/java/org/lamsfoundation/lams/admin/service/ImportService.java
- History
- Source
- Diff
/lams_admin/src/.../ImportService.java
- -15
- +18
/lams_admin/src/java/org/lamsfoundation/lams/admin/web/UserSaveAction.java
- History
- Source
- Diff
/lams_admin/src/.../web/UserSaveAction.java
- binary
/lams_build/lib/lams/lams-central.jar
- History
- Source
- Diff
/lams_build/lib/lams/lams-central.jar
- binary
/lams_build/lib/lams/lams.jar
- History
- Source
- Diff
/lams_build/lib/lams/lams.jar
- -41
- +93
/lams_central/src/java/org/lamsfoundation/lams/security/DatabaseAuthenticator.java
- History
- Source
- Diff
/lams_central/.../DatabaseAuthenticator.java
- -23
- +33
/lams_central/src/java/org/lamsfoundation/lams/security/UniversalLoginModule.java
- History
- Source
- Diff
/lams_central/.../UniversalLoginModule.java
- -1
- +3
/lams_central/src/java/org/lamsfoundation/lams/web/LoginAsAction.java
- History
- Source
- Diff
/lams_central/src/.../web/LoginAsAction.java
- -6
- +9
/lams_central/src/java/org/lamsfoundation/lams/web/LoginRequestServlet.java
- History
- Source
- Diff
/lams_central/.../LoginRequestServlet.java
- -11
- +16
/lams_central/src/java/org/lamsfoundation/lams/web/PasswordChangeAction.java
- History
- Source
- Diff
/lams_central/.../PasswordChangeAction.java
- -41
- +47
/lams_central/src/java/org/lamsfoundation/lams/web/action/SignupAction.java
- History
- Source
- Diff
/lams_central/src/.../SignupAction.java
- -33
- +34
/lams_central/src/java/org/lamsfoundation/lams/webservice/RegisterAction.java
- History
- Source
- Diff
/lams_central/src/.../RegisterAction.java
- -63
- +86
/lams_central/src/java/org/lamsfoundation/lams/webservice/RegisterServiceSoapBindingImpl.java
- History
- Source
- Diff
/lams_central/.../RegisterServiceSoapBindingImpl.java
- -11
- +2
/lams_central/web/login.jsp
- History
- Source
- Diff
/lams_central/web/login.jsp
- -1
- +0
/lams_central/web/template.jsp
- History
- Source
- Diff
/lams_central/web/template.jsp
- -2
- +16
/lams_common/conf/hibernate/mappings/org/lamsfoundation/lams/usermanagement/User.hbm.xml
- History
- Source
- Diff
/lams_common/conf/.../User.hbm.xml
… 9 more files in changeset.

7:05 pm

Marcin Cieslak

More
57fd959
changed 1 file
v4.7, v4.8

LDEV-3335: Prevent NullPointerException when the user provided blank login.

- -1
- +1
/lams_common/src/java/org/lamsfoundation/lams/integration/security/SsoHandler.java
- History
- Source
- Diff
/lams_common/src/.../security/SsoHandler.java

9:47 am

FionaMalikoff <Fiona.Malikoff@gmail.com>

More
ad572fe
changed 7 files
v4.7, v4.8

LDEV-3592: When disabling fields as we are at the max number of rated items, don't disable the fields that are part of a set already being rated.

- -12
- +40
/lams_central/web/includes/javascript/rating.js
- History
- Source
- Diff
/lams_central/web/.../javascript/rating.js
- -9
- +18
/lams_tool_images/web/WEB-INF/tags/Rating.tag
- History
- Source
- Diff
/lams_tool_images/web/.../tags/Rating.tag
- -9
- +18
/lams_tool_laqa/web/WEB-INF/tags/Rating.tag
- History
- Source
- Diff
/lams_tool_laqa/web/.../tags/Rating.tag
- -3
- +16
/lams_tool_laqa/web/learning/LearnerRep.jsp
- History
- Source
- Diff
/lams_tool_laqa/web/.../LearnerRep.jsp
- -2
- +16
/lams_tool_laqa/web/learning/RevisitedLearnerRep.jsp
- History
- Source
- Diff
/lams_tool_laqa/.../RevisitedLearnerRep.jsp
- -2
- +16
/lams_tool_laqa/web/learning/mobile/LearnerRep.jsp
- History
- Source
- Diff
/lams_tool_laqa/web/.../mobile/LearnerRep.jsp
- -2
- +16
/lams_tool_laqa/web/learning/mobile/RevisitedLearnerRep.jsp
- History
- Source
- Diff
/lams_tool_laqa/.../RevisitedLearnerRep.jsp

7:51 am

FionaMalikoff <Fiona.Malikoff@gmail.com>

More
784468e
changed 1 file

LDEV-3593: Leftover debugging removed - was causing odd chars to be displayed in the Criteria field.

- -2
- +0
/lams_tool_preview/web/pages/learning/learning.jsp
- History
- Source
- Diff
/lams_tool_preview/web/.../learning.jsp

1:24 am

Marcin Cieslak

More
0ce9905
changed 1 file
v4.7, v4.8

LDEV-2463: Revert SsoHandler code as the check is not needed there - JSP code does it correctly.

- -9
- +1
/lams_common/src/java/org/lamsfoundation/lams/integration/security/SsoHandler.java
- History
- Source
- Diff
/lams_common/src/.../security/SsoHandler.java

6:41 pm

Marcin Cieslak

More
4c67a2a
changed 2 files
v4.7, v4.8

LDEV-2463: Escape redirectURL param on the login page. Check for HTML tages in redirectURL param during authentication.

- -2
- +3
/lams_central/web/login.jsp
- History
- Source
- Diff
/lams_central/web/login.jsp
- -1
- +9
/lams_common/src/java/org/lamsfoundation/lams/integration/security/SsoHandler.java
- History
- Source
- Diff
/lams_common/src/.../security/SsoHandler.java

6:38 pm

Marcin Cieslak

More
39708e7
changed 1 file
v4.7, v4.8

LDEV-3335: Prevent NullPointerException when the user provided blank login.

- -1
- +1
/lams_common/src/java/org/lamsfoundation/lams/integration/security/SsoHandler.java
- History
- Source
- Diff
/lams_common/src/.../security/SsoHandler.java

12:24 pm

FionaMalikoff <Fiona.Malikoff@gmail.com>

More
185407e
changed 7 files

LDEV-3592: When disabling fields as we are at the max number of rated items, don't disable the fields that are part of a set already being rated.

- -9
- +18
/lams_tool_laqa/web/WEB-INF/tags/Rating.tag
- History
- Source
- Diff
/lams_tool_laqa/web/.../tags/Rating.tag
- -3
- +16
/lams_tool_laqa/web/learning/LearnerRep.jsp
- History
- Source
- Diff
/lams_tool_laqa/web/.../LearnerRep.jsp
- -2
- +16
/lams_tool_laqa/web/learning/RevisitedLearnerRep.jsp
- History
- Source
- Diff
/lams_tool_laqa/.../RevisitedLearnerRep.jsp
- -2
- +16
/lams_tool_laqa/web/learning/mobile/LearnerRep.jsp
- History
- Source
- Diff
/lams_tool_laqa/web/.../mobile/LearnerRep.jsp
- -2
- +16
/lams_tool_laqa/web/learning/mobile/RevisitedLearnerRep.jsp
- History
- Source
- Diff
/lams_tool_laqa/.../RevisitedLearnerRep.jsp
- -9
- +18
/lams_tool_preview/web/WEB-INF/tags/Rating.tag
- History
- Source
- Diff
/lams_tool_preview/web/.../tags/Rating.tag
- -5
- +18
/lams_tool_preview/web/pages/learning/learning.jsp
- History
- Source
- Diff
/lams_tool_preview/web/.../learning.jsp

12:11 pm

FionaMalikoff <Fiona.Malikoff@gmail.com>

More
0b33e6a
changed 2 files

LDEV-3592: When disabling fields as we are at the max number of rated items, don't disable the fields that are part of a set already being rated.

- -12
- +40
/lams_central/web/includes/javascript/rating.js
- History
- Source
- Diff
/lams_central/web/.../javascript/rating.js
- -9
- +18
/lams_tool_images/web/WEB-INF/tags/Rating.tag
- History
- Source
- Diff
/lams_tool_images/web/.../tags/Rating.tag

8:21 pm

Marcin Cieslak

More
3a46dc5
changed 13 files
v4.7, v4.8

LDEV-3591: Flatten UniversalLoginModule hierarchy - it was just a single leaf anyway. Format code. Clean up logs, errors and comments. Move queries from config files to code.

- -8
- +0
/lams_build/conf/slim/standalone.xml
- History
- Source
- Diff
/lams_build/conf/slim/standalone.xml
- -8
- +0
/lams_build/conf/standalone.xml
- History
- Source
- Diff
/lams_build/conf/standalone.xml
- binary
/lams_build/lib/lams/lams-central.jar
- History
- Source
- Diff
/lams_build/lib/lams/lams-central.jar
- binary
/lams_build/lib/lams/lams.jar
- History
- Source
- Diff
/lams_build/lib/lams/lams.jar
- -307
- +0
/lams_central/src/java/org/lamsfoundation/lams/security/AbstractServerLoginModule.java
- History
- Source
- Diff
/lams_central/.../AbstractServerLoginModule.java
- -76
- +65
/lams_central/src/java/org/lamsfoundation/lams/security/DatabaseAuthenticator.java
- History
- Source
- Diff
/lams_central/.../DatabaseAuthenticator.java
- -56
- +39
/lams_central/src/java/org/lamsfoundation/lams/security/LDAPAuthenticator.java
- History
- Source
- Diff
/lams_central/src/.../LDAPAuthenticator.java
- -139
- +0
/lams_central/src/java/org/lamsfoundation/lams/security/NestableGroup.java
- History
- Source
- Diff
/lams_central/src/.../NestableGroup.java
- -96
- +68
/lams_central/src/java/org/lamsfoundation/lams/security/SimpleGroup.java
- History
- Source
- Diff
/lams_central/src/.../SimpleGroup.java
- -29
- +33
/lams_central/src/java/org/lamsfoundation/lams/security/SimplePrincipal.java
- History
- Source
- Diff
/lams_central/src/.../SimplePrincipal.java
- -204
- +332
/lams_central/src/java/org/lamsfoundation/lams/security/UniversalLoginModule.java
- History
- Source
- Diff
/lams_central/.../UniversalLoginModule.java
- -340
- +0
/lams_central/src/java/org/lamsfoundation/lams/security/UsernamePasswordLoginModule.java
- History
- Source
- Diff
/lams_central/.../UsernamePasswordLoginModule.java
- -46
- +54
/lams_common/src/java/org/lamsfoundation/lams/usermanagement/service/ILdapService.java
- History
- Source
- Diff
/lams_common/src/.../ILdapService.java

12:15 pm

FionaMalikoff <Fiona.Malikoff@gmail.com>

More
4c4f529
changed 1 file
v4.7, v4.8

LKC-61: Added reference to this fix in the Release Notes

- -1
- +2
/lams_bb_integration/RELEASE_NOTES.TXT
- History
- Source
- Diff
/lams_bb_integration/RELEASE_NOTES.TXT

12:15 pm

FionaMalikoff <Fiona.Malikoff@gmail.com>

More
17a5d8b
changed 1 file

LKC-61: Added reference to this fix in the Release Notes

- -1
- +2
/lams_bb_integration/RELEASE_NOTES.TXT
- History
- Source
- Diff
/lams_bb_integration/RELEASE_NOTES.TXT

11:21 am

FionaMalikoff <Fiona.Malikoff@gmail.com>

More
94e9c33
changed 5 files
v4.7, v4.8

LDEV-3510: In trying to fix the ordering problem, started opening lessons in a new tab/window. Now reverted back to previous behaviour with lesson loading in the same tab.

- -0
- +5
/lams_bb_integration/RELEASE_NOTES.TXT
- History
- Source
- Diff
/lams_bb_integration/RELEASE_NOTES.TXT
- -1
- +1
/lams_bb_integration/WEB-INF/bb-manifest.xml
- History
- Source
- Diff
/lams_bb_integration/.../bb-manifest.xml
- -1
- +1
/lams_bb_integration/build.xml
- History
- Source
- Diff
/lams_bb_integration/build.xml
- -2
- +0
/lams_bb_integration/src/org/lamsfoundation/ld/integration/blackboard/StartLessonServlet.java
- History
- Source
- Diff
/lams_bb_integration/.../StartLessonServlet.java
- -2
- +0
/lams_bb_integration/web/modules/start_lesson_proc.jsp
- History
- Source
- Diff
/lams_bb_integration/.../start_lesson_proc.jsp

11:21 am

FionaMalikoff <Fiona.Malikoff@gmail.com>

More
7d945ec
changed 5 files

LDEV-3510: In trying to fix the ordering problem, started opening lessons in a new tab/window. Now reverted back to previous behaviour with lesson loading in the same tab.