lams-github

Clone Tools

Stats

Commits this week: 0
Total Committers: 50
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 18 Oct 2021
10:32 pm

Marcin Cieslak

LDEV-4411 Make relation from Evaluation to ToolActivity unidirectional

Hibernate can not lazy load properties connected with OneToOne

relationship. It means that with every fetch of ToolActivity its

ActivityEvaluation was also fetched, whether is was needed or not. It

made up even 10% of all queries sent to DB during a lesson.

By having the relationship unidirectional and fetching

ActivityEvaluation via DAO we ensure that it is fetched only when it is

needed. The code is not as nice, though.

Options
    • -59
    • +8
    /lams_central/src/java/org/lamsfoundation/lams/authoring/ObjectExtractor.java
    • -1
    • +6
    /lams_central/src/java/org/lamsfoundation/lams/authoring/service/AuthoringService.java
    • -9
    • +10
    /lams_central/src/java/org/lamsfoundation/lams/webservice/xml/LessonManagerServlet.java
    • -12
    • +10
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/ToolActivity.java
    • -2
    • +4
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/dao/IActivityDAO.java
    • -1
    • +7
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/dao/hibernate/ActivityDAO.java
    • -2
    • +4
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/dto/AuthoringActivityDTO.java
    • -3
    • +4
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/service/ExportToolContentService.java
    • -26
    • +32
    /lams_common/src/java/org/lamsfoundation/lams/tool/service/LamsCoreToolService.java
    • -4
    • +2
    /lams_common/src/java/org/lamsfoundation/lams/tool/service/LamsToolService.java
    • -1
    • +23
    /lams_common/src/java/org/lamsfoundation/lams/usermanagement/service/UserManagementService.java
    • -1
    • +3
    /lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/dto/GBActivityGridRowDTO.java
    • -16
    • +24
    /lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/service/GradebookService.java
    • -2
    • +7
    /lams_learning/src/java/org/lamsfoundation/lams/learning/service/LearnerService.java
10:29 pm

Marcin Cieslak

LDEV-4411 Do not cache native SQL queries as it causes exceptions

Options
    • -1
    • +1
    /lams_common/src/java/org/lamsfoundation/lams/security/SecurityDAO.java
6:32 pm

Marcin Cieslak

Merge branch 'v4.5' into LDEV-5250

Options
6:31 pm

Marcin Cieslak

LDEV-3656 Clean up invalidated session from internal tracking mapping

These session should have been removed from the mapping when

SessionListener is called. Sometimes the listener is not called due to

WildFly internal bugs. We are left with a long list of stale sessions.

We should periodically clean up the mapping. Making it happen on runtime

stats fetch is as place as any other, plus it happens periodically.

Options
    • -6
    • +0
    /lams_central/src/java/org/lamsfoundation/lams/web/SessionListener.java
    • -0
    • +14
    /lams_common/src/java/org/lamsfoundation/lams/web/session/SessionManager.java
Sunday 17 Oct 2021
11:46 pm

Marcin Cieslak

LDEV-4411 Remove FetchMode as it seems to trigger excessive queries

Options
    • -7
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/qb/model/QbQuestion.java
11:36 pm

Marcin Cieslak

LDEV-4411 Make cacheable queries for checking user roles

Options
    • -5
    • +5
    /lams_common/src/java/org/lamsfoundation/lams/security/SecurityDAO.java
    • -1
    • +1
    /lams_common/src/java/org/lamsfoundation/lams/usermanagement/service/UserManagementService.java
11:01 pm

Marcin Cieslak

LDEV-4411 Make Tool -> ExtServerToolAdapterMap collection lazy

Options
    • -2
    • +1
    /lams_common/src/java/org/lamsfoundation/lams/tool/Tool.java
10:53 pm

Marcin Cieslak

LDEV-5250 Remove Pedagogical Planner integration with core LAMS

Options
    • -12
    • +0
    /lams_central/src/java/org/lamsfoundation/lams/web/IndexController.java
    • -11
    • +0
    /lams_central/web/includes/javascript/ckconfig_custom.js
    • -17
    • +0
    /lams_central/web/includes/javascript/openUrls.js
    • -3
    • +0
    /lams_central/web/loadVars.jsp
    • -1
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/commonContext.xml
    • -0
    • +19
    /lams_common/src/java/org/lamsfoundation/lams/dbupdates/patch20211017.sql
    • -19
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/ToolActivity.java
    • -14
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/dto/AuthoringActivityDTO.java
    • -118
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/dto/PlannerActivityMetadataDTO.java
    • -11
    • +1
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/service/ExportToolContentService.java
    • -145
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/planner/PedagogicalPlannerActivityMetadata.java
    • -110
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/planner/PedagogicalPlannerActivitySpringForm.java
    • -11
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/tool/SystemTool.java
    • -15
    • +2
    /lams_common/src/java/org/lamsfoundation/lams/tool/Tool.java
    • -14
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/usermanagement/User.java
  16. … 53 more files in changeset.
5:35 pm

Marcin Cieslak

LDEV-4078 Only sysadmin can change other users' passwords

Options
    • -12
    • +14
    /lams_admin/web/user.jsp
3:52 pm

Marcin Cieslak

LDEV-4367 Change Sass CLI parameter for newer version compability

Sass installed as Ruby gem is deprecated since March 2019. Newer

versions of Sass accept a slightly different parameter for sourcemap.

Options
    • -2
    • +2
    /lams_build/build_base.xml
Thursday 14 Oct 2021
3:03 pm

Ernie Ghiglione

LDEV-4769 Updating Simplified Chinese, English, Spanish

Options
    • -0
    • +71
    /lams_central/conf/language/lams/ApplicationResources_zh_CN.properties
    • -1
    • +1
    /lams_monitoring/conf/language/lams/ApplicationResources.properties
    • -0
    • +1
    /lams_monitoring/conf/language/lams/ApplicationResources_en_AU.properties
    • -0
    • +1
    /lams_monitoring/conf/language/lams/ApplicationResources_es_ES.properties
Wednesday 13 Oct 2021
5:30 pm

Marcin Cieslak

LDEV-3555 Do not create LD thumbnail with incorrect read-only colouring

Options
    • -5
    • +13
    /lams_central/web/includes/javascript/authoring/authoringGeneral.js
Tuesday 12 Oct 2021
6:16 pm

Marcin Cieslak

Merge branch 'LDEV-5130' into v4.5

Options
6:16 pm

Marcin Cieslak

LDEV-4950 Remove obsolete ordering arrows in Scratchie authoring

Options
    • -12
    • +0
    /lams_tool_scratchie/web/pages/authoring/parts/itemlist.jsp
Monday 11 Oct 2021
11:28 pm

Marcin Cieslak

LDEV-4440 Reintroduce history-aware Cancel button on Edit User form

Options
    • -1
    • +1
    /lams_admin/web/user.jsp
11:21 pm

Marcin Cieslak

LDEV-4932 Add CSRF token to course manager organisation edit page

Options
    • -0
    • +1
    /lams_admin/web/organisation/courseAdminEdit.jsp
10:52 pm

Marcin Cieslak

LDEV-4540 Never copy Assessment question disclose status

Assessment questions can be disclosed on lesson level only. If they are

cloned or exported, their disclose status should be always the default,

i.e. not disclosed.

Options
    • -1
    • +2
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/model/AssessmentQuestion.java
    • -0
    • +3
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java
1:53 pm

Ernie Ghiglione

Update README.md

Added GitBook support

Options
    • -0
    • +3
    /README.md
Saturday 09 Oct 2021
10:00 pm

Marcin Cieslak

LDEV-5249 Add img-responsive class to images in CKEditor templates

Options
    • -5
    • +5
    /lams_www/web/public/ckeditor-templates/bootsnippets.js
    • -1
    • +1
    /lams_www/web/public/ckeditor-templates/htmltemplates.js
7:02 pm

Marcin Cieslak

LDEV-4411 Silence cache logs which flood LAMS log files

Options
    • -8
    • +12
    /lams_build/conf/slim/standalone.xml
    • -8
    • +12
    /lams_build/conf/standalone.xml
5:53 pm

Marcin Cieslak

Merge branch 'LDEV-5249' into v4.5

Options
5:53 pm

Marcin Cieslak

LDEV-5249 Document ckeditor code change

Options
    • -1
    • +1
    /lams_central/web/ckeditor/README.md
5:49 pm

Marcin Cieslak

LDEV-5249 Prevent error when image class is empty

Options
    • -1
    • +15
    /lams_central/web/ckeditor/README.md
    • -1
    • +1
    /lams_central/web/ckeditor/ckeditor.js
5:28 pm

Marcin Cieslak

Merge branch 'LDEV-5248' into v4.5

Options
5:19 pm

Marcin Cieslak

LDEV-4826 Reintroduce MCQ tool QTI export

It is needed to migrate TBL sequences with MCQ as iRAT to Assessment as

iRAT.

Options
    • -193
    • +198
    /lams_central/src/java/org/lamsfoundation/lams/web/qb/ImsQtiController.java
    • -2
    • +52
    /lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/web/controller/AuthoringController.java
    • -0
    • +10
    /lams_tool_lamc/web/authoring/BasicContent.jsp
    • -0
    • +3
    /lams_tool_lamc/web/authoring/itemlist.jsp
Friday 08 Oct 2021
10:25 pm

Marcin Cieslak

Merge branch 'LDEV-5243' into v4.5

Options
10:24 pm

Marcin Cieslak

LDEV-5243 Add "stop at preceding activity" info to gate monitoring

Options
    • -0
    • +1
    /lams_monitoring/conf/language/lams/ApplicationResources.properties
    • -0
    • +6
    /lams_monitoring/web/gate/gateInfo.jsp
Thursday 07 Oct 2021
8:03 pm

Marcin Cieslak

LDEV-4875 Fix Scratchie learner UI on iPad

Newer JS format is not accepted on old iPad Safari. It makes JS break.

We need to stick to old syntax.

Also double clicking is problematic on old iPads. We allow single tap

scratching even if double click scratching is enabled.

Options
    • -5
    • +21
    /lams_tool_scratchie/web/pages/learning/learning.jsp
    • -6
    • +5
    /lams_tool_scratchie/web/pages/learning/scratchies.jsp
5:19 pm

Marcin Cieslak

Merge branch 'v4.5' into LDEV-5248

Options
5:18 pm

Marcin Cieslak

LKC-89 Fix TBL monitor sequence tab refresh

Initial refreshMonitor() call must be made so interval refresh gets set

up.

Options
    • -2
    • +8
    /lams_monitoring/web/includes/javascript/monitorLesson.js
    • -1
    • +2
    /lams_monitoring/web/monitor.jsp