lams-github

Clone Tools

Stats

Commits this week: 0
Total Committers: 50
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 28 Sep 2021
10:14 pm

Ernie Ghiglione

LDEV-4769 Updating Simplified Chinese, English, Spanish, Greek, Norwegian

Options
    • -1
    • +1
    /lams_admin/conf/language/lams/ApplicationResources.properties
    • -1
    • +1
    /lams_admin/conf/language/lams/ApplicationResources_en_AU.properties
    • -28
    • +28
    /lams_central/conf/language/lams/ApplicationResources.properties
    • -28
    • +28
    /lams_central/conf/language/lams/ApplicationResources_en_AU.properties
    • -25
    • +25
    /lams_central/conf/language/lams/ApplicationResources_es_ES.properties
    • -0
    • +81
    /lams_central/conf/language/lams/ApplicationResources_zh_CN.properties
    • -2
    • +2
    /lams_common/conf/language/lams/ApplicationResources.properties
    • -2
    • +2
    /lams_common/conf/language/lams/ApplicationResources_en_AU.properties
    • -2
    • +2
    /lams_common/conf/language/lams/ApplicationResources_es_ES.properties
    • -7
    • +7
    /lams_monitoring/conf/language/lams/ApplicationResources.properties
    • -7
    • +7
    /lams_monitoring/conf/language/lams/ApplicationResources_en_AU.properties
    • -7
    • +7
    /lams_monitoring/conf/language/lams/ApplicationResources_es_ES.properties
    • -0
    • +1
    /lams_tool_assessment/conf/language/lams/ApplicationResources_el_GR.properties
    • -1
    • +0
    /lams_tool_doku/conf/language/lams/ApplicationResources.properties
    • -1
    • +0
    /lams_tool_doku/conf/language/lams/ApplicationResources_el_GR.properties
  16. … 16 more files in changeset.
3:17 pm

Marcin Cieslak

LDEV-5157 Fix essay question validation when code style is used

Options
    • -5
    • +25
    /lams_tool_assessment/web/pages/learning/learning.jsp
Monday 27 Sep 2021
4:54 pm

Marcin Cieslak

LDEV-4411 Add log configuration to follow cache work

Options
    • -1
    • +9
    /lams_build/conf/slim/standalone.xml
    • -1
    • +17
    /lams_build/conf/standalone.xml
4:42 pm

Marcin Cieslak

LDEV-4411 Add configuration for collection cache on multinode env

Options
    • -0
    • +3
    /lams_common/src/java/org/lamsfoundation/lams/applicationContext.xml
4:16 pm

Marcin Cieslak

LDEV-4411 Native SQL queries are not cacheable by default

There seems to be a bug in Hibernate

https://hibernate.atlassian.net/browse/HHH-9111

There is a way to make native queries cacheable, but since there are so

few of them in LAMS, it is not worth the effort.

Options
    • -3
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/policies/dao/hibernate/PolicyDAO.java
4:12 pm

Marcin Cieslak

LDEV-4411 Fix cacheable API method

Options
    • -1
    • +1
    /lams_common/src/java/org/lamsfoundation/lams/dao/hibernate/LAMSBaseDAO.java
3:56 pm

Marcin Cieslak

Merge branch 'v4.5' into LDEV-5248

Options
3:56 pm

Marcin Cieslak

LDEV-4288 Prevent duplicate entries in Gradebook activity table

Unique key allows us to track situations in which duplicate entries get

created in the table.

There is no point in copying Gradebook entries on tool content copy - we

never copy live lessons, only template Learning Designs which should not

have any gradebook entries set.

Options
    • -0
    • +16
    /lams_common/src/java/org/lamsfoundation/lams/dbupdates/patch20210927.sql
    • -12
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/ToolActivity.java
3:45 pm

Marcin Cieslak

LDEV-5248, LDEV-4411 Mark some collections as cacheable

Similar to query cache, the collection cache makes sense if the table

which collection elements map to do not change often. Each modification

to table content invalidates the given collection cache.

Options
    • -2
    • +5
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/Activity.java
    • -2
    • +5
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/ComplexActivity.java
    • -1
    • +4
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/LearningDesign.java
    • -0
    • +3
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/LearningLibrary.java
    • -3
    • +6
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/SequenceActivity.java
    • -1
    • +4
    /lams_common/src/java/org/lamsfoundation/lams/lesson/Lesson.java
    • -0
    • +3
    /lams_common/src/java/org/lamsfoundation/lams/tool/Tool.java
    • -4
    • +10
    /lams_common/src/java/org/lamsfoundation/lams/usermanagement/Organisation.java
    • -1
    • +2
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/model/Assessment.java
    • -4
    • +0
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/model/AssessmentQuestionResult.java
    • -4
    • +0
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/model/AssessmentResult.java
    • -8
    • +9
    /lams_tool_chat/src/java/org/lamsfoundation/lams/tool/chat/model/Chat.java
    • -1
    • +4
    /lams_tool_daco/src/java/org/lamsfoundation/lams/tool/daco/model/Daco.java
    • -4
    • +7
    /lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/model/Forum.java
    • -0
    • +3
    /lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/model/ImageGallery.java
  16. … 17 more files in changeset.
Friday 24 Sep 2021
3:50 pm

Marcin Cieslak

LDEV-5248, LDEV-4411 Mark some queries as cacheable

Query cache makes sense if tables which the query reference does not

change often. Each modification to table content invalidates the given

query's cache. Also each set of query parameters is a different cache

entry, so if there are various parameter values the cache overhead can

generate more load than benefit.

Options
    • -1
    • +1
    /lams_common/src/java/org/lamsfoundation/lams/config/dao/hibernate/ConfigurationDAO.java
    • -0
    • +4
    /lams_common/src/java/org/lamsfoundation/lams/dao/IBaseDAO.java
    • -17
    • +23
    /lams_common/src/java/org/lamsfoundation/lams/dao/hibernate/LAMSBaseDAO.java
    • -10
    • +9
    /lams_common/src/java/org/lamsfoundation/lams/integration/service/IntegrationService.java
    • -1
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/Activity.java
    • -1
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/LearningDesign.java
    • -5
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/dao/IActivityDAO.java
    • -14
    • +7
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/dao/hibernate/ActivityDAO.java
    • -5
    • +2
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/dao/hibernate/BranchActivityEntryDAO.java
    • -13
    • +14
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/dao/hibernate/LearningDesignDAO.java
    • -2
    • +2
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/dao/hibernate/LearningLibraryDAO.java
    • -2
    • +2
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/dao/hibernate/LicenseDAO.java
    • -1
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/lesson/Lesson.java
    • -4
    • +4
    /lams_common/src/java/org/lamsfoundation/lams/lesson/dao/hibernate/LearnerProgressDAO.java
    • -9
    • +11
    /lams_common/src/java/org/lamsfoundation/lams/lesson/dao/hibernate/LessonDAO.java
  16. … 82 more files in changeset.
3:58 am

Marcin Cieslak

LDEV-4411 Add 2nd level cache configuration to slimmed WildFly config

Options
    • -25
    • +16
    /lams_build/conf/slim/standalone.xml
3:52 am

Marcin Cieslak

LDEV-4411 Set up default and immutable 2nd level cache configuration

Options
    • -6
    • +21
    /lams_build/conf/standalone.xml
    • -16
    • +43
    /lams_common/src/java/org/lamsfoundation/lams/applicationContext.xml
Thursday 23 Sep 2021
9:21 pm

Marcin Cieslak

LDEV-2978 Fix exception when removing HTML markup for export

Options
    • -1
    • +1
    /lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/service/ScratchieServiceImpl.java
Tuesday 21 Sep 2021
8:25 pm

Marcin Cieslak

LDEV-5248 Fix exception when exporting LD

Options
    • -1
    • +1
    /lams_common/src/java/org/lamsfoundation/lams/qb/service/QbService.java
8:23 pm

Marcin Cieslak

LDEV-5248 Fix exception when processing QB units lazy collection

Options
    • -1
    • +3
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/dto/QuestionDTO.java
5:35 pm

Marcin Cieslak

LDEV-5248 Move QB create question logic to service

Keeping it in Controller caused lazy initialisation exception and is bad

practice anyway.

Options
    • -298
    • +3
    /lams_central/src/java/org/lamsfoundation/lams/web/qb/EditQbQuestionController.java
    • -1
    • +11
    /lams_common/src/java/org/lamsfoundation/lams/qb/service/IQbService.java
    • -2
    • +293
    /lams_common/src/java/org/lamsfoundation/lams/qb/service/QbService.java
4:35 pm

Marcin Cieslak

Merge branch 'v4.5' into LDEV-5248

Options
    • -1
    • +1
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentResultDAOHibernate.java
4:31 pm

Marcin Cieslak

LDEV-4944 Fix mark recalculation query

Options
    • -1
    • +1
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentResultDAOHibernate.java
4:07 pm

Marcin Cieslak

LDEV-5248 Fix exception when processing Assessment overall feedback

Options
    • -2
    • +2
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/controller/AuthoringController.java
12:34 am

Marcin Cieslak

LDEV-5248, LDEV-4411 Add 2nd level cache to selected elements

Displaying Assessment results is too DB-intense for multiple learners.

We can enable a short-lived query cache for some entities which have

most impact on the results page. This way multiple requests can reuse

same objects from cache and there is little danger of inconsistency.

Options
    • -29
    • +6
    /lams_build/conf/standalone.xml
    • -5
    • +17
    /lams_common/src/java/org/lamsfoundation/lams/applicationContext.xml
    • -0
    • +2
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/Activity.java
    • -6
    • +11
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/LearningDesign.java
    • -0
    • +2
    /lams_common/src/java/org/lamsfoundation/lams/lesson/Lesson.java
    • -0
    • +2
    /lams_common/src/java/org/lamsfoundation/lams/qb/model/QbOption.java
    • -0
    • +6
    /lams_common/src/java/org/lamsfoundation/lams/qb/model/QbQuestion.java
    • -0
    • +2
    /lams_common/src/java/org/lamsfoundation/lams/qb/model/QbQuestionUnit.java
    • -2
    • +4
    /lams_common/src/java/org/lamsfoundation/lams/rating/dao/hibernate/RatingCriteriaDAO.java
    • -0
    • +2
    /lams_common/src/java/org/lamsfoundation/lams/rating/model/RatingCriteria.java
    • -0
    • +2
    /lams_common/src/java/org/lamsfoundation/lams/usermanagement/User.java
    • -6
    • +8
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentQuestionResultDAOHibernate.java
    • -2
    • +3
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentResultDAOHibernate.java
    • -3
    • +4
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentSessionDAOHibernate.java
    • -0
    • +5
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/model/Assessment.java
  16. … 5 more files in changeset.
12:32 am

Marcin Cieslak

LDEV-5248 Refresh Assessment object from DB instead of from form

We should not keep objects in form at all. If we do and a new request is

processed, we need to fetch the original object from DB.

Options
    • -1
    • +1
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/controller/AuthoringController.java
Friday 17 Sep 2021
11:47 pm

Marcin Cieslak

LDEV-5248 Switch collections to lazy loading

No need to fetch all data straight away.

Options
    • -3
    • +2
    /lams_common/src/java/org/lamsfoundation/lams/qb/model/QbQuestion.java
    • -1
    • +1
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/model/Assessment.java
    • -1
    • +1
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/model/AssessmentQuestionResult.java
    • -1
    • +1
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/model/AssessmentResult.java
11:46 pm

Marcin Cieslak

LDEV-5248 Fix an exception when result is not available yet

Options
    • -2
    • +3
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/controller/LearningController.java
11:41 pm

Marcin Cieslak

LDEV-5248 Improve finding objects by IDs when displaying results

Options
    • -21
    • +21
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java
    • -44
    • +42
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/controller/LearningController.java
10:44 pm

Marcin Cieslak

LDEV-5248 Skip isLastActivity? check if is already discovered earlier

Options
    • -1
    • +5
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/controller/LearningController.java
10:38 pm

Marcin Cieslak

LDEV-5248 Skip isLeader? check if it is already discovered earlier

Options
    • -3
    • +4
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/controller/LearningController.java
10:32 pm

Marcin Cieslak

LDEV-5248 Skip copying leader answers if they already been copied

Options
    • -1
    • +5
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java
Monday 13 Sep 2021
1:42 am

Marcin Cieslak

Merge branch 'LDEV-5244' into v4.5

Options
1:42 am

Marcin Cieslak

LDEV-5244 Fix exception when signup page is missing or disabled

Options
    • -1
    • +3
    /lams_common/src/java/org/lamsfoundation/lams/signup/service/SignupService.java
1:35 am

Marcin Cieslak

Merge branch 'LDEV-5245' into v4.5

Options