lams-github

lams_build

Clone Tools

Stats

Commits this week: 0
Total Committers: 31
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 17 May 2021
8:10 pm

Marcin Cieslak

Revert "LDEV-5204 Make Whiteboard always behave like it is in production mode"

This reverts commit 7db7949e3398394d514f5d4f044d381955676eb5.

Options
    • -8
    • +11
    ./conf/whiteboard/src/js/main.js
Thursday 13 May 2021
1:26 pm

Marcin Cieslak

LDEV-5204 Hide Whiteboard contents until all resources load

Otherwise the UI looks messed up while it loads.

Options
    • -1
    • +3
    ./conf/whiteboard/readme.txt
    • -1
    • +2
    ./conf/whiteboard/src/index.html
    • -0
    • +30
    ./conf/whiteboard/src/js/index.js
  4. … 1 more file in changeset.
Tuesday 11 May 2021
1:15 pm

Marcin Cieslak

LDEV-5204 Make Whiteboard always behave like it is in production mode

There is a problem with image loading in Whiteboard. Uploaded images get

stuck while being loaded in a copied canvas. For example after a learner

enters a grouped Whiteboard activity and a canvas gets cloned for his

session.

It does not occur when Whiteboard is in development mode. Maybe it has

to do with request proxying.

We now always run Whiteboard in development mode, but make it behave

like it is in production mode.

Options
    • -11
    • +8
    ./conf/whiteboard/src/js/main.js
12:57 pm

Marcin Cieslak

LDEV-5204 Introduce imageURL config property

In vanilla Whiteboard all images are prefixed with current server URL.

If we move Whiteboard or export & import data, it will not work.

Now images have relative URL prefixed with whatever is in imageURL.

Options
    • -0
    • +62
    ./conf/whiteboard/config.default.yml
    • -1
    • +5
    ./conf/whiteboard/readme.txt
    • -0
    • +105
    ./conf/whiteboard/scripts/config/config-schema.json
    • -0
    • +151
    ./conf/whiteboard/src/js/services/ConfigService.js
    • -0
    • +1513
    ./conf/whiteboard/src/js/whiteboard.js
Monday 10 May 2021
9:32 pm

Marcin Cieslak

LDEV-5204 Embed images when exporting Whiteboard canvas

In vanilla Whiteboard images are referenced by absolute URLs. If we

upload content to another LAMS instance with a different URL, images

will not be found.

Now when exporting a LAMS LD we embed Whiteboard image base64 data

directly in tool exported XML. When we import the LD, we check if image

already exists on the server. If it does not, we recreate it from the

exported data.

Options
    • -2
    • +31
    ./conf/whiteboard/scripts/s_whiteboard.js
    • -2
    • +17
    ./conf/whiteboard/scripts/server-backend.js
  3. … 1 more file in changeset.
8:40 pm

Marcin Cieslak

LDEV-5204 Make uploaded images use relative URL

Using absolute URL can cause problems when migrating data to another

server.

Options
    • -2
    • +3
    ./conf/whiteboard/src/js/main.js
7:52 pm

Marcin Cieslak

LDEV-5204 Use separate file for each saved Whiteboard canvas

In original version all canvases were stored in a single JSON file. The

file would grow indefinitely. It would have to be stored in memory

whole. If it got corrupted, all canvases' data would be lost.

For all these reason now we store each canvas in its own file in

savedBoards/<whiteboard ID>.json

Each file is loaded only when corresponding canvas is used.

We can easily later do clean up - delete files which have not be used

for a year or so.

When doing a LAMS back up, the whole /savedBoards directory needs to be

backe up.

Options
    • -37
    • +58
    ./conf/whiteboard/scripts/s_whiteboard.js
6:47 pm

Marcin Cieslak

LDEV-5204 Hide unnecessary button in Whiteboard for better UX

Options
    • -1
    • +3
    ./conf/whiteboard/readme.txt
    • -0
    • +322
    ./conf/whiteboard/src/index.html
Sunday 02 May 2021
11:51 pm

Marcin Cieslak

LDEV-5204 Add Whiteboard tool content export and import

Options
    • -2
    • +3
    ./conf/whiteboard/readme.txt
    • -0
    • +9
    ./conf/whiteboard/scripts/s_whiteboard.js
    • -0
    • +27
    ./conf/whiteboard/scripts/server-backend.js
  4. … 2 more files in changeset.
11:08 pm

Marcin Cieslak

LDEV-5204 Fix image upload in Whiteboard

Options
    • -1
    • +1
    ./conf/whiteboard/scripts/server-backend.js
4:36 pm

Marcin Cieslak

LDEV-5204 Initiate canvas copy on tool content copy on back-end

In previous version canvas was copied when an user opened it. Sometimes

in LAMS we copy content without opening a canvas. For example when using

Save As or Copy buttons in Authoring. We had to make sure that canvas is

always either copied on back-end or it gets opened and copied via

front-end.

Options
    • -1
    • +4
    ./conf/whiteboard/readme.txt
    • -0
    • +140
    ./conf/whiteboard/scripts/s_whiteboard.js
    • -0
    • +16
    ./conf/whiteboard/scripts/server-backend.js
  4. … 10 more files in changeset.
Saturday 01 May 2021
12:12 am

Marcin Cieslak

LDEV-5204 Introduce improved security using hashing

In vanilla Whiteboard a global access token is configured on server and

must be present in all requests made to Whiteboard. It means that anyone

can modify any whiteboard ID (wid).

In LAMS we introduce a hash of wid + accesstoken. Users do not know

access token, so they can not generate the hash for another wid.

The hash is simple Java hashCode() function, sufficient for this

situation.

The hash does not include author name as it is not present in many use

cases.

The hash optionally has a different form: source wid + wid +

accesstoken. It is when copyfromwid parameter is present. In this case

the target canvas is using standard wid and hash, but for the extra call

to source canvas we use source wid and the modified hash. This modified

hash is only usable to copy content from this particular source wid to

this particular target wid, so users can not use the hash to draw on the

source canvas.

Options
    • -1
    • +3
    ./conf/whiteboard/readme.txt
    • -0
    • +403
    ./conf/whiteboard/scripts/server-backend.js
    • -1
    • +5
    ./conf/whiteboard/src/js/main.js
  4. … 7 more files in changeset.
Wednesday 28 Apr 2021
12:20 am

Marcin Cieslak

LDEV-5204 Copy and refactor doKu code for Whiteboard use

doKu is a similar tool which hold various useful elements, like working

with an external Node server, Gallery Walk etc. Its code has been taken

and reused as a base for Whiteboard.

Options
    • -0
    • +4
    ./build.xml
  2. … 107 more files in changeset.
Friday 23 Apr 2021
11:43 pm

Marcin Cieslak

LDEV-5204 Save source canvas data so target canvas is independent clone

Options
    • -7
    • +4
    ./conf/whiteboard/src/js/main.js
6:49 pm

Marcin Cieslak

LDEV-5204 Put images from source canvas to background to draw over them

Options
    • -1
    • +1
    ./conf/whiteboard/src/js/main.js
6:07 pm

Marcin Cieslak

LDEV-5204 Add readme file

Options
    • -0
    • +14
    ./conf/whiteboard/readme.txt
6:07 pm

Marcin Cieslak

LDEV-5204 Set default port to 9003

Options
    • -0
    • +32
    ./conf/whiteboard/scripts/server.js
6:06 pm

Marcin Cieslak

LDEV-5204 Allow cloning another canvas to non-empty canvas

Options
    • -0
    • +951
    ./conf/whiteboard/src/js/main.js
Thursday 22 Apr 2021
2:22 am

Marcin Cieslak

LDEV-5127 Prevent author name wrapping in Etherpad

Multi-word names got wrapped and overlapped with each other, rendering

them unreadable.

Options
    • -0
    • +82
    ./conf/etherpad/etherpad-lite/src/static/css/pad.css
Tuesday 16 Feb 2021
9:00 pm

Marcin Cieslak

LDEV-5178 Check for common and breached passwords

Options
    • -5
    • +6
    ./3rdParty.userlibraries
    • -0
    • +8
    ./build.xml
    • -0
    • +1
    ./conf/j2ee/jboss-deployment-structure.xml
    • binary
    ./lib/passpol/passpol-0.7.1-SNAPSHOT.jar
    • -0
    • +29
    ./lib/passpol/passpol.module.xml
    • -0
    • +2
    ./liblist.txt
  7. … 16 more files in changeset.
Tuesday 19 Jan 2021
1:57 am

Marcin Cieslak

LDEV-5149 Upgrade Comments plugin to 0.1.47

It does not throw an exception on text copy.

Also changes to replace new line characters with spaces is not needed

anymore.

Options
    • -11
    • +91
    ./conf/etherpad/etherpad-lite/node_modules/ep_comments_page/static/js/index.js
    • -1
    • +1
    ./conf/etherpad/readme.txt
Wednesday 30 Dec 2020
5:05 pm

Marcin Cieslak

Merge remote-tracking branch 'origin/v4.0' into LDEV-5016

Conflicts:

lams_build/3rdParty.userlibraries

lams_central/conf/language/lams/ApplicationResources_en_AU.properties

lams_central/src/java/org/lamsfoundation/lams/authoring/template/web/LdTemplateController.java

lams_central/src/java/org/lamsfoundation/lams/authoring/template/web/TBLTemplateController.java

lams_central/src/java/org/lamsfoundation/lams/web/QuestionsController.java

lams_central/web/qb/collection.jsp

lams_central/web/questions/questionFile.jsp

lams_common/db/sql/create_lams_11_tables.sql

lams_common/db/sql/insert_lams_config_data.sql

lams_common/db/sql/insert_types_data.sql

lams_common/src/java/org/lamsfoundation/lams/dbupdates/patch20200129.sql

lams_common/src/java/org/lamsfoundation/lams/questions/QuestionWordParser.java

lams_common/src/java/org/lamsfoundation/lams/tool/service/LamsToolService.java

lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/service/GradebookService.java

lams_tool_assessment/conf/language/lams/ApplicationResources_en_AU.properties

lams_tool_assessment/db/sql/create_lams_tool_assessment.sql

lams_tool_lamc/conf/language/lams/ApplicationResources.properties

lams_tool_lamc/conf/language/lams/ApplicationResources_en_AU.properties

lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/model/McContent.java

lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/model/McUsrAttempt.java

lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/service/McService.java

lams_tool_lamc/web/WEB-INF/tags/Arrow.tag

lams_tool_lamc/web/WEB-INF/tags/CKEditor.tag

lams_tool_lamc/web/WEB-INF/tags/Etherpad.tag

lams_tool_lamc/web/WEB-INF/tags/Rating.tag

lams_tool_lamc/web/WEB-INF/tags/StyledRating.tag

lams_tool_lamc/web/authoring/candidateAnswersList.jsp

lams_tool_lamc/web/authoring/itemlist.jsp

lams_tool_scratchie/web/pages/authoring/basic.jsp

lams_tool_scratchie/web/pages/authoring/parts/itemlist.jsp

Options
    • -1
    • +1
    ./3rdParty.userlibraries
  2. … 29 more files in changeset.
Sunday 20 Dec 2020
12:46 pm

Ernie Ghiglione

LDEV-5120 index.html should be blank

Options
    • -0
    • +3
    ./conf/etherpad/etherpad-lite/src/templates/index.html
Thursday 17 Dec 2020
8:35 pm

Marcin Cieslak

LDEV-5127 Fix a bug when change suggestion with new lines caused error

Options
    • -0
    • +6
    ./conf/etherpad/etherpad-lite/node_modules/ep_comments_page/static/js/index.js
6:29 pm

Marcin Cieslak

LDEV-5127 Fix a bug when counting characters in stats plugin

Options
    • -1
    • +1
    ./conf/etherpad/etherpad-lite/node_modules/ep_stats/static/js/stats.js
6:21 pm

Marcin Cieslak

LDEV-5127 Improve stats popup layout and positioning

Options
    • -0
    • +46
    ./conf/etherpad/etherpad-lite/node_modules/ep_stats/static/css/stats.css
    • -0
    • +303
    ./conf/etherpad/etherpad-lite/node_modules/ep_stats/static/js/stats.js
6:04 pm

Marcin Cieslak

LDEV-5127 Hide right comments bar by default

Options
    • -0
    • +1325
    ./conf/etherpad/etherpad-lite/node_modules/ep_comments_page/static/js/index.js
5:29 pm

Marcin Cieslak

LDEV-5127 Add settings to show stats and comments section

Options
    • -0
    • +1
    ./conf/etherpad/etherpad-lite/settings.json
    • -1
    • +9
    ./conf/etherpad/etherpad-lite/src/static/js/pad.js
Thursday 03 Dec 2020
6:23 pm

Marcin Cieslak

LDEV-5127 Inform that Etherpad plugins are not optional anymore

Options
    • -8
    • +9
    ./conf/etherpad/readme.txt
Wednesday 02 Dec 2020
5:14 am

Marcin Cieslak

LDEV-5127 Identify new Etherpad authors immediately

Options
    • -0
    • +287
    ./conf/etherpad/etherpad-lite/node_modules/ep_author_neat/static/js/index.js
    • -0
    • +51
    ./conf/etherpad/etherpad-lite/node_modules/ep_authornames/static/js/index.js