lams-github / lams_central

src

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 03 Nov 2014
10:12 pm

Marcin Cieslak

LDEV-3315, LDEV-3367: Refactor SecurityService methods. Improve security in several places.

Options
    • -7
    • +7
    ./java/org/lamsfoundation/lams/authoring/web/AuthoringAction.java
    • -2
    • +2
    ./java/org/lamsfoundation/lams/web/DisplayGroupAction.java
    • -53
    • +54
    ./java/org/lamsfoundation/lams/web/FindUserLessonsAction.java
    • -135
    • +121
    ./java/org/lamsfoundation/lams/web/HomeAction.java
    • -35
    • +52
    ./java/org/lamsfoundation/lams/web/LessonConditionsAction.java
    • -25
    • +47
    ./java/org/lamsfoundation/lams/web/OrganisationGroupAction.java
  7. … 12 more files in changeset.
9:40 pm

Marcin Cieslak

LDEV-3315, LDEV-3367: Refactor SecurityService methods. Improve security in several places.

Options
    • -7
    • +7
    ./java/org/lamsfoundation/lams/authoring/web/AuthoringAction.java
    • -2
    • +2
    ./java/org/lamsfoundation/lams/web/DisplayGroupAction.java
    • -53
    • +54
    ./java/org/lamsfoundation/lams/web/FindUserLessonsAction.java
    • -135
    • +121
    ./java/org/lamsfoundation/lams/web/HomeAction.java
    • -35
    • +52
    ./java/org/lamsfoundation/lams/web/LessonConditionsAction.java
    • -25
    • +47
    ./java/org/lamsfoundation/lams/web/OrganisationGroupAction.java
  7. … 12 more files in changeset.
Wednesday 29 Oct 2014
8:03 pm

Marcin Cieslak

LDEV-3315, LDEV-3367: Refactor SecurityService methods. Replace Monitoring and Gradebook own security code with SecurityService checks.

Options
    • -8
    • +3
    ./java/org/lamsfoundation/lams/authoring/web/AuthoringAction.java
    • -7
    • +4
    ./java/org/lamsfoundation/lams/web/DisplayGroupAction.java
    • -6
    • +2
    ./java/org/lamsfoundation/lams/web/HomeAction.java
  4. … 15 more files in changeset.
7:58 pm

Marcin Cieslak

LDEV-3315, LDEV-3367: Refactor SecurityService methods. Replace Monitoring and Gradebook own security code with SecurityService checks.

Options
    • -8
    • +3
    ./java/org/lamsfoundation/lams/authoring/web/AuthoringAction.java
    • -7
    • +4
    ./java/org/lamsfoundation/lams/web/DisplayGroupAction.java
    • -6
    • +2
    ./java/org/lamsfoundation/lams/web/HomeAction.java
  4. … 17 more files in changeset.
Thursday 23 Oct 2014
9:18 pm

Marcin Cieslak

LDEV-3115: Copy tool content when copying an activity.

Options
    • -5
    • +2
    ./java/org/lamsfoundation/lams/authoring/service/AuthoringService.java
    • -4
    • +3
    ./java/org/lamsfoundation/lams/authoring/service/IAuthoringService.java
    • -4
    • +28
    ./java/org/lamsfoundation/lams/authoring/web/AuthoringAction.java
  4. … 2 more files in changeset.
9:16 pm

Marcin Cieslak

LDEV-3115: Copy tool content when copying an activity.

Options
    • -5
    • +2
    ./java/org/lamsfoundation/lams/authoring/service/AuthoringService.java
    • -4
    • +3
    ./java/org/lamsfoundation/lams/authoring/service/IAuthoringService.java
    • -4
    • +28
    ./java/org/lamsfoundation/lams/authoring/web/AuthoringAction.java
  4. … 2 more files in changeset.
7:11 pm

Marcin Cieslak

LDEV-3358: Fix attribute storing and loading for different grouping types.

Options
    • -1
    • +1
    ./java/org/lamsfoundation/lams/authoring/ObjectExtractor.java
  2. … 2 more files in changeset.
7:07 pm

Marcin Cieslak

LDEV-3358: Fix attribute storing and loading for different grouping types.

Options
    • -1
    • +1
    ./java/org/lamsfoundation/lams/authoring/ObjectExtractor.java
  2. … 2 more files in changeset.
Wednesday 22 Oct 2014
2:50 am

Marcin Cieslak

LDEV-3331: Allow logging in via integrations. Allow redirecting to a given URL after log in. Adjust sysadmin "login as" functionality.

Options
    • -7
    • +7
    ./java/org/lamsfoundation/lams/web/LoginAsAction.java
    • -12
    • +17
    ./java/org/lamsfoundation/lams/web/LoginRequestServlet.java
  3. … 2 more files in changeset.
Tuesday 21 Oct 2014
6:27 pm

Marcin Cieslak

LDEV-3315: Add security service and use it in vital entry points.

Options
    • -1
    • +22
    ./java/org/lamsfoundation/lams/authoring/web/AuthoringAction.java
    • -7
    • +29
    ./java/org/lamsfoundation/lams/web/DisplayGroupAction.java
    • -11
    • +32
    ./java/org/lamsfoundation/lams/web/HomeAction.java
  4. … 12 more files in changeset.
Monday 20 Oct 2014
5:27 pm

Marcin Cieslak

LDEV-3315: Add utility methods for security. Use the new SecurityService in several places.

Options
    • -1
    • +22
    ./java/org/lamsfoundation/lams/authoring/web/AuthoringAction.java
  2. … 8 more files in changeset.
Sunday 19 Oct 2014
4:35 pm

marek

LDEV-3332: revert spring-beans schema declaration in application context xml files. export spring meta-inf in jboss-deployment-structure.xml

It is way more elegant approach to fix an issue with spring-beans.xsd loading from internet.

Options
    • -1
    • +1
    ./java/org/lamsfoundation/lams/authoring/authoringApplicationContext.xml
    • -1
    • +1
    ./java/org/lamsfoundation/lams/web/webApplicationContext.xml
    • -1
    • +1
    ./java/org/lamsfoundation/lams/workspace/workspaceApplicationContext.xml
  4. … 75 more files in changeset.
4:29 am

marek

LDEV-3332: fix spring contexts declaration to find spring-beans-4.0.xsd locally at classpath.

Having spring module defined as a set of spring jars (as we do have in Wildfly), it is impossible for spring to resolve xsd schema mapping file 'spring.schemas' correctly. With set of jars, we have 5 instances of this file (with different content) under the same path 'META-INF/spring.schemas'. This ended up in spring not beeing able to map spring-beans-4.0.xsd URL path to local resource location. Finally, this xsd was loaded from internet - and that significantly slowed Wildfly startup.

With this fix LAMS is way (depends on internet connection) faster to start.

Options
    • -1
    • +1
    ./java/org/lamsfoundation/lams/authoring/authoringApplicationContext.xml
    • -1
    • +1
    ./java/org/lamsfoundation/lams/web/webApplicationContext.xml
    • -1
    • +1
    ./java/org/lamsfoundation/lams/workspace/workspaceApplicationContext.xml
  4. … 74 more files in changeset.
Wednesday 15 Oct 2014
12:43 am

Marcin Cieslak

LDEV-3275: Remove duplicate error log.

Options
    • -1
    • +0
    ./java/org/lamsfoundation/lams/security/UniversalLoginModule.java
Tuesday 14 Oct 2014
8:49 pm

Marcin Cieslak

LDEV-3275: Add SsoConsumer in LAMS Central as requests (index.jsp, index.do) immediate after j_security_check are also being authenticated. They also are considered an authentication attempt, but they bypass shared session creation in SsoProducer and it causes errors. This was addressed by a simple check - no shared session in UniversalLoginModule, no authentication attempt.

Options
    • -2
    • +2
    ./java/org/lamsfoundation/lams/security/UniversalLoginModule.java
  2. … 2 more files in changeset.
Wednesday 08 Oct 2014
12:47 am

Marcin Cieslak

LDEV-3321: Use the "progressUser" to produce progress output, not the one being authenticated.

Options
    • -1
    • +1
    ./java/org/lamsfoundation/lams/webservice/xml/LessonManagerServlet.java
12:45 am

Marcin Cieslak

LDEV-3321: Use the "progressUser" to produce progress output, not the one being authenticated.

Options
    • -1
    • +1
    ./java/org/lamsfoundation/lams/webservice/xml/LessonManagerServlet.java
Friday 03 Oct 2014
9:10 pm

Marcin Cieslak

LDEV-3315: Add security service and use it in vital entry points.

Options
    • -7
    • +29
    ./java/org/lamsfoundation/lams/web/DisplayGroupAction.java
    • -11
    • +32
    ./java/org/lamsfoundation/lams/web/HomeAction.java
  3. … 11 more files in changeset.
Tuesday 30 Sep 2014
9:11 pm

Marcin Cieslak

LDEV-3315: Clean up roles and paths to secured resources in all modules. Remove AUTHOR ADMIN role.

Options
    • -287
    • +307
    ./java/org/lamsfoundation/lams/security/UniversalLoginModule.java
    • -4
    • +3
    ./java/org/lamsfoundation/lams/web/IndexAction.java
    • -8
    • +8
    ./java/org/lamsfoundation/lams/web/planner/PedagogicalPlannerAction.java
    • -3
    • +2
    ./java/org/lamsfoundation/lams/workspace/service/WorkspaceManagementService.java
  5. … 69 more files in changeset.
1:10 am

Marcin Cieslak

LDEV-3315: Remove AUTHOR ADMIN role. Allow AUTHOR role to preview lessons. Allow MONITOR role to edit activities and run Live Edit.

Options
    • -2
    • +1
    ./java/org/lamsfoundation/lams/security/UniversalLoginModule.java
    • -4
    • +3
    ./java/org/lamsfoundation/lams/web/IndexAction.java
    • -8
    • +8
    ./java/org/lamsfoundation/lams/web/planner/PedagogicalPlannerAction.java
    • -3
    • +2
    ./java/org/lamsfoundation/lams/workspace/service/WorkspaceManagementService.java
  5. … 69 more files in changeset.
Friday 19 Sep 2014
6:55 pm

Marcin Cieslak

LDEV-3275: Introduce SSO using Undertow mechanisms.

Valves do not exist in Undertow. Another approach had to be used.

In each WAR there is a file in META-INF/service dir which adds a class in request processing chaing.

For Central it is SsoProducer which put the authenticated account into shared session.

All other modules use SsoConsumer which takes the account and puts it into its security context.

In standalone.xml caching of credentials was switched off as it would prevent UniversalLoginModule from putting UserDTO into shared session.

TODO: use a simple pass-all authentication mechanism for static files like images and JS files.

Options
    • -308
    • +287
    ./java/org/lamsfoundation/lams/security/UniversalLoginModule.java
  2. … 12 more files in changeset.
Saturday 13 Sep 2014
5:01 am

Andrey Balan

LDEV-2463 Added new method "learnerStrictAuth" available to LoginRequest. It works the same way as "learner" but requires hash to also contain lesson id parameter.

Options
    • -1
    • +13
    ./java/org/lamsfoundation/lams/web/LoginRequestServlet.java
  2. … 4 more files in changeset.
4:46 am

Andrey Balan

LDEV-3309 Add isUpdateUserDetails parameter for LoginRequest so user details get updated

Options
    • -1
    • +4
    ./java/org/lamsfoundation/lams/web/LoginRequestServlet.java
    • -2
    • +3
    ./java/org/lamsfoundation/lams/webservice/xml/LearningDesignRepositoryServlet.java
    • -1
    • +2
    ./java/org/lamsfoundation/lams/webservice/xml/LessonManagerServlet.java
  4. … 4 more files in changeset.
3:45 am

Andrey Balan

LDEV-3309 Add isUpdateUserDetails parameter for LoginRequest so user details get updated

Options
    • -1
    • +4
    ./java/org/lamsfoundation/lams/web/LoginRequestServlet.java
    • -2
    • +3
    ./java/org/lamsfoundation/lams/webservice/xml/LearningDesignRepositoryServlet.java
    • -1
    • +2
    ./java/org/lamsfoundation/lams/webservice/xml/LessonManagerServlet.java
  4. … 4 more files in changeset.
Wednesday 03 Sep 2014
3:27 pm

Marcin Cieslak

LDEV-3292: When looking for an unique LD title to create a lesson, search for LDs with given prefix instead taking all from given workspace folder.

Options
    • -1
    • +2
    ./java/org/lamsfoundation/lams/authoring/service/AuthoringService.java
  2. … 2 more files in changeset.
3:10 pm

Marcin Cieslak

LDEV-3292: When looking for an unique LD title to create a lesson, search for LDs with given prefix instead taking all from given workspace folder.

Options
    • -1
    • +2
    ./java/org/lamsfoundation/lams/authoring/service/AuthoringService.java
  2. … 3 more files in changeset.
6:00 am

Andrey Balan

LDEV-3287 Audit log when loginas

Options
    • -30
    • +42
    ./java/org/lamsfoundation/lams/web/LoginAsAction.java
5:02 am

Andrey Balan

LDEV-3283 don't pass parameters on starting a lesson in order to prevent users tampering with them

Options
    • -36
    • +35
    ./java/org/lamsfoundation/lams/web/HomeAction.java
  2. … 2 more files in changeset.
Saturday 16 Aug 2014
7:20 pm

Marcin Cieslak

LDEV-3293: Rewrite Application Context configuration files for Spring 4.

Options
    • -3
    • +6
    ./java/org/lamsfoundation/lams/authoring/authoringApplicationContext.xml
    • -5
    • +5
    ./java/org/lamsfoundation/lams/web/webApplicationContext.xml
    • -2
    • +5
    ./java/org/lamsfoundation/lams/workspace/workspaceApplicationContext.xml
  4. … 76 more files in changeset.
Monday 11 Aug 2014
10:50 pm

Andrey Balan

LDEV-3287 Audit log when loginas

Options
    • -30
    • +42
    ./java/org/lamsfoundation/lams/web/LoginAsAction.java