lams-github / lams_common / src / java / org

lamsfoundation

Clone Tools

Stats

Commits this week: 0
Total Committers: 32
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 22 Jan 2019
5:26 pm

Marcin Cieslak

LDEV-4746 Allow adding new QB questions to MCQ

Add some comments.

Options
    • -1
    • +3
    ./lams/qb/QbQuestion.java
  2. … 1 more file in changeset.
5:08 pm

Marcin Cieslak

LDEV-4746 Redesign flow for saving MCQ questions

Detached QB entities act as their own DTOs.

Question options modification is detected and processed.

Options
    • -1
    • +28
    ./lams/qb/QbOption.java
    • -20
    • +27
    ./lams/qb/QbQuestion.java
  3. … 7 more files in changeset.
5:07 pm

Marcin Cieslak

LDEV-4746 Fix a typo in SQL patch

Options
    • -1
    • +1
    ./lams/dbupdates/patch20190110.sql
Monday 21 Jan 2019
9:08 am

Marcin Cieslak

LDEV-4755 Scan when importing LDs

Options
    • -10
    • +15
    ./lams/learningdesign/service/ExportToolContentService.java
  2. … 3 more files in changeset.
Saturday 19 Jan 2019
4:25 pm

Marcin Cieslak

LDEV-4755 Add configuration for antivirus

Options
    • -0
    • +17
    ./lams/dbupdates/patch20190119.sql
    • -0
    • +6
    ./lams/util/ConfigurationKeys.java
    • -2
    • +7
    ./lams/util/FileUtil.java
  4. … 1 more file in changeset.
3:49 pm

Marcin Cieslak

LDEV-4755 Initial virus scanning implementation

Options
    • -1
    • +37
    ./lams/util/FileUtil.java
  2. … 3 more files in changeset.
Sunday 13 Jan 2019
4:18 pm

Marcin Cieslak

LDEV-4746 Add Question Bank option and process it in MCQ tool

Options
    • -3
    • +28
    ./lams/dbupdates/patch20190110.sql
    • -0
    • +66
    ./lams/qb/QbOption.java
    • -0
    • +16
    ./lams/qb/QbQuestion.java
  4. … 5 more files in changeset.
Thursday 10 Jan 2019
7:49 pm

Andrey Balan

LDEV-4678 Push some util methods to the service layer

Certain static util methods (mainly from LearningWebUtil.java) expect

service beans as a parameter. It was changed by pushing those methods to

the appropriate service layer.

Options
    • -0
    • +15
    ./lams/learning/service/ILearnerService.java
    • -0
    • +2
    ./lams/usermanagement/service/IUserManagementService.java
    • -0
    • +5
    ./lams/usermanagement/service/UserManagementService.java
    • -91
    • +3
    ./lams/util/WebUtil.java
  5. … 26 more files in changeset.
2:00 pm

Marcin Cieslak

LDEV-4746 Format SQL patch

Options
    • -4
    • +12
    ./lams/dbupdates/patch20190110.sql
1:08 pm

Marcin Cieslak

LDEV-4746 Fix Hibernate management of QB question to prevent duplicates

Options
    • -0
    • +41
    ./lams/dbupdates/patch20190110.sql
    • -2
    • +2
    ./lams/qb/QbQuestion.java
  3. … 1 more file in changeset.
1:07 pm

Marcin Cieslak

LDEV-4746 Initial Question Bank question implementation

The question is tested on Multiple Choice tool.

Options
    • -0
    • +1
    ./lams/commonContext.xml
    • -0
    • +162
    ./lams/qb/QbQuestion.java
  3. … 8 more files in changeset.
Thursday 03 Jan 2019
12:21 pm

Marcin Cieslak

LDEV-4696 Make inherited properties also mapped to DB.

Options
    • -0
    • +2
    ./lams/learningdesign/BranchingActivity.java
Wednesday 02 Jan 2019
7:33 pm

Andrey Balan

LDEV-4692 Fix time taken's timezone

And some minor code formatting.

Options
    • -2
    • +2
    ./lams/util/DateUtil.java
  2. … 2 more files in changeset.
6:50 pm

Andrey Balan

LDEV-4700 Fix getDefaultTheme() method

Options
    • -3
    • +3
    ./lams/usermanagement/service/UserManagementService.java
Thursday 20 Dec 2018
9:47 pm

Andrey Balan

LDEV-4678 WebUtil.putActivityPositionInRequestByToolSessionId transformed into service method

Also introduce ICommonToolService that will hold methods shared by all

tools.

Options
    • -0
    • +30
    ./lams/tool/service/ICommonToolService.java
    • -0
    • +6
    ./lams/tool/service/ILamsToolService.java
    • -0
    • +9
    ./lams/tool/service/LamsToolService.java
    • -18
    • +0
    ./lams/util/WebUtil.java
    • -0
    • +1
    ./lams/web/util/AttributeNames.java
  6. … 138 more files in changeset.
Tuesday 18 Dec 2018
3:45 am

Fiona Malikoff <Fiona.Malikoff@gmail.com>

LDEV-4737 Course based lesson delete does not throw exception

Options
    • -0
    • +6
    ./lams/lesson/dao/ILessonDAO.java
    • -4
    • +15
    ./lams/lesson/dao/hibernate/LessonDAO.java
    • -0
    • +6
    ./lams/lesson/service/ILessonService.java
    • -0
    • +5
    ./lams/lesson/service/LessonService.java
  5. … 2 more files in changeset.
Friday 14 Dec 2018
2:25 am

Fiona Malikoff <Fiona.Malikoff@gmail.com>

LDEV-4726 Licenses updated to Creative Commons 4.0

Options
    • -0
    • +55
    ./lams/dbupdates/patch20181214.sql
    • -0
    • +11
    ./lams/learningdesign/License.java
    • -0
    • +3
    ./lams/learningdesign/dao/ILicenseDAO.java
    • -0
    • +9
    ./lams/learningdesign/dao/hibernate/LicenseDAO.java
  5. … 17 more files in changeset.
Thursday 13 Dec 2018
7:02 am

Marcin Cieslak

LDEV-4705 Merge group admin role to manager in LDAP configuration

Options
    • -0
    • +17
    ./lams/dbupdates/patch20181213.sql
Wednesday 05 Dec 2018
2:24 pm

Marcin Cieslak

LDEV-4696 Allow default value of Hibernate cache JNDI name

Options
    • -1
    • +0
    ./lams/applicationContext.xml
Tuesday 04 Dec 2018
9:18 am

Marcin Cieslak

LDEV-4705 Remove references to Group Admin role from DB

Options
    • -0
    • +14
    ./lams/dbupdates/patch20181204.sql
9:07 am

Marcin Cieslak

LDEV-4705 Remove obsolete Privilege tables

Options
    • -0
    • +15
    ./lams/dbupdates/patch20181204.sql
    • -62
    • +0
    ./lams/usermanagement/Privilege.java
    • -66
    • +0
    ./lams/usermanagement/RolePrivilege.java
8:51 am

Marcin Cieslak

LDEV-4705 Remove references to Group Admin role from Java code

Options
    • -5
    • +1
    ./lams/security/SecurityService.java
    • -6
    • +2
    ./lams/usermanagement/Role.java
    • -1
    • +1
    ./lams/usermanagement/service/IUserManagementService.java
    • -4
    • +0
    ./lams/usermanagement/service/LdapService.java
    • -8
    • +4
    ./lams/usermanagement/service/UserManagementService.java
  6. … 22 more files in changeset.
5:32 am

Marcin Cieslak

LDEV-4721 Change order of changes applied to imported LD XML

First we need to change class names, then add/remove fields as otherwise

owner classes would not get recognised.

Options
    • -13
    • +5
    ./lams/learningdesign/service/ToolContentVersionFilter.java
Monday 03 Dec 2018
2:39 am

Marcin Cieslak

LDEV-4721 Add class renaming filter for tool content import

Options
    • -30
    • +86
    ./lams/learningdesign/service/ToolContentVersionFilter.java
  2. … 17 more files in changeset.
Saturday 01 Dec 2018
4:27 pm

Marcin Cieslak

LDEV-4696 Remove an unnecessary Hibernate restriction

Options
    • -11
    • +1
    ./lams/learningdesign/GroupingActivity.java
Wednesday 28 Nov 2018
8:50 am

Marcin Cieslak

Merge remote-tracking branch 'origin/master' into lams31

Conflicts:

lams_central/src/java/org/lamsfoundation/lams/web/ForgotPasswordServlet.java

lams_central/web/forgotPassword.jsp

lams_central/web/forgotPasswordChange.jsp

lams_central/web/forgotPasswordProc.jsp

lams_tool_assessment/web/pages/learning/results.jsp

Options
    • -0
    • +2
    ./lams/util/ConfigurationKeys.java
  2. … 10 more files in changeset.
Tuesday 27 Nov 2018
8:54 pm

Andrey Balan

LDEV-4710 Add config setting to enable "Forgot your password?" option

Also if people try to get to the login page by going to the URL

directly, we display a 404 error message.

Options
    • -0
    • +15
    ./lams/dbupdates/patch20181127.sql
    • -0
    • +2
    ./lams/util/ConfigurationKeys.java
  3. … 4 more files in changeset.
2:46 pm

Marcin Cieslak

LDEV-4714 Fix LD access adding and processing

Options
    • -4
    • +6
    ./lams/learningdesign/dao/ILearningDesignDAO.java
    • -1
    • +12
    ./lams/learningdesign/dao/hibernate/LearningDesignDAO.java
  3. … 2 more files in changeset.
Monday 26 Nov 2018
4:23 pm

Marcin Cieslak

LDEV-4696 Make all @ManyToOne and @OneToOne lazy

Hibernate 3 used lazy loading of single-object relationships by default.

JPA's default setting is eager. When loading entities all references are

loaded immediately using JOINs. A large entity, like Learning Design,

can have a query consisting of 25 JOINs. It makes it very slow.

There is no way to change JPA's default behaviour. In order to make JPA

annotations behave like old Hibernate, each of them got an explicit

attribute saying that loading is lazy.

Options
    • -15
    • +15
    ./lams/comments/Comment.java
    • -5
    • +4
    ./lams/comments/CommentLike.java
    • -1
    • +2
    ./lams/events/Subscription.java
    • -2
    • +3
    ./lams/gradebook/GradebookUserActivity.java
    • -2
    • +3
    ./lams/gradebook/GradebookUserLesson.java
    • -2
    • +3
    ./lams/integration/ExtCourseClassMap.java
    • -1
    • +2
    ./lams/integration/ExtServerLessonMap.java
    • -2
    • +3
    ./lams/integration/ExtServerToolAdapterMap.java
    • -2
    • +3
    ./lams/integration/ExtUserUseridMap.java
    • -7
    • +8
    ./lams/learningdesign/Activity.java
    • -1
    • +2
    ./lams/learningdesign/ActivityEvaluation.java
    • -4
    • +4
    ./lams/learningdesign/BranchActivityEntry.java
    • -1
    • +2
    ./lams/learningdesign/Competence.java
    • -2
    • +3
    ./lams/learningdesign/CompetenceMapping.java
    • -1
    • +1
    ./lams/learningdesign/ComplexActivity.java
  16. … 156 more files in changeset.
4:23 pm

Marcin Cieslak

LDEV-4696 Make all @ManyToOne and @OneToOne lazy

Hibernate 3 used lazy loading of single-object relationships by default.

JPA's default setting is eager. When loading entities all references are

loaded immediately using JOINs. A large entity, like Learning Design,

can have a query consisting of 25 JOINs. It makes it very slow.

There is no way to change JPA's default behaviour. In order to make JPA

annotations behave like old Hibernate, each of them got an explicit

attribute saying that loading is lazy.

Options
    • -15
    • +15
    ./lams/comments/Comment.java
    • -5
    • +4
    ./lams/comments/CommentLike.java
    • -1
    • +2
    ./lams/events/Subscription.java
    • -2
    • +3
    ./lams/gradebook/GradebookUserActivity.java
    • -2
    • +3
    ./lams/gradebook/GradebookUserLesson.java
    • -2
    • +3
    ./lams/integration/ExtCourseClassMap.java
    • -1
    • +2
    ./lams/integration/ExtServerLessonMap.java
    • -2
    • +3
    ./lams/integration/ExtServerToolAdapterMap.java
    • -2
    • +3
    ./lams/integration/ExtUserUseridMap.java
    • -7
    • +8
    ./lams/learningdesign/Activity.java
    • -1
    • +2
    ./lams/learningdesign/ActivityEvaluation.java
    • -4
    • +4
    ./lams/learningdesign/BranchActivityEntry.java
    • -1
    • +2
    ./lams/learningdesign/Competence.java
    • -2
    • +3
    ./lams/learningdesign/CompetenceMapping.java
    • -1
    • +1
    ./lams/learningdesign/ComplexActivity.java
  16. … 156 more files in changeset.