lams-github / lams_common / src / java / org

lamsfoundation

Clone Tools

Stats

Commits this week: 0
Total Committers: 32
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 24 Oct 2022
4:50 pm

Marcin Cieslak

Merge remote-tracking branch 'origin/v4.6' into v4.7

Conflicts:

lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/ExtServerManagementController.java

lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/LtiConsumerManagementController.java

lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/OrganisationController.java

lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserOrgRoleSaveController.java

lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserRolesSaveController.java

lams_admin/web/integration/ltiConsumerList.jsp

lams_admin/web/signupmanagement/list.jsp

Options
    • -1
    • +2
    ./lams/security/SecurityService.java
    • -0
    • +4
    ./lams/usermanagement/service/UserManagementService.java
  3. … 15 more files in changeset.
Saturday 22 Oct 2022
12:43 pm

Marcin Cieslak

LDEV-5335 Log adjustments and fixes

Options
    • -0
    • +5
    ./lams/web/filter/AuditLogFilter.java
  2. … 8 more files in changeset.
Friday 14 Oct 2022
3:23 pm

Marcin Cieslak

LDEB-5335 Add structured audit logs on various admin actions

Options
    • -4
    • +4
    ./lams/integration/security/SsoHandler.java
    • -0
    • +4
    ./lams/learningdesign/service/LearningDesignService.java
    • -17
    • +26
    ./lams/policies/service/PolicyService.java
    • -1
    • +2
    ./lams/security/SecurityService.java
    • -0
    • +4
    ./lams/usermanagement/service/UserManagementService.java
    • -10
    • +71
    ./lams/web/filter/AuditLogFilter.java
  7. … 17 more files in changeset.
Thursday 13 Oct 2022
11:20 am

Marcin Cieslak

LDEV-5277 Fix course naming and enrolment issue

Options
    • -0
    • +5
    ./lams/integration/service/IIntegrationService.java
    • -2
    • +18
    ./lams/integration/service/IntegrationService.java
10:02 am

Marcin Cieslak

LDEV-5332 Add VSA support to Question Results table

In Scratchie VSA answers were not linked to corresponding QB options,

making it impossible to count correct answer. From now on if answer is

correct, it will get linked to its QB option. Old VSA lessons though

will not yield good Question Results table.

Options
    • -11
    • +21
    ./lams/qb/dao/hibernate/QbDAO.java
  2. … 2 more files in changeset.
Wednesday 12 Oct 2022
2:21 pm

Marcin Cieslak

LDEV-5332 Identify questions and options by display order

iRAT and tRAT activities should be based on same questions from Question

Bank, with same IDs. It is not always the case, especially when

importing exported LDs.

Now corresponding questions are identified by display order, which

should be the same in both RAT activities.

Options
    • -3
    • +3
    ./lams/qb/dao/hibernate/QbDAO.java
    • -5
    • +5
    ./lams/qb/dto/QbAnswersForOptionDTO.java
  3. … 4 more files in changeset.
Tuesday 11 Oct 2022
2:59 pm

Marcin Cieslak

Merge branch 'LDEV-5332' into v4.7

Options
    • -1
    • +4
    ./lams/qb/dao/IQbDAO.java
    • -3
    • +70
    ./lams/qb/dao/hibernate/QbDAO.java
    • -1
    • +8
    ./lams/qb/service/QbService.java
2:57 pm

Marcin Cieslak

LDEV-5332 Add Question Results table in Teams tab

Options
    • -1
    • +4
    ./lams/qb/dao/IQbDAO.java
    • -5
    • +72
    ./lams/qb/dao/hibernate/QbDAO.java
    • -0
    • +39
    ./lams/qb/dto/QbAnswersForOptionDTO.java
    • -0
    • +4
    ./lams/qb/service/IQbService.java
    • -1
    • +8
    ./lams/qb/service/QbService.java
  6. … 6 more files in changeset.
Friday 07 Oct 2022
2:20 pm

Marcin Cieslak

LDEV-5178 Skip password expiration check on login via integrations

Options
    • -0
    • +2
    ./lams/integration/security/SsoHandler.java
  2. … 2 more files in changeset.
Thursday 06 Oct 2022
11:44 am

Marcin Cieslak

LDEV-5333 Move HTML templates from WWW to Central folder

Options
    • -0
    • +1
    ./lams/util/FileUtil.java
  2. … 6 more files in changeset.
11:26 am

Marcin Cieslak

LDEV-5334 Make shared collections available to authors

Options
    • -0
    • +2
    ./lams/qb/dao/IQbDAO.java
    • -2
    • +13
    ./lams/qb/dao/hibernate/QbDAO.java
    • -2
    • +5
    ./lams/qb/service/QbService.java
  4. … 2 more files in changeset.
Monday 03 Oct 2022
3:43 pm

Marcin Cieslak

LDEV-5329 Remove obsolete configuration items

Options
    • -0
    • +15
    ./lams/dbupdates/patch20221003.sql
    • -37
    • +0
    ./lams/util/ConfigurationKeys.java
  3. … 12 more files in changeset.
Thursday 29 Sep 2022
1:52 pm

Marcin Cieslak

LDEV-5330 Merge changes made for sysadmin

It included upgrading to Bootstrap 5 and using UI guidelines set for

Monitoring UI.

Options
    • -0
    • +2
    ./lams/dao/IBaseDAO.java
    • -0
    • +5
    ./lams/dao/hibernate/LAMSBaseDAO.java
    • -8
    • +10
    ./lams/statistics/service/StatisticsService.java
  4. … 189 more files in changeset.
Wednesday 28 Sep 2022
7:33 pm

Ernie Ghiglione

LDEV-5320 replace CR for values

As logs are parsed one line at the time, if some of these contain CRs, then these cannot be parsed properly and regexp for log monitors aren't triggered properly

Options
    • -2
    • +2
    ./lams/web/filter/AuditLogFilter.java
Thursday 22 Sep 2022
11:55 am

Marcin Cieslak

LDEV-5302 Fix bug when adding appadmin role

Options
    • -2
    • +2
    ./lams/usermanagement/Role.java
Wednesday 21 Sep 2022
12:44 pm

Marcin Cieslak

LDEV-5327 Add Clear Cache button

Options
    • -1
    • +22
    ./lams/util/hibernate/HibernateSessionManager.java
  2. … 5 more files in changeset.
10:57 am

Marcin Cieslak

Merge remote-tracking branch 'origin/LDEV-5302' into v4.7

Conflicts:

lams_admin/conf/language/lams/ApplicationResources_zh_CN.properties

lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserController.java

lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserOrgRoleSaveController.java

lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserRolesSaveController.java

lams_admin/web/user.jsp

lams_central/conf/language/lams/ApplicationResources_zh_CN.properties

lams_central/src/java/org/lamsfoundation/lams/web/DisplayGroupController.java

lams_common/src/java/org/lamsfoundation/lams/usermanagement/service/UserManagementService.java

Options
    • -7
    • +30
    ./lams/security/SecurityService.java
    • -7
    • +7
    ./lams/usermanagement/Role.java
    • -5
    • +7
    ./lams/usermanagement/service/IUserManagementService.java
    • -10
    • +17
    ./lams/usermanagement/service/UserManagementService.java
  5. … 55 more files in changeset.
7:56 am

Marcin Cieslak

LDEV-5328 Squash DB patches and update versions

Options
    • -17
    • +0
    ./lams/dbupdates/patch20190119.sql
    • -15
    • +0
    ./lams/dbupdates/patch20190126.sql
    • -17
    • +0
    ./lams/dbupdates/patch20190201.sql
    • -16
    • +0
    ./lams/dbupdates/patch20190226.sql
    • -23
    • +0
    ./lams/dbupdates/patch20190313.sql
    • -15
    • +0
    ./lams/dbupdates/patch20190520.sql
    • -17
    • +0
    ./lams/dbupdates/patch20190721.sql
    • -848
    • +0
    ./lams/dbupdates/patch20190722.sql
    • -20
    • +0
    ./lams/dbupdates/patch20190723.sql
    • -63
    • +0
    ./lams/dbupdates/patch20190724.sql
    • -14
    • +0
    ./lams/dbupdates/patch20190725.sql
    • -14
    • +0
    ./lams/dbupdates/patch20190808.sql
    • -15
    • +0
    ./lams/dbupdates/patch20190816.sql
    • -14
    • +0
    ./lams/dbupdates/patch20190913.sql
    • -19
    • +0
    ./lams/dbupdates/patch20191023.sql
  16. … 140 more files in changeset.
Friday 02 Sep 2022
7:06 am

Marcin Cieslak

Revert "LDEV-5320 Add LAMS instance information to audit logs"

This reverts commit 3db824f7e69ecba2b1e53b1060cf849cfe23ae9c.

Options
    • -7
    • +3
    ./lams/web/filter/AuditLogFilter.java
Wednesday 31 Aug 2022
8:20 am

Marcin Cieslak

LDEV-5325 Import "stop at preceding activity" gate property

Options
    • -0
    • +3
    ./lams/learningdesign/service/ExportToolContentService.java
Tuesday 30 Aug 2022
7:43 pm

Marcin Cieslak

LDEV-5083 Fix absolute time limit check by using UTC time

Options
    • -1
    • +1
    ./lams/lesson/dao/hibernate/LessonDAO.java
7:03 pm

Marcin Cieslak

LDEV-5083 Update time limits on dashboard using Flux

Options
    • -1
    • +1
    ./lams/flux/FluxRegistry.java
    • -1
    • +1
    ./lams/lesson/dao/hibernate/LessonDAO.java
    • -5
    • +5
    ./lams/lesson/dto/ActivityTimeLimitDTO.java
    • -0
    • +2
    ./lams/util/CommonConstants.java
  5. … 4 more files in changeset.
4:39 pm

Marcin Cieslak

LDEV-5083 Add frontend for displaying running time limits in lesson

Options
    • -2
    • +3
    ./lams/lesson/dto/ActivityTimeLimitDTO.java
  2. … 4 more files in changeset.
3:27 pm

Marcin Cieslak

LDEV-5083 Add backend for fetching running time limits in lesson

Options
    • -0
    • +6
    ./lams/lesson/dao/ILessonDAO.java
    • -0
    • +45
    ./lams/lesson/dao/hibernate/LessonDAO.java
    • -0
    • +27
    ./lams/lesson/dto/ActivityTimeLimitDTO.java
    • -0
    • +6
    ./lams/lesson/service/ILessonService.java
    • -0
    • +6
    ./lams/lesson/service/LessonService.java
    • -0
    • +1
    ./lams/util/CommonConstants.java
  7. … 1 more file in changeset.
Thursday 25 Aug 2022
6:34 pm

Marcin Cieslak

LDEV-5083 Show Burning Question nav button only if they are enabled

Options
    • -0
    • +5
    ./lams/tool/service/ICommonScratchieService.java
  2. … 3 more files in changeset.
Sunday 21 Aug 2022
11:37 am

Marcin Cieslak

LDEV-5320 Add LAMS instance information to audit logs

Options
    • -3
    • +7
    ./lams/web/filter/AuditLogFilter.java
Monday 15 Aug 2022
3:55 pm

Marcin Cieslak

LDEV-5324 Detect new question version as author changes its details

Options
    • -20
    • +25
    ./lams/qb/model/QbQuestion.java
  2. … 14 more files in changeset.
Monday 01 Aug 2022
12:05 pm

Marcin Cieslak

LDEV-5321 Prevent non-sysadmins from editing sysadmins

Options
    • -0
    • +2
    ./lams/usermanagement/service/IUserManagementService.java
    • -2
    • +6
    ./lams/usermanagement/service/UserManagementService.java
  3. … 1 more file in changeset.
Wednesday 27 Jul 2022
9:56 am

Marcin Cieslak

LDEV-5320 Add audit logs on role check failure

Options
    • -0
    • +26
    ./lams/security/SecurityService.java
Thursday 14 Jul 2022
3:50 pm

Marcin Cieslak

LDEV-5083 Prevent WF from freezing on shutdown because of unclosed Flux

Open Fluxes prevent WF from shutting down as they are threads not

managed by the server lifecycle.

Now we force complete Sinks on Spring context destroy. It closes

underlying Flux threads.

The problem is that it occurs when most Spring beans are already

destroyed. Fluxes on close want to emit a signal to front end

subscribers. Spring tries to reinitialise controllers which should send

those signals. It fails as context basically does not exist anymore.

All in all we get some harmless errors on server shutdown.

The way to avoid would be to have more control over Spring bean destroy

order which does not seem easily achievable.

Options
    • -1
    • +4
    ./lams/flux/FluxMap.java
    • -1
    • +17
    ./lams/flux/FluxRegistry.java
    • -0
    • +5
    ./lams/flux/SharedSink.java
    • -0
    • +13
    ./lams/web/filter/LamsContextLoaderListener.java