lams-github / lams_common / src / java / org

lamsfoundation

Clone Tools

Stats

Commits this week: 0
Total Committers: 32
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 24 Dec 2021
8:36 am

Marcin Cieslak

LDEV-5273 Remove single VSA allocation interface from Assessment

Since UI for VSA allocation moved to Central, it is more difficult to

make it embedded within a tools own monitoring interface. It is probably

not needed too - a well designed VSA allocation UI for all questions

should be sufficient.

Options
    • -6
    • +1
    ./lams/tool/service/ICommonAssessmentService.java
    • -1
    • +1
    ./lams/tool/service/LamsToolService.java
  3. … 3 more files in changeset.
8:32 am

Marcin Cieslak

LDEV-5273 Move VSA allocation code to Central

Options
    • -0
    • +27
    ./lams/qb/QbUtils.java
    • -0
    • +2
    ./lams/qb/service/IQbService.java
    • -0
    • +97
    ./lams/qb/service/QbService.java
    • -1
    • +14
    ./lams/tool/service/ICommonAssessmentService.java
    • -1
    • +1
    ./lams/tool/service/ICommonScratchieService.java
    • -2
    • +11
    ./lams/tool/service/ILamsToolService.java
    • -1
    • +1
    ./lams/tool/service/LamsCoreToolService.java
    • -2
    • +28
    ./lams/tool/service/LamsToolService.java
  9. … 14 more files in changeset.
Sunday 05 Dec 2021
10:09 am

Marcin Cieslak

LDEV-4644 Use [] instead of () to recognise LO code

Teachers tend to use () as a part of Learning Outcome name

Options
    • -2
    • +2
    ./lams/outcome/service/OutcomeService.java
  2. … 34 more files in changeset.
Saturday 04 Dec 2021
3:45 pm

Marcin Cieslak

LDEV-5260 Add utility class for global Flux management

Options
    • -17
    • +19
    ./lams/flux/FluxMap.java
    • -0
    • +49
    ./lams/flux/FluxRegistry.java
    • -4
    • +4
    ./lams/flux/SharedSink.java
  4. … 2 more files in changeset.
3:02 pm

Marcin Cieslak

LDEV-5260 Move custom Flux classes to separate package

Options
    • -0
    • +137
    ./lams/flux/FluxMap.java
    • -0
    • +40
    ./lams/flux/SharedSink.java
    • -137
    • +0
    ./lams/util/FluxMap.java
    • -40
    • +0
    ./lams/util/SharedSink.java
10:39 am

Marcin Cieslak

LDEV-5260 Improve Flux cancellation mechanism

Options
    • -10
    • +42
    ./lams/util/FluxMap.java
    • -0
    • +40
    ./lams/util/SharedSink.java
  3. … 1 more file in changeset.
1:21 am

Marcin Cieslak

LDEV-5260 Rewrite polling to producer-subscriber model

Till now we had "are-learners-answers-updated" polling on controller

level.

It was rewritten to following scenario:

- method which stores learner answers is aware whether answers have

changed, i.e. it knows if charts need to be updated

- it flushes latest data to DB and puts tool content ID to Sink

- Sink notifies all interested Fluxes (currently only charts updating

one, but in the future other ones like updating table with answer % too)

- FluxMap holds a map of tool content ID -> interested hot publisher

Flux

- the Flux checks if it is interested in the tool content ID from the

Sink

- if so, it fetches data from DB and emits it to all subscribers, i.e.

opened monitoring windows with charts displayed

- data is cached so it is immediately available on for the next

subscriber

- data is throttled so calls to DB are not made too often

- if all subscribers are gone, the hot publisher Flux is still active; a

timeout is added which removes it from FluxMap when there were not emits

for the given time

Options
    • -0
    • +105
    ./lams/util/FluxMap.java
  2. … 6 more files in changeset.
Friday 03 Dec 2021
12:06 am

Marcin Cieslak

LDEV-5260 Use WildFly task executor for Spring async request processing

Options
    • -0
    • +4
    ./lams/commonContext.xml
  2. … 1 more file in changeset.
Monday 29 Nov 2021
10:18 pm

Marcin Cieslak

LDEV-5259 Manually create parent application context

Previous attempt to reproduce BeanFactoryLocater was an overkill. A

simple singleton parent application context is sufficient.

Options
    • -29
    • +30
    ./lams/beanRefContext.xml
    • -74
    • +0
    ./lams/context/BeanFactoryLocator.java
    • -57
    • +0
    ./lams/context/BeanFactoryReference.java
    • -53
    • +0
    ./lams/context/BootstrapException.java
    • -168
    • +0
    ./lams/context/ContextSingletonBeanFactoryLocator.java
    • -562
    • +0
    ./lams/context/SingletonBeanFactoryLocator.java
    • -24
    • +11
    ./lams/web/filter/LamsContextLoaderListener.java
  8. … 39 more files in changeset.
9:10 pm

Marcin Cieslak

LDEV-5259 Use MVC initialisation via annotation

Manually triggering controller scanning by adding an annotation handler

bean does not register all useful support beans. If

<mvc:annotation-driven> is used in spring-servlet.xml, all support beans

are registered via WebMvcConfigurer.

<mvc:path-matching suffix-pattern="true" /> need to be added because we

use .do suffix for Spring actions and suffix was turned off for Spring

5.3

https://github.com/spring-projects/spring-framework/issues/24179

Options
    • -23
    • +1
    ./lams/commonContext.xml
    • -118
    • +0
    ./lams/context/AbstractUrlMethodNameResolver.java
    • -1297
    • +0
    ./lams/context/AnnotationMethodHandlerAdapter.java
    • -288
    • +0
    ./lams/context/DefaultAnnotationHandlerMapping.java
    • -44
    • +0
    ./lams/context/HandlerMethodInvocationException.java
    • -901
    • +0
    ./lams/context/HandlerMethodInvoker.java
    • -172
    • +0
    ./lams/context/HandlerMethodResolver.java
    • -129
    • +0
    ./lams/context/InternalPathMethodNameResolver.java
    • -47
    • +0
    ./lams/context/MethodNameResolver.java
    • -87
    • +0
    ./lams/context/NoSuchRequestHandlingMethodException.java
    • -166
    • +0
    ./lams/context/ServletAnnotationMappingUtils.java
    • -295
    • +0
    ./lams/context/SourceHttpMessageConverter.java
    • -51
    • +0
    ./lams/context/WebUtils.java
    • -40
    • +0
    ./lams/context/XmlAwareFormHttpMessageConverter.java
  15. … 38 more files in changeset.
Wednesday 24 Nov 2021
11:10 am

Marcin Cieslak

LDEV-5259 Remove unnecessary util class

Options
    • -22
    • +0
    ./lams/web/util/ApplicationContextUtil.java
Tuesday 23 Nov 2021
7:24 pm

Marcin Cieslak

LDEV-5125 Improve support for VSA questions import from Word file

VSA questions should have 2 options if they are going to be TBL

compatible. When importing from Word document only correct answers

option is required. The other one, incorrect answers option, now gets

added automatically. Also incorrect answers option does not get deleted

after editing via QB interface.

Options
    • -1
    • +1
    ./lams/qb/service/QbService.java
    • -1
    • +3
    ./lams/questions/QuestionWordParser.java
  3. … 2 more files in changeset.
12:24 pm

Marcin Cieslak

LDEV-5259 Manually start controller annotation detection

Options
    • -0
    • +33
    ./lams/commonContext.xml
  2. … 38 more files in changeset.
12:23 pm

Marcin Cieslak

LDEV-5259 Reintroduce BeanFactoryLocator mechanism back to LAMS

It was removed for Spring 5

Options
    • -29
    • +8
    ./lams/beanRefContext.xml
    • -0
    • +118
    ./lams/context/AbstractUrlMethodNameResolver.java
    • -0
    • +1297
    ./lams/context/AnnotationMethodHandlerAdapter.java
    • -0
    • +74
    ./lams/context/BeanFactoryLocator.java
    • -0
    • +57
    ./lams/context/BeanFactoryReference.java
    • -0
    • +53
    ./lams/context/BootstrapException.java
    • -0
    • +168
    ./lams/context/ContextSingletonBeanFactoryLocator.java
    • -0
    • +288
    ./lams/context/DefaultAnnotationHandlerMapping.java
    • -0
    • +44
    ./lams/context/HandlerMethodInvocationException.java
    • -0
    • +901
    ./lams/context/HandlerMethodInvoker.java
    • -0
    • +172
    ./lams/context/HandlerMethodResolver.java
    • -0
    • +129
    ./lams/context/InternalPathMethodNameResolver.java
    • -0
    • +47
    ./lams/context/MethodNameResolver.java
    • -0
    • +87
    ./lams/context/NoSuchRequestHandlingMethodException.java
    • -0
    • +166
    ./lams/context/ServletAnnotationMappingUtils.java
  16. … 44 more files in changeset.
7:21 am

Marcin Cieslak

LDEV-5258 Prevent exception if user timezone is not set

Options
    • -1
    • +2
    ./lams/usermanagement/dto/UserDTO.java
7:21 am

Marcin Cieslak

LDEV-5258 Prevent exception if user timezone is not set

Options
    • -1
    • +2
    ./lams/usermanagement/dto/UserDTO.java
Monday 22 Nov 2021
1:07 pm

Marcin Cieslak

LDEV-5257 Add LD and activity title validation also on backend

Options
    • -8
    • +13
    ./lams/util/ValidationUtil.java
  2. … 1 more file in changeset.
Saturday 20 Nov 2021
2:37 pm

Marcin Cieslak

LDEV-5258 Retrieve correct time zone offset

Options
    • -1
    • +9
    ./lams/usermanagement/dto/UserDTO.java
  2. … 1 more file in changeset.
Wednesday 10 Nov 2021
7:36 pm

Marcin Cieslak

LDEV-5257 Secure fileDownloadToken cookie

Options
    • -0
    • +10
    ./lams/util/WebUtil.java
  2. … 9 more files in changeset.
10:20 am

Marcin Cieslak

LDEV-5257 Escape formulas in LAMS-generated spreadsheets

Options
    • -1
    • +3
    ./lams/util/excel/ExcelUtil.java
Tuesday 02 Nov 2021
2:39 pm

Marcin Cieslak

LDEV-5256 Sanitise jqGrid sorting options before using them in queries

Options
    • -4
    • +5
    ./lams/dao/hibernate/LAMSBaseDAO.java
    • -2
    • +3
    ./lams/qb/dao/hibernate/QbDAO.java
  3. … 2 more files in changeset.
2:20 pm

Marcin Cieslak

LDEV-4411 Reintroduce eager fetching and caching of QB options and units

There are several places in LAMS code where we need to detach QB

question entity from session to do copying and comparison. While another

approach can be found, it requires a lot of effort to rewrite now.

Fetching options from a detached question causes lazy initialisation

exceptions. We had to make them eagerly fetched again.

Collection caching is introduced too to address numerous queries run

with every question fetch.

Options
    • -4
    • +11
    ./lams/qb/model/QbQuestion.java
Monday 01 Nov 2021
10:59 pm

Marcin Cieslak

LDEV-5256 Prevent SQL injection for results order

Options
    • -1
    • +9
    ./lams/dao/hibernate/LAMSBaseDAO.java
    • -0
    • +3
    ./lams/qb/dao/hibernate/QbDAO.java
  3. … 2 more files in changeset.
Wednesday 27 Oct 2021
12:54 pm

Marcin Cieslak

LDEV-4411 Do not fetch groups eagerly

Options
    • -2
    • +1
    ./lams/learningdesign/Grouping.java
Monday 25 Oct 2021
4:19 pm

Marcin Cieslak

LDEV-5253 Sysadmin Login As feature to be configurable

Options
    • -0
    • +17
    ./lams/dbupdates/patch20211025.sql
    • -0
    • +3
    ./lams/util/ConfigurationKeys.java
  3. … 3 more files in changeset.
Monday 18 Oct 2021
4:42 pm

Marcin Cieslak

LDEV-4411 Allow Hibernate to choose fetch type by itself

Options
    • -5
    • +3
    ./lams/lesson/Lesson.java
4:42 pm

Marcin Cieslak

LDEV-4411 Make relation from Lesson to LessonClass unidirectional

Hibernate can not lazy load properties connected with OneToOne

relationship.

Options
    • -13
    • +6
    ./lams/lesson/LessonClass.java
  2. … 1 more file in changeset.
4:32 pm

Marcin Cieslak

LDEV-4411 Make relation from Evaluation to ToolActivity unidirectional

Hibernate can not lazy load properties connected with OneToOne

relationship. It means that with every fetch of ToolActivity its

ActivityEvaluation was also fetched, whether is was needed or not. It

made up even 10% of all queries sent to DB during a lesson.

By having the relationship unidirectional and fetching

ActivityEvaluation via DAO we ensure that it is fetched only when it is

needed. The code is not as nice, though.

Options
    • -12
    • +10
    ./lams/learningdesign/ToolActivity.java
    • -2
    • +4
    ./lams/learningdesign/dao/IActivityDAO.java
    • -1
    • +7
    ./lams/learningdesign/dao/hibernate/ActivityDAO.java
    • -2
    • +4
    ./lams/learningdesign/dto/AuthoringActivityDTO.java
    • -3
    • +4
    ./lams/learningdesign/service/ExportToolContentService.java
    • -26
    • +32
    ./lams/tool/service/LamsCoreToolService.java
    • -4
    • +2
    ./lams/tool/service/LamsToolService.java
    • -1
    • +23
    ./lams/usermanagement/service/UserManagementService.java
  9. … 6 more files in changeset.
4:29 pm

Marcin Cieslak

LDEV-4411 Do not cache native SQL queries as it causes exceptions

Options
    • -1
    • +1
    ./lams/security/SecurityDAO.java
12:31 pm

Marcin Cieslak

LDEV-3656 Clean up invalidated session from internal tracking mapping

These session should have been removed from the mapping when

SessionListener is called. Sometimes the listener is not called due to

WildFly internal bugs. We are left with a long list of stale sessions.

We should periodically clean up the mapping. Making it happen on runtime

stats fetch is as place as any other, plus it happens periodically.

Options
    • -0
    • +14
    ./lams/web/session/SessionManager.java
  2. … 1 more file in changeset.