lams-github / lams_common / src / java

org

Clone Tools

Stats

Commits this week: 0
Total Committers: 32
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 01 Aug 2018
6:03 pm

Marcin Cieslak

LDEV-4440 Add missing no-arg constructors

They are required by LD import in authoring.

Options
    • -1
    • +5
    ./lamsfoundation/lams/learningdesign/dto/GroupDTO.java
    • -0
    • +4
    ./lamsfoundation/lams/learningdesign/dto/GroupingDTO.java
Monday 30 Jul 2018
10:40 pm

Marcin Cieslak

LDEV-4639 Use tour instead of tutorials video on first login

Tutorial videos have never been fully implemented. We get rid of them in

favour of tours.

Options
    • -0
    • +15
    ./lamsfoundation/lams/dbupdates/patch20180731.sql
    • -27
    • +1
    ./lamsfoundation/lams/usermanagement/User.java
    • -1
    • +1
    ./lamsfoundation/lams/usermanagement/dao/hibernate/UserDAO.java
    • -26
    • +3
    ./lamsfoundation/lams/usermanagement/dto/UserDTO.java
    • -6
    • +4
    ./lamsfoundation/lams/usermanagement/service/LdapService.java
    • -5
    • +0
    ./lamsfoundation/lams/web/util/AttributeNames.java
  7. … 14 more files in changeset.
3:22 pm

Marcin Cieslak

LDEV-4641 Allow STARTTLS and SSL when sending emails with SMTP

Options
    • -0
    • +16
    ./lamsfoundation/lams/dbupdates/patch20180730.sql
    • -0
    • +4
    ./lamsfoundation/lams/util/ConfigurationKeys.java
    • -1
    • +9
    ./lamsfoundation/lams/util/Emailer.java
  4. … 3 more files in changeset.
Friday 20 Jul 2018
5:54 pm

Marcin Cieslak

LDEV-4440 Tweak file validators to return correct messages

Options
    • -107
    • +2
    ./lamsfoundation/lams/util/FileValidatorSpringUtil.java
  2. … 3 more files in changeset.
5:28 am

Andrey Balan

LDEV-4627 Set country and locale for users created via integrations

New locale detecting algorithm:

1. Check whether we have exactly the same locale. If we do - select it.

2. Grab the first two letters of the provided locale (which we assume to

be the language code), and map it to one of our locales of the

respective language. If we have multiple ones - choose the first one

from the list indiscriminately.

3. If we don't have locale of such language - use the server default

one.

Options
    • -12
    • +9
    ./lamsfoundation/lams/integration/service/IIntegrationService.java
    • -43
    • +24
    ./lamsfoundation/lams/integration/service/IntegrationService.java
    • -0
    • +7
    ./lamsfoundation/lams/usermanagement/SupportedLocale.java
    • -8
    • +57
    ./lamsfoundation/lams/util/LanguageUtil.java
  5. … 3 more files in changeset.
Wednesday 18 Jul 2018
10:29 pm

Marcin Cieslak

Merge branch 'LDEV-4609'

Options
    • -0
    • +24
    ./lamsfoundation/lams/dbupdates/patch20180629.sql
  2. … 3 more files in changeset.
9:02 pm

Marcin Cieslak

Monthly merge from master to lams31

Conflicts:

lams_build/3rdParty.userlibraries

lams_build/build.xml

lams_build/conf/j2ee/jboss-deployment-structure.xml

lams_build/lib/lams/lams.jar

lams_build/liblist.txt

lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/actions/MonitoringAction.java

lams_tool_sbmt/src/java/org/lamsfoundation/lams/tool/sbmt/service/SubmitFilesService.java

Options
    • -0
    • +29
    ./lamsfoundation/lams/commonContext.xml
    • -13
    • +33
    ./lamsfoundation/lams/integration/service/IntegrationService.java
  3. … 25 more files in changeset.
2:33 pm

Marcin Cieslak

LDEV-4617 Implement full email verification on sign up

Options
    • -1
    • +2
    ./lamsfoundation/lams/signup/service/ISignupService.java
    • -1
    • +15
    ./lamsfoundation/lams/signup/service/SignupService.java
    • -9
    • +15
    ./lamsfoundation/lams/usermanagement/User.java
  4. … 7 more files in changeset.
Tuesday 17 Jul 2018
9:41 pm

Joanna Mielczarek <amielczarek.web@gmail.com>

LDEV-4440 Necessary changes for validation

Options
    • -40
    • +46
    ./lamsfoundation/lams/util/FileValidatorSpringUtil.java
9:36 pm

Marcin Cieslak

LDEV-4617 Add an option to enable email verification on sign up

Options
    • -0
    • +15
    ./lamsfoundation/lams/dbupdates/patch20180717.sql
    • -0
    • +9
    ./lamsfoundation/lams/signup/model/SignupOrganisation.java
  3. … 8 more files in changeset.
7:59 pm

Marcin Cieslak

LDEV-4609 Sort attempts in reverse order

It was implemented from the start, but our Java -> jqGrid XML conversion

method sorts the rows in ascending order by default.

Options
    • -2
    • +2
    ./lamsfoundation/lams/gradebook/dao/hibernate/GradebookDAO.java
  2. … 2 more files in changeset.
Monday 16 Jul 2018
11:23 pm

Joanna Mielczarek <amielczarek.web@gmail.com>

LDEV-4440 Necessary changes for migration to Spring - changes in method of validation

Options
    • -5
    • +4
    ./lamsfoundation/lams/util/FileValidatorSpringUtil.java
  2. … 8 more files in changeset.
Friday 13 Jul 2018
10:26 pm

Joanna Mielczarek <amielczarek.web@gmail.com>

LDEV-4440 Added new way of sending error messages

Options
    • -631
    • +632
    ./lamsfoundation/lams/commonContext.xml
  2. … 10 more files in changeset.
Wednesday 11 Jul 2018
12:56 am

Joanna Mielczarek <amielczarek.web@gmail.com>

LDEV-4440 Started migration of Noticeboard

Options
    • -0
    • +199
    ./lamsfoundation/lams/util/FileValidatorSpringUtil.java
  2. … 45 more files in changeset.
Tuesday 10 Jul 2018
1:13 am

Andrey Balan

LDEV-4631 Set server timezone for users created via integrations/spreadsheet and signup pages

Options
    • -4
    • +11
    ./lamsfoundation/lams/integration/service/IntegrationService.java
    • -1
    • +2
    ./lamsfoundation/lams/integrationContext.xml
    • -0
    • +1
    ./lamsfoundation/lams/usermanagement/ldapContext.xml
    • -13
    • +20
    ./lamsfoundation/lams/usermanagement/service/LdapService.java
  5. … 3 more files in changeset.
12:16 am

Andrey Balan

LDEV-4631 Prevent accidental storing of timezone as JVM one

Options
    • -2
    • +1
    ./lamsfoundation/lams/usermanagement/User.java
Monday 09 Jul 2018
1:18 am

Marcin Cieslak

LDEV-4627 Accept country in integrations servlet

If a received langIsoCode is just 2 letters, then countryIsoCode stays

the same and country will fall back to default. If langIsoCode is en_AU,

then it gets split to langIsoCode and countryIsoCode and the old value

of countryIsoCode is considered country.

Options
    • -3
    • +3
    ./lamsfoundation/lams/integration/service/IIntegrationService.java
    • -6
    • +12
    ./lamsfoundation/lams/integration/service/IntegrationService.java
  3. … 5 more files in changeset.
Sunday 08 Jul 2018
5:27 pm

Marcin Cieslak

LDEV-4625 Make server country configurable

Also use default country in integrations

Options
    • -0
    • +15
    ./lamsfoundation/lams/dbupdates/patch20180708.sql
    • -6
    • +3
    ./lamsfoundation/lams/integration/service/IntegrationService.java
    • -1
    • +1
    ./lamsfoundation/lams/signup/service/SignupService.java
    • -2
    • +2
    ./lamsfoundation/lams/util/LanguageUtil.java
  5. … 4 more files in changeset.
4:31 pm

Marcin Cieslak

LDEV-4625 Use default country configured on server

Options
    • -1
    • +1
    ./lamsfoundation/lams/signup/service/SignupService.java
    • -0
    • +5
    ./lamsfoundation/lams/util/ConfigurationKeys.java
    • -16
    • +23
    ./lamsfoundation/lams/util/LanguageUtil.java
  4. … 1 more file in changeset.
3:58 am

Andrey Balan

LDEV-4624 Signup page to use system language for country list

Options
    • -2
    • +8
    ./lamsfoundation/lams/util/LanguageUtil.java
    • -0
    • +22
    ./lamsfoundation/lams/util/MessageService.java
  3. … 3 more files in changeset.
Saturday 07 Jul 2018
11:51 pm

Marcin Cieslak

LDEV-4616 Remove locale from courses

Options
    • -0
    • +15
    ./lamsfoundation/lams/dbupdates/patch20180707.sql
    • -3
    • +2
    ./lamsfoundation/lams/integration/service/IntegrationService.java
    • -10
    • +0
    ./lamsfoundation/lams/usermanagement/Organisation.java
  4. … 10 more files in changeset.
Friday 06 Jul 2018
12:59 am

Joanna Mielczarek <amielczarek.web@gmail.com>

LDEV-4440 Almost finished learning and monitoring - needed corrections

Options
    • -2
    • +24
    ./lamsfoundation/lams/util/FileValidatorUtil.java
  2. … 16 more files in changeset.
Thursday 05 Jul 2018
8:02 pm

Andrey Balan

LDEV-4614 Sort country list by name rather than code

Options
    • -22
    • +48
    ./lamsfoundation/lams/util/LanguageUtil.java
  2. … 6 more files in changeset.
4:56 am

Andrey Balan

LDEV-4620 Submit Files tool to log release marks event

Options
    • -0
    • +14
    ./lamsfoundation/lams/dbupdates/patch20180704.sql
    • -1
    • +1
    ./lamsfoundation/lams/lesson/dao/hibernate/LessonDAO.java
    • -1
    • +2
    ./lamsfoundation/lams/logevent/LogEvent.java
    • -0
    • +11
    ./lamsfoundation/lams/logevent/service/ILogEventService.java
    • -29
    • +20
    ./lamsfoundation/lams/logevent/service/LogEventService.java
  6. … 2 more files in changeset.
4:55 am

Andrey Balan

LDEV-4620 Change return type of getLessonActivityIdsForToolContentId

Options
    • -1
    • +1
    ./lamsfoundation/lams/lesson/dao/ILessonDAO.java
    • -3
    • +10
    ./lamsfoundation/lams/lesson/dao/hibernate/LessonDAO.java
Wednesday 04 Jul 2018
10:23 pm

Joanna Mielczarek <amielczarek.web@gmail.com>

LDEV-4440 Started learning migration

Options
    • -2
    • +3
    ./lamsfoundation/lams/util/FileValidatorUtil.java
  2. … 10 more files in changeset.
Monday 02 Jul 2018
1:47 pm

Ernie Ghiglione <ernieg@gmail.com>

LDEV-4605 adding missing country/territory

I forgot to include BQ = Bonaire, Saint Eustatius and Saba. Glad no one noticed ;-)

Options
    • -13
    • +13
    ./lamsfoundation/lams/util/CommonConstants.java
  2. … 2 more files in changeset.
Saturday 30 Jun 2018
1:22 pm

Marcin Cieslak

LDEV-4609 Calculate dates and status for archived progress

Methods which calculate LearnerProgress dates and status use ugly

instanceof constructs. There seem to be no good alternatives, though.

LearnerProgressArchive can inherit from LearnerProgress and we use

table-per-subclass Hibernate strategy. But then queries for

LearnerProgress would fetch also LearnerProgressArchive entities unless

in each HQL query we put "WHERE lp.class = LearnerProgress". It is easy

to forget plus generic methods like findAll() will not work well anyway.

LearnerProgress and LearnerProgressArchive can extend a new

AbstractLearnerProgress and we use table-per-concrete-class Hibernate

strategy. Same with CompletedActivityProgress and

CompletedActivityProgressArchive. But then

AbstractLearnerProgress.completedActivities will not let use both of

them due to lack of polymorphism in collections. Neither

Map<Activty, AbstractCompletedActivityProgress>

nor

Map<Activity, ? extends AbstractCompletedActivityProgress>

will not work. And this collection is the main reason why to do

inheritance in the first place.

Looking how the above solutions add complexity and little gain, these

few methods with instanceof seem to be a fine trade off.

Options
    • -0
    • +6
    ./lamsfoundation/lams/dbupdates/patch20180628.sql
    • -1
    • +0
    ./lamsfoundation/lams/lesson/LearnerProgress.java
    • -1
    • +22
    ./lamsfoundation/lams/lesson/LearnerProgressArchive.java
    • -0
    • +4
    ./lamsfoundation/lams/lesson/dao/ILearnerProgressDAO.java
    • -2
    • +12
    ./lamsfoundation/lams/lesson/dao/hibernate/LearnerProgressDAO.java
  6. … 6 more files in changeset.
5:35 am

Andrey Balan

LDEV-4605 Codify country for users

Change the country field to ISO_3166-1 alpha-2 codes (two letters).

So in when editing the profile, a user should be able to set his/her

country based on the list of countries in the ISO list.

Country should be a compulsory when editing profile, editing user

as group manager and in signup pages.

For integrations, if the country is not passed, then we should default

to a default country server.

Options
    • -0
    • +16
    ./lamsfoundation/lams/dbupdates/patch20180628.sql
    • -1
    • +12
    ./lamsfoundation/lams/integration/service/IntegrationService.java
  3. … 11 more files in changeset.
5:31 am

Andrey Balan

LDEV-4605 Introduce CommonConstants.java

For starters it will contain user portrait dimensions and the list of

country codes.

Options
    • -3
    • +0
    ./lamsfoundation/lams/usermanagement/service/IUserManagementService.java
    • -3
    • +4
    ./lamsfoundation/lams/usermanagement/service/UserManagementService.java
    • -0
    • +24
    ./lamsfoundation/lams/util/CommonConstants.java
  4. … 1 more file in changeset.