Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDEV-3275: Add SsoConsumer in LAMS Central as requests (index.jsp, index.do) immediate after j_security_check are also being authenticated. They also are considered an authentication attempt, but they bypass shared session creation in SsoProducer and it causes errors. This was addressed by a simple check - no shared session in UniversalLoginModule, no authentication attempt.

  1. … 2 more files in changeset.
LDEV-3319: Synchronize patch execution with an external monitor. Modules in WildFly can be loaded in parallel. AutoPatch is not ready for this as it uses static methods with unsynchronized collections. Each AutoPatchService instance should be run sequentially.

    • -0
    • +30
    ./lamsfoundation/lams/dbupdates/AutoPatchServiceSynchronizer.java
    • -0
    • +26
    ./lamsfoundation/lams/dbupdates/WebAppJNDIMigrationLauncherSynchronizer.java
  1. … 31 more files in changeset.
LDEV-3275: Allow NULL attributes in shared sessions.

LDEV-3293: Clear log warnings : "HHH000038: Composite-id class does not override equals(): org.lamsfoundation.lams.learningdesign.GroupUser" and "HHH000039: Composite-id class does not override hashCode(): org.lamsfoundation.lams.learningdesign.GroupUser"

LDEV-3320: fix Infinispan configuration as 2nd level cache of Hibernate. The problem was, that for plain Hibernate usage, Infinispan has to be eagerly initialized (an already present when Hibernate starts). Also RegionFactory was changed to JNDIRegionFactory.

    • -3
    • +5
    ./lamsfoundation/lams/applicationContext.xml
  1. … 1 more file in changeset.
LDEV-3315: Add security service and use it in vital entry points.

    • -2
    • +22
    ./lamsfoundation/lams/commonContext.xml
    • -0
    • +39
    ./lamsfoundation/lams/security/ISecurityDAO.java
    • -0
    • +53
    ./lamsfoundation/lams/security/ISecurityService.java
    • -0
    • +103
    ./lamsfoundation/lams/security/SecurityDAO.java
    • -0
    • +37
    ./lamsfoundation/lams/security/SecurityException.java
    • -0
    • +131
    ./lamsfoundation/lams/security/SecurityService.java
  1. … 7 more files in changeset.
LDEV-3315: Clean up roles and paths to secured resources in all modules. Remove AUTHOR ADMIN role.

    • -0
    • +12
    ./lamsfoundation/lams/dbupdates/patch02040032.sql
  1. … 68 more files in changeset.
LDEV-3315: Remove AUTHOR ADMIN role. Allow AUTHOR role to preview lessons. Allow MONITOR role to edit activities and run Live Edit.

    • -0
    • +12
    ./lamsfoundation/lams/dbupdates/patch02040032.sql
  1. … 68 more files in changeset.
LDEV-2846: Remove obsolete filters.

  1. … 1 more file in changeset.
LDEV-2846: Remove obsolete filters.

  1. … 2 more files in changeset.
LDEV-3275: Introduce SSO using Undertow mechanisms.

Valves do not exist in Undertow. Another approach had to be used.

In each WAR there is a file in META-INF/service dir which adds a class in request processing chaing.

For Central it is SsoProducer which put the authenticated account into shared session.

All other modules use SsoConsumer which takes the account and puts it into its security context.

In standalone.xml caching of credentials was switched off as it would prevent UniversalLoginModule from putting UserDTO into shared session.

TODO: use a simple pass-all authentication mechanism for static files like images and JS files.

    • -0
    • +1
    ./lamsfoundation/lams/commonContext.xml
    • -0
    • +97
    ./lamsfoundation/lams/integration/security/SsoConsumer.java
    • -0
    • +80
    ./lamsfoundation/lams/integration/security/SsoProducer.java
  1. … 9 more files in changeset.
LDEV-2463 Added new method "learnerStrictAuth" available to LoginRequest. It works the same way as "learner" but requires hash to also contain lesson id parameter.

  1. … 2 more files in changeset.
LDEV-3309 Add isUpdateUserDetails parameter for LoginRequest so user details get updated

  1. … 4 more files in changeset.
LDEV-3309 Add isUpdateUserDetails parameter for LoginRequest so user details get updated

  1. … 4 more files in changeset.
LDEV-3292: Add an index on Activity table.

    • -0
    • +10
    ./lamsfoundation/lams/dbupdates/patch02040031.sql
LDEV-3292: Add an index on Activity table.

    • -0
    • +10
    ./lamsfoundation/lams/dbupdates/patch02040031.sql
LDEV-3292: When looking for an unique LD title to create a lesson, search for LDs with given prefix instead taking all from given workspace folder.

  1. … 1 more file in changeset.
LDEV-3292: When looking for an unique LD title to create a lesson, search for LDs with given prefix instead taking all from given workspace folder.

  1. … 2 more files in changeset.
LDEV-3293: Further remove LAMS custom cache management.

    • -3
    • +1
    ./lamsfoundation/lams/applicationContext.xml
    • -6
    • +0
    ./lamsfoundation/lams/commonContext.xml
LDEV-3292: Improve Add Lesson dialog response time: Fetch all users and filter them afterwards instead of fetchin one by one. Make some collections lazy or extra-lazy.

  1. … 7 more files in changeset.
LDEV-3292: Improve Add Lesson dialog response time: Fetch all users and filter them afterwards instead of fetchin one by one. Make some collections lazy or extra-lazy.

  1. … 7 more files in changeset.
LDEV-3293: Use Hibernate 4 cache. Remove unused cache management from lams_admin.

    • -2
    • +7
    ./lamsfoundation/lams/applicationContext.xml
    • -324
    • +0
    ./lamsfoundation/lams/cache/CacheManager.java
    • -112
    • +0
    ./lamsfoundation/lams/cache/ICacheManager.java
  1. … 906 more files in changeset.
LDEV-3275: Remove Application Context files which seem obsolete. They have been probably used for testing.

    • -55
    • +0
    ./lamsfoundation/lams/localApplicationContext.xml
    • -468
    • +0
    ./lamsfoundation/lams/localCommonContext.xml
LDEV-3275: Change call parameters as Java 8 warns about misuse of varargs.

LDEV-3293: Use Spring support for Hibernate 4 instead of 3 (session factory and filters). Use new path for Hibernate DTDs. Make XDoclet generate hbm.xml files with the correct path by providing it a new template.

    • -1
    • +1
    ./lamsfoundation/lams/applicationContext.xml
    • -1
    • +1
    ./lamsfoundation/lams/commonContext.xml
    • -1
    • +1
    ./lamsfoundation/lams/localApplicationContext.xml
    • -2
    • +2
    ./lamsfoundation/lams/localCommonContext.xml
    • -1
    • +1
    ./lamsfoundation/lams/util/CustomizedOpenSessionInViewFilter.java
  1. … 107 more files in changeset.
LDEV-3293: Rewrite Application Context configuration files for Spring 4.

    • -6
    • +4
    ./lamsfoundation/lams/applicationContext.xml
    • -2
    • +5
    ./lamsfoundation/lams/beanRefContext.xml
    • -46
    • +45
    ./lamsfoundation/lams/commonContext.xml
    • -2
    • +6
    ./lamsfoundation/lams/integrationContext.xml
    • -8
    • +9
    ./lamsfoundation/lams/localApplicationContext.xml
    • -37
    • +36
    ./lamsfoundation/lams/localCommonContext.xml
    • -2
    • +4
    ./lamsfoundation/lams/messageContext.xml
    • -9
    • +8
    ./lamsfoundation/lams/toolApplicationContext.xml
  1. … 69 more files in changeset.
LDEV-3293: Save or update each collection item manually as new Hibernate does not have a method for processing the whole collection anymore.

  1. … 1 more file in changeset.
LDEV-3293: Rewrite the class to use new Hibernate's tools. It can not be confirmed at the moment if it does the same.

    • -9
    • +14
    ./lamsfoundation/lams/util/CustomizedOpenSessionInViewFilter.java
LDEV-3293: Use the new Spring's support for Hibernate 4 instead of Hibernate 3. Switch from using HibernateDaoSupport.getSession() to its getSessionFactory().getSession(). The latter is sure to close the session automatically while a session returned by the first method should be closed manually. Theoritecally we do it in OpenSessionInViewFilter, but it may not be always the case, leading to open Hibernate session being left behind.

  1. … 73 more files in changeset.
LDEV-3293: Cast DAO methods' results to their return type. Java 8 is more restrictive about generics. Hibernate find() methods returns List<?> and it can not be quietly cast to List<SomeClass>. Each occurence was explicitly casted and warnings about the type being unchecked were supressed.

  1. … 46 more files in changeset.