lams-github / lams_common / src / java

org

Clone Tools

Stats

Commits this week: 0
Total Committers: 32
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 14 Aug 2017
11:37 pm

Andrey Balan

LDEV-4401 Remove deprecated parameters for integrations

We no longer use External server URL and Timeout URL settings. So they

can be removed.

Options
    • -0
    • +15
    ./lamsfoundation/lams/dbupdates/patch2040085.sql
    • -22
    • +0
    ./lamsfoundation/lams/integration/ExtServer.java
  3. … 6 more files in changeset.
5:33 pm

Marcin Cieslak

LDEV-4400 Disable session ID change on demand

WildFly 10 changes session ID after log in by default. It prevent

session fixation attack.

TestHarness can not process it correctly. When calling /j_security_check

it gets session ID in SET-COOKIE header different to what Undertow

generates. Browsers seem to have no problem with it, but TestHarness

fails to set correct session ID. That is why session ID change needs to

be disabled when running TH.

Options
    • -16
    • +29
    ./lamsfoundation/lams/integration/security/SsoHandler.java
Sunday 13 Aug 2017
10:43 pm

Marcin Cieslak

NTU-12, LDEV-1261 Fix a lazy initialisation exception

Objects should not be passed to services' methods if they were not

fetched in other service methods. For example, passing an object from

Action to a service can result in a lazy initialisation exception. It it

better to use primitives, IDs.

Options
    • -8
    • +11
    ./lamsfoundation/lams/usermanagement/service/IUserManagementService.java
    • -2
    • +14
    ./lamsfoundation/lams/usermanagement/service/UserManagementService.java
Friday 11 Aug 2017
1:08 pm

Marcin Cieslak

NTU-12 Add typing to a collection so lambdas can cope with it

Options
    • -5
    • +5
    ./lamsfoundation/lams/usermanagement/UserOrganisation.java
Thursday 10 Aug 2017
3:38 am

Marcin Cieslak

LDEV-4402, LDEV-3315 Remove custom session fixation attack fix

Manual change of session ID was needed in WF8. WF10 changes session

automatically.

Options
    • -6
    • +0
    ./lamsfoundation/lams/integration/security/SsoHandler.java
12:28 am

Marcin Cieslak

LDEV-4402 Substitute Gson and Apache JSON with Jackson

Jackson is a top JSON library shipped with WF10.

Apache JSON resides in an ancient library which we do not need for

anything else.

We use GSon only for serializing Java objects to JSON, which Jackson can

do too.

Options
    • -63
    • +65
    ./lamsfoundation/lams/integration/service/IntegrationService.java
    • -38
    • +55
    ./lamsfoundation/lams/rating/service/IRatingService.java
    • -153
    • +170
    ./lamsfoundation/lams/rating/service/RatingService.java
    • -33
    • +87
    ./lamsfoundation/lams/util/JsonUtil.java
    • -10
    • +7
    ./lamsfoundation/lams/util/WebUtil.java
  6. … 131 more files in changeset.
Monday 07 Aug 2017
6:23 pm

Marcin Cieslak

LDEV-4402 Remove obsolete XPP3 and XMLPull libraries

The libraries have been used by earlier versions of XStream. They are

not needed for latest XStream and Java 6+.

Deserialized classes must implement a no-arg constructor.

Options
    • -0
    • +3
    ./lamsfoundation/lams/learningdesign/dto/AuthoringActivityDTO.java
    • -4
    • +5
    ./lamsfoundation/lams/learningdesign/service/ExportToolContentService.java
    • -3
    • +4
    ./lamsfoundation/lams/util/FileUtil.java
  4. … 10 more files in changeset.
3:03 pm

Marcin Cieslak

LDEV-4402 Get rid of LAMS customised session filter

This filter was implemented in 2005 and seems more like a workaround

than a feature we need. Especially that many of LAMS tools already use

the standard filter and they work OK.

Options
    • -93
    • +0
    ./lamsfoundation/lams/util/CustomizedOpenSessionInViewFilter.java
  2. … 23 more files in changeset.
2:53 pm

Marcin Cieslak

LDEV-4402 Use Spring support for Hibernate v5 instead of v4

WF10 is shipped with Hibernate 5, so Spring support version should

match.

Options
    • -1
    • +1
    ./lamsfoundation/lams/commonContext.xml
    • -3
    • +3
    ./lamsfoundation/lams/util/CustomizedOpenSessionInViewFilter.java
    • -1
    • +1
    ./lamsfoundation/lams/util/hibernate/HibernateSessionManager.java
    • -1
    • +1
    ./lamsfoundation/lams/util/hibernate/TransactionAwareSessionContext.java
  5. … 16 more files in changeset.
Friday 04 Aug 2017
9:56 pm

Andrey Balan

LDEV-4381 Removed requestSrc parameter

This parameter was responsible for passing integration server name to

LAMS which was used on closing authoring and refreshing integration

server page. It stopped working when authoring became Flash-less (as

there is not more "Close" button). And now we decided to finally remove

all its leftovers. This change also involves removal of

"isPostMessageToParent" parameter.

Options
    • -24
    • +5
    ./lamsfoundation/lams/integration/util/LoginRequestDispatcher.java
  2. … 1 more file in changeset.
Thursday 03 Aug 2017
5:39 am

Andrey Balan

LDEV-4398 Introduce imgscalr library for image resizing

Options
    • -0
    • +565
    ./lamsfoundation/lams/util/imgscalr/AsyncScalr.java
    • -0
    • +98
    ./lamsfoundation/lams/util/imgscalr/ResizePictureUtil.java
    • -0
    • +2286
    ./lamsfoundation/lams/util/imgscalr/Scalr.java
  4. … 1 more file in changeset.
Monday 31 Jul 2017
11:55 am

Fiona Malikoff <Fiona.Malikoff@gmail.com>

LDEV-4395 Portrait tag and javascript to display portraits

A new tag and javascript file shows the user portraits in one of 4 sizes

and either square or round. If no portrait exists a generic coloured

user icon is used. Portraits shown in Forum and Noticeboard Comments.

Options
    • -0
    • +10
    ./lamsfoundation/lams/comments/dto/CommentDTO.java
  2. … 53 more files in changeset.
Tuesday 25 Jul 2017
9:50 am

Fiona Malikoff <Fiona.Malikoff@gmail.com>

LDEV-4390 Purple Theme

Options
    • -0
    • +15
    ./lamsfoundation/lams/dbupdates/patch20170720.sql
  2. … 9 more files in changeset.
1:05 am

Marcin Cieslak

LDEV-4366 Introduce rubrics to Kumalive

Options
    • -4
    • +16
    ./lamsfoundation/lams/dbupdates/patch20170710.sql
  2. … 29 more files in changeset.
Friday 21 Jul 2017
9:40 am

tkkaung@ntu.edu.sg <tkkaung@ntu.edu.sg>

LDEV-4377 - Show timezones to select order alphabetically

Options
    • -0
    • +32
    ./lamsfoundation/lams/timezone/util/TimezoneIDComparator.java
  2. … 1 more file in changeset.
Wednesday 19 Jul 2017
6:30 pm

Fiona Malikoff <Fiona.Malikoff@gmail.com>

LDEV-4367 Skins can be created

The SASS files are now configured to allow a new variable file to be

set up with different colours and for users to be able to switch

between skins.

Options
    • -11
    • +10
    ./lamsfoundation/lams/util/CSSThemeUtil.java
  2. … 156 more files in changeset.
Monday 10 Jul 2017
6:17 pm

Marcin Cieslak

LDEV-4366 Allow multiple score per learner per Kumalive

Fix showing user login as a div title for teachers.

Options
    • -36
    • +0
    ./lamsfoundation/lams/dbupdates/patch20170623.sql
    • -0
    • +37
    ./lamsfoundation/lams/dbupdates/patch20170710.sql
  3. … 7 more files in changeset.
Wednesday 28 Jun 2017
12:36 pm

Marcin Cieslak

LDEV-4184, LDEV-4368 Allow longer ID format for password recovery request key

Options
    • -0
    • +15
    ./lamsfoundation/lams/dbupdates/patch20170628.sql
  2. … 1 more file in changeset.
11:58 am

Marcin Cieslak

LDEV-4366 Prototype Kumalive front and back ends

Options
    • -7
    • +5
    ./lamsfoundation/lams/usermanagement/User.java
    • -1
    • +1
    ./lamsfoundation/lams/usermanagement/dao/hibernate/UserDAO.java
    • -2
    • +14
    ./lamsfoundation/lams/usermanagement/dto/UserDTO.java
  4. … 16 more files in changeset.
Sunday 25 Jun 2017
12:03 am

Marcin Cieslak

LDEV-4366 Add database and Hibernate layer for Kumalive.

Options
    • -0
    • +36
    ./lamsfoundation/lams/dbupdates/patch20170623.sql
  2. … 4 more files in changeset.
Sunday 11 Jun 2017
9:28 pm

Marcin Cieslak

LDEV-4274: Use service proxy bean instead of concrete implementation, so methods called from child threads are transactional.

Options
    • -55
    • +69
    ./lamsfoundation/lams/events/EventNotificationService.java
    • -2
    • +7
    ./lamsfoundation/lams/events/IEventNotificationService.java
Wednesday 07 Jun 2017
9:00 am

FionaMalikoff <Fiona.Malikoff@gmail.com>

LDEV-4355: Have improved the checks for invalid data and the warning messages that are given when invalid data is found.

Options
    • -13
    • +25
    ./lamsfoundation/lams/rating/service/RatingService.java
Monday 05 Jun 2017
6:48 pm

Andrey Balan

LDEV-4354 Prevent exception on starting a lesson by Moodle using LAMS as LTI tool provider

Options
    • -1
    • +2
    ./lamsfoundation/lams/integration/util/LoginRequestDispatcher.java
Thursday 01 Jun 2017
3:31 pm

FionaMalikoff <Fiona.Malikoff@gmail.com>

LDEV-4274: Initial implementation of a Learner Progress Report email, to be sent to Monitors on a set of dates. Dates are entered via a new dialog box in monitoring. The code works as long as the mailserver is running when the reports are emailed but if it fails then the emails do not resend properly.

Options
    • -2
    • +35
    ./lamsfoundation/lams/events/Event.java
    • -11
    • +26
    ./lamsfoundation/lams/events/EventNotificationService.java
    • -0
    • +13
    ./lamsfoundation/lams/events/IEventNotificationService.java
    • -0
    • +8
    ./lamsfoundation/lams/util/hibernate/HibernateSessionManager.java
  5. … 14 more files in changeset.
Wednesday 24 May 2017
7:35 pm

FionaMalikoff <Fiona.Malikoff@gmail.com>

LDEV-2999: Moving the database update into the tool as the Peer Review tool is not included in the standard build.

Options
    • -28
    • +1
    ./lamsfoundation/lams/dbupdates/patch20170512.sql
  2. … 1 more file in changeset.
Tuesday 23 May 2017
11:57 am

SanjanaPabsetti <Sanjana.pabsetti@gmail.com>

LDEV-4347:Improve date/time for spreadsheet exports

Options
    • -4
    • +2
    ./lamsfoundation/lams/util/ExcelUtil.java
    • -2
    • +3
    ./lamsfoundation/lams/util/FileUtil.java
  3. … 1 more file in changeset.
Friday 19 May 2017
11:05 am

FionaMalikoff <Fiona.Malikoff@gmail.com>

LDEV-4274: Adding support for a file attachment to the email sender.

Options
    • -0
    • +3
    ./lamsfoundation/lams/events/AbstractDeliveryMethod.java
    • -3
    • +7
    ./lamsfoundation/lams/events/DeliveryMethodMail.java
    • -0
    • +6
    ./lamsfoundation/lams/events/DeliveryMethodNotification.java
    • -4
    • +62
    ./lamsfoundation/lams/util/Emailer.java
  5. … 1 more file in changeset.
Wednesday 17 May 2017
9:17 am

FionaMalikoff <Fiona.Malikoff@gmail.com>

LDEV-2999 Include a rating option for reviewed resources (authored only). To make the grouped rating of authored resources work properly, session id was added to the rating and rating comments tables and all code using the shared jRating script and shared ratings updated to store the session code. DB script updates existing rating, rating comment records.

Options
    • -0
    • +103
    ./lamsfoundation/lams/dbupdates/patch20170512.sql
    • -0
    • +67
    ./lamsfoundation/lams/rating/RatingException.java
    • -1
    • +1
    ./lamsfoundation/lams/rating/ToolRatingManager.java
    • -3
    • +3
    ./lamsfoundation/lams/rating/dao/IRatingCommentDAO.java
    • -9
    • +16
    ./lamsfoundation/lams/rating/dao/IRatingDAO.java
    • -9
    • +9
    ./lamsfoundation/lams/rating/dao/hibernate/RatingCommentDAO.java
    • -27
    • +37
    ./lamsfoundation/lams/rating/dao/hibernate/RatingDAO.java
    • -0
    • +18
    ./lamsfoundation/lams/rating/model/Rating.java
    • -0
    • +20
    ./lamsfoundation/lams/rating/model/RatingComment.java
    • -9
    • +27
    ./lamsfoundation/lams/rating/service/IRatingService.java
    • -22
    • +95
    ./lamsfoundation/lams/rating/service/RatingService.java
  12. … 4 more files in changeset.
Monday 08 May 2017
9:35 am

FionaMalikoff <Fiona.Malikoff@gmail.com>

LDEV-4334: Moving Lesson Gradebook into Monitoring window so that it is always available. EnableGradebookForMonitors field / db column has been completely removed.

Options
    • -0
    • +15
    ./lamsfoundation/lams/dbupdates/patch20170508.sql
    • -19
    • +0
    ./lamsfoundation/lams/usermanagement/Organisation.java
  3. … 1 more file in changeset.
Thursday 04 May 2017
12:10 pm

FionaMalikoff <Fiona.Malikoff@gmail.com>

LDEV-4334: Moving Lesson Gradebook into Monitoring window so that it is always available and adding a Marks chart. This requires a new lookup to get the raw marks for the chart and the enableGradebookForMonitors field has been deprecated as it is now always on.

Options
    • -0
    • +2
    ./lamsfoundation/lams/gradebook/dao/IGradebookDAO.java
    • -0
    • +9
    ./lamsfoundation/lams/gradebook/dao/hibernate/GradebookDAO.java
    • -2
    • +9
    ./lamsfoundation/lams/usermanagement/Organisation.java
  4. … 1 more file in changeset.