lams-github

lams_common

Clone Tools

Stats

Commits this week: 0
Total Committers: 37
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 14 Jul 2022
3:50 pm

Marcin Cieslak

LDEV-5083 Prevent WF from freezing on shutdown because of unclosed Flux

Open Fluxes prevent WF from shutting down as they are threads not

managed by the server lifecycle.

Now we force complete Sinks on Spring context destroy. It closes

underlying Flux threads.

The problem is that it occurs when most Spring beans are already

destroyed. Fluxes on close want to emit a signal to front end

subscribers. Spring tries to reinitialise controllers which should send

those signals. It fails as context basically does not exist anymore.

All in all we get some harmless errors on server shutdown.

The way to avoid would be to have more control over Spring bean destroy

order which does not seem easily achievable.

Options
    • -1
    • +4
    ./src/java/org/lamsfoundation/lams/flux/FluxMap.java
    • -1
    • +17
    ./src/java/org/lamsfoundation/lams/flux/FluxRegistry.java
    • -0
    • +5
    ./src/java/org/lamsfoundation/lams/flux/SharedSink.java
    • -0
    • +13
    ./src/java/org/lamsfoundation/lams/web/filter/LamsContextLoaderListener.java
Friday 08 Jul 2022
11:55 am

Marcin Cieslak

LDEV-5320 Give more details about course roles being added and removed

This approach uses logs in controllers rather than in services.

Options
    • -10
    • +7
    ./src/java/org/lamsfoundation/lams/integration/security/SsoHandler.java
    • -0
    • +4
    ./src/java/org/lamsfoundation/lams/usermanagement/Role.java
    • -36
    • +59
    ./src/java/org/lamsfoundation/lams/web/filter/AuditLogFilter.java
  4. … 3 more files in changeset.
10:22 am

Marcin Cieslak

Revert "LDEV-5320 Give more details about course roles being added and removed"

This reverts commit bd5afdb894181e618bc5871783f7c621bbb1453f.

Options
    • -24
    • +1
    ./src/java/org/lamsfoundation/lams/usermanagement/service/UserManagementService.java
  2. … 1 more file in changeset.
Thursday 07 Jul 2022
2:24 pm

Marcin Cieslak

LDEV-4497 Transform legacy content folder IDs into multi-part version

Options
    • -16
    • +3
    ./src/java/org/lamsfoundation/lams/learningdesign/service/ExportToolContentService.java
    • -10
    • +41
    ./src/java/org/lamsfoundation/lams/util/FileUtil.java
11:38 am

Marcin Cieslak

LDEV-5320 Give more details about course roles being added and removed

Options
    • -1
    • +24
    ./src/java/org/lamsfoundation/lams/usermanagement/service/UserManagementService.java
  2. … 1 more file in changeset.
Tuesday 05 Jul 2022
11:33 am

Marcin Cieslak

LDEV-5320 Audit user being locked out

Options
    • -8
    • +13
    ./src/java/org/lamsfoundation/lams/integration/security/SsoHandler.java
11:09 am

Marcin Cieslak

LDEV-5320 Rename security filter to audit filter

Options
    • -0
    • +80
    ./src/java/org/lamsfoundation/lams/web/filter/AuditLogFilter.java
    • -80
    • +0
    ./src/java/org/lamsfoundation/lams/web/filter/SecurityLogFilter.java
  3. … 3 more files in changeset.
Monday 04 Jul 2022
11:54 am

Marcin Cieslak

LDEV-5320 Add security logger

It logs calls to Spring controllers in Admin module.

Options
    • -0
    • +80
    ./src/java/org/lamsfoundation/lams/web/filter/SecurityLogFilter.java
  2. … 3 more files in changeset.
Saturday 02 Jul 2022
7:16 pm

Marcin Cieslak

LDEV-5319 Replace invalid XML characters instead of throwing error

Options
    • -0
    • +2
    ./.classpath
    • -0
    • +15
    ./src/java/org/lamsfoundation/lams/util/InvalidCharReplacingWstxOutputFatory.java
  3. … 3 more files in changeset.
Wednesday 15 Jun 2022
8:06 pm

Marcin Cieslak

LDEV-5083 Trigger Flux update on each activity entrance

Till now the update was triggered on activity completion. It is a better

approach, but it only worked on finishing tool activities. Gates and,

for example, Leader Selection activity were skipped and would not

trigger learner progress update.

Now update gets triggered on learner joining a lesson and traversing

through each activity, which is good enough. Emitted items get throttled

anyway.

Options
    • -1
    • +1
    ./src/java/org/lamsfoundation/lams/util/CommonConstants.java
  2. … 4 more files in changeset.
8:03 pm

Marcin Cieslak

LDEV-5083 Supress warnings in FluxRegistry

This class has to be flexible enough to accommodate all kinds of

messages. Heavy static typing is not usable here. It is better to

suppress warnings and stay open.

Options
    • -1
    • +9
    ./src/java/org/lamsfoundation/lams/flux/FluxRegistry.java
Monday 13 Jun 2022
3:06 pm

Marcin Cieslak

LDEV-5083 Fix max activity score calculation

Options
    • -3
    • +6
    ./src/java/org/lamsfoundation/lams/tool/service/LamsCoreToolService.java
Tuesday 31 May 2022
12:16 pm

Marcin Cieslak

LDEV-5301 Set fixed column width correctly in number of characters

Options
    • -0
    • +1
    ./src/java/org/lamsfoundation/lams/util/excel/ExcelUtil.java
  2. … 1 more file in changeset.
Saturday 28 May 2022
6:21 pm

Marcin Cieslak

LDEV-5316 Change content folder ID to default one

Only for questions which have images referring the default content

folder and which do not have images which refer a new content folder.

Options
    • -0
    • +20
    ./src/java/org/lamsfoundation/lams/dbupdates/patch20220528.sql
Friday 27 May 2022
8:47 am

Marcin Cieslak

LDEV-5273 Fix allocation of answers being prefixed with "null"

Options
    • -1
    • +5
    ./src/java/org/lamsfoundation/lams/qb/service/QbService.java
Wednesday 25 May 2022
3:28 pm

Marcin Cieslak

LDEV-213 Do not hardcode IGPS URL

Options
    • -0
    • +1
    ./src/java/org/lamsfoundation/lams/util/ConfigurationKeys.java
Friday 13 May 2022
7:31 am

Marcin Cieslak

LDEV-4949 Fix stripped of non-break whitespace

Options
    • -13
    • +29
    ./src/java/org/lamsfoundation/lams/questions/QuestionWordParser.java
Wednesday 11 May 2022
7:59 pm

Marcin Cieslak

LDEV-5309 Fix removing units from numerical question

delete-orphan setting in QbQuestion units causes problems when importing

QbQuestion from XML. JPA does not recognise the collection parent and

fails on save. Another approach to removing units had to be found.

Options
    • -1
    • +1
    ./src/java/org/lamsfoundation/lams/qb/model/QbQuestion.java
    • -3
    • +2
    ./src/java/org/lamsfoundation/lams/qb/model/QbQuestionUnit.java
    • -4
    • +19
    ./src/java/org/lamsfoundation/lams/qb/service/QbService.java
Tuesday 10 May 2022
5:45 pm

Marcin Cieslak

LDEV-5081 Merge changes made for monitor in LDEV-5083

Options
    • -1847
    • +1410
    ./db/sql/create_lams_11_tables.sql
    • -5
    • +3
    ./db/sql/insert_lams_config_data.sql
    • -4
    • +4
    ./db/sql/insert_types_data.sql
    • -0
    • +22
    ./src/java/org/lamsfoundation/lams/dbupdates/patch20200129.sql
    • -15
    • +7
    ./src/java/org/lamsfoundation/lams/learningdesign/service/ExportToolContentService.java
    • -36
    • +150
    ./src/java/org/lamsfoundation/lams/learningdesign/service/LearningDesignService.java
    • -27
    • +98
    ./src/java/org/lamsfoundation/lams/tool/service/LamsToolService.java
    • -1
    • +11
    ./src/java/org/lamsfoundation/lams/util/CommonConstants.java
  9. … 29 more files in changeset.
Friday 06 May 2022
1:48 pm

Marcin Cieslak

Merge branch 'LDEV-5307' into v4.6

Options
    • -0
    • +11
    ./src/java/org/lamsfoundation/lams/qb/model/QbQuestion.java
    • -7
    • +11
    ./src/java/org/lamsfoundation/lams/qb/service/QbService.java
  3. … 3 more files in changeset.
Wednesday 04 May 2022
4:46 pm

Marcin Cieslak

LDEV-5311 Send emails with password change link on user import

Options
    • -1
    • +26
    ./src/java/org/lamsfoundation/lams/integration/security/RandomPasswordGenerator.java
  2. … 9 more files in changeset.
2:48 pm

Marcin Cieslak

LDEV-5311 Generate passwords for imported users with no passwd provided

Options
    • -0
    • +11
    ./src/java/org/lamsfoundation/lams/integration/security/RandomPasswordGenerator.java
  2. … 4 more files in changeset.
Tuesday 03 May 2022
1:34 pm

Marcin Cieslak

LDEV-5277 Add LTI Advantage own user ID

In some cases, for consistency we need the same user ID as Moodle uses

and which was sent to LAMS for old integrations. But LTI Advantage

integration uses another user ID. We need to keep both to keep existing

LAMS data and to talk to platform.

Options
    • -0
    • +15
    ./src/java/org/lamsfoundation/lams/dbupdates/patch20220503.sql
    • -0
    • +11
    ./src/java/org/lamsfoundation/lams/integration/ExtUserUseridMap.java
    • -29
    • +30
    ./src/java/org/lamsfoundation/lams/integration/service/IntegrationService.java
Thursday 28 Apr 2022
4:24 am

Ernie Ghiglione

LDEV-4769 Updating Chinese Traditional

Options
    • -59
    • +317
    ./conf/language/lams/ApplicationResources_zh_CN.properties
  2. … 28 more files in changeset.
Monday 25 Apr 2022
6:13 pm

Marcin Cieslak

LDEV-5083 Update learner progress timeline using Flux

Options
    • -11
    • +14
    ./src/java/org/lamsfoundation/lams/flux/FluxMap.java
    • -4
    • +8
    ./src/java/org/lamsfoundation/lams/flux/FluxRegistry.java
    • -4
    • +29
    ./src/java/org/lamsfoundation/lams/lesson/util/LearnerActivityCompleteFluxItem.java
  4. … 7 more files in changeset.
1:39 pm

Marcin Cieslak

LDEV-5083 Update LD canvas and chart on learner joining a lesson

Options
    • -0
    • +28
    ./src/java/org/lamsfoundation/lams/lesson/util/LearnerActivityCompleteFluxItem.java
    • -0
    • +22
    ./src/java/org/lamsfoundation/lams/lesson/util/LearnerLessonJoinFluxItem.java
    • -28
    • +0
    ./src/java/org/lamsfoundation/lams/lesson/util/LearnerProgressFluxItem.java
    • -0
    • +2
    ./src/java/org/lamsfoundation/lams/util/CommonConstants.java
  5. … 3 more files in changeset.
12:01 pm

Marcin Cieslak

LDEV-5083 Add Sink binding mechanism

Options
    • -5
    • +36
    ./src/java/org/lamsfoundation/lams/flux/FluxRegistry.java
    • -0
    • +28
    ./src/java/org/lamsfoundation/lams/lesson/util/LearnerProgressFluxItem.java
    • -2
    • +6
    ./src/java/org/lamsfoundation/lams/util/CommonConstants.java
  4. … 2 more files in changeset.
Friday 22 Apr 2022
5:50 pm

Marcin Cieslak

LDEV-5083 Initial implementation on monitoring update based on Flux

Options
    • -9
    • +12
    ./src/java/org/lamsfoundation/lams/flux/FluxRegistry.java
    • -1
    • +4
    ./src/java/org/lamsfoundation/lams/util/CommonConstants.java
  3. … 9 more files in changeset.
3:36 pm

Marcin Cieslak

LDEV-5083 Add activity mark and time taken to learner timeline

Options
    • -3
    • +19
    ./src/java/org/lamsfoundation/lams/learningdesign/dto/ActivityURL.java
    • -0
    • +41
    ./src/java/org/lamsfoundation/lams/lesson/util/LessonUtil.java
    • -0
    • +2
    ./src/java/org/lamsfoundation/lams/tool/service/ILamsCoreToolService.java
    • -0
    • +6
    ./src/java/org/lamsfoundation/lams/tool/service/LamsCoreToolService.java
    • -5
    • +62
    ./src/java/org/lamsfoundation/lams/util/DateUtil.java
  6. … 14 more files in changeset.
Sunday 17 Apr 2022
6:00 pm

Marcin Cieslak

LDEV-5083 Add learner info to learner tab in monitoring

Options
    • -0
    • +1
    ./src/java/org/lamsfoundation/lams/util/WebUtil.java
  2. … 3 more files in changeset.