lams-github

lams_common

Clone Tools

Stats

Commits this week: 0
Total Committers: 37
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 26 Jul 2023
8:12 pm

Ernie Ghiglione

LDEV-5345 Adding and updating latest translations

Options
    • -0
    • +262
    ./conf/language/lams/ApplicationResources_de_DE.properties
    • -4
    • +4
    ./conf/language/lams/ApplicationResources_es_ES.properties
    • -0
    • +9
    ./conf/language/lams/ApplicationResources_fr_FR.properties
    • -64
    • +317
    ./conf/language/lams/ApplicationResources_it_IT.properties
  5. … 196 more files in changeset.
Monday 24 Jul 2023
2:30 pm

Marcin Cieslak

LDEV-5391 Move cluster building logic to core for other tools to use

Options
    • -20
    • +19
    ./src/java/org/lamsfoundation/lams/tool/service/ILamsToolService.java
    • -41
    • +105
    ./src/java/org/lamsfoundation/lams/tool/service/LamsToolService.java
  3. … 1 more file in changeset.
Thursday 13 Jul 2023
5:14 pm

Marcin Cieslak

LDEV-5401 Fix timer display on monitoring Dashboard

Options
    • -13
    • +8
    ./src/java/org/lamsfoundation/lams/lesson/dao/hibernate/LessonDAO.java
Friday 23 Jun 2023
5:36 pm

Marcin Cieslak

Merge branch 'LDEV-5401' into v4.7

# Conflicts:

# lams_common/src/java/org/lamsfoundation/lams/web/controller/AbstractTimeLimitWebsocketServer.java

Options
    • -8
    • +15
    ./src/java/org/lamsfoundation/lams/web/controller/AbstractTimeLimitWebsocketServer.java
  2. … 1 more file in changeset.
Thursday 22 Jun 2023
4:18 pm

Marcin Cieslak

LDEV-5142 Fortify time limit websocket server code to prevent NPEs

Options
    • -51
    • +43
    ./src/java/org/lamsfoundation/lams/web/controller/AbstractTimeLimitWebsocketServer.java
  2. … 1 more file in changeset.
Wednesday 21 Jun 2023
8:10 pm

Marcin Cieslak

LDEV-5401 Add learner-triggered absolute time limit authoring and learning

Options
    • -29
    • +32
    ./src/java/org/lamsfoundation/lams/web/controller/AbstractTimeLimitWebsocketServer.java
  2. … 16 more files in changeset.
Monday 05 Jun 2023
12:09 pm

Marcin Cieslak

LAI-5 Add menu item in authoring to open AI wizard

Options
    • -0
    • +3
    ./src/java/org/lamsfoundation/lams/web/util/AttributeNames.java
  2. … 6 more files in changeset.
Tuesday 30 May 2023
9:35 am

Marcin Cieslak

Merge remote-tracking branch 'origin/v4.6' into v4.7

# Conflicts:

# idea_project/.idea/runConfigurations/WildFly.xml

# lams_tool_assessment/lams_tool_assessment.eml

# lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java

# lams_tool_scratchie/conf/language/lams/ApplicationResources.properties

# lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/service/ScratchieServiceImpl.java

Options
    • -63
    • +33
    ./src/java/org/lamsfoundation/lams/usermanagement/service/UserManagementService.java
  2. … 10 more files in changeset.
Saturday 20 May 2023
10:40 am

Marcin Cieslak

SP-4 Make sure that roles in subcourse are propagated to parent course.

Options
    • -63
    • +33
    ./src/java/org/lamsfoundation/lams/usermanagement/service/UserManagementService.java
  2. … 3 more files in changeset.
Tuesday 09 May 2023
9:57 pm

Ernie Ghiglione

LDEV-5395 Updating version info

I've been working in LAMS for 20 years (almost) and I always forgot to tag the development versions at the beginning. This is the first time I've done so properly. Hopefully this sets a precedent :-)

Options
    • -2
    • +2
    ./db/sql/insert_lams_config_data.sql
  2. … 1 more file in changeset.
3:29 pm

Marcin Cieslak

LDEV-5386 Modify config files for LAMS v4.8

Options
    • -31
    • +31
    ./.classpath
    • -11
    • +11
    ./lams_common.eml
  3. … 65 more files in changeset.
Sunday 07 May 2023
12:58 pm

Marcin Cieslak

LDEV-5393 Update marks for all peers in group after activity

Options
    • -3
    • +13
    ./src/java/org/lamsfoundation/lams/tool/ToolOutputDefinition.java
  2. … 2 more files in changeset.
Sunday 30 Apr 2023
11:36 am

Marcin Cieslak

Merge remote-tracking branch 'origin/v4.6' into v4.7

Options
    • -1
    • +1
    ./.classpath
    • -1
    • +4
    ./lams_common.eml
  3. … 14 more files in changeset.
10:51 am

Marcin Cieslak

LAI-3 Add support for other file types

Options
    • -7
    • +18
    ./src/java/org/lamsfoundation/lams/util/FileUtil.java
  2. … 3 more files in changeset.
Wednesday 26 Apr 2023
6:38 pm

Marcin Cieslak

LAI-3 Add recursive summarisation

Options
    • -22
    • +1
    ./src/java/org/lamsfoundation/lams/util/FileUtil.java
11:29 am

Marcin Cieslak

LAI-3 Extract PDF contents

PDF contents are often in UTF-16 and OpenAI requires UTF-8. We need to do conversion.

Options
    • -2
    • +16
    ./lams_common.eml
    • -12
    • +1
    ./lams_common.iml
    • -68
    • +104
    ./src/java/org/lamsfoundation/lams/util/FileUtil.java
  4. … 10 more files in changeset.
8:02 am

Marcin Cieslak

LDEV-5386 Library management

Options
    • -31
    • +31
    ./.classpath
    • -11
    • +11
    ./lams_common.eml
  3. … 69 more files in changeset.
Tuesday 25 Apr 2023
5:08 pm

Marcin Cieslak

LAI-3 Upgrade libraries to work with Word and PDF documents

Some libraries that we used for working with Word documents are outdated and insecure. It is a good idea to update them and their dependencies so we work with modern code when extracting PDF text for AI summarisation.

Options
    • -1
    • +1
    ./.classpath
    • -32
    • +23
    ./src/java/org/lamsfoundation/lams/questions/QuestionWordParser.java
  3. … 7041 more files in changeset.
Monday 24 Apr 2023
9:34 am

Marcin Cieslak

LDEV-5386 IntelliJ configuration file maintenance

Options
    • -31
    • +31
    ./.classpath
    • -11
    • +11
    ./lams_common.eml
  3. … 71 more files in changeset.
Friday 21 Apr 2023
2:14 pm

Marcin Cieslak

# WARNING: head commit changed in the meantime

Merge remote-tracking branch 'origin/v4.6' into v4.7

Options
    • -1
    • +6
    ./src/java/org/lamsfoundation/lams/qb/service/QbService.java
  2. … 8 more files in changeset.
Monday 17 Apr 2023
2:14 pm

Marcin Cieslak

LDEV-5386 Add per moduule IntelliJ configuration files

Options
    • -0
    • +40
    ./lams_common.eml
    • -0
    • +13
    ./lams_common.iml
  3. … 86 more files in changeset.
2:08 pm

Marcin Cieslak

LDEV-5386 Clean up .classpath files to make them compatible with IntelliJ

Options
    • -2
    • +1
    ./.classpath
  2. … 33 more files in changeset.
Wednesday 12 Apr 2023
9:51 am

Marcin Cieslak

Merge remote-tracking branch 'origin/v4.6' into v4.7

Options
    • -2
    • +6
    ./src/java/org/lamsfoundation/lams/usermanagement/service/IUserManagementService.java
    • -6
    • +16
    ./src/java/org/lamsfoundation/lams/usermanagement/service/UserManagementService.java
7:47 am

Marcin Cieslak

SP-4 Skip event log when disabling users via batch enrolment processing

Options
    • -2
    • +6
    ./src/java/org/lamsfoundation/lams/usermanagement/service/IUserManagementService.java
    • -6
    • +16
    ./src/java/org/lamsfoundation/lams/usermanagement/service/UserManagementService.java
  3. … 1 more file in changeset.
Monday 10 Apr 2023
9:00 pm

Marcin Cieslak

Merge remote-tracking branch 'origin/v4.6' into v4.7

Conflicts:

lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserOrgRoleSaveController.java

lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserRolesSaveController.java

lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/GroupingUploadAJAXController.java

Options
    • -0
    • +6
    ./src/java/org/lamsfoundation/lams/lesson/service/ILessonService.java
    • -2
    • +39
    ./src/java/org/lamsfoundation/lams/lesson/service/LessonService.java
  3. … 5 more files in changeset.
8:54 pm

Marcin Cieslak

LDEV-5383 Allow adding user to all lessons in a course

Options
    • -0
    • +6
    ./src/java/org/lamsfoundation/lams/lesson/service/ILessonService.java
    • -1
    • +37
    ./src/java/org/lamsfoundation/lams/lesson/service/LessonService.java
  3. … 7 more files in changeset.
7:49 am

Marcin Cieslak

LDEV-4501 Prevent exceptions on missing user references from LogEvents

This time in entity there is no reference to User objects. It reflects

DB structure without foreign key: there is just integer ID.

Options
    • -29
    • +21
    ./src/java/org/lamsfoundation/lams/logevent/LogEvent.java
    • -6
    • +2
    ./src/java/org/lamsfoundation/lams/logevent/service/LogEventService.java
  3. … 1 more file in changeset.
Friday 07 Apr 2023
1:55 pm

Marcin Cieslak

LDEV-5350 Do not remove groups used for branching on spreadsheet upload

Options
    • -1
    • +2
    ./src/java/org/lamsfoundation/lams/lesson/service/LessonService.java
  2. … 1 more file in changeset.
Friday 24 Mar 2023
11:55 am

Marcin Cieslak

LDEV-5277 Allow duplicate prefixes for integrated servers

Options
    • -0
    • +15
    ./src/java/org/lamsfoundation/lams/dbupdates/patch20230324.sql
  2. … 1 more file in changeset.
Thursday 23 Mar 2023
4:06 pm

Marcin Cieslak

LDEV-5260 Prevent EventStream retransmission from invalidating session

Event Stream, which LAMS uses for reactive communication via Flux, keeps

a line open between browser and LAMS. If this line is considered

stalled, usually because there is no interaction neither on back nor on

front end, it closes. It happens after about 5 minutes.

If in the meantime the teacher navigated to another LAMS lesson via LMS,

he/she gets reauthenticated via integrations mechanism and gets a new

HTTP session ID. This works fine and allows working on multiple

monitoring windows via LMS.

If now the stalled Event Stream sends a message to LAMS, it uses the old

session ID, not the new one. It happens even when the monitoring window

where the Event Stream was created gets closed. It is a browser

"feature".

This request with old session ID gets picked up by LAMS double login

prevention mechanism. LAMS does not allow users to be logged in to same

account on two browsers. And this Event Stream retransmission looks like

a double login. So LAMS invalidates the correct current session.

It results in teacher getting logged out from the monitoring window and

getting the login page on refresh.

The fix is just throwing an exception on Event Stream retransmission

which would otherwise invalidate the current session. It should be good

enough as the Event Stream does not need a valid response, no one is

waiting for one anymore.

Options
    • -0
    • +8
    ./src/java/org/lamsfoundation/lams/web/session/SessionManager.java
    • -4
    • +7
    ./src/java/org/lamsfoundation/lams/web/session/SystemSessionFilter.java