lams-github / lams_gradebook / src

java

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 17 Jul 2018
7:59 pm

Marcin Cieslak

LDEV-4609 Sort attempts in reverse order

It was implemented from the start, but our Java -> jqGrid XML conversion

method sorts the rows in ascending order by default.

Options
    • -2
    • +2
    ./org/lamsfoundation/lams/gradebook/service/GradebookService.java
    • -1
    • +1
    ./org/lamsfoundation/lams/gradebook/web/action/GradebookAction.java
  3. … 1 more file in changeset.
Saturday 30 Jun 2018
1:22 pm

Marcin Cieslak

LDEV-4609 Calculate dates and status for archived progress

Methods which calculate LearnerProgress dates and status use ugly

instanceof constructs. There seem to be no good alternatives, though.

LearnerProgressArchive can inherit from LearnerProgress and we use

table-per-subclass Hibernate strategy. But then queries for

LearnerProgress would fetch also LearnerProgressArchive entities unless

in each HQL query we put "WHERE lp.class = LearnerProgress". It is easy

to forget plus generic methods like findAll() will not work well anyway.

LearnerProgress and LearnerProgressArchive can extend a new

AbstractLearnerProgress and we use table-per-concrete-class Hibernate

strategy. Same with CompletedActivityProgress and

CompletedActivityProgressArchive. But then

AbstractLearnerProgress.completedActivities will not let use both of

them due to lack of polymorphism in collections. Neither

Map<Activty, AbstractCompletedActivityProgress>

nor

Map<Activity, ? extends AbstractCompletedActivityProgress>

will not work. And this collection is the main reason why to do

inheritance in the first place.

Looking how the above solutions add complexity and little gain, these

few methods with instanceof seem to be a fine trade off.

Options
    • -20
    • +75
    ./org/lamsfoundation/lams/gradebook/service/GradebookService.java
    • -1
    • +2
    ./org/lamsfoundation/lams/gradebook/service/IGradebookService.java
  3. … 9 more files in changeset.
Friday 29 Jun 2018
11:14 pm

Marcin Cieslak

LDEV-4440 Show archived activity attempts in gradebook

Options
    • -0
    • +57
    ./org/lamsfoundation/lams/gradebook/dto/GBActivityArchiveGridRowDTO.java
    • -3
    • +12
    ./org/lamsfoundation/lams/gradebook/dto/GBUserGridRowDTO.java
    • -0
    • +34
    ./org/lamsfoundation/lams/gradebook/service/GradebookService.java
    • -3
    • +6
    ./org/lamsfoundation/lams/gradebook/service/IGradebookService.java
    • -0
    • +39
    ./org/lamsfoundation/lams/gradebook/web/action/GradebookAction.java
  6. … 5 more files in changeset.
Thursday 28 Jun 2018
2:41 pm

Marcin Cieslak

LDEV-4609 Add archive date to gradebook marks on lesson restart

Options
    • -4
    • +5
    ./org/lamsfoundation/lams/gradebook/service/GradebookService.java
  2. … 6 more files in changeset.
Saturday 23 Jun 2018
12:42 am

Marcin Cieslak

LDEV-4607 Remove marks on output change to "none" in monitoring

Options
    • -11
    • +24
    ./org/lamsfoundation/lams/gradebook/service/GradebookService.java
    • -1
    • +4
    ./org/lamsfoundation/lams/gradebook/service/IGradebookService.java
  3. … 10 more files in changeset.
Thursday 21 Jun 2018
6:54 pm

Marcin Cieslak

LDEV-4606 Remove lesson mark if there are no activity marks left

Options
    • -6
    • +13
    ./org/lamsfoundation/lams/gradebook/service/GradebookService.java
2:34 pm

Marcin Cieslak

Revert "LDEV_NTU-10 Add a column "LAMS group" in exported summary"

This reverts commit 502290bd52d375ca2661924f6c80ff5590e5aaaf.

Options
    • -67
    • +11
    ./org/lamsfoundation/lams/gradebook/service/GradebookService.java
  2. … 1 more file in changeset.
Wednesday 06 Jun 2018
4:21 pm

tkkaung@ntu.edu.sg <tkkaung@ntu.edu.sg>

LDEV_NTU-10 Add a column "LAMS group" in exported summary

Options
    • -11
    • +67
    ./org/lamsfoundation/lams/gradebook/service/GradebookService.java
  2. … 1 more file in changeset.
Friday 18 May 2018
6:43 pm

Marcin Cieslak

Monthly merge from master to lams31

Conflicts:

lams_admin/src/java/org/lamsfoundation/lams/admin/web/action/OrgPasswordChangeAction.java

lams_build/lib/lams/lams.jar

lams_central/src/java/org/lamsfoundation/lams/authoring/ObjectExtractor.java

lams_central/src/java/org/lamsfoundation/lams/comments/web/CommentAction.java

lams_central/src/java/org/lamsfoundation/lams/web/IndexAction.java

lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/GroupingUploadAJAXAction.java

lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/action/LearningAction.java

lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/action/MonitoringAction.java

lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/web/actions/LearningAction.java

lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/service/McService.java

lams_tool_survey/src/java/org/lamsfoundation/lams/tool/survey/web/action/MonitoringAction.java

Options
    • -1
    • +1
    ./org/lamsfoundation/lams/gradebook/web/action/GradebookAction.java
  2. … 22 more files in changeset.
1:05 pm

Fiona Malikoff <Fiona.Malikoff@gmail.com>

LDEV-4585 Activity names in Greek appear properly in export file.

Options
    • -3
    • +21
    ./org/lamsfoundation/lams/gradebook/dto/GBActivityGridRowDTO.java
    • -9
    • +10
    ./org/lamsfoundation/lams/gradebook/service/GradebookService.java
    • -2
    • +2
    ./org/lamsfoundation/lams/gradebook/service/IGradebookService.java
    • -1
    • +1
    ./org/lamsfoundation/lams/gradebook/web/action/GradebookAction.java
Saturday 24 Mar 2018
2:12 am

Marcin Cieslak

Monthly merge from master to lams31

Multiple conflicts regarding audit service and JSON.

Conflicts:

lams_admin/src/java/org/lamsfoundation/lams/admin/web/action/UserSearchAction.java

lams_build/conf/domain.xml

lams_build/conf/slim/standalone.xml

lams_build/conf/standalone.xml

lams_build/lib/lams/lams-central.jar

lams_build/lib/lams/lams.jar

lams_central/src/java/org/lamsfoundation/lams/authoring/service/AuthoringService.java

lams_central/src/java/org/lamsfoundation/lams/workspace/service/WorkspaceManagementService.java

lams_common/src/java/org/lamsfoundation/lams/integration/security/SsoHandler.java

lams_common/src/java/org/lamsfoundation/lams/rating/service/RatingService.java

lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/web/action/GradebookAction.java

lams_learning/src/java/org/lamsfoundation/lams/learning/kumalive/KumaliveWebsocketServer.java

lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/EmailNotificationsAction.java

lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/MonitoringAction.java

lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java

lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/action/MonitoringAction.java

lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/service/McService.java

lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/web/action/QaLearningAction.java

lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/web/action/QaMonitoringAction.java

lams_tool_larsrc/src/java/org/lamsfoundation/lams/tool/rsrc/web/action/MonitoringAction.java

lams_tool_leader/src/java/org/lamsfoundation/lams/tool/leaderselection/service/ILeaderselectionService.java

lams_tool_leader/src/java/org/lamsfoundation/lams/tool/leaderselection/service/LeaderselectionService.java

lams_tool_notebook/src/java/org/lamsfoundation/lams/tool/notebook/web/actions/MonitoringAction.java

lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/service/PeerreviewServiceImpl.java

lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/web/action/MonitoringAction.java

lams_tool_sbmt/src/java/org/lamsfoundation/lams/tool/sbmt/service/SubmitFilesService.java

lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/web/action/LearningAction.java

lams_tool_spreadsheet/src/java/org/lamsfoundation/lams/tool/spreadsheet/web/action/MonitoringAction.java

lams_tool_survey/src/java/org/lamsfoundation/lams/tool/survey/web/action/LearningAction.java

lams_tool_task/src/java/org/lamsfoundation/lams/tool/taskList/web/action/MonitoringAction.java

lams_tool_vote/src/java/org/lamsfoundation/lams/tool/vote/web/action/MonitoringAction.java

Options
    • -1
    • +42
    ./org/lamsfoundation/lams/gradebook/web/action/GradebookAction.java
  2. … 83 more files in changeset.
Monday 05 Mar 2018
8:39 pm

Fiona Malikoff <Fiona.Malikoff@gmail.com>

LDEV-4522 Emojis not displaying correctly in monitoring

Also fixed some general escaping issues found while testing.

Options
    • -2
    • +2
    ./org/lamsfoundation/lams/gradebook/dto/GBLessonGridRowDTO.java
    • -2
    • +2
    ./org/lamsfoundation/lams/gradebook/dto/GBUserGridRowDTO.java
    • -3
    • +3
    ./org/lamsfoundation/lams/gradebook/service/GradebookService.java
  4. … 32 more files in changeset.
6:39 pm

Marcin Cieslak

LDEV-4523 Add method to remove actitivy mark

Options
    • -9
    • +34
    ./org/lamsfoundation/lams/gradebook/service/GradebookService.java
    • -2
    • +6
    ./org/lamsfoundation/lams/gradebook/service/IGradebookService.java
  3. … 1 more file in changeset.
Sunday 04 Mar 2018
9:59 am

Fiona Malikoff <Fiona.Malikoff@gmail.com>

LDEV-4501 Merge work replacing audit logs with LogEvent entries

Resolved conflicts for lams.jar and the Admin language file.

Options
    • -9
    • +10
    ./org/lamsfoundation/lams/gradebook/service/GradebookService.java
  2. … 13 more files in changeset.
Wednesday 28 Feb 2018
2:17 pm

Fiona Malikoff <Fiona.Malikoff@gmail.com>

LDEV-4505 Learners identified by Lastname, Surname in Monitoring

Options
    • -1
    • +1
    ./org/lamsfoundation/lams/gradebook/dto/GBUserGridRowDTO.java
  2. … 8 more files in changeset.
Tuesday 27 Feb 2018
10:29 am

Andrey Balan

LKC-89 add auxiliary methods required for TBL monitoring

Options
    • -0
    • +5
    ./org/lamsfoundation/lams/gradebook/service/GradebookService.java
    • -0
    • +9
    ./org/lamsfoundation/lams/gradebook/service/IGradebookService.java
  3. … 3 more files in changeset.
Thursday 22 Feb 2018
11:46 am

Fiona Malikoff <Fiona.Malikoff@gmail.com>

LDEV-4501 Gradebook audit log entry parameter order corrected

Options
    • -1
    • +1
    ./org/lamsfoundation/lams/gradebook/service/GradebookService.java
Tuesday 13 Feb 2018
1:52 am

Andrey Balan

LDEV-4512 Move isWeightedMarks method to LamsCoreToolService

Move isWeightedMarks(LearningDesign design) from GradebookService

to LamsCoreToolService in order to avoid creation of a new

dependency on lams_gradebook.

Options
    • -25
    • +13
    ./org/lamsfoundation/lams/gradebook/service/GradebookService.java
    • -3
    • +0
    ./org/lamsfoundation/lams/gradebook/service/IGradebookService.java
  3. … 2 more files in changeset.
Tuesday 06 Feb 2018
7:37 pm

Marcin Cieslak

LDEV-4504 Use just first part of grouped activity ID

We know there will be no name clash as this is a single learner table,

not an aggregate in monitoring.

Options
    • -1
    • +8
    ./org/lamsfoundation/lams/gradebook/web/action/GradebookAction.java
12:17 pm

Fiona Malikoff <Fiona.Malikoff@gmail.com>

LDEV-4501 Tool context files no longer reference audit service.

Options
    • -1
    • +1
    ./org/lamsfoundation/lams/gradebook/gradebookApplicationContext.xml
    • -8
    • +9
    ./org/lamsfoundation/lams/gradebook/service/GradebookService.java
    • -4
    • +9
    ./org/lamsfoundation/lams/gradebook/web/servlet/RecalculateTotalMarksForLessonServlet.java
  4. … 60 more files in changeset.
Saturday 03 Feb 2018
5:16 am

Andrey Balan

LDEV-4407 Other projects stop depending on lams_gradebook

* GradebookService interfaces are redefined now:

- IGradebookService is going to be used by core modules.

- IGradebookFullService is used inside of lams_gradebook only and

nowhere else, as it contains lams_gradebook's internal logic and

classes.

* Introduce CommonContants.java which contains for now common

constants that used to be located in GradebookConstants.java

* Tools stop using gradebookService directly, but rather through

ILamsToolService's method updateGradebookUserActivityMark()

* Move GradebookUserActivityArchive and GradebookUserLessonArchive

to lams_gradebook

Options
    • -0
    • +109
    ./org/lamsfoundation/lams/gradebook/model/GradebookUserActivityArchive.java
    • -0
    • +86
    ./org/lamsfoundation/lams/gradebook/model/GradebookUserLessonArchive.java
    • -17
    • +16
    ./org/lamsfoundation/lams/gradebook/service/GradebookService.java
    • -0
    • +278
    ./org/lamsfoundation/lams/gradebook/service/IGradebookFullService.java
    • -337
    • +0
    ./org/lamsfoundation/lams/gradebook/service/IGradebookService.java
    • -13
    • +0
    ./org/lamsfoundation/lams/gradebook/util/GradebookConstants.java
    • -7
    • +8
    ./org/lamsfoundation/lams/gradebook/util/GradebookUtil.java
    • -17
    • +0
    ./org/lamsfoundation/lams/gradebook/util/UserComparator.java
    • -20
    • +21
    ./org/lamsfoundation/lams/gradebook/web/action/GradebookAction.java
    • -48
    • +38
    ./org/lamsfoundation/lams/gradebook/web/action/GradebookMonitoringAction.java
    • -3
    • +3
    ./org/lamsfoundation/lams/gradebook/web/servlet/RecalculateTotalMarksForLessonServlet.java
  12. … 46 more files in changeset.
Friday 02 Feb 2018
6:11 am

Andrey Balan

LDEV-4407 Introduce new LearnerService interfaces

LearnerService interfaces are redefined now:

1. ILearnerService is used by core modules. Also tools no longer

use it.

2. ILearnerFullService is used inside of lams_learning only and

nowhere else, as it contains lams_learning's internal logic and

classes.

3. ICoreLearnerService is removed, its method are split between

ILearnerService and ILearnerFullService.

Options
    • -7
    • +6
    ./org/lamsfoundation/lams/gradebook/service/GradebookService.java
  2. … 34 more files in changeset.
Monday 29 Jan 2018
10:26 pm

Marcin Cieslak

LDEV-4504 Wrap activity names in links to pop up with their content

Options
    • -0
    • +34
    ./org/lamsfoundation/lams/gradebook/web/action/GradebookAction.java
  2. … 1 more file in changeset.
Friday 26 Jan 2018
9:09 pm

Andrey Balan

LDEV-4407 Tools and core to use learning classes from lams_common

Tools and core start using shared learning classes that were

recently moved from lams_learning to lams_common.

Remove any leftover dependencies on lams_learning.

Options
    • -1
    • +1
    ./org/lamsfoundation/lams/gradebook/service/GradebookService.java
  2. … 78 more files in changeset.
Tuesday 19 Dec 2017
8:47 pm

Marcin Cieslak

Merge remote-tracking branch 'origin/master' into lams31

Conflicts:

lams_build/conf/domain.xml

lams_build/lib/lams/lams.jar

lams_common/src/java/org/lamsfoundation/lams/rating/service/IRatingService.java

lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/EmailNotificationsAction.java

lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/MonitoringAction.java

lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java

lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/action/LearningAction.java

lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/action/MonitoringAction.java

lams_tool_chat/src/java/org/lamsfoundation/lams/tool/chat/service/ChatService.java

lams_tool_doku/src/java/org/lamsfoundation/lams/tool/dokumaran/service/DokumaranService.java

lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/service/ForumService.java

lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/service/McService.java

lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/service/QaService.java

lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/web/action/QaMonitoringAction.java

lams_tool_larsrc/src/java/org/lamsfoundation/lams/tool/rsrc/service/ResourceServiceImpl.java

lams_tool_leader/src/java/org/lamsfoundation/lams/tool/leaderselection/service/LeaderselectionService.java

lams_tool_mindmap/src/java/org/lamsfoundation/lams/tool/mindmap/service/MindmapService.java

lams_tool_nb/src/java/org/lamsfoundation/lams/tool/noticeboard/service/NoticeboardService.java

lams_tool_notebook/src/java/org/lamsfoundation/lams/tool/notebook/service/NotebookService.java

lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/service/PeerreviewServiceImpl.java

lams_tool_sbmt/src/java/org/lamsfoundation/lams/tool/sbmt/service/SubmitFilesService.java

lams_tool_sbmt/src/java/org/lamsfoundation/lams/tool/sbmt/web/action/MonitoringAction.java

lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/service/ScratchieServiceImpl.java

lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/web/action/LearningAction.java

lams_tool_scribe/src/java/org/lamsfoundation/lams/tool/scribe/service/ScribeService.java

lams_tool_survey/src/java/org/lamsfoundation/lams/tool/survey/service/SurveyServiceImpl.java

lams_tool_vote/src/java/org/lamsfoundation/lams/tool/vote/service/VoteService.java

lams_tool_wiki/src/java/org/lamsfoundation/lams/tool/wiki/service/WikiService.java

Options
    • -9
    • +59
    ./org/lamsfoundation/lams/gradebook/web/action/GradebookAction.java
  2. … 45 more files in changeset.
Monday 04 Dec 2017
3:19 pm

SanjanaPabsetti <Sanjana.pabsetti@gmail.com>

LDEV-4481 Add full implementation of min/max time taken.

Options
    • -0
    • +39
    ./org/lamsfoundation/lams/gradebook/dto/GradebookGridRowDTO.java
    • -2
    • +15
    ./org/lamsfoundation/lams/gradebook/service/GradebookService.java
  3. … 4 more files in changeset.
Friday 10 Nov 2017
2:25 am

Andrey Balan

LDEV-4464 Fix Gradebook export: problem displaying Chinese characters

StringEscapeUtils.escapeHtml() method has a bug (in version of

commons-lang prior to 3.0): it escapes multibyte characters like

Chinese, Japanese, etc. Thus it was replaced it with Spring's

HtmlUtils.htmlEscape().

Options
    • -3
    • +3
    ./org/lamsfoundation/lams/gradebook/dto/GBActivityGridRowDTO.java
    • -2
    • +2
    ./org/lamsfoundation/lams/gradebook/service/GradebookService.java
Thursday 09 Nov 2017
4:41 pm

Marcin Cieslak

LDEV-4453 Fix an error when a learner has no marks at all in a lesson

Options
    • -3
    • +4
    ./org/lamsfoundation/lams/gradebook/web/action/GradebookAction.java
Wednesday 08 Nov 2017
3:52 pm

Marcin Cieslak

LDEV-4453 Clean up unused methods

Options
    • -43
    • +7
    ./org/lamsfoundation/lams/gradebook/dto/GradebookGridRowDTO.java
3:50 pm

Marcin Cieslak

LDEV-4453 Prevent errors when marks are null

Options
    • -4
    • +8
    ./org/lamsfoundation/lams/gradebook/web/action/GradebookAction.java