lams-github

lams_gradebook

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 03 Feb 2022
9:29 pm

Marcin Cieslak

LDEV-5140 Rename Release Marks button

Teachers may think that the button releases marks immediately instead of

showing a panel to release/schedule marks.

Options
    • -0
    • +1
    ./conf/language/lams/ApplicationResources.properties
    • -1
    • +1
    ./web/gradebookMonitor.jsp
Saturday 18 Dec 2021
12:29 am

Marcin Cieslak

LDEV-5155 Escape rubrics text as it breaks authoring

Options
    • -1
    • +3
    ./web/WEB-INF/tags/AuthoringRatingAllStyleCriteria.tag
  2. … 32 more files in changeset.
Thursday 09 Dec 2021
1:45 am

Marcin Cieslak

LDEV-5268 Add max word limit to CKEditor tag

Options
    • -4
    • +20
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 32 more files in changeset.
Sunday 05 Dec 2021
5:09 pm

Marcin Cieslak

LDEV-4644 Use [] instead of () to recognise LO code

Teachers tend to use () as a part of Learning Outcome name

Options
    • -1
    • +1
    ./web/WEB-INF/tags/OutcomeAuthor.tag
  2. … 34 more files in changeset.
Tuesday 30 Nov 2021
5:18 am

Marcin Cieslak

LDEV-5259 Manually create parent application context

Previous attempt to reproduce BeanFactoryLocater was an overkill. A

simple singleton parent application context is sufficient.

Options
    • -8
    • +0
    ./web/WEB-INF/web.xml
  2. … 45 more files in changeset.
4:10 am

Marcin Cieslak

LDEV-5259 Use MVC initialisation via annotation

Manually triggering controller scanning by adding an annotation handler

bean does not register all useful support beans. If

<mvc:annotation-driven> is used in spring-servlet.xml, all support beans

are registered via WebMvcConfigurer.

<mvc:path-matching suffix-pattern="true" /> need to be added because we

use .do suffix for Spring actions and suffix was turned off for Spring

5.3

https://github.com/spring-projects/spring-framework/issues/24179

Options
    • -11
    • +14
    ./web/WEB-INF/spring-servlet.xml
  2. … 51 more files in changeset.
Tuesday 23 Nov 2021
7:24 pm

Marcin Cieslak

LDEV-5259 Manually start controller annotation detection

Options
    • -4
    • +4
    ./web/WEB-INF/spring-servlet.xml
  2. … 38 more files in changeset.
7:23 pm

Marcin Cieslak

LDEV-5259 Reintroduce BeanFactoryLocator mechanism back to LAMS

It was removed for Spring 5

Options
    • -1
    • +1
    ./web/WEB-INF/web.xml
  2. … 58 more files in changeset.
Thursday 11 Nov 2021
2:36 am

Marcin Cieslak

LDEV-5257 Secure fileDownloadToken cookie

Options
    • -12
    • +3
    ./src/java/org/lamsfoundation/lams/gradebook/web/controller/GradebookMonitoringController.java
  2. … 9 more files in changeset.
Tuesday 02 Nov 2021
9:39 pm

Marcin Cieslak

LDEV-5256 Sanitise jqGrid sorting options before using them in queries

Options
    • -5
    • +5
    ./src/java/org/lamsfoundation/lams/gradebook/dao/hibernate/GradebookDAO.java
  2. … 3 more files in changeset.
5:59 am

Marcin Cieslak

LDEV-5256 Prevent SQL injection for results order

Options
    • -13
    • +5
    ./src/java/org/lamsfoundation/lams/gradebook/dao/hibernate/GradebookDAO.java
  2. … 3 more files in changeset.
5:48 am

Marcin Cieslak

LDEV-4609 Prevent SQL injection for results order in Gradebook

Options
    • -15
    • +18
    ./src/java/org/lamsfoundation/lams/gradebook/dao/hibernate/GradebookDAO.java
Saturday 23 Oct 2021
1:03 am

Marcin Cieslak

LDEV-5140 Add release marks code to cusomised Gradebook

Options
    • -99
    • +475
    ./src/java/org/lamsfoundation/lams/gradebook/service/GradebookService.java
    • -0
    • +13
    ./src/java/org/lamsfoundation/lams/gradebook/service/IGradebookFullService.java
    • -2
    • +9
    ./src/java/org/lamsfoundation/lams/gradebook/web/controller/GradebookMonitoringController.java
    • -1
    • +19
    ./web/gradebookCourseMonitor.jsp
Monday 18 Oct 2021
10:32 pm

Marcin Cieslak

LDEV-4411 Make relation from Evaluation to ToolActivity unidirectional

Hibernate can not lazy load properties connected with OneToOne

relationship. It means that with every fetch of ToolActivity its

ActivityEvaluation was also fetched, whether is was needed or not. It

made up even 10% of all queries sent to DB during a lesson.

By having the relationship unidirectional and fetching

ActivityEvaluation via DAO we ensure that it is fetched only when it is

needed. The code is not as nice, though.

Options
    • -1
    • +3
    ./src/java/org/lamsfoundation/lams/gradebook/dto/GBActivityGridRowDTO.java
    • -16
    • +24
    ./src/java/org/lamsfoundation/lams/gradebook/service/GradebookService.java
  3. … 12 more files in changeset.
Saturday 11 Sep 2021
5:46 pm

Marcin Cieslak

LDEV-5247 Fix user name parameter sent to Etherpad

LAMS allows apostrophes but not quotation marks in names, so it is safer

to use quotations when operating with javascript.

Options
    • -1
    • +1
    ./web/WEB-INF/tags/Etherpad.tag
  2. … 33 more files in changeset.
Friday 13 Aug 2021
4:48 pm

Marcin Cieslak

LDEV-5155 Highlight rubrics row title

Make it more distinguished from selectable options in next columns

Options
    • -0
    • +4
    ./web/WEB-INF/tags/StyledRating.tag
  2. … 33 more files in changeset.
Thursday 12 Aug 2021
8:55 pm

Marcin Cieslak

LDEV-5155 Allow free flow of rubrics columns

Trying to calculate their width actually yields worse results.

Options
    • -4
    • +4
    ./web/WEB-INF/tags/StyledRating.tag
  2. … 33 more files in changeset.
Saturday 31 Jul 2021
12:47 am

Marcin Cieslak

LDEV-5227 Improve processing time of lesson gradebook export

Options
    • -12
    • +15
    ./src/java/org/lamsfoundation/lams/gradebook/service/GradebookService.java
Saturday 24 Jul 2021
4:22 pm

Marcin Cieslak

LDEV-5223 Prevent ep_resize from rendering short initial Etherpad

Options
    • -2
    • +1
    ./web/WEB-INF/tags/Etherpad.tag
  2. … 34 more files in changeset.
Thursday 22 Jul 2021
7:28 pm

Marcin Cieslak

LDEV-5220 Distribute the new popover tag

Options
    • -0
    • +31
    ./web/WEB-INF/tags/Popover.tag
    • -0
    • +4
    ./web/WEB-INF/tlds/lams/lams.tld
  3. … 62 more files in changeset.
6:52 pm

Marcin Cieslak

LDEV-5223 Fix Etherpad resizing

Options
    • -1
    • +1
    ./web/WEB-INF/tags/Etherpad.tag
  2. … 33 more files in changeset.
Tuesday 06 Jul 2021
6:07 pm

Marcin Cieslak

Merge branch 'LDEV-5155' into v4.0

Options
    • -1
    • +1
    ./web/WEB-INF/tags/Page.tag
  2. … 33 more files in changeset.
Thursday 01 Jul 2021
7:02 pm

Marcin Cieslak

LDEV-5155 Add column with average rating for given rubrics row

Options
    • -2
    • +21
    ./web/WEB-INF/tags/StyledRating.tag
  2. … 31 more files in changeset.
Wednesday 30 Jun 2021
5:01 pm

Marcin Cieslak

LDEV-5155 Always put rubrics column's value next to its description

Options
    • -4
    • +4
    ./web/WEB-INF/tags/StyledRating.tag
  2. … 31 more files in changeset.
3:39 pm

Marcin Cieslak

LDEV-5192 Limit maximum width of tool authoring content

For rubrics we may need a wider authoring window so their text areas are

not so squeezed. But having a super wide authoring windows does not look

good either. So now we have a container-fluid class, but limited to

1400px width.

Options
    • -76
    • +319
    ./web/WEB-INF/tags/AuthoringRatingAllStyleCriteria.tag
    • -1
    • +1
    ./web/WEB-INF/tags/Page.tag
    • -0
    • +182
    ./web/WEB-INF/tags/StyledRating.tag
  4. … 92 more files in changeset.
Wednesday 23 Jun 2021
3:16 pm

Marcin Cieslak

LDEV-5213 Add a missing JSTL library import

Options
    • -0
    • +1
    ./web/WEB-INF/tags/JSImport.tag
  2. … 32 more files in changeset.
Tuesday 22 Jun 2021
8:42 pm

Marcin Cieslak

LDEV-5213 Never show minus sign in hash code

Options
    • -1
    • +1
    ./web/WEB-INF/tags/JSImport.tag
  2. … 32 more files in changeset.
8:37 pm

Marcin Cieslak

LDEV-5213 Replace volatile JS imports with their non-cached version

Options
    • -1
    • +1
    ./web/WEB-INF/tags/Page.tag
    • -1
    • +1
    ./web/gradebookCourseMonitor.jsp
  3. … 92 more files in changeset.
7:37 pm

Marcin Cieslak

LDEV-5213 Add a tag to prevent JS file caching

Options
    • -0
    • +16
    ./web/WEB-INF/tags/JSImport.tag
    • -1
    • +4
    ./web/WEB-INF/tlds/lams/lams.tld
  3. … 64 more files in changeset.
Tuesday 15 Jun 2021
5:19 pm

Ernie Ghiglione

LDEV-4769 Updating Greek, French, English, Spanish, Norwegian

Options
    • -0
    • +5
    ./conf/language/lams/ApplicationResources_fr_FR.properties
  2. … 8 more files in changeset.