lams-github / lams_learning / src / java / org / lamsfoundation / lams / learning / web

action

Clone Tools

Stats

Commits this week: 0
Total Committers: 17
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 10 Sep 2018
1:55 am

Marcin Cieslak

Merge remote-tracking branch 'origin/master' into lams31

Conflicts:

lams_admin/.classpath

lams_build/lib/lams/lams-central.jar

lams_build/lib/lams/lams-gradebook.jar

lams_build/lib/lams/lams.jar

lams_central/.classpath

lams_central/src/java/org/lamsfoundation/lams/authoring/ObjectExtractor.java

lams_central/src/java/org/lamsfoundation/lams/authoring/service/IAuthoringService.java

lams_central/src/java/org/lamsfoundation/lams/authoring/template/web/LdTemplateAction.java

lams_central/src/java/org/lamsfoundation/lams/authoring/template/web/TBLTemplateAction.java

lams_central/src/java/org/lamsfoundation/lams/authoring/web/AuthoringAction.java

lams_central/src/java/org/lamsfoundation/lams/rest/RestServlet.java

lams_central/src/java/org/lamsfoundation/lams/rest/ToolRestManager.java

lams_central/src/java/org/lamsfoundation/lams/web/action/LtiAction.java

lams_central/src/java/org/lamsfoundation/lams/web/planner/PedagogicalPlannerAction.java

lams_central/src/java/org/lamsfoundation/lams/workspace/service/WorkspaceManagementService.java

lams_central/web/includes/javascript/pedagogicalPlanner.js

lams_common/.classpath

lams_common/src/java/org/lamsfoundation/lams/integration/service/IntegrationService.java

lams_common/src/java/org/lamsfoundation/lams/util/WebUtil.java

lams_gradebook/.classpath

lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/web/action/GradebookAction.java

lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/web/action/GradebookMonitoringAction.java

lams_learning/.classpath

lams_learning/src/java/org/lamsfoundation/lams/learning/kumalive/KumaliveAction.java

lams_learning/src/java/org/lamsfoundation/lams/learning/kumalive/service/KumaliveService.java

lams_monitoring/.classpath

lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/EmailNotificationsAction.java

lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/GroupingAJAXAction.java

lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/MonitoringAction.java

lams_tool_assessment/.classpath

lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/action/LearningAction.java

lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/action/MonitoringAction.java

lams_tool_bbb/.classpath

lams_tool_chat/.classpath

lams_tool_doku/.classpath

lams_tool_doku/src/java/org/lamsfoundation/lams/tool/dokumaran/web/action/LearningAction.java

lams_tool_eadventure/.classpath

lams_tool_forum/.classpath

lams_tool_images/.classpath

lams_tool_kaltura/.classpath

lams_tool_kaltura/src/java/org/lamsfoundation/lams/tool/kaltura/web/actions/AuthoringAction.java

lams_tool_kaltura/src/java/org/lamsfoundation/lams/tool/kaltura/web/actions/LearningAction.java

lams_tool_lamc/.classpath

lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/service/McService.java

lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/web/action/McLearningAction.java

lams_tool_laqa/.classpath

lams_tool_larsrc/.classpath

lams_tool_leader/.classpath

lams_tool_leader/src/java/org/lamsfoundation/lams/tool/leaderselection/web/actions/LearningAction.java

lams_tool_mindmap/src/java/org/lamsfoundation/lams/tool/mindmap/web/actions/AuthoringAction.java

lams_tool_mindmap/src/java/org/lamsfoundation/lams/tool/mindmap/web/actions/LearningAction.java

lams_tool_nb/.classpath

lams_tool_notebook/.classpath

lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/web/action/LearningAction.java

lams_tool_sbmt/.classpath

lams_tool_sbmt/src/java/org/lamsfoundation/lams/tool/sbmt/service/SubmitFilesService.java

lams_tool_scratchie/.classpath

lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/service/ScratchieServiceImpl.java

lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/web/action/LearningAction.java

lams_tool_scribe/src/java/org/lamsfoundation/lams/tool/scribe/web/actions/LearningAction.java

lams_tool_spreadsheet/.classpath

lams_tool_survey/.classpath

lams_tool_survey/src/java/org/lamsfoundation/lams/tool/survey/web/action/LearningAction.java

lams_tool_task/.classpath

lams_tool_vote/.classpath

lams_tool_vote/src/java/org/lamsfoundation/lams/tool/vote/web/action/LearningAction.java

lams_tool_wiki/.classpath

Options
    • -6
    • +6
    ./LearnerAction.java
  2. … 103 more files in changeset.
Sunday 19 Aug 2018
1:44 am

Andrey Balan

Merge branch 'master' into LDEV-4407

Conflicts:

lams_build/lib/lams/lams-gradebook.jar

lams_build/lib/lams/lams-learning.jar

lams_central/src/java/org/lamsfoundation/lams/web/planner/PedagogicalPlannerAction.java

lams_central/web/css/pedagogicalPlanner.css

lams_central/web/includes/javascript/openUrls.js

lams_common/src/java/org/lamsfoundation/lams/util/CommonConstants.java

lams_common/src/java/org/lamsfoundation/lams/web/util/AttributeNames.java

lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/model/GradebookUserLessonArchive.java

lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/service/GradebookService.java

lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/service/IGradebookFullService.java

lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/web/action/GradebookAction.java

lams_learning/src/java/org/lamsfoundation/lams/learning/learningApplicationContext.xml

lams_learning/src/java/org/lamsfoundation/lams/learning/service/ILearnerService.java

lams_learning/src/java/org/lamsfoundation/lams/learning/service/LearnerService.java

lams_learning/src/java/org/lamsfoundation/lams/learning/web/action/GroupingAction.java

lams_learning/src/java/org/lamsfoundation/lams/learning/web/servlet/RepopulateProgressMarksServlet.java

lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/IMonitoringService.java

lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/MonitoringService.java

lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/web/EmailNotificationsAction.java

lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/assessmentApplicationContext.xml

lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java

lams_tool_chat/src/java/org/lamsfoundation/lams/tool/chat/chatApplicationContext.xml

lams_tool_doku/src/java/org/lamsfoundation/lams/tool/dokumaran/dokumaranApplicationContext.xml

lams_tool_doku/src/java/org/lamsfoundation/lams/tool/dokumaran/service/DokumaranService.java

lams_tool_forum/src/java/org/lamsfoundation/lams/tool/forum/service/ForumService.java

lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/imageGalleryApplicationContext.xml

lams_tool_images/src/java/org/lamsfoundation/lams/tool/imageGallery/service/ImageGalleryServiceImpl.java

lams_tool_imscc/src/java/org/lamsfoundation/lams/tool/commonCartridge/commonCartridgeApplicationContext.xml

lams_tool_imscc/src/java/org/lamsfoundation/lams/tool/commonCartridge/service/CommonCartridgeServiceImpl.java

lams_tool_kaltura/src/java/org/lamsfoundation/lams/tool/kaltura/kalturaApplicationContext.xml

lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/service/McService.java

lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/qaApplicationContext.xml

lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/service/QaService.java

lams_tool_larsrc/src/java/org/lamsfoundation/lams/tool/rsrc/rsrcApplicationContext.xml

lams_tool_larsrc/src/java/org/lamsfoundation/lams/tool/rsrc/service/ResourceServiceImpl.java

lams_tool_mindmap/src/java/org/lamsfoundation/lams/tool/mindmap/mindmapApplicationContext.xml

lams_tool_mindmap/src/java/org/lamsfoundation/lams/tool/mindmap/web/actions/LearningAction.java

lams_tool_notebook/src/java/org/lamsfoundation/lams/tool/notebook/notebookApplicationContext.xml

lams_tool_pixlr/src/java/org/lamsfoundation/lams/tool/pixlr/pixlrApplicationContext.xml

lams_tool_sbmt/src/java/org/lamsfoundation/lams/tool/sbmt/service/ISubmitFilesService.java

lams_tool_sbmt/src/java/org/lamsfoundation/lams/tool/sbmt/service/SubmitFilesService.java

lams_tool_sbmt/src/java/org/lamsfoundation/lams/tool/sbmt/submitFilesApplicationContext.xml

lams_tool_sbmt/src/java/org/lamsfoundation/lams/tool/sbmt/web/action/MarkAction.java

lams_tool_sbmt/src/java/org/lamsfoundation/lams/tool/sbmt/web/action/SubmitFilesPedagogicalPlannerAction.java

lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/scratchieApplicationContext.xml

lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/service/ScratchieServiceImpl.java

lams_tool_spreadsheet/src/java/org/lamsfoundation/lams/tool/spreadsheet/web/action/LearningAction.java

lams_tool_vote/src/java/org/lamsfoundation/lams/tool/vote/service/VoteService.java

lams_tool_vote/src/java/org/lamsfoundation/lams/tool/vote/voteApplicationContext.xml

Options
    • -31
    • +16
    ./GroupingAction.java
    • -2
    • +4
    ./LearnerAction.java
  3. … 102 more files in changeset.
Tuesday 14 Aug 2018
9:01 pm

MichalKowalski <mickowal@hotmail.com>

LDEV-4440 Learning and Gradebook

Options
    • -48
    • +0
    ./ActivityAction.java
    • -221
    • +0
    ./BranchingActivityAction.java
    • -88
    • +0
    ./ChooseActivityAction.java
    • -121
    • +0
    ./CompleteActivityAction.java
    • -110
    • +0
    ./DisplayActivityAction.java
    • -125
    • +0
    ./DisplayOptionsActivityAction.java
    • -103
    • +0
    ./DisplayParallelActivityAction.java
    • -82
    • +0
    ./DisplayToolActivityAction.java
    • -228
    • +0
    ./GateAction.java
    • -275
    • +0
    ./GroupingAction.java
    • -454
    • +0
    ./LearnerAction.java
    • -97
    • +0
    ./LessonCompleteActivityAction.java
    • -133
    • +0
    ./LoadToolActivityAction.java
    • -276
    • +0
    ./NotebookAction.java
    • -93
    • +0
    ./SequenceActivityAction.java
  16. … 50 more files in changeset.
Thursday 19 Jul 2018
3:17 pm

Marcin Cieslak

Merge to lams31 after a vital commit to master

Options
    • -2
    • +4
    ./LearnerAction.java
  2. … 4 more files in changeset.
Saturday 30 Jun 2018
1:22 pm

Marcin Cieslak

LDEV-4609 Calculate dates and status for archived progress

Methods which calculate LearnerProgress dates and status use ugly

instanceof constructs. There seem to be no good alternatives, though.

LearnerProgressArchive can inherit from LearnerProgress and we use

table-per-subclass Hibernate strategy. But then queries for

LearnerProgress would fetch also LearnerProgressArchive entities unless

in each HQL query we put "WHERE lp.class = LearnerProgress". It is easy

to forget plus generic methods like findAll() will not work well anyway.

LearnerProgress and LearnerProgressArchive can extend a new

AbstractLearnerProgress and we use table-per-concrete-class Hibernate

strategy. Same with CompletedActivityProgress and

CompletedActivityProgressArchive. But then

AbstractLearnerProgress.completedActivities will not let use both of

them due to lack of polymorphism in collections. Neither

Map<Activty, AbstractCompletedActivityProgress>

nor

Map<Activity, ? extends AbstractCompletedActivityProgress>

will not work. And this collection is the main reason why to do

inheritance in the first place.

Looking how the above solutions add complexity and little gain, these

few methods with instanceof seem to be a fine trade off.

Options
    • -2
    • +4
    ./LearnerAction.java
  2. … 10 more files in changeset.
Wednesday 30 May 2018
8:18 pm

Marcin Cieslak

LDEV-4587 Display all ordered branches in progress bar

Ordered branching should be displayed similarly to optional sequences.

Options
    • -1
    • +1
    ./LearnerAction.java
  2. … 1 more file in changeset.
Tuesday 06 Feb 2018
10:55 pm

Marcin Cieslak

LDEV-4507 Use DTOs instead of entities as page attributes

It seems that using entities as page attributes outside a transaction

causes undesired effect. Portrait tag fetches data from DB and existing

entities, including group participants, get flushed from session. It

overwrites changes made by learners being added to a group.

Options
    • -15
    • +9
    ./GroupingAction.java
  2. … 5 more files in changeset.
Friday 02 Feb 2018
6:11 am

Andrey Balan

LDEV-4407 Introduce new LearnerService interfaces

LearnerService interfaces are redefined now:

1. ILearnerService is used by core modules. Also tools no longer

use it.

2. ILearnerFullService is used inside of lams_learning only and

nowhere else, as it contains lams_learning's internal logic and

classes.

3. ICoreLearnerService is removed, its method are split between

ILearnerService and ILearnerFullService.

Options
    • -3
    • +3
    ./ActivityAction.java
    • -10
    • +3
    ./BranchingActivityAction.java
    • -7
    • +2
    ./ChooseActivityAction.java
    • -2
    • +2
    ./CompleteActivityAction.java
    • -16
    • +2
    ./DisplayActivityAction.java
    • -10
    • +2
    ./DisplayOptionsActivityAction.java
    • -8
    • +2
    ./DisplayParallelActivityAction.java
    • -7
    • +2
    ./DisplayToolActivityAction.java
    • -3
    • +3
    ./GateAction.java
    • -6
    • +6
    ./GroupingAction.java
    • -5
    • +5
    ./LearnerAction.java
    • -10
    • +2
    ./LoadToolActivityAction.java
    • -3
    • +3
    ./NotebookAction.java
  14. … 22 more files in changeset.
5:41 am

Andrey Balan

LDEV-4407 Tools to stop using learnerService

There is no need to have a separate ILearnerService designed

for tools only. As long as they require only one method from it

completeToolSession() which we can simply move to

ILamsToolService. After which we just remove learnerService

from the tools.

Options
    • -5
    • +2
    ./SequenceActivityAction.java
  2. … 58 more files in changeset.
Thursday 01 Feb 2018
9:39 pm

Marcin Cieslak

LDEV-4507 Use redirect after learner chooses a group

Plain Struts forward resulted in "learnerChooseGroup" being the current

address which could lead to unnecessary retransmissions.

Options
    • -24
    • +7
    ./GroupingAction.java
  2. … 2 more files in changeset.
8:33 pm

Marcin Cieslak

LDEV-4507 Prevent duplicate groups with a DB constraint

Lesson staff groups need to have order id different than 1 so they do

not clash with learner groups.

Fetch lesson learner count faster by an exact query rather than fetching

all learners with Hibernate and counting them.

Options
    • -6
    • +4
    ./GroupingAction.java
  2. … 4 more files in changeset.
Friday 26 Jan 2018
9:09 pm

Andrey Balan

LDEV-4407 Tools and core to use learning classes from lams_common

Tools and core start using shared learning classes that were

recently moved from lams_learning to lams_common.

Remove any leftover dependencies on lams_learning.

Options
    • -1
    • +1
    ./BranchingActivityAction.java
    • -1
    • +1
    ./DisplayOptionsActivityAction.java
    • -1
    • +1
    ./DisplayParallelActivityAction.java
    • -1
    • +1
    ./GateAction.java
    • -11
    • +0
    ./GroupingAction.java
    • -1
    • +1
    ./LearnerAction.java
    • -1
    • +1
    ./LoadToolActivityAction.java
  8. … 72 more files in changeset.
Wednesday 13 Dec 2017
4:04 pm

Fiona Malikoff <Fiona.Malikoff@gmail.com>

LDEV-4474 Able to change the scheduled open date time for a gate.

Also fixed a number of bugs causing the schedule gate screens to

report strange times, missing fields, etc.

Options
    • -0
    • +3
    ./GateAction.java
  2. … 15 more files in changeset.
Saturday 04 Nov 2017
8:10 pm

Marcin Cieslak

LDEV-4453 Add gradebook on lesson complete front end

Options
    • -6
    • +6
    ./LessonCompleteActivityAction.java
  2. … 6 more files in changeset.
Friday 20 Oct 2017
3:44 am

Marcin Cieslak

LDEV-4402 Fix an incorrect property in JSON

Options
    • -1
    • +1
    ./LearnerAction.java
Friday 22 Sep 2017
11:20 am

Fiona Malikoff <Fiona.Malikoff@gmail.com>

LDEV-4423 Adding portraits to Monitor screens

Portraits incorporated into general monitor screens such as the

email sending popup, journal viewing, grouping and learner

progress. Also fixed issues in journal viewing relating to

LDEV-4393.

Options
    • -20
    • +45
    ./NotebookAction.java
  2. … 12 more files in changeset.
Tuesday 22 Aug 2017
12:30 pm

Marcin Cieslak

LDEV-4393 Fix parameter flow for lesson notebook

Current lesson ID was not retained during submits. It has to be present

on each page and submit so "view all" page knows where to add a new

entry.

Options
    • -12
    • +12
    ./NotebookAction.java
  2. … 4 more files in changeset.
Thursday 10 Aug 2017
12:28 am

Marcin Cieslak

LDEV-4402 Substitute Gson and Apache JSON with Jackson

Jackson is a top JSON library shipped with WF10.

Apache JSON resides in an ancient library which we do not need for

anything else.

We use GSon only for serializing Java objects to JSON, which Jackson can

do too.

Options
    • -22
    • +23
    ./LearnerAction.java
  2. … 135 more files in changeset.
Monday 03 Apr 2017
3:28 pm

FionaMalikoff <Fiona.Malikoff@gmail.com>

LDEV-4290 Removed caching of progress bar messages as it makes the language first used stick for all users.

Options
    • -15
    • +11
    ./LearnerAction.java
Friday 24 Mar 2017
2:58 am

Marcin Cieslak

LDEV-4288: Archive gradebook on lesson retry. Remove activity content on lesson retry.

Options
    • -4
    • +13
    ./LearnerAction.java
  2. … 15 more files in changeset.
Friday 17 Mar 2017
12:57 pm

Marcin Cieslak

LDEV-4278: Put and get activity ID from form since it is not present in request anymore.

Options
    • -0
    • +1
    ./GroupingAction.java
  2. … 2 more files in changeset.
Tuesday 14 Mar 2017
9:56 pm

Marcin Cieslak

LDEV-4272: Check if learner progress belongs to the logged in user.

Options
    • -0
    • +6
    ./CompleteActivityAction.java
Friday 03 Feb 2017
7:39 pm

Andrey Balan

LDEV-4155 In order to be able to use "history.back()" without any problems - using redirect in NotebookAction

Options
    • -31
    • +2
    ./NotebookAction.java
  2. … 1 more file in changeset.
Tuesday 24 Jan 2017
9:25 pm

Marcin Cieslak

LDEV-4175: Do not put DB entities (LearnerProgress, Activity) into request as this can cause problems. Better stick to IDs as parameters.

Options
    • -2
    • +0
    ./ActivityAction.java
    • -2
    • +0
    ./BranchingActivityAction.java
    • -4
    • +4
    ./CompleteActivityAction.java
    • -8
    • +1
    ./GateAction.java
    • -7
    • +5
    ./GroupingAction.java
    • -13
    • +10
    ./LearnerAction.java
    • -2
    • +0
    ./SequenceActivityAction.java
  8. … 2 more files in changeset.
Wednesday 23 Nov 2016
4:57 pm

Marcin Cieslak

LDEV-4075: Get rid of Next Activity button in preview Branching.

Options
    • -1
    • +0
    ./BranchingActivityAction.java
  2. … 1 more file in changeset.
Friday 09 Sep 2016
3:24 pm

Marcin Cieslak

LDEV-3971: Remove pointless synchronisation from Java methods. It would not work in multi-node environment anyway. Focus on DB transactions. General clean up and formatting.

Options
    • -26
    • +25
    ./LoadToolActivityAction.java
  2. … 13 more files in changeset.
Friday 29 Jul 2016
12:23 pm

FionaMalikoff <Fiona.Malikoff@gmail.com>

LDEV-3914: Adding support activities

Options
    • -1
    • +2
    ./LearnerAction.java
  2. … 29 more files in changeset.
10:26 am

FionaMalikoff <Fiona.Malikoff@gmail.com>

LDEV-3915: Updating core learner screens like gates and groups to suit sliding div based progress bar.

Options
    • -0
    • +3
    ./BranchingActivityAction.java
    • -0
    • +4
    ./DisplayOptionsActivityAction.java
    • -1
    • +14
    ./GroupingAction.java
  4. … 4 more files in changeset.
Thursday 28 Jul 2016
11:49 am

FionaMalikoff <Fiona.Malikoff@gmail.com>

LDEV-3914: Replacing learner control frames with a div based sliding bar.

Options
    • -2
    • +75
    ./LearnerAction.java
    • -2
    • +0
    ./LessonCompleteActivityAction.java
  3. … 27 more files in changeset.
11:47 am

FionaMalikoff <Fiona.Malikoff@gmail.com>

LDEV-3915: Updating core learner screens like gates and groups to suit sliding div based progress bar.

Options
    • -0
    • +1
    ./GroupingAction.java
  2. … 2 more files in changeset.