lams-github / lams_learning / src / java / org

lamsfoundation

Clone Tools

Stats

Commits this week: 0
Total Committers: 24
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 12 Jul 2006
12:48 pm

fmalikoff

Moving from a tool activity to a grouped tool activity was throwing an exception as the "create tool session" code (which calls the tool to create the tool session details) was being called within the tool context.

Moved the call to create the tool session into LoadToolActivityAction so that it will always be run within the lams-learning war context and hence all the tools' beans are available in the Spring context.

To try to stop this sort of problem occuring again (ie a tool calling code that relies on all tools' beans being in the context) the ILearnerService has been split into two interfaces. ILearnerService now only contains the one method that should be called by tools (to complete a tool session). All other calls are in ICoreLearnerService. Any of the core modules may use the ICoreLearnerService but only tools should use the ILearnerService.

Options
    • -3
    • +3
    ./lams/learning/export/service/ExportPortfolioService.java
    • -1
    • +0
    ./lams/learning/export/web/action/MainExportServlet.java
    • -0
    • +245
    ./lams/learning/service/ICoreLearnerService.java
    • -202
    • +2
    ./lams/learning/service/ILearnerService.java
    • -61
    • +55
    ./lams/learning/service/LearnerService.java
    • -2
    • +2
    ./lams/learning/service/LearnerServiceProxy.java
    • -3
    • +3
    ./lams/learning/web/action/ActivityAction.java
    • -2
    • +2
    ./lams/learning/web/action/ChooseActivityAction.java
    • -2
    • +2
    ./lams/learning/web/action/CompleteActivityAction.java
    • -2
    • +2
    ./lams/learning/web/action/DisplayActivityAction.java
    • -2
    • +2
    ./lams/learning/web/action/DisplayOptionsActivityAction.java
    • -2
    • +2
    ./lams/learning/web/action/DisplayToolActivityAction.java
    • -3
    • +3
    ./lams/learning/web/action/DummyLearnerAction.java
    • -2
    • +2
    ./lams/learning/web/action/GateAction.java
    • -5
    • +5
    ./lams/learning/web/action/GroupingAction.java
  16. … 10 more files in changeset.
Tuesday 11 Jul 2006
3:37 pm

fmalikoff

Learner Progress DTO changes made to so that Flash will know when a learner is finished. * Current activity now set to null (and hence won't appear in packet) when the learner has completed the lesson. * New field lessonComplete which is true when the learner has completed the lesson, false otherwise.

Options
    • -1
    • +3
    ./lams/learning/progress/ProgressEngine.java
    • -1
    • +1
    ./lams/learning/web/util/ActivityMapping.java
  3. … 5 more files in changeset.
9:40 am

fmalikoff

Make it work offline.

Options
    • -0
    • +3
    ./lams/learning/web/action/GroupingAction.java
  2. … 1 more file in changeset.
Monday 03 Jul 2006
8:22 am

fmalikoff

Added styling images to export portfolio. The directory of the images is hardcoded and this will need to be fixed before we can create any other styles.

This required adding the lams directory to the configuration file so that the css and image files could be copied using a file copy rather than using http (for performance).

Options
    • -0
    • +257
    ./lams/learning/export/web/action/CSSBundler.java
    • -27
    • +4
    ./lams/learning/export/web/action/MainExportServlet.java
  3. … 1 more file in changeset.
Saturday 01 Jul 2006
8:49 pm

fmalikoff

Converted to the learner content styles

Options
    • -0
    • +6
    ./lams/learning/web/action/GroupingAction.java
  2. … 25 more files in changeset.
Friday 30 Jun 2006
11:44 am

fmalikoff

Updating export portfolio for the new stylesheets. New sheets applied and some extra data added to the page (such as learner name). Doesn't look right yet as the images aren't available and the css references have had to be hardcoded and this should be done via the css tag.

Options
    • -0
    • +31
    ./lams/learning/export/Portfolio.java
    • -1
    • +2
    ./lams/learning/export/service/ExportPortfolioService.java
    • -1
    • +7
    ./lams/learning/export/web/action/MainExportServlet.java
  4. … 3 more files in changeset.
Tuesday 27 Jun 2006
7:32 am

fmalikoff

Added user id as a parameter to the export portfolio url for learner. This allows the teacher to download the portfolio for a particular user.

Options
    • -4
    • +19
    ./lams/learning/export/web/action/MainExportServlet.java
Friday 23 Jun 2006
3:57 pm

fmalikoff

Fixing null ptr exception - previous activity is sometimes null when doing a subactivity within an optional activity.

Options
    • -1
    • +1
    ./lams/learning/web/util/ActivityMapping.java
3:54 pm

fmalikoff

Optional activity wasn't showing title and description - values were missing from the form.

Options
    • -0
    • +2
    ./lams/learning/web/action/DisplayOptionsActivityAction.java
Wednesday 21 Jun 2006
8:08 pm

fmalikoff

Implementing gate and grouping screens for export portfolio.

Options
    • -35
    • +37
    ./lams/learning/export/service/ExportPortfolioService.java
    • -21
    • +50
    ./lams/learning/export/service/PortfolioBuilder.java
    • -6
    • +50
    ./lams/learning/web/action/GroupingAction.java
    • -0
    • +74
    ./lams/learning/web/action/GroupingExportPortfolioServlet.java
    • -1
    • +1
    ./lams/learning/web/util/ActivityMapping.java
  6. … 38 more files in changeset.
Monday 19 Jun 2006
11:34 am

fmalikoff

Adding lessonID to the activity form, so that the passon.swf can have it separately and make it part of the connection name. Changed form.activityId to form.activityID for consistency.

Options
    • -6
    • +7
    ./lams/learning/web/action/ActivityAction.java
    • -1
    • +1
    ./lams/learning/web/action/DisplayOptionsActivityAction.java
    • -1
    • +1
    ./lams/learning/web/action/DisplayParallelActivityAction.java
    • -1
    • +1
    ./lams/learning/web/action/LoadToolActivityAction.java
    • -5
    • +16
    ./lams/learning/web/form/ActivityForm.java
  6. … 1 more file in changeset.
2:51 am

fyang

remove userDAO reference , use baseDAO instead

Options
    • -1
    • +1
    ./lams/learning/service/LearnerService.java
    • -1
    • +1
    ./lams/learning/web/util/LearningWebUtil.java
2:10 am

fyang

remove userDAO reference , use baseDAO instead

Options
    • -13
    • +7
    ./lams/learning/export/service/ExportPortfolioService.java
    • -1
    • +1
    ./lams/learning/learningApplicationContext.xml
2:01 am

fyang

update user related method calls only

Options
    • -3
    • +3
    ./lams/learning/service/LearnerService.java
    • -1
    • +1
    ./lams/learning/web/action/LearnerAction.java
Sunday 18 Jun 2006
9:08 pm

fmalikoff

Removing learnerProgress from the user's shared session. This should allow preview and learner to run without interfering with each other.

Options
    • -12
    • +26
    ./lams/learning/service/ILearnerService.java
    • -42
    • +55
    ./lams/learning/service/LearnerService.java
    • -28
    • +9
    ./lams/learning/web/action/ActivityAction.java
    • -4
    • +5
    ./lams/learning/web/action/ChooseActivityAction.java
    • -8
    • +6
    ./lams/learning/web/action/CompleteActivityAction.java
    • -7
    • +21
    ./lams/learning/web/action/DisplayActivityAction.java
    • -3
    • +4
    ./lams/learning/web/action/DisplayOptionsActivityAction.java
    • -2
    • +4
    ./lams/learning/web/action/DisplayToolActivityAction.java
    • -1
    • +1
    ./lams/learning/web/action/DummyLearnerAction.java
    • -42
    • +14
    ./lams/learning/web/action/GateAction.java
    • -11
    • +4
    ./lams/learning/web/action/GroupingAction.java
    • -8
    • +4
    ./lams/learning/web/action/LearnerAction.java
    • -2
    • +4
    ./lams/learning/web/action/LoadToolActivityAction.java
    • -4
    • +10
    ./lams/learning/web/util/ActivityMapping.java
    • -80
    • +53
    ./lams/learning/web/util/LearningWebUtil.java
  16. … 11 more files in changeset.
12:56 pm

fmalikoff

Changed export portfolio to * reduce the number of error messages * move the html out of the I18N file and into jsps * use the learning design processor so that the activities are processed (and hence displayed) in the correct order.

Options
    • -0
    • +129
    ./lams/learning/export/ActivityPortfolio.java
    • -12
    • +3
    ./lams/learning/export/ExportPortfolioConstants.java
    • -11
    • +37
    ./lams/learning/export/Portfolio.java
    • -117
    • +0
    ./lams/learning/export/ToolPortfolio.java
    • -427
    • +132
    ./lams/learning/export/service/ExportPortfolioService.java
    • -63
    • +4
    ./lams/learning/export/service/IExportPortfolioService.java
    • -0
    • +206
    ./lams/learning/export/service/PortfolioBuilder.java
    • -1
    • +2
    ./lams/learning/export/web/action/ExportDownloadServlet.java
    • -95
    • +0
    ./lams/learning/export/web/action/ExportNotSupportedServlet.java
    • -161
    • +11
    ./lams/learning/export/web/action/MainExportServlet.java
    • -2
    • +3
    ./lams/learning/learningApplicationContext.xml
    • -1
    • +1
    ./lams/learning/web/action/LearnerAction.java
  13. … 6 more files in changeset.
Friday 16 Jun 2006
9:34 am

mseaton

appended lessonID to progressSummary query string

Options
    • -1
    • +13
    ./lams/learning/web/action/ActivityAction.java
Thursday 15 Jun 2006
9:07 am

fmalikoff

Added the define later special screen code to the wrong Action class.

Options
    • -21
    • +9
    ./lams/learning/web/action/DisplayToolActivityAction.java
    • -2
    • +18
    ./lams/learning/web/action/LoadToolActivityAction.java
  3. … 2 more files in changeset.
7:13 am

fmalikoff

Preview changes: (1) when define later activity occurs don't tell the tool that it is define later but display a special screen before going to the next tool (2) for chosen grouping, schedule and permission gates show the normal page with an extra preview message then override the normal process and continue.

Also part A of a change to the Flash call to get the learner progress - it should take the lesson id not the progress id.

Options
    • -6
    • +12
    ./lams/learning/service/ILearnerService.java
    • -16
    • +41
    ./lams/learning/service/LearnerService.java
    • -9
    • +21
    ./lams/learning/web/action/DisplayToolActivityAction.java
    • -3
    • +16
    ./lams/learning/web/action/GateAction.java
    • -2
    • +16
    ./lams/learning/web/action/GroupingAction.java
    • -2
    • +8
    ./lams/learning/web/action/LearnerAction.java
  7. … 9 more files in changeset.
Sunday 11 Jun 2006
10:48 am

fmalikoff

Call passon to update the progress bar on tool pages, optional activities and the completed screen.

Should also cope with the user partially doing an optional activity, continuing on in the design, then coming back later to the optional activity to do more, and then going back to where they were up to in the sequence before jumping back.

Options
    • -28
    • +56
    ./lams/learning/progress/ProgressEngine.java
    • -5
    • +69
    ./lams/learning/web/action/ActivityAction.java
    • -2
    • +6
    ./lams/learning/web/action/ChooseActivityAction.java
    • -0
    • +4
    ./lams/learning/web/action/CompleteActivityAction.java
    • -57
    • +7
    ./lams/learning/web/action/DisplayActivityAction.java
    • -0
    • +3
    ./lams/learning/web/action/DisplayOptionsActivityAction.java
    • -0
    • +2
    ./lams/learning/web/action/DisplayParallelActivityAction.java
    • -0
    • +2
    ./lams/learning/web/action/DisplayToolActivityAction.java
    • -0
    • +69
    ./lams/learning/web/action/LessonCompleteActivityAction.java
    • -1
    • +4
    ./lams/learning/web/action/LoadToolActivityAction.java
    • -48
    • +1
    ./lams/learning/web/util/ActivityMapping.java
    • -1
    • +1
    ./lams/learning/web/util/ActivityMappingStrategy.java
  13. … 7 more files in changeset.
Friday 09 Jun 2006
8:00 am

fmalikoff

Changing getLearnerActivityURL so that it returns a suitable url for the optional activity page.

All urls returned in this packet are now full urls, which requires a change on the client end.

Options
    • -1
    • +1
    ./lams/learning/web/action/DisplayOptionsActivityAction.java
    • -2
    • +1
    ./lams/learning/web/action/DisplayParallelActivityAction.java
    • -17
    • +10
    ./lams/learning/web/util/ActivityMapping.java
    • -2
    • +1
    ./lams/learning/web/util/ActivityMappingStrategy.java
    • -1
    • +1
    ./lams/learning/web/util/ParallelActivityMappingStrategy.java
Thursday 08 Jun 2006
9:03 am

fmalikoff

Modify progress engine to call the preview urls for tools when the lesson is a preview lesson.

Options
    • -2
    • +1
    ./lams/learning/web/action/DisplayToolActivityAction.java
    • -1
    • +1
    ./lams/learning/web/action/LearnerAction.java
    • -3
    • +2
    ./lams/learning/web/action/LoadToolActivityAction.java
    • -5
    • +8
    ./lams/learning/web/util/ActivityMapping.java
Tuesday 06 Jun 2006
10:35 am

fmalikoff

Added support for chosen grouping.

Options
    • -1
    • +2
    ./lams/learning/web/action/DummyLearnerAction.java
    • -1
    • +2
    ./lams/learning/web/action/GroupingAction.java
    • -2
    • +2
    ./lams/learning/web/action/LearnerAction.java
    • -4
    • +4
    ./lams/learning/web/util/ActivityMapping.java
    • -8
    • +6
    ./lams/learning/web/util/LearningWebUtil.java
  6. … 6 more files in changeset.
Friday 02 Jun 2006
3:56 pm

fmalikoff

Clean up grouping code so that the shared code is in lams.jar, and making it so that learner can't trigger the chosen grouping. I18N the grouping screen and added a wait page for the chosen grouping.

Options
    • -21
    • +5
    ./lams/learning/service/ILearnerService.java
    • -45
    • +24
    ./lams/learning/service/LearnerService.java
    • -0
    • +24
    ./lams/learning/service/LearnerServiceException.java
    • -16
    • +22
    ./lams/learning/web/action/GroupingAction.java
  5. … 7 more files in changeset.
6:58 am

fmalikoff

Random grouping now working. Changed to make learner service changes to stop a hibernate lazy initialisation exception when grouping has just been run. Also reduced the amount of data needed to be cached in the session - only the lesson id is needed not the complete lesson.

Options
    • -1
    • +1
    ./lams/learning/export/service/ExportPortfolioService.java
    • -6
    • +9
    ./lams/learning/progress/ProgressEngine.java
    • -8
    • +8
    ./lams/learning/service/ILearnerService.java
    • -23
    • +16
    ./lams/learning/service/LearnerService.java
    • -2
    • +2
    ./lams/learning/web/action/ChooseActivityAction.java
    • -2
    • +2
    ./lams/learning/web/action/CompleteActivityAction.java
    • -2
    • +2
    ./lams/learning/web/action/DummyLearnerAction.java
    • -2
    • +2
    ./lams/learning/web/action/GroupingAction.java
    • -2
    • +2
    ./lams/learning/web/action/LearnerAction.java
    • -22
    • +17
    ./lams/learning/web/util/LearningWebUtil.java
  11. … 2 more files in changeset.
Thursday 01 Jun 2006
12:47 pm

fmalikoff

Removed the original SessionBean from the system. If needed again, the shared session bean developed by Dapeng can be used. Fixed various issues with Optional Activities and Parallel activites. Should be able to run through a sequence with them okay now.

Options
    • -0
    • +1
    ./lams/learning/learningApplicationContext.xml
    • -3
    • +9
    ./lams/learning/progress/ProgressEngine.java
    • -22
    • +24
    ./lams/learning/service/LearnerService.java
    • -34
    • +2
    ./lams/learning/web/action/ActivityAction.java
    • -11
    • +0
    ./lams/learning/web/action/CompleteActivityAction.java
    • -1
    • +0
    ./lams/learning/web/action/DisplayActivityAction.java
    • -6
    • +4
    ./lams/learning/web/action/DisplayOptionsActivityAction.java
    • -1
    • +0
    ./lams/learning/web/action/LearnerAction.java
    • -70
    • +0
    ./lams/learning/web/bean/SessionBean.java
    • -2
    • +2
    ./lams/learning/web/util/ActivityMapping.java
  11. … 1 more file in changeset.
Wednesday 31 May 2006
8:38 pm

fmalikoff

Changed calls to update lesson to use the lessonId rather than the lesson. Change allowed us to reduce the amount cached in the context. This fixed various issues with Optional and Parallel activities.

Options
    • -2
    • +1
    ./lams/learning/export/service/ExportPortfolioService.java
    • -0
    • +1
    ./lams/learning/learningApplicationContext.xml
    • -13
    • +23
    ./lams/learning/service/ILearnerService.java
    • -22
    • +33
    ./lams/learning/service/LearnerService.java
    • -14
    • +4
    ./lams/learning/web/action/ChooseActivityAction.java
    • -10
    • +6
    ./lams/learning/web/action/CompleteActivityAction.java
    • -3
    • +6
    ./lams/learning/web/action/DisplayOptionsActivityAction.java
    • -10
    • +6
    ./lams/learning/web/action/DummyLearnerAction.java
    • -4
    • +7
    ./lams/learning/web/action/GateAction.java
    • -10
    • +3
    ./lams/learning/web/action/GroupingAction.java
    • -5
    • +6
    ./lams/learning/web/action/LearnerAction.java
    • -46
    • +4
    ./lams/learning/web/util/LearningWebUtil.java
  13. … 3 more files in changeset.
Tuesday 30 May 2006
3:24 pm

fmalikoff

Replaced getActiveLessons with getLesson, to suit the change from listing all the lessons in the learner client to just working with a single lesson.

Also moved the logic to cache the lesson learners into the lams.jar (in the LessonService).

Options
    • -0
    • +1
    ./lams/learning/learningApplicationContext.xml
    • -15
    • +20
    ./lams/learning/service/ILearnerService.java
    • -11
    • +32
    ./lams/learning/service/LearnerService.java
    • -9
    • +3
    ./lams/learning/web/action/GateAction.java
    • -6
    • +2
    ./lams/learning/web/action/GroupingAction.java
    • -61
    • +40
    ./lams/learning/web/action/LearnerAction.java
    • -167
    • +0
    ./lams/learning/web/util/LessonLearnerDataManager.java
  8. … 4 more files in changeset.
Wednesday 17 May 2006
3:25 pm

fmalikoff

Implementing the gate screens for learner.

Options
    • -3
    • +3
    ./lams/learning/service/ILearnerService.java
    • -3
    • +4
    ./lams/learning/service/LearnerService.java
    • -12
    • +121
    ./lams/learning/web/action/GateAction.java
  4. … 11 more files in changeset.
Wednesday 10 May 2006
1:30 pm

fmalikoff

Moving gate and group url support to a lams_system_tool table - the first "inch" towards making these pluggable tools in a later version of LAMS.

Options
    • -0
    • +5
    ./lams/learning/web/action/DisplayActivityAction.java
    • -7
    • +8
    ./lams/learning/web/action/DisplayToolActivityAction.java
    • -1
    • +2
    ./lams/learning/web/action/LearnerAction.java
    • -16
    • +11
    ./lams/learning/web/action/LoadToolActivityAction.java
    • -11
    • +8
    ./lams/learning/web/util/ActivityMapping.java
    • -11
    • +2
    ./lams/learning/web/util/ActivityMappingStrategy.java
  7. … 9 more files in changeset.