lamsfoundation

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDEV-1134: Dummying up a branching page for the progress engine. Had missed the entry for the abstract branching class in the Hibernate file when I switched from 1 branching class to 3.

    • -0
    • +121
    ./lams/learning/web/action/BranchingActivityAction.java
  1. … 4 more files in changeset.
LDEV-1241: Problem with progess engine getting stuck when a user is in a parallel activity within an optional activity required a change to the LearnerProgress.setProgressState() method call. Learner classes changed to match.

LDEV-1155 revert to storing temp portfolio on server as a constant 'export.zip'; URLEncoded the portfolio name when it is passed as a URL parameter (for i18n purposes); strip out punctuation chars from the export portfolio filename that is downloaded by users.

  1. … 1 more file in changeset.
Debug statement no longer needed.

LDEV-1225: While testing, found that the notSupported.jsp doesn't work properly. This page only appeared when the system tools (gates and grouping) don't work in export portfolio properly, so its not worth trying to fix it. Now if they don't work there is an entry in the main page but no "no supported" page.

  1. … 1 more file in changeset.
LDEV-1182 & LDEV-1126: Fixing up behaviour of the close.jsp - which is called when the user completes an activity that was already finished. There were problems with the parallel activities when one was finished and the user clicked resume (or restarted learner) and with force complete. Now instead of just showing the "close" message, it detects that it is not in the popup window and instead of trying to close it now forwards to the next appropriate screen.

    • -6
    • +6
    ./lams/learning/web/action/LearnerAction.java
    • -3
    • +49
    ./lams/learning/web/util/ActivityMapping.java
    • -9
    • +13
    ./lams/learning/web/util/LearningWebUtil.java
  1. … 1 more file in changeset.
LDEV-1051 and LDEV-1198: Fixed the break out of frames logic for parallels at the end of a design and inside an optional activity.

    • -15
    • +22
    ./lams/learning/web/util/ActivityMapping.java
  1. … 7 more files in changeset.
LDEV-1155 filename parameter in response parameter needs to be enclosed by quotes otherwise firefox truncates the filename when it encounters the first space

Merging RAMS and Edit On Fly changes from branch to the head.

    • -31
    • +110
    ./lams/learning/progress/ProgressEngine.java
    • -13
    • +16
    ./lams/learning/service/ICoreLearnerService.java
    • -2
    • +14
    ./lams/learning/web/action/ActivityAction.java
    • -23
    • +44
    ./lams/learning/web/action/GateAction.java
    • -7
    • +16
    ./lams/learning/web/action/GroupingAction.java
    • -4
    • +0
    ./lams/learning/web/action/LearnerAction.java
    • -0
    • +10
    ./lams/learning/web/form/ActivityForm.java
    • -76
    • +47
    ./lams/learning/web/util/ActivityMapping.java
    • -2
    • +37
    ./lams/learning/web/util/LearningWebUtil.java
  1. … 225 more files in changeset.
LDEV-1210: While fixing the notebook text entry, I cleaned up processNotes to reduce processing - there was processing there that had no effect!

LDEV-1155 name export portfolios according to lesson name

LDEV-1097: Remove the finish button from the learner progress view of the grouping screen, plus updated some out of date method calls relating to force complete.

    • -2
    • +6
    ./lams/learning/web/action/GroupingAction.java
  1. … 1 more file in changeset.
LDEV-1131: If the user is using a custom stylesheet, export portfolio wasn't copying the images directory for the stylesheet. Changed the export so it now copies the theme's special images (using the new image_directory column in the theme) as well as the default images.

  1. … 9 more files in changeset.
moved joinLesson call to jsp ldev-1128

    • -5
    • +64
    ./lams/learning/web/action/LearnerAction.java
  1. … 4 more files in changeset.
LDEV-1125: Getting a blank screen for the next activity if you force complete a user on a parallel activity. The code to calculate the next url was there but the calculated url wasn't being returned to the Action class.

    • -1
    • +1
    ./lams/learning/web/util/ActivityMapping.java
Learner stylesheet was always RTL - now detects whether it should be RTL or LTR and gets the right styleheet.

tools export page utf8 encoding + css bundler update to include rtl styles for rtl locale/lang

  1. … 5 more files in changeset.
LDEV-988: Made the GroupingAction page handle both doing a grouping and going back to the screen later via the progress bar. To do this I had to make change performGrouping so it checks if the grouping has been done before trying to do it. Also changed the completeActivity to move the logic that closes the popup window to completeActivity rather than completeToolSession - now it is called for system tools like grouping as well as the normal tools.

    • -1
    • +1
    ./lams/learning/web/action/GateAction.java
    • -39
    • +18
    ./lams/learning/web/action/GroupingAction.java
fixed learner - double click on grouping activity + fixed casting error

    • -1
    • +1
    ./lams/learning/web/util/ActivityMapping.java
  1. … 2 more files in changeset.
Avoiding a potential null ptr exception, although not sure why we ever end up with no forward!

Fixing the probem breaking out of a parallel activity within an optional activity. Rather than trying to fix it in the web layer, I've changed the progress engine so that as it processes up the hierarchy of complex activityes, it sets any completed complex activities to be the previous activity. Then the web layer works correctly.

    • -9
    • +0
    ./lams/learning/web/form/ActivityForm.java
  1. … 1 more file in changeset.
Fixed up code for css handling when using http save.

fixed for finishing optional act when inside parallel act frame

  1. … 1 more file in changeset.
fixed escaping from parallel frames when running parallel act as an option in optional activity ldev-817

    • -0
    • +10
    ./lams/learning/web/form/ActivityForm.java
    • -6
    • +15
    ./lams/learning/web/util/ActivityMapping.java
  1. … 1 more file in changeset.
No longer used - needed for initial development

Added comments on some potential synchronisation, to avoid issues when tools call completeToolSession twice in a short time.

journal entries page for teachers - accessible from Monitor (learners tab)

    • -2
    • +71
    ./lams/learning/web/action/NotebookAction.java
  1. … 15 more files in changeset.
my notes - add/edit/view notes/journal entries

    • -6
    • +81
    ./lams/learning/web/action/NotebookAction.java
  1. … 13 more files in changeset.
Added "copy-tags" to the build to make it easier to update the tags. Updated the jsp pages to support stripes and the separate learner stylesheet.

  1. … 269 more files in changeset.
notebook view all page (popup jsp) + add notebook entry or journal (not quite ready) (popup jsp)

    • -0
    • +164
    ./lams/learning/web/action/NotebookAction.java
  1. … 15 more files in changeset.