Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDEV-3514: Wrap all transactional methods with TransactionRetryInterceptor. Set number of attempts to 3. Remove previous safety mechanism for completeActivity() method.

  1. … 41 more files in changeset.
LDEV-3505: Try completing an activity 3 times before giving up.

LDEV-3505: Try completing an activity 3 times before giving up.

LDEV-3406: Send and process a different HTTP code when a learner did not finish the lesson yet.

  1. … 2 more files in changeset.
LDEV-3406: Send and process a different HTTP code when a learner did not finish the lesson yet.

  1. … 2 more files in changeset.
LDEV-3404: Check if export portfolion for learner is enabled only if user is learner.

LDEV-3404: Check if export portfolion for learner is enabled only if user is learner.

LDEV-3315, LDEV-3367: Refactor SecurityService methods. Replace Monitoring and Gradebook own security code with SecurityService checks.

  1. … 17 more files in changeset.
LDEV-3315, LDEV-3367: Refactor SecurityService methods. Replace Monitoring and Gradebook own security code with SecurityService checks.

  1. … 19 more files in changeset.
LDEV-3315: Add security service and use it in vital entry points.

  1. … 13 more files in changeset.
LDEV-3332: revert spring-beans schema declaration in application context xml files. export spring meta-inf in jboss-deployment-structure.xml

It is way more elegant approach to fix an issue with spring-beans.xsd loading from internet.

  1. … 77 more files in changeset.
LDEV-3332: fix spring contexts declaration to find spring-beans-4.0.xsd locally at classpath.

Having spring module defined as a set of spring jars (as we do have in Wildfly), it is impossible for spring to resolve xsd schema mapping file 'spring.schemas' correctly. With set of jars, we have 5 instances of this file (with different content) under the same path 'META-INF/spring.schemas'. This ended up in spring not beeing able to map spring-beans-4.0.xsd URL path to local resource location. Finally, this xsd was loaded from internet - and that significantly slowed Wildfly startup.

With this fix LAMS is way (depends on internet connection) faster to start.

  1. … 76 more files in changeset.
LDEV-3315: Add security service and use it in vital entry points.

  1. … 11 more files in changeset.
LDEV-3315: Clean up roles and paths to secured resources in all modules. Remove AUTHOR ADMIN role.

  1. … 72 more files in changeset.
LDEV-3315: Clean up roles and paths to secured resources in all modules.

  1. … 38 more files in changeset.
LDEV-3286 audit log when marks are released

  1. … 5 more files in changeset.
LDEV-3283: Check user on lesson join and export portfolio.

LDEV-3293: Rewrite Application Context configuration files for Spring 4.

  1. … 78 more files in changeset.
LDEV-3286 audit log mark changes done in gradebook

  1. … 6 more files in changeset.
LDEV-3283: Check user priviledges before exporting portfolio.

LDEV-3283: Check lesson state on learner join.

LDEV-3283: Check user on lesson join.

LDEV-3026: Skip last-ness checking if the user who is displaying progress (Monitor) is not the one who took the lesson (Learner).

LDEV-3215 Proper handling and message in case of Activity requires existing grouping but no group for user exists yet.

  1. … 8 more files in changeset.
LDEV-3207: Remove unused columns for setting absolute open & close gate times.

  1. … 12 more files in changeset.
LDEV-3207: Add support for Schedule Gate based on activity completion. Fix bugs in Flashless Authoring LD save.

  1. … 24 more files in changeset.
LDEV-3179: Make export portfolio unavailable to learners by default. Make this option honoured by Learner interface. Remove unnecessary code.

  1. … 4 more files in changeset.
LDEV-3147 Simplify tools: get rid of instructions tab, define in monitor and offline activity options

  1. … 70 more files in changeset.
LDEV-3163: Make LAMS use ServerURL when providing URLs.

  1. … 39 more files in changeset.
LKC-40: Synchronise calls to the same activity and attempt to create a session, if it does not exist. Even though the method creating sessions in LamsCoreToolService is synchronised, subsequent reads from DB are (probably) dirty, i.e. they show that session does not exist while it is already there, created by another, isolated transaction. Reattempting session creation from within transaction not only is broken (because of the dirty reads) but also does not make sense, because if the session already exists, there is no point in repeating a failed attempt to create it. The synchronisation code prevents threads from creating sessions at the same time and even if anything happens, allows an user to carry on.