lams-github

lams_learning

Clone Tools

Stats

Commits this week: 0
Total Committers: 28
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 18 Dec 2021
12:29 am

Marcin Cieslak

LDEV-5155 Escape rubrics text as it breaks authoring

Options
    • -1
    • +3
    ./web/WEB-INF/tags/AuthoringRatingAllStyleCriteria.tag
  2. … 32 more files in changeset.
Thursday 09 Dec 2021
1:45 am

Marcin Cieslak

LDEV-5268 Add max word limit to CKEditor tag

Options
    • -4
    • +20
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 32 more files in changeset.
Sunday 05 Dec 2021
5:09 pm

Marcin Cieslak

LDEV-4644 Use [] instead of () to recognise LO code

Teachers tend to use () as a part of Learning Outcome name

Options
    • -1
    • +1
    ./web/WEB-INF/tags/OutcomeAuthor.tag
  2. … 34 more files in changeset.
Tuesday 30 Nov 2021
5:18 am

Marcin Cieslak

LDEV-5259 Manually create parent application context

Previous attempt to reproduce BeanFactoryLocater was an overkill. A

simple singleton parent application context is sufficient.

Options
    • -13
    • +0
    ./web/WEB-INF/web.xml
  2. … 45 more files in changeset.
4:10 am

Marcin Cieslak

LDEV-5259 Use MVC initialisation via annotation

Manually triggering controller scanning by adding an annotation handler

bean does not register all useful support beans. If

<mvc:annotation-driven> is used in spring-servlet.xml, all support beans

are registered via WebMvcConfigurer.

<mvc:path-matching suffix-pattern="true" /> need to be added because we

use .do suffix for Spring actions and suffix was turned off for Spring

5.3

https://github.com/spring-projects/spring-framework/issues/24179

Options
    • -11
    • +14
    ./web/WEB-INF/spring-servlet.xml
  2. … 51 more files in changeset.
Tuesday 23 Nov 2021
7:24 pm

Marcin Cieslak

LDEV-5259 Manually start controller annotation detection

Options
    • -4
    • +4
    ./web/WEB-INF/spring-servlet.xml
  2. … 38 more files in changeset.
7:23 pm

Marcin Cieslak

LDEV-5259 Reintroduce BeanFactoryLocator mechanism back to LAMS

It was removed for Spring 5

Options
    • -1
    • +1
    ./web/WEB-INF/web.xml
  2. … 58 more files in changeset.
Thursday 11 Nov 2021
2:36 am

Marcin Cieslak

LDEV-5257 Secure fileDownloadToken cookie

Options
    • -13
    • +5
    ./src/java/org/lamsfoundation/lams/learning/kumalive/KumaliveController.java
  2. … 9 more files in changeset.
Monday 18 Oct 2021
10:32 pm

Marcin Cieslak

LDEV-4411 Make relation from Evaluation to ToolActivity unidirectional

Hibernate can not lazy load properties connected with OneToOne

relationship. It means that with every fetch of ToolActivity its

ActivityEvaluation was also fetched, whether is was needed or not. It

made up even 10% of all queries sent to DB during a lesson.

By having the relationship unidirectional and fetching

ActivityEvaluation via DAO we ensure that it is fetched only when it is

needed. The code is not as nice, though.

Options
    • -2
    • +7
    ./src/java/org/lamsfoundation/lams/learning/service/LearnerService.java
  2. … 13 more files in changeset.
Friday 24 Sep 2021
3:50 pm

Marcin Cieslak

LDEV-5248, LDEV-4411 Mark some queries as cacheable

Query cache makes sense if tables which the query reference does not

change often. Each modification to table content invalidates the given

query's cache. Also each set of query parameters is a different cache

entry, so if there are various parameter values the cache overhead can

generate more load than benefit.

Options
    • -7
    • +7
    ./src/java/org/lamsfoundation/lams/learning/kumalive/dao/hibernate/KumaliveDAO.java
  2. … 96 more files in changeset.
Saturday 11 Sep 2021
5:46 pm

Marcin Cieslak

LDEV-5247 Fix user name parameter sent to Etherpad

LAMS allows apostrophes but not quotation marks in names, so it is safer

to use quotations when operating with javascript.

Options
    • -1
    • +1
    ./web/WEB-INF/tags/Etherpad.tag
  2. … 33 more files in changeset.
Friday 13 Aug 2021
4:48 pm

Marcin Cieslak

LDEV-5155 Highlight rubrics row title

Make it more distinguished from selectable options in next columns

Options
    • -0
    • +4
    ./web/WEB-INF/tags/StyledRating.tag
  2. … 33 more files in changeset.
Thursday 12 Aug 2021
8:55 pm

Marcin Cieslak

LDEV-5155 Allow free flow of rubrics columns

Trying to calculate their width actually yields worse results.

Options
    • -4
    • +4
    ./web/WEB-INF/tags/StyledRating.tag
  2. … 33 more files in changeset.
9:10 am

Ernie Ghiglione

LDEV-4769 Updating Greek, English, Spanish, Norwegian

Options
    • -0
    • +3
    ./conf/language/lams/ApplicationResources_es_ES.properties
  2. … 17 more files in changeset.
Saturday 24 Jul 2021
4:22 pm

Marcin Cieslak

LDEV-5223 Prevent ep_resize from rendering short initial Etherpad

Options
    • -2
    • +1
    ./web/WEB-INF/tags/Etherpad.tag
  2. … 34 more files in changeset.
Thursday 22 Jul 2021
7:28 pm

Marcin Cieslak

LDEV-5220 Distribute the new popover tag

Options
    • -0
    • +31
    ./web/WEB-INF/tags/Popover.tag
    • -0
    • +4
    ./web/WEB-INF/tlds/lams/lams.tld
  3. … 62 more files in changeset.
6:52 pm

Marcin Cieslak

LDEV-5223 Fix Etherpad resizing

Options
    • -1
    • +1
    ./web/WEB-INF/tags/Etherpad.tag
  2. … 33 more files in changeset.
12:45 pm

Ernie Ghiglione

LDEV-4769 Updating Greek, English, Spanish, Norwegian

Options
    • -3
    • +3
    ./conf/language/lams/ApplicationResources.properties
    • -0
    • +3
    ./conf/language/lams/ApplicationResources_el_GR.properties
    • -0
    • +3
    ./conf/language/lams/ApplicationResources_en_AU.properties
  4. … 12 more files in changeset.
Friday 16 Jul 2021
12:39 pm

Marcin Cieslak

LDEV-5219 Fix gate flow for optional branching

Options
    • -4
    • +3
    ./src/java/org/lamsfoundation/lams/learning/service/LearnerService.java
12:21 am

Marcin Cieslak

LDEV-5219 Use versioned JS import for gate check JS file

Options
    • -1
    • +1
    ./web/grouping/show.jsp
    • -1
    • +1
    ./web/optionsActivity.jsp
  3. … 54 more files in changeset.
12:13 am

Marcin Cieslak

LDEV-5219 Check gate after Optional Branching activity

Options
    • -13
    • +7
    ./src/java/org/lamsfoundation/lams/learning/service/LearnerService.java
12:08 am

Marcin Cieslak

LDEV-5219 Check gate after Grouping activity

Options
    • -2
    • +7
    ./web/grouping/show.jsp
12:07 am

Marcin Cieslak

LDEV-5219 Check gate after Optional activity

Options
    • -3
    • +8
    ./web/optionsActivity.jsp
12:07 am

Marcin Cieslak

LDEV-5219 Use activity ID instead of lesson ID for non-tools

Options
    • -5
    • +13
    ./src/java/org/lamsfoundation/lams/learning/service/LearnerService.java
    • -4
    • +4
    ./src/java/org/lamsfoundation/lams/learning/web/controller/LearnerController.java
    • -2
    • +2
    ./web/includes/javascript/gate-check.js
  4. … 1 more file in changeset.
Wednesday 14 Jul 2021
1:00 am

Marcin Cieslak

LDEV-5219 Skip gate check in preview lessons

Options
    • -1
    • +5
    ./src/java/org/lamsfoundation/lams/learning/service/LearnerService.java
Tuesday 13 Jul 2021
6:09 pm

Marcin Cieslak

LDEV-5219 Get user from session instead of parameter

Options
    • -3
    • +9
    ./src/java/org/lamsfoundation/lams/learning/web/controller/LearnerController.java
    • -2
    • +2
    ./web/includes/javascript/gate-check.js
  3. … 4 more files in changeset.
6:01 pm

Marcin Cieslak

LDEV-5219 Adjust gate check JS code for <a> tags

Options
    • -4
    • +9
    ./web/includes/javascript/gate-check.js
5:19 pm

Marcin Cieslak

LDEV-5219 Allow gate check after branching activity

Options
    • -0
    • +9
    ./src/java/org/lamsfoundation/lams/learning/service/LearnerService.java
5:07 pm

Marcin Cieslak

LDEV-5219 Move next-gate check to learner module

It will be used in various tools so we need a central place to keep the

code.

Options
    • -0
    • +65
    ./web/includes/javascript/gate-check.js
  2. … 1 more file in changeset.
4:15 pm

Marcin Cieslak

LDEV-5219 Display customised messages for various gate types

Move i18n labels from tool to Learning module so they are the same for

all tools.

Options
    • -0
    • +3
    ./conf/language/lams/ApplicationResources.properties
    • -9
    • +7
    ./src/java/org/lamsfoundation/lams/learning/service/LearnerService.java
    • -5
    • +49
    ./src/java/org/lamsfoundation/lams/learning/web/controller/LearnerController.java
  4. … 8 more files in changeset.