lams-github

lams_tool_assessment

Clone Tools

Stats

Commits this week: 0
Total Committers: 20
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 18 Dec 2021
9:12 pm

Marcin Cieslak

LDEV-5271 Refactor code for checking if VS answer was allocated

Options
    • -25
    • +14
    ./src/java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java
    • -4
    • +14
    ./src/java/org/lamsfoundation/lams/tool/assessment/util/AssessmentEscapeUtils.java
8:52 pm

Marcin Cieslak

LDEV-5271 Correctly remove answer from previously allocated option

Options
    • -47
    • +22
    ./src/java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java
    • -1
    • +2
    ./src/java/org/lamsfoundation/lams/tool/assessment/util/AssessmentEscapeUtils.java
8:37 pm

Marcin Cieslak

LDEV-5271 Do not normalise VSA answer twice

Options
    • -14
    • +2
    ./src/java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java
12:29 am

Marcin Cieslak

LDEV-5155 Escape rubrics text as it breaks authoring

Options
    • -1
    • +3
    ./web/WEB-INF/tags/AuthoringRatingAllStyleCriteria.tag
  2. … 32 more files in changeset.
Saturday 11 Dec 2021
3:35 pm

Ernie Ghiglione

LDEV-5268 Remove table hover as it ain't need it

Options
    • -1
    • +1
    ./web/pages/learning/parts/essay.jsp
3:35 pm

Ernie Ghiglione

LDEV-5268 Remove table hover as it ain't need it

Options
    • -1
    • +1
    ./web/pages/learning/parts/essay.jsp
Friday 10 Dec 2021
9:41 pm

Marcin Cieslak

LDEV-5268 Merge 4.5 into 4.6

Options
    • -0
    • +1
    ./conf/language/lams/ApplicationResources.properties
  2. … 4 more files in changeset.
Thursday 09 Dec 2021
7:58 pm

Marcin Cieslak

LDEV-5268 Improve word count detection in essay questions

Options
    • -2
    • +9
    ./web/pages/learning/parts/essay.jsp
2:18 am

Marcin Cieslak

LDEV-5268 Add word counter to CKEditor essay question

Also improve warning message for plain text area.

Options
    • -38
    • +57
    ./web/pages/learning/parts/essay.jsp
1:45 am

Marcin Cieslak

LDEV-5268 Prevent learners from entering more than max words in essay

Options
    • -0
    • +1
    ./conf/language/lams/ApplicationResources.properties
    • -37
    • +14
    ./web/pages/learning/learning.jsp
    • -1
    • +1
    ./web/pages/learning/parts/allquestions.jsp
    • -45
    • +45
    ./web/pages/learning/parts/essay.jsp
1:45 am

Marcin Cieslak

LDEV-5268 Add max word limit to CKEditor tag

Options
    • -4
    • +20
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 32 more files in changeset.
Monday 06 Dec 2021
8:36 am

Ernie Ghiglione

LDEV-4769 Updating Simplified Chinese and English

Options
    • -1
    • +1
    ./conf/language/lams/ApplicationResources.properties
    • -0
    • +1
    ./conf/language/lams/ApplicationResources_en_AU.properties
    • -0
    • +1
    ./conf/language/lams/ApplicationResources_es_ES.properties
  4. … 1 more file in changeset.
Sunday 05 Dec 2021
5:33 pm

Marcin Cieslak

LDEV-4271 Give correct feedback only on 100% correct order

Till now if order was incorrect but some items were in their correct

places, even by a chance, learner would get correct feedback.

Options
    • -1
    • +1
    ./web/pages/learning/results/ordering.jsp
5:09 pm

Marcin Cieslak

LDEV-4644 Use [] instead of () to recognise LO code

Teachers tend to use () as a part of Learning Outcome name

Options
    • -1
    • +1
    ./web/WEB-INF/tags/OutcomeAuthor.tag
  2. … 34 more files in changeset.
Saturday 04 Dec 2021
10:45 pm

Marcin Cieslak

LDEV-5260 Add utility class for global Flux management

Options
    • -1
    • +6
    ./src/java/org/lamsfoundation/lams/tool/assessment/AssessmentConstants.java
    • -15
    • +9
    ./src/java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java
  3. … 3 more files in changeset.
5:39 pm

Marcin Cieslak

LDEV-5260 Improve Flux cancellation mechanism

Options
    • -5
    • +5
    ./src/java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java
  2. … 2 more files in changeset.
8:21 am

Marcin Cieslak

LDEV-5260 Rewrite polling to producer-subscriber model

Till now we had "are-learners-answers-updated" polling on controller

level.

It was rewritten to following scenario:

- method which stores learner answers is aware whether answers have

changed, i.e. it knows if charts need to be updated

- it flushes latest data to DB and puts tool content ID to Sink

- Sink notifies all interested Fluxes (currently only charts updating

one, but in the future other ones like updating table with answer % too)

- FluxMap holds a map of tool content ID -> interested hot publisher

Flux

- the Flux checks if it is interested in the tool content ID from the

Sink

- if so, it fetches data from DB and emits it to all subscribers, i.e.

opened monitoring windows with charts displayed

- data is cached so it is immediately available on for the next

subscriber

- data is throttled so calls to DB are not made too often

- if all subscribers are gone, the hot publisher Flux is still active; a

timeout is added which removes it from FluxMap when there were not emits

for the given time

Options
    • -10
    • +48
    ./src/java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java
    • -1
    • +3
    ./src/java/org/lamsfoundation/lams/tool/assessment/service/IAssessmentService.java
    • -43
    • +3
    ./src/java/org/lamsfoundation/lams/tool/assessment/web/controller/MonitoringController.java
    • -1
    • +4
    ./web/includes/javascript/chart.js
  5. … 3 more files in changeset.
Friday 03 Dec 2021
6:27 pm

Marcin Cieslak

LDEV-5260 Emit chart update only when new data is available

Options
    • -0
    • +14
    ./src/java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java
    • -0
    • +2
    ./src/java/org/lamsfoundation/lams/tool/assessment/service/IAssessmentService.java
    • -2
    • +6
    ./src/java/org/lamsfoundation/lams/tool/assessment/web/controller/MonitoringController.java
7:06 am

Marcin Cieslak

LDEV-5260 Skip Flux retransmissions if data has not changed

Options
    • -1
    • +1
    ./src/java/org/lamsfoundation/lams/tool/assessment/web/controller/MonitoringController.java
7:06 am

Marcin Cieslak

LDEV-5260 Use WildFly task executor for Spring async request processing

Options
    • -2
    • +4
    ./web/WEB-INF/spring-servlet.xml
  2. … 1 more file in changeset.
6:35 am

Marcin Cieslak

LDEV-5260 Rewrite test implementation using Reactor Flux instead of SSE

Options
    • -38
    • +12
    ./src/java/org/lamsfoundation/lams/tool/assessment/web/controller/MonitoringController.java
Tuesday 30 Nov 2021
6:57 am

Marcin Cieslak

LDEV-5260 Initial implementation of EventSource-powered chart

Options
    • -3
    • +50
    ./src/java/org/lamsfoundation/lams/tool/assessment/web/controller/MonitoringController.java
    • -1
    • +14
    ./web/WEB-INF/web.xml
    • -22
    • +7
    ./web/includes/javascript/chart.js
5:18 am

Marcin Cieslak

LDEV-5259 Manually create parent application context

Previous attempt to reproduce BeanFactoryLocater was an overkill. A

simple singleton parent application context is sufficient.

Options
    • -8
    • +0
    ./web/WEB-INF/web.xml
  2. … 45 more files in changeset.
4:10 am

Marcin Cieslak

LDEV-5259 Use MVC initialisation via annotation

Manually triggering controller scanning by adding an annotation handler

bean does not register all useful support beans. If

<mvc:annotation-driven> is used in spring-servlet.xml, all support beans

are registered via WebMvcConfigurer.

<mvc:path-matching suffix-pattern="true" /> need to be added because we

use .do suffix for Spring actions and suffix was turned off for Spring

5.3

https://github.com/spring-projects/spring-framework/issues/24179

Options
    • -8
    • +11
    ./web/WEB-INF/spring-servlet.xml
  2. … 51 more files in changeset.
12:51 am

Marcin Cieslak

LDEV-5230 Add missing VSA label

Options
    • -0
    • +1
    ./conf/language/lams/ApplicationResources.properties
12:41 am

Marcin Cieslak

LDEV-4762 Fix saving option order in ordering question

TreeSet.addAll() seems not to work correctly in some cases

https://bugs.java.com/bugdatabase/view_bug.do?bug_id=6385838

Options
    • -4
    • +4
    ./src/java/org/lamsfoundation/lams/tool/assessment/web/controller/LearningController.java
Saturday 27 Nov 2021
3:09 pm

Marcin Cieslak

LDEV-5261 Fix popovers in QB and Assessment question stats

Options
    • -23
    • +7
    ./web/pages/monitoring/statisticpart.jsp
  2. … 2 more files in changeset.
Wednesday 24 Nov 2021
2:24 am

Marcin Cieslak

LDEV-5125 Improve support for VSA questions import from Word file

VSA questions should have 2 options if they are going to be TBL

compatible. When importing from Word document only correct answers

option is required. The other one, incorrect answers option, now gets

added automatically. Also incorrect answers option does not get deleted

after editing via QB interface.

Options
    • -2
    • +3
    ./src/java/org/lamsfoundation/lams/tool/assessment/util/AssessmentEscapeUtils.java
  2. … 3 more files in changeset.
Tuesday 23 Nov 2021
7:24 pm

Marcin Cieslak

LDEV-5259 Manually start controller annotation detection

Options
    • -10
    • +11
    ./web/WEB-INF/spring-servlet.xml
  2. … 38 more files in changeset.
7:23 pm

Marcin Cieslak

LDEV-5259 Reintroduce BeanFactoryLocator mechanism back to LAMS

It was removed for Spring 5

Options
    • -1
    • +1
    ./web/WEB-INF/web.xml
  2. … 58 more files in changeset.