lams-github

lams_tool_forum

Clone Tools

Stats

Commits this week: 0
Total Committers: 29
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 31 Dec 2010
9:08 pm

Andrey Balan

LDEV-1743 fixing the problem with messages having the same sequence_id

*merge from lams2_3_release

Options
    • -1
    • +1
    ./src/java/org/lamsfoundation/lams/tool/forum/dbupdates/patch20100303_updateTo24.sql
Sunday 12 Dec 2010
10:44 pm

Marcin Cieslak

LDEV-2577: Fixed a bug - the response after ajaxSubmit was trimmed improperly, leaving unnecessary code on the top. Also added missing label.

Options
    • -1
    • +1
    ./conf/language/lams/ApplicationResources.properties
    • -1
    • +4
    ./web/jsps/authoring/pedagogicalPlannerForm.jsp
  3. … 7 more files in changeset.
10:31 pm

Marcin Cieslak

LDEV-2577: Fixed a bug preventing multiple CKEditor instances on one page to be properly reinitialized after form submit.

Options
    • -7
    • +14
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 27 more files in changeset.
Wednesday 08 Dec 2010
4:02 am

Andrey Balan

LDEV-2618 fixing "Unable to find 'success' forward" warning

*merge from lams2_3_release

Options
    • -47
    • +21
    ./src/java/org/lamsfoundation/lams/tool/forum/web/actions/MonitoringAction.java
Monday 06 Dec 2010
4:52 am

Marcin Cieslak

LDEV-2577: Added extra safety measure preventing plain textarea from being show instead of CKEditor instance.

Options
    • -1
    • +1
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 27 more files in changeset.
Tuesday 30 Nov 2010
12:15 am

Andrey Balan

LDEV-2612 fixed Forum problems on upgrade

*merge from lams2_3_release

Options
    • -2
    • +2
    ./src/java/org/lamsfoundation/lams/tool/forum/dbupdates/patch20101025_updateTo24.sql
Thursday 25 Nov 2010
5:20 pm

Andrey Balan

LDEV-2549 delete unnecesary conditions from DB and update condition's sequenceId every time we do this

*merge from lams2_3_release

Options
    • -7
    • +15
    ./src/java/org/lamsfoundation/lams/tool/forum/web/actions/AuthoringAction.java
  2. … 2 more files in changeset.
Wednesday 24 Nov 2010
10:35 pm

Andrey Balan

LDEV-2605 fixing output factories so that tool doesn't throw exception when no conditions

*merge from lams2_3_release

Options
    • -6
    • +12
    ./src/java/org/lamsfoundation/lams/tool/forum/service/ForumOutputFactory.java
  2. … 1 more file in changeset.
2:36 am

Marcin Cieslak

LDEV-2607: Hardcoded CKEditor width as a fix for Chrome inability to process "100%" width correctly.

Options
    • -1
    • +1
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 26 more files in changeset.
Monday 22 Nov 2010
3:13 pm

Marcin Cieslak

LDEV-2577: Set default height for CKEditor instances, as in IE it was minimal.

Options
    • -0
    • +4
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 27 more files in changeset.
Saturday 20 Nov 2010
6:25 am

Andrey Balan

LDEV-2608 fixed problem with first time user

Options
    • -0
    • +2
    ./src/java/org/lamsfoundation/lams/tool/forum/web/actions/AuthoringAction.java
3:08 am

Andrey Balan

LDEV-2608 fixed Adding new topics in monitor doesn't affects the topics in learner

Options
    • -0
    • +1
    ./src/java/org/lamsfoundation/lams/tool/forum/service/ForumService.java
    • -0
    • +2
    ./src/java/org/lamsfoundation/lams/tool/forum/util/ForumConstants.java
    • -1
    • +16
    ./src/java/org/lamsfoundation/lams/tool/forum/web/actions/AuthoringAction.java
Thursday 18 Nov 2010
11:34 pm

Andrey Balan

LDEV-2609 fixed error on replying to a message in learner

Options
    • -0
    • +1
    ./src/java/org/lamsfoundation/lams/tool/forum/forumApplicationContext.xml
9:20 pm

Andrey Balan

LDEV-2545 updating summary page in monitoring

*merge from lams2_3_release

Options
    • -0
    • +34
    ./web/jsps/monitoring/summary.jsp
6:28 am

Marcin Cieslak

LDEV-2595: As CSS parameter "display: none" does not work in IE, the initial textarea for CKEditor has height = 0px which does the trick instead.

Options
    • -1
    • +1
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 27 more files in changeset.
Tuesday 16 Nov 2010
1:49 am

Andrey Balan

LDEV-2551 fixing 2 problems: - when lesson gets created not all MessageSeq objects were stored in DB - Message's cascade="all-delete-orphan" Hibernate setting which prevented deletion of topics

*merge from lams2_3_release

Options
    • -1
    • +1
    ./conf/hibernate/mappings/org/lamsfoundation/lams/tool/forum/persistence/Message.hbm.xml
    • -1
    • +1
    ./src/java/org/lamsfoundation/lams/tool/forum/persistence/Message.java
    • -2
    • +11
    ./src/java/org/lamsfoundation/lams/tool/forum/service/ForumService.java
Friday 05 Nov 2010
4:24 am

Marcin Cieslak

LDEV-2596: Forcing CKEditor be reinitialized after AJAX form submit.

Options
    • -17
    • +27
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 28 more files in changeset.
Thursday 28 Oct 2010
6:05 pm

erniegx <ernieg@gmail.com>

Updating English, Spanish(ES)

Options
    • -40
    • +48
    ./conf/language/lams/ApplicationResources.properties
    • -39
    • +48
    ./conf/language/lams/ApplicationResources_en_AU.properties
    • -54
    • +63
    ./conf/language/lams/ApplicationResources_es_ES.properties
5:58 pm

erniegx <ernieg@gmail.com>

Updating German

Options
    • -11
    • +59
    ./conf/language/lams/ApplicationResources_de_DE.properties
5:57 pm

erniegx <ernieg@gmail.com>

Adding Spanish Mexico

Options
    • -0
    • +221
    ./conf/language/lams/ApplicationResources_es_MX.properties
5:52 pm

erniegx <ernieg@gmail.com>

Adding Slovenian, Catalan

Options
    • -0
    • +221
    ./conf/language/lams/ApplicationResources_ca_ES.properties
    • -0
    • +221
    ./conf/language/lams/ApplicationResources_sl_SI.properties
3:07 pm

Andrey Balan

LDEV-1743 fixing problem with NULL sequence_id

*merge from lams2_3_release

Options
    • -1
    • +2
    ./src/java/org/lamsfoundation/lams/tool/forum/dbupdates/patch20100303_updateTo24.sql
1:27 am

Andrey Balan

LDEV-2545 Deliver email messages to students/teachers on forum postings

*merge from lams2_3_release

Options
    • -1
    • +1
    ./build.properties
    • -0
    • +16
    ./conf/hibernate/mappings/org/lamsfoundation/lams/tool/forum/persistence/Forum.hbm.xml
    • -2
    • +4
    ./db/sql/create_lams_tool_forum.sql
    • -0
    • +14
    ./src/java/org/lamsfoundation/lams/tool/forum/dbupdates/patch20101025_updateTo24.sql
    • -0
    • +6
    ./src/java/org/lamsfoundation/lams/tool/forum/forumApplicationContext.xml
    • -1
    • +29
    ./src/java/org/lamsfoundation/lams/tool/forum/persistence/Forum.java
    • -0
    • +55
    ./src/java/org/lamsfoundation/lams/tool/forum/service/ForumService.java
    • -0
    • +2
    ./src/java/org/lamsfoundation/lams/tool/forum/service/IForumService.java
    • -1
    • +8
    ./src/java/org/lamsfoundation/lams/tool/forum/web/actions/LearningAction.java
    • -0
    • +16
    ./web/jsps/authoring/advance.jsp
Sunday 24 Oct 2010
9:39 pm

Marcin Cieslak

LDEV-2577: Readded videorecorder plugin. Readded missing contentFolderID parameter to CKEditor instances.

Options
    • -1
    • +2
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 36 more files in changeset.
Friday 22 Oct 2010
2:57 am

Marcin Cieslak

LDEV-2577, LDEV-2588: Fixed names of buttons that have changed from FCKEditor. CKEditor are hidden until they are completely initialized.

Options
    • -1
    • +1
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 24 more files in changeset.
Sunday 10 Oct 2010
7:48 pm

Marcin Cieslak

LDEV-2577: Removed quotation marks on "displayExpanded" option so it gets parsed correctly.

Options
    • -1
    • +1
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 27 more files in changeset.
Wednesday 06 Oct 2010
6:18 pm

Marcin Cieslak

LDEV-2577 The new CKEditor does not have Java Integration library (yet). We have been using it to: a) get the tag library to create our own tag <lams:FCKeditor> But the new CKEditor uses AJAX to get the contents, so the library is not needed anymore. The references to it has been deleted from every tool. FCKEditor.tag has been rewritten to use the new syntax. b) get a FCKEditor internal file manager by a Connector from the jar The new CKEditor does not provide a file manager - the license became commercial and the whole thing became a separate project, CKFinder. There were alternatives suggested on the web: jasfinder - http://sourceforge.net/projects/jasfinder/support kcfinder - http://kcfinder.sunhater.com/ some other - http://www.miguelmanchego.com/2009/gestor-de-archivos-ckeditor/ but we have already nicely integrated with the old file manager. This page: http://jacek-kromski.jogger.pl/2009/09/25/integracja-ckeditor-z-przegladarka-plikow-z-fckeditor/ in polish says how to use the file manager from the old FCKEditor. The steps that have to be done: - download the new CKEditor - download the old FCKEditor - copy the filemanager to ckeditor directory - in the file browser/default/frmresourceslist.html, line 92 (with SetUrl call) needs to be replaced to: window.top.opener.CKEDITOR.tools.callFunction( window.top.document.CKEditorFuncNum, fileUrl, '' ); - in the file browser/default/browser.html add in line 80: document.CKEditorFuncNum = GetUrlParam( 'CKEditorFuncNum');

FCKeditor has been used in version 2.6.6, the last one before switching to CKEditor project.

Changes required to use newer version of Java Integration library

for FCKEditor so it was upgraded to the latest (for FCKEditor, because one for CKEditor does not exist) version 2.6.

This also required the Prototype to be upgraded to the latest 1.6.1.

The CKEditor code also needed to be changed, so if another upgrade to a newer version occurs, we need to remember to repeat these steps:

http://cksource.com/forums/viewtopic.php?f=5&t=15750

It says:

/ckeditor/plugins/link/dialogs/link.js

Changes

label:a.lang.common.target,'default':'notSet' --> label:a.lang.common.target,'default':'_blank'

label:a.lang.link.targetFrameName,'default':'' --> label:a.lang.link.targetFrameName,'default':'_blank'

It is also worth mentioning that if you include the ckeditor.js file twice in the same page, sometimes it causes trouble, thus detection in the CKEditor.tag files.

Options
    • -1
    • +0
    ./build.xml
    • -1
    • +1
    ./conf/xdoclet/servlet-mappings.xml
    • -9
    • +1
    ./conf/xdoclet/taglibs.xml
    • -88
    • +91
    ./test/java/org/lamsfoundation/lams/tool/forum/selenium/TestForum.java
    • -129
    • +0
    ./web/WEB-INF/fckeditor/tlds/FCKeditor.tld
    • -2
    • +2
    ./web/WEB-INF/lams.tld
    • -16
    • +18
    ./web/WEB-INF/struts-config.xml
    • -0
    • +53
    ./web/WEB-INF/tags/CKEditor.tag
    • -54
    • +0
    ./web/WEB-INF/tags/FCKEditor.tag
    • -1
    • +1
    ./web/common/taglibs.jsp
    • -1
    • +1
    ./web/includes/taglibs.jsp
    • -2
    • +2
    ./web/jsps/authoring/basic.jsp
    • -2
    • +2
    ./web/jsps/authoring/message/create.jsp
    • -2
    • +2
    ./web/jsps/authoring/message/edit.jsp
    • -10
    • +10
    ./web/jsps/authoring/pedagogicalPlannerForm.jsp
  16. … 1082 more files in changeset.
Wednesday 14 Apr 2010
8:09 pm

Andrey Balan

LDEV-1743 adding missing js file

Options
    • -0
    • +2
    ./web/jsps/authoring/definelater.jsp
Tuesday 06 Apr 2010
1:27 am

Andrey Balan

LDEV-2546 fixing error with Deletion of topics

*merge from lams2_3_release

Options
    • -13
    • +15
    ./src/java/org/lamsfoundation/lams/tool/forum/web/actions/AuthoringAction.java
  2. … 1 more file in changeset.
Thursday 25 Mar 2010
5:32 am

Andrey Balan

LDEV-1743 * fixed problem with deletion of topics and according conditions * fixed hibernate query * fixed wrong equal check

Options
    • -1
    • +1
    ./src/java/org/lamsfoundation/lams/tool/forum/persistence/MessageDao.java
    • -32
    • +32
    ./src/java/org/lamsfoundation/lams/tool/forum/web/actions/AuthoringAction.java