lams-github

lams_tool_leader

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 23 Nov 2021
12:24 pm

Marcin Cieslak

LDEV-5259 Manually start controller annotation detection

Options
    • -4
    • +4
    ./web/WEB-INF/spring-servlet.xml
  2. … 38 more files in changeset.
12:23 pm

Marcin Cieslak

LDEV-5259 Reintroduce BeanFactoryLocator mechanism back to LAMS

It was removed for Spring 5

Options
    • -1
    • +1
    ./web/WEB-INF/web.xml
  2. … 58 more files in changeset.
Thursday 07 Oct 2021
10:44 am

Marcin Cieslak

LDEV-4411 Stop using collection cache for now

Cache annotations were commented out so we can come back to them easily

in the future.

Collection cache is not detecting changes made to entities. When a new

entity is added, collection cache does not see the change.

Properly tweaking concurrency strategy does not seem possible at the

moment, so we just turn it off.

Options
    • -1
    • +1
    ./src/java/org/lamsfoundation/lams/tool/leaderselection/model/Leaderselection.java
  2. … 29 more files in changeset.
Monday 27 Sep 2021
9:45 am

Marcin Cieslak

LDEV-5248, LDEV-4411 Mark some collections as cacheable

Similar to query cache, the collection cache makes sense if the table

which collection elements map to do not change often. Each modification

to table content invalidates the given collection cache.

Options
    • -5
    • +5
    ./src/java/org/lamsfoundation/lams/tool/leaderselection/model/Leaderselection.java
  2. … 31 more files in changeset.
Friday 24 Sep 2021
9:50 am

Marcin Cieslak

LDEV-5248, LDEV-4411 Mark some queries as cacheable

Query cache makes sense if tables which the query reference does not

change often. Each modification to table content invalidates the given

query's cache. Also each set of query parameters is a different cache

entry, so if there are various parameter values the cache overhead can

generate more load than benefit.

Options
    • -2
    • +1
    ./src/java/org/lamsfoundation/lams/tool/leaderselection/dao/hibernate/LeaderselectionDAO.java
    • -2
    • +1
    ./src/java/org/lamsfoundation/lams/tool/leaderselection/dao/hibernate/LeaderselectionSessionDAO.java
  3. … 95 more files in changeset.
Saturday 11 Sep 2021
11:46 am

Marcin Cieslak

LDEV-5247 Fix user name parameter sent to Etherpad

LAMS allows apostrophes but not quotation marks in names, so it is safer

to use quotations when operating with javascript.

Options
    • -1
    • +1
    ./web/WEB-INF/tags/Etherpad.tag
  2. … 33 more files in changeset.
Tuesday 31 Aug 2021
4:42 pm

Marcin Cieslak

LDEV-5229 Make previous changes to tools consistent

Options
    • -1
    • +2
    ./conf/language/lams/ApplicationResources.properties
    • -8
    • +9
    ./web/WEB-INF/tags/OutcomeAuthor.tag
  3. … 30 more files in changeset.
9:25 am

Ernie Ghiglione

LDEV-5229 Authoring popovers for leader selection

Options
    • -0
    • +1
    ./conf/language/lams/ApplicationResources.properties
    • -5
    • +9
    ./web/WEB-INF/tags/OutcomeAuthor.tag
Friday 20 Aug 2021
7:59 am

Marcin Cieslak

LDEV-5231 Sanitise Leader Selection icon

Options
    • -1
    • +1
    ./web/images/icon_leaderselection.svg
5:39 am

Ernie Ghiglione

LDEV-5231 changing icons

Options
    • binary
    ./web/images/icon_leaderselection.png
    • -1
    • +1
    ./web/images/icon_leaderselection.svg
Tuesday 17 Aug 2021
5:01 pm

Marcin Cieslak

LDEV-5143 Show all learners in group in leader selection learning UI

Even one who have not reached the leader selection activity yet.

Options
    • -0
    • +4
    ./src/java/org/lamsfoundation/lams/tool/leaderselection/service/ILeaderselectionService.java
    • -5
    • +7
    ./src/java/org/lamsfoundation/lams/tool/leaderselection/service/LeaderselectionService.java
    • -2
    • +3
    ./src/java/org/lamsfoundation/lams/tool/leaderselection/web/controller/LearningController.java
Friday 13 Aug 2021
10:48 am

Marcin Cieslak

LDEV-5155 Highlight rubrics row title

Make it more distinguished from selectable options in next columns

Options
    • -0
    • +4
    ./web/WEB-INF/tags/StyledRating.tag
  2. … 33 more files in changeset.
Thursday 12 Aug 2021
2:55 pm

Marcin Cieslak

LDEV-5155 Allow free flow of rubrics columns

Trying to calculate their width actually yields worse results.

Options
    • -4
    • +4
    ./web/WEB-INF/tags/StyledRating.tag
  2. … 33 more files in changeset.
Saturday 24 Jul 2021
10:22 am

Marcin Cieslak

LDEV-5223 Prevent ep_resize from rendering short initial Etherpad

Options
    • -2
    • +1
    ./web/WEB-INF/tags/Etherpad.tag
  2. … 34 more files in changeset.
Thursday 22 Jul 2021
1:28 pm

Marcin Cieslak

LDEV-5220 Distribute the new popover tag

Options
    • -0
    • +31
    ./web/WEB-INF/tags/Popover.tag
    • -0
    • +4
    ./web/WEB-INF/tlds/lams/lams.tld
  3. … 62 more files in changeset.
12:52 pm

Marcin Cieslak

LDEV-5223 Fix Etherpad resizing

Options
    • -1
    • +1
    ./web/WEB-INF/tags/Etherpad.tag
  2. … 33 more files in changeset.
Thursday 15 Jul 2021
6:21 pm

Marcin Cieslak

LDEV-5219 Use versioned JS import for gate check JS file

Options
    • -1
    • +1
    ./web/pages/learning/leaderselection.jsp
  2. … 55 more files in changeset.
9:21 am

Marcin Cieslak

LDEV-5219 Check gate after Leader Selection activity

Options
    • -2
    • +5
    ./web/pages/learning/leaderselection.jsp
Tuesday 06 Jul 2021
12:07 pm

Marcin Cieslak

Merge branch 'LDEV-5155' into v4.0

Options
    • -1
    • +1
    ./web/WEB-INF/tags/Page.tag
  2. … 33 more files in changeset.
Thursday 01 Jul 2021
1:02 pm

Marcin Cieslak

LDEV-5155 Add column with average rating for given rubrics row

Options
    • -2
    • +21
    ./web/WEB-INF/tags/StyledRating.tag
  2. … 31 more files in changeset.
Wednesday 30 Jun 2021
11:01 am

Marcin Cieslak

LDEV-5155 Always put rubrics column's value next to its description

Options
    • -4
    • +4
    ./web/WEB-INF/tags/StyledRating.tag
  2. … 31 more files in changeset.
9:39 am

Marcin Cieslak

LDEV-5192 Limit maximum width of tool authoring content

For rubrics we may need a wider authoring window so their text areas are

not so squeezed. But having a super wide authoring windows does not look

good either. So now we have a container-fluid class, but limited to

1400px width.

Options
    • -76
    • +319
    ./web/WEB-INF/tags/AuthoringRatingAllStyleCriteria.tag
    • -1
    • +1
    ./web/WEB-INF/tags/Page.tag
    • -0
    • +182
    ./web/WEB-INF/tags/StyledRating.tag
  4. … 92 more files in changeset.
Wednesday 23 Jun 2021
9:16 am

Marcin Cieslak

LDEV-5213 Add a missing JSTL library import

Options
    • -0
    • +1
    ./web/WEB-INF/tags/JSImport.tag
  2. … 32 more files in changeset.
Tuesday 22 Jun 2021
2:42 pm

Marcin Cieslak

LDEV-5213 Never show minus sign in hash code

Options
    • -1
    • +1
    ./web/WEB-INF/tags/JSImport.tag
  2. … 32 more files in changeset.
2:37 pm

Marcin Cieslak

LDEV-5213 Replace volatile JS imports with their non-cached version

Options
    • -1
    • +1
    ./web/WEB-INF/tags/Page.tag
  2. … 93 more files in changeset.
1:37 pm

Marcin Cieslak

LDEV-5213 Add a tag to prevent JS file caching

Options
    • -0
    • +16
    ./web/WEB-INF/tags/JSImport.tag
    • -1
    • +4
    ./web/WEB-INF/tlds/lams/lams.tld
  3. … 64 more files in changeset.
Tuesday 15 Jun 2021
12:05 am

Marcin Cieslak

LDEV-5200 Isolate CSS classes of activity SVG icons

Options
    • -1
    • +1
    ./web/images/icon_leaderselection.svg
  2. … 25 more files in changeset.
Monday 14 Jun 2021
1:30 pm

Ernie Ghiglione

LDEV-5200 Adjusting icons colours and svg optimisation

I think this does it. However, there might be some issues with the embedding of SVG's css. As we compressed the files, the classes are called "A, B, C" and when different SVGs have the same class name, then the conflicts start to show.

Went thru all the tools but it's looking good now. There might be some others with system tools

Options
    • -0
    • +1
    ./.gitignore
    • binary
    ./web/images/icon_leaderselection.png
    • -123
    • +1
    ./web/images/icon_leaderselection.svg
    • binary
    ./web/images/icon_leaderselection_large.png
  5. … 63 more files in changeset.
Tuesday 01 Jun 2021
11:09 am

Marcin Cieslak

LDEV-5200 Clean up new SVG icons

Some internal style definitions were overlapping with other icons

embedded in LD SVG. Some definitions were obsolete.

Options
    • -4
    • +4
    ./web/images/icon_leaderselection.svg
  2. … 30 more files in changeset.
Friday 28 May 2021
12:19 pm

Marcin Cieslak

LDEV-5200 Introduce redesigned tool icons

Options
    • -1435
    • +0
    ./web/images/icon_leaderselection.ai
    • binary
    ./web/images/icon_leaderselection.png
    • -383
    • +116
    ./web/images/icon_leaderselection.svg
    • -390
    • +0
    ./web/images/icon_leaderselection_16.svg
    • binary
    ./web/images/icon_leaderselection_large.png
  6. … 122 more files in changeset.