lams-github

lams_tool_preview

Clone Tools

Stats

Commits this week: 0
Total Committers: 14
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 17 Mar 2022
9:35 am

Marcin Cieslak

LDEV-5301 Split learner name into first and last name

Options
    • -0
    • +2
    ./conf/language/lams/ApplicationResources.properties
    • -8
    • +18
    ./src/java/org/lamsfoundation/lams/tool/peerreview/util/SpreadsheetBuilder.java
  3. … 1 more file in changeset.
8:35 am

Marcin Cieslak

LDEV-5301 Introduce fixed column width in spreadsheet exports

Set Peer Evaluation export column width to about 12.5 points.

Options
    • -3
    • +2
    ./src/java/org/lamsfoundation/lams/tool/peerreview/util/SpreadsheetBuilder.java
    • -1
    • +4
    ./src/java/org/lamsfoundation/lams/tool/peerreview/web/controller/MonitoringController.java
  3. … 1 more file in changeset.
Wednesday 09 Mar 2022
7:56 am

Marcin Cieslak

LDEV-5219 Change gate check flow in Peer Review

Criteria like mark hedging need to be validated before going to next

step, which can be finishing the activity. Current "check gate" JS code

does not allow it. Once the finish button is clicked, a check is made

and learner gets pushed to the next activity and whether his/her results

were saved or not.

Now we display results screen even if "show own ratings" or "show

ratings given to other learners" options are off. This allows to do

validation and store last criterion in DB. It also allows to show redo

questions button if this feature is on.

If there is no summary nor redo button, the results page automatically

attempts to go to next activity. If it succeeds, learner does not even

notice the blank results screen. If after Peer Activity there is a

closed gate, the learner will see single button and a message.

Options
    • -8
    • +0
    ./web/pages/learning/learning.jsp
    • -4
    • +12
    ./web/pages/learning/results.jsp
Wednesday 02 Mar 2022
3:12 pm

Marcin Cieslak

LDEV-5290 Improve detection of multiple tabs being open on autosave

Options
    • -1
    • +1
    ./web/WEB-INF/tags/Page.tag
  2. … 32 more files in changeset.
Tuesday 22 Feb 2022
5:06 pm

Marcin Cieslak

LDEV-5287 Allow multiple collapsible Comment tags on a single page

If one folded panel gets expanded, all other ones get collapsed and

emptied.

Options
    • -3
    • +13
    ./web/WEB-INF/tags/Comments.tag
  2. … 32 more files in changeset.
Sunday 20 Feb 2022
7:32 pm

Marcin Cieslak

LDEV-5290 Prevent multiple tabs from being open on autosave

Options
    • -1
    • +14
    ./web/WEB-INF/tags/Page.tag
  2. … 40 more files in changeset.
Saturday 19 Feb 2022
5:40 pm

Marcin Cieslak

LDEV-5287 Add missing CKEditor init parameter

Options
    • -1
    • +1
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 32 more files in changeset.
5:39 pm

Marcin Cieslak

LDEV-5287 Allow multiple comments tags on a single page

Options
    • -6
    • +8
    ./web/WEB-INF/tags/Comments.tag
  2. … 32 more files in changeset.
Tuesday 08 Feb 2022
10:54 am

Marcin Cieslak

LDEV-5282 Prevent Unicode characters from being displayed incorrectly

Options
    • -2
    • +2
    ./web/WEB-INF/tags/StyledRating.tag
    • -1
    • +1
    ./web/pages/learning/rubrics.jsp
  3. … 32 more files in changeset.
Thursday 13 Jan 2022
12:17 am

Ernie Ghiglione

LDEV-4769 Updating Norwegian

Options
    • -1
    • +2
    ./conf/language/lams/ApplicationResources_no_NO.properties
  2. … 4 more files in changeset.
Monday 03 Jan 2022
6:50 am

Ernie Ghiglione

LDEV-4769 Updating Norwegian, Spanish, Greek, Chinese Simplified and English

Options
    • -0
    • +9
    ./conf/language/lams/ApplicationResources_no_NO.properties
  2. … 15 more files in changeset.
Friday 17 Dec 2021
5:29 pm

Marcin Cieslak

LDEV-5155 Escape rubrics text as it breaks authoring

Options
    • -1
    • +3
    ./web/WEB-INF/tags/AuthoringRatingAllStyleCriteria.tag
  2. … 32 more files in changeset.
Wednesday 08 Dec 2021
6:45 pm

Marcin Cieslak

LDEV-5268 Add max word limit to CKEditor tag

Options
    • -4
    • +20
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 32 more files in changeset.
Monday 06 Dec 2021
1:35 am

Ernie Ghiglione

LDEV-5263 Rename peer evaluation tool

Rename peer review to peer evaluation instead.

Options
    • -13
    • +13
    ./conf/language/lams/ApplicationResources.properties
    • -13
    • +13
    ./conf/language/lams/ApplicationResources_en_AU.properties
  3. … 4 more files in changeset.
Sunday 05 Dec 2021
10:09 am

Marcin Cieslak

LDEV-4644 Use [] instead of () to recognise LO code

Teachers tend to use () as a part of Learning Outcome name

Options
    • -1
    • +1
    ./web/WEB-INF/tags/OutcomeAuthor.tag
  2. … 34 more files in changeset.
Monday 29 Nov 2021
10:18 pm

Marcin Cieslak

LDEV-5259 Manually create parent application context

Previous attempt to reproduce BeanFactoryLocater was an overkill. A

simple singleton parent application context is sufficient.

Options
    • -8
    • +0
    ./web/WEB-INF/web.xml
  2. … 45 more files in changeset.
9:10 pm

Marcin Cieslak

LDEV-5259 Use MVC initialisation via annotation

Manually triggering controller scanning by adding an annotation handler

bean does not register all useful support beans. If

<mvc:annotation-driven> is used in spring-servlet.xml, all support beans

are registered via WebMvcConfigurer.

<mvc:path-matching suffix-pattern="true" /> need to be added because we

use .do suffix for Spring actions and suffix was turned off for Spring

5.3

https://github.com/spring-projects/spring-framework/issues/24179

Options
    • -11
    • +14
    ./web/WEB-INF/spring-servlet.xml
  2. … 51 more files in changeset.
Tuesday 23 Nov 2021
12:24 pm

Marcin Cieslak

LDEV-5259 Manually start controller annotation detection

Options
    • -4
    • +4
    ./web/WEB-INF/spring-servlet.xml
  2. … 38 more files in changeset.
12:23 pm

Marcin Cieslak

LDEV-5259 Reintroduce BeanFactoryLocator mechanism back to LAMS

It was removed for Spring 5

Options
    • -1
    • +1
    ./web/WEB-INF/web.xml
  2. … 58 more files in changeset.
Wednesday 10 Nov 2021
7:36 pm

Marcin Cieslak

LDEV-5257 Secure fileDownloadToken cookie

Options
    • -5
    • +1
    ./src/java/org/lamsfoundation/lams/tool/peerreview/web/controller/MonitoringController.java
  2. … 9 more files in changeset.
Thursday 07 Oct 2021
10:44 am

Marcin Cieslak

LDEV-4411 Stop using collection cache for now

Cache annotations were commented out so we can come back to them easily

in the future.

Collection cache is not detecting changes made to entities. When a new

entity is added, collection cache does not see the change.

Properly tweaking concurrency strategy does not seem possible at the

moment, so we just turn it off.

Options
    • -1
    • +1
    ./src/java/org/lamsfoundation/lams/tool/peerreview/model/Peerreview.java
  2. … 29 more files in changeset.
Tuesday 28 Sep 2021
4:14 pm

Ernie Ghiglione

LDEV-4769 Updating Simplified Chinese, English, Spanish, Greek, Norwegian

Options
    • -1
    • +1
    ./conf/language/lams/ApplicationResources_el_GR.properties
    • -1
    • +1
    ./conf/language/lams/ApplicationResources_es_ES.properties
    • -1
    • +1
    ./conf/language/lams/ApplicationResources_no_NO.properties
  4. … 28 more files in changeset.
Monday 27 Sep 2021
9:45 am

Marcin Cieslak

LDEV-5248, LDEV-4411 Mark some collections as cacheable

Similar to query cache, the collection cache makes sense if the table

which collection elements map to do not change often. Each modification

to table content invalidates the given collection cache.

Options
    • -0
    • +3
    ./src/java/org/lamsfoundation/lams/tool/peerreview/model/Peerreview.java
  2. … 31 more files in changeset.
Friday 24 Sep 2021
9:50 am

Marcin Cieslak

LDEV-5248, LDEV-4411 Mark some queries as cacheable

Query cache makes sense if tables which the query reference does not

change often. Each modification to table content invalidates the given

query's cache. Also each set of query parameters is a different cache

entry, so if there are various parameter values the cache overhead can

generate more load than benefit.

Options
    • -10
    • +7
    ./src/java/org/lamsfoundation/lams/tool/peerreview/dao/hibernate/PeerreviewDAOHibernate.java
    • -2
    • +2
    ./src/java/org/lamsfoundation/lams/tool/peerreview/dao/hibernate/PeerreviewSessionDAOHibernate.java
  3. … 95 more files in changeset.
Saturday 11 Sep 2021
11:46 am

Marcin Cieslak

LDEV-5247 Fix user name parameter sent to Etherpad

LAMS allows apostrophes but not quotation marks in names, so it is safer

to use quotations when operating with javascript.

Options
    • -1
    • +1
    ./web/WEB-INF/tags/Etherpad.tag
  2. … 33 more files in changeset.
Tuesday 07 Sep 2021
9:27 pm

Marcin Cieslak

LDEV-5232 Remove "notify student" option from Peer Review authoring

Options
    • -0
    • +15
    ./src/java/org/lamsfoundation/lams/tool/peerreview/dbupdates/patch20210907.sql
    • -11
    • +0
    ./src/java/org/lamsfoundation/lams/tool/peerreview/model/Peerreview.java
    • -1
    • +0
    ./src/java/org/lamsfoundation/lams/tool/peerreview/service/PeerreviewServiceImpl.java
    • -6
    • +0
    ./web/pages/authoring/advance.jsp
    • -17
    • +0
    ./web/pages/monitoring/advanceoptions.jsp
    • -4
    • +4
    ./web/pages/monitoring/criteriapart.jsp
    • -5
    • +1
    ./web/pages/monitoring/summary.jsp
6:41 pm

Marcin Cieslak

LDEV-5219 Display Peer Review results when it is required

It was skipped even though "showRatingsLeftByUser" was checked.

Options
    • -1
    • +1
    ./web/pages/learning/learning.jsp
Monday 06 Sep 2021
9:58 pm

Marcin Cieslak

LDEV-5234 Hide tolerance input when self review is disabled

Options
    • -5
    • +13
    ./web/pages/authoring/advance.jsp
9:47 pm

Marcin Cieslak

LDEV-5234 Fix a typo in i18n label

Options
    • -1
    • +1
    ./conf/language/lams/ApplicationResources.properties
    • -1
    • +1
    ./conf/language/lams/ApplicationResources_en_AU.properties
10:06 am

Ernie Ghiglione

LDEV-5229 Authoring popovers for peer evaluation

Options
    • -3
    • +3
    ./conf/language/lams/ApplicationResources.properties
    • -4
    • +18
    ./conf/language/lams/ApplicationResources_en_AU.properties
    • -1
    • +1
    ./web/pages/authoring/advance.jsp