lams-github

lams_tool_survey

Clone Tools

Stats

Commits this week: 0
Total Committers: 23
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 18 Dec 2021
12:29 am

Marcin Cieslak

LDEV-5155 Escape rubrics text as it breaks authoring

Options
    • -1
    • +3
    ./web/WEB-INF/tags/AuthoringRatingAllStyleCriteria.tag
  2. … 32 more files in changeset.
Thursday 09 Dec 2021
1:45 am

Marcin Cieslak

LDEV-5268 Add max word limit to CKEditor tag

Options
    • -4
    • +20
    ./web/WEB-INF/tags/CKEditor.tag
  2. … 32 more files in changeset.
Monday 06 Dec 2021
4:41 pm

Marcin Cieslak

LDEV-5265 Fix adding a choice question in Vote authoring

We must not use constructs like <div/> or <i/> and only <div></div> and

<i></i>

Options
    • -3
    • +3
    ./web/pages/authoring/parts/addchoicequestion.jsp
Sunday 05 Dec 2021
5:09 pm

Marcin Cieslak

LDEV-4644 Use [] instead of () to recognise LO code

Teachers tend to use () as a part of Learning Outcome name

Options
    • -1
    • +1
    ./web/WEB-INF/tags/OutcomeAuthor.tag
  2. … 34 more files in changeset.
Tuesday 30 Nov 2021
5:18 am

Marcin Cieslak

LDEV-5259 Manually create parent application context

Previous attempt to reproduce BeanFactoryLocater was an overkill. A

simple singleton parent application context is sufficient.

Options
    • -9
    • +0
    ./web/WEB-INF/web.xml
  2. … 45 more files in changeset.
4:10 am

Marcin Cieslak

LDEV-5259 Use MVC initialisation via annotation

Manually triggering controller scanning by adding an annotation handler

bean does not register all useful support beans. If

<mvc:annotation-driven> is used in spring-servlet.xml, all support beans

are registered via WebMvcConfigurer.

<mvc:path-matching suffix-pattern="true" /> need to be added because we

use .do suffix for Spring actions and suffix was turned off for Spring

5.3

https://github.com/spring-projects/spring-framework/issues/24179

Options
    • -11
    • +13
    ./web/WEB-INF/spring-servlet.xml
  2. … 51 more files in changeset.
Tuesday 23 Nov 2021
7:24 pm

Marcin Cieslak

LDEV-5259 Manually start controller annotation detection

Options
    • -5
    • +6
    ./web/WEB-INF/spring-servlet.xml
  2. … 38 more files in changeset.
7:23 pm

Marcin Cieslak

LDEV-5259 Reintroduce BeanFactoryLocator mechanism back to LAMS

It was removed for Spring 5

Options
    • -1
    • +1
    ./web/WEB-INF/web.xml
  2. … 58 more files in changeset.
Thursday 11 Nov 2021
2:36 am

Marcin Cieslak

LDEV-5257 Secure fileDownloadToken cookie

Options
    • -5
    • +1
    ./src/java/org/lamsfoundation/lams/tool/survey/web/controller/MonitoringController.java
  2. … 9 more files in changeset.
Thursday 07 Oct 2021
4:44 pm

Marcin Cieslak

LDEV-4411 Stop using collection cache for now

Cache annotations were commented out so we can come back to them easily

in the future.

Collection cache is not detecting changes made to entities. When a new

entity is added, collection cache does not see the change.

Properly tweaking concurrency strategy does not seem possible at the

moment, so we just turn it off.

Options
    • -2
    • +2
    ./src/java/org/lamsfoundation/lams/tool/survey/model/Survey.java
    • -1
    • +1
    ./src/java/org/lamsfoundation/lams/tool/survey/model/SurveyQuestion.java
  3. … 28 more files in changeset.
Monday 27 Sep 2021
3:45 pm

Marcin Cieslak

LDEV-5248, LDEV-4411 Mark some collections as cacheable

Similar to query cache, the collection cache makes sense if the table

which collection elements map to do not change often. Each modification

to table content invalidates the given collection cache.

Options
    • -4
    • +8
    ./src/java/org/lamsfoundation/lams/tool/survey/model/Survey.java
    • -0
    • +3
    ./src/java/org/lamsfoundation/lams/tool/survey/model/SurveyQuestion.java
  3. … 30 more files in changeset.
Friday 24 Sep 2021
3:50 pm

Marcin Cieslak

LDEV-5248, LDEV-4411 Mark some queries as cacheable

Query cache makes sense if tables which the query reference does not

change often. Each modification to table content invalidates the given

query's cache. Also each set of query parameters is a different cache

entry, so if there are various parameter values the cache overhead can

generate more load than benefit.

Options
    • -1
    • +1
    ./src/java/org/lamsfoundation/lams/tool/survey/dao/hibernate/SurveyDAOHibernate.java
    • -2
    • +2
    ./src/java/org/lamsfoundation/lams/tool/survey/dao/hibernate/SurveySessionDAOHibernate.java
  3. … 95 more files in changeset.
Saturday 11 Sep 2021
5:46 pm

Marcin Cieslak

LDEV-5247 Fix user name parameter sent to Etherpad

LAMS allows apostrophes but not quotation marks in names, so it is safer

to use quotations when operating with javascript.

Options
    • -1
    • +1
    ./web/WEB-INF/tags/Etherpad.tag
  2. … 33 more files in changeset.
Tuesday 31 Aug 2021
10:42 pm

Marcin Cieslak

LDEV-5229 Make previous changes to tools consistent

Options
    • -5
    • +6
    ./conf/language/lams/ApplicationResources.properties
    • -8
    • +9
    ./web/WEB-INF/tags/OutcomeAuthor.tag
    • -5
    • +6
    ./web/pages/authoring/advance.jsp
    • -0
    • +10
    ./web/pages/monitoring/advanceoptions.jsp
  5. … 28 more files in changeset.
3:01 pm

Ernie Ghiglione

LDEV-5229 Authoring popovers for survey

Options
    • -2
    • +6
    ./conf/language/lams/ApplicationResources.properties
    • -5
    • +9
    ./web/WEB-INF/tags/OutcomeAuthor.tag
    • -0
    • +9
    ./web/pages/authoring/advance.jsp
  4. … 1 more file in changeset.
Friday 13 Aug 2021
4:48 pm

Marcin Cieslak

LDEV-5155 Highlight rubrics row title

Make it more distinguished from selectable options in next columns

Options
    • -0
    • +4
    ./web/WEB-INF/tags/StyledRating.tag
  2. … 33 more files in changeset.
Thursday 12 Aug 2021
8:55 pm

Marcin Cieslak

LDEV-5155 Allow free flow of rubrics columns

Trying to calculate their width actually yields worse results.

Options
    • -4
    • +4
    ./web/WEB-INF/tags/StyledRating.tag
  2. … 33 more files in changeset.
Saturday 24 Jul 2021
4:22 pm

Marcin Cieslak

LDEV-5223 Prevent ep_resize from rendering short initial Etherpad

Options
    • -2
    • +1
    ./web/WEB-INF/tags/Etherpad.tag
  2. … 34 more files in changeset.
Thursday 22 Jul 2021
7:28 pm

Marcin Cieslak

LDEV-5220 Distribute the new popover tag

Options
    • -0
    • +31
    ./web/WEB-INF/tags/Popover.tag
    • -0
    • +4
    ./web/WEB-INF/tlds/lams/lams.tld
  3. … 62 more files in changeset.
6:52 pm

Marcin Cieslak

LDEV-5223 Fix Etherpad resizing

Options
    • -1
    • +1
    ./web/WEB-INF/tags/Etherpad.tag
  2. … 33 more files in changeset.
Friday 16 Jul 2021
12:21 am

Marcin Cieslak

LDEV-5219 Use versioned JS import for gate check JS file

Options
    • -1
    • +1
    ./web/pages/learning/notebook.jsp
    • -1
    • +1
    ./web/pages/learning/result.jsp
  3. … 54 more files in changeset.
Thursday 15 Jul 2021
10:41 pm

Marcin Cieslak

LDEV-5219 Check gate after Survey activity

Options
    • -5
    • +11
    ./web/pages/learning/notebook.jsp
    • -4
    • +6
    ./web/pages/learning/result.jsp
Tuesday 06 Jul 2021
6:07 pm

Marcin Cieslak

Merge branch 'LDEV-5155' into v4.0

Options
    • -1
    • +1
    ./web/WEB-INF/tags/Page.tag
  2. … 33 more files in changeset.
Thursday 01 Jul 2021
7:02 pm

Marcin Cieslak

LDEV-5155 Add column with average rating for given rubrics row

Options
    • -2
    • +21
    ./web/WEB-INF/tags/StyledRating.tag
  2. … 31 more files in changeset.
Wednesday 30 Jun 2021
5:01 pm

Marcin Cieslak

LDEV-5155 Always put rubrics column's value next to its description

Options
    • -4
    • +4
    ./web/WEB-INF/tags/StyledRating.tag
  2. … 31 more files in changeset.
3:39 pm

Marcin Cieslak

LDEV-5192 Limit maximum width of tool authoring content

For rubrics we may need a wider authoring window so their text areas are

not so squeezed. But having a super wide authoring windows does not look

good either. So now we have a container-fluid class, but limited to

1400px width.

Options
    • -76
    • +319
    ./web/WEB-INF/tags/AuthoringRatingAllStyleCriteria.tag
    • -1
    • +1
    ./web/WEB-INF/tags/Page.tag
    • -0
    • +182
    ./web/WEB-INF/tags/StyledRating.tag
  4. … 92 more files in changeset.
Wednesday 23 Jun 2021
3:16 pm

Marcin Cieslak

LDEV-5213 Add a missing JSTL library import

Options
    • -0
    • +1
    ./web/WEB-INF/tags/JSImport.tag
  2. … 32 more files in changeset.
Tuesday 22 Jun 2021
8:42 pm

Marcin Cieslak

LDEV-5213 Never show minus sign in hash code

Options
    • -1
    • +1
    ./web/WEB-INF/tags/JSImport.tag
  2. … 32 more files in changeset.
8:37 pm

Marcin Cieslak

LDEV-5213 Replace volatile JS imports with their non-cached version

Options
    • -1
    • +1
    ./web/WEB-INF/tags/Page.tag
    • -1
    • +1
    ./web/pages/authoring/parts/addopenquestion.jsp
  3. … 92 more files in changeset.
7:37 pm

Marcin Cieslak

LDEV-5213 Add a tag to prevent JS file caching

Options
    • -0
    • +16
    ./web/WEB-INF/tags/JSImport.tag
    • -1
    • +4
    ./web/WEB-INF/tlds/lams/lams.tld
  3. … 64 more files in changeset.