lams / lams_tool_images / web / pages

authoring

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 6
Last Commit:
Commits this week: 0
Total Lines of Code (LoC): 816
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 24 Apr 2015
11:45 am

Marcin Cieslak

LDEV-3095: Revert incorrect fix. Try to mute cross-domain

iframe access errors, as requested by a client.

Options
    • -6
    • +8
    ./parts/itemlist.jsp
  2. … 26 more files in changeset.
12:42 am

Andrey Balan

LDEV-3450

1) Display what rate you have given

2) Rate only once

3) Don't see the average rating until you rate it.

4) Add an option for a brief comment

Options
    • -3
    • +6
    ./advance.jsp
  2. … 26 more files in changeset.
Saturday 18 Apr 2015
3:24 am

Andrey Balan

LDEV-3450 Introduce rating limits

Options
    • -4
    • +3
    ./advance.jsp
    • -6
    • +2
    ./authoring.jsp
  3. … 24 more files in changeset.
Friday 17 Apr 2015
6:13 pm

Marcin Cieslak

LDEV-3095: Check if the current window is the one containing given methods. It may happen for some clients.

Options
    • -1
    • +3
    ./parts/itemlist.jsp
  2. … 27 more files in changeset.
5:49 pm

Marcin Cieslak

LDEV-3095: Check if the current window is the one containing given methods. It may happen for some clients.

Options
    • -1
    • +3
    ./parts/itemlist.jsp
  2. … 27 more files in changeset.
Monday 13 Apr 2015
8:17 pm

Andrey Balan

LDEV-3450 Introduced central rating service

Options
    • -24
    • +37
    ./advance.jsp
    • -1
    • +1
    ./authoring.jsp
    • -37
    • +54
    ./basic.jsp
    • -5
    • +6
    ./parts/addimage.jsp
  5. … 48 more files in changeset.
Thursday 26 Mar 2015
10:21 pm

Andrey Balan

LDEV-3450 Use central rating system.

Plus introduced common rating tags.

Options
    • -24
    • +37
    ./advance.jsp
    • -1
    • +1
    ./authoring.jsp
    • -37
    • +54
    ./basic.jsp
  4. … 19 more files in changeset.
Friday 12 Dec 2014
5:31 pm

Andrey Balan

LDEV-3377 Image gallery frame size adjusts properly in Firefox now

Options
    • -5
    • +6
    ./parts/addimage.jsp
  2. … 1 more file in changeset.
Thursday 30 Oct 2014
7:22 pm

Andrey Balan

LDEV-3259 Improved Image Gallery's learning

Options
    • -2
    • +1
    ./authoring.jsp
    • -2
    • +1
    ./definelater.jsp
    • -2
    • +2
    ./definelaterforbid.jsp
    • -2
    • +2
    ./parts/addimage.jsp
    • -2
    • +2
    ./parts/addmultipleimages.jsp
  6. … 40 more files in changeset.
Friday 26 Sep 2014
11:47 pm

Andrey Balan

LDEV-3259 Improved Image Gallery's learning

Options
    • -2
    • +1
    ./authoring.jsp
    • -2
    • +1
    ./definelater.jsp
    • -2
    • +2
    ./definelaterforbid.jsp
    • -2
    • +2
    ./parts/addimage.jsp
    • -2
    • +2
    ./parts/addmultipleimages.jsp
  6. … 39 more files in changeset.
Friday 12 Sep 2014
11:20 pm

Andrey Balan

LDEV-3305 Prevent iframe from expanding too big in Chrome

Options
    • -1
    • +0
    ./basic.jsp
  2. … 13 more files in changeset.
11:07 pm

Andrey Balan

LDEV-3298 fixed issue when CKeditor missed right and sometimes left border when it's being opened in an iframe using showMessage() method

Options
    • -1
    • +2
    ./parts/addimage.jsp
  2. … 9 more files in changeset.
Thursday 11 Sep 2014
9:35 pm

Andrey Balan

LDEV-3298 fixed issue when CKeditor missed right and sometimes left border when it's being opened in an iframe using showMessage() method

Options
    • -1
    • +2
    ./parts/addimage.jsp
  2. … 9 more files in changeset.
Tuesday 09 Sep 2014
11:16 pm

Andrey Balan

LDEV-3305 Prevent iframe from expanding too big in Chrome

Options
    • -1
    • +0
    ./basic.jsp
  2. … 13 more files in changeset.
Wednesday 03 Sep 2014
2:52 pm

Andrey Balan

LDEV-3301 prevent CKEditor from occupying more space than available due to its autogrow feature

Options
    • -2
    • +15
    ./parts/addimage.jsp
  2. … 14 more files in changeset.
Monday 25 Aug 2014
10:03 pm

Andrey Balan

LDEV-3301 prevent CKEditor from occupying more space than available due to its autogrow feature

Options
    • -2
    • +15
    ./parts/addimage.jsp
  2. … 11 more files in changeset.
Thursday 24 Apr 2014
10:39 pm

Andrey Balan

LDEV-2668 Being able to sort images by rating

Options
    • -0
    • +1
    ./authoring.jsp
  2. … 4 more files in changeset.
Thursday 27 Mar 2014
9:10 pm

Ernie Ghiglione

LDEV-2463: escape HTML to prevent possible XSS attacks

Options
    • -4
    • +7
    ./parts/itemlist.jsp
  2. … 11 more files in changeset.
Friday 17 Jan 2014
10:35 pm

Andrey Balan

LDEV-3147 Simplify tools: get rid of instructions tab, define in monitor and offline activity options

Options
    • -18
    • +0
    ./authoring.jsp
    • -131
    • +0
    ./instructions.jsp
    • -65
    • +0
    ./parts/instructionfilelist.jsp
  4. … 174 more files in changeset.
Monday 28 Oct 2013
2:17 pm

Marcin Cieslak

LDEV-3142: Add help icon which fixes padding problem as well.

Options
    • -1
    • +1
    ./definelater.jsp
  2. … 10 more files in changeset.
Thursday 15 Aug 2013
10:20 pm

Marcin Cieslak

LDEV-3095: Display item list in top or parent window, but never in current.

Options
    • -11
    • +10
    ./parts/itemlist.jsp
  2. … 37 more files in changeset.
Friday 26 Jul 2013
3:16 pm

Marcin Cieslak

LDEV-3070: Use window.parent if required in Tools. Make single activity lesson wizard optional, set in sysadmin menu.

Options
    • -8
    • +14
    ./parts/itemlist.jsp
  2. … 59 more files in changeset.
Tuesday 23 Jul 2013
7:52 pm

Marcin Cieslak

LDEV-3070: Add single activity lessons wizard, first implementation iteration. Some changes were not committed as they interfere with old index page design.

Options
    • -4
    • +5
    ./parts/itemlist.jsp
  2. … 123 more files in changeset.
Monday 17 Dec 2012
3:47 pm

Andrey Balan

LDEV-2936 reinitialize lytebox after adding image

Options
    • -0
    • +1
    ./basic.jsp
    • -19
    • +4
    ./parts/itemlist.jsp
Wednesday 04 Jan 2012
1:05 pm

Ernie Ghiglione

LDEV-2764: fixing frame width and height for Tool Images

Options
    • -4
    • +12
    ./basic.jsp
    • -1
    • +1
    ./parts/addimage.jsp
Monday 02 Jan 2012
1:41 pm

Ernie Ghiglione

LDEV-2759: fixing with and height for image iframe

Options
    • -2
    • +2
    ./basic.jsp
Wednesday 06 Oct 2010
12:09 pm

Marcin Cieslak

LDEV-2577

The new CKEditor does not have Java Integration library (yet). We have been

using it to:

a) get the tag library to create our own tag <lams:FCKeditor>

But the new CKEditor uses AJAX to get the contents, so the library is

not needed anymore.

The references to it has been deleted from every tool.

FCKEditor.tag has been rewritten to use the new syntax.

b) get a FCKEditor internal file manager by a Connector from the jar

The new CKEditor does not provide a file manager - the license became

commercial and the whole thing became a separate project, CKFinder.

There were alternatives suggested on the web:

jasfinder - http://sourceforge.net/projects/jasfinder/support

kcfinder - http://kcfinder.sunhater.com/

some other - http://www.miguelmanchego.com/2009/gestor-de-archivos-ckeditor/

but we have already nicely integrated with the old file manager. This page:

http://jacek-kromski.jogger.pl/2009/09/25/integracja-ckeditor-z-przegladarka-plikow-z-fckeditor/

in polish says how to use the file manager from the old FCKEditor.

The steps that have to be done:

- download the new CKEditor

- download the old FCKEditor

- copy the filemanager to ckeditor directory

- in the file browser/default/frmresourceslist.html, line 92 (with SetUrl call) needs to be replaced to:

window.top.opener.CKEDITOR.tools.callFunction( window.top.document.CKEditorFuncNum, fileUrl, '' );

- in the file browser/default/browser.html add in line 80:

document.CKEditorFuncNum = GetUrlParam( 'CKEditorFuncNum');

FCKeditor has been used in version 2.6.6, the last one before switching to CKEditor project.

Changes required to use newer version of Java Integration library

for FCKEditor so it was upgraded to the latest (for FCKEditor, because one for CKEditor does not exist) version 2.6.

This also required the Prototype to be upgraded to the latest 1.6.1.

The CKEditor code also needed to be changed, so if another upgrade to a newer version occurs, we need to remember to repeat these steps:

http://cksource.com/forums/viewtopic.php?f=5&t=15750

It says:

/ckeditor/plugins/link/dialogs/link.js

Changes

label:a.lang.common.target,'default':'notSet' --> label:a.lang.common.target,'default':'_blank'

label:a.lang.link.targetFrameName,'default':'' --> label:a.lang.link.targetFrameName,'default':'_blank'

It is also worth mentioning that if you include the ckeditor.js file twice in the same page, sometimes it causes trouble, thus detection in the CKEditor.tag files.

Options
    • -2
    • +2
    ./basic.jsp
    • -1
    • +1
    ./parts/addimage.jsp
  3. … 1095 more files in changeset.
Monday 16 Nov 2009
3:25 am

jliew

LDEV-2459 LDEV-2462 surround i18n messages with double quotes when outputting to html or javascript

Options
    • -1
    • +1
    ./basic.jsp
  2. … 45 more files in changeset.
Friday 13 Nov 2009
4:13 am

jliew

LDEV-2459 use double quotes when enclosing i18n text in javascript

Options
    • -1
    • +1
    ./basic.jsp
  2. … 47 more files in changeset.
Tuesday 28 Jul 2009
4:19 pm

Andrey Balan

LDEV-2387 simplified rendering of FCKEditor

* removed commented JS part from FCKEditor jsp tag

* removed fckeditorheader.jsp

* got rid of any references to fckeditor.js, fckcontroller.js, fckeditor.css

Options
    • -1
    • +0
    ./authoring.jsp
    • -1
    • +0
    ./definelater.jsp
  3. … 96 more files in changeset.