lams / lams_tool_laqa

web

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 17
Last Commit:
Commits this week: 0
Total Lines of Code (LoC): 24,070
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 12 Feb 2011
7:53 pm

Marcin Cieslak

LDEV-2642, LDEV-2616:

Move Planner activity metadata (hidden, collapsed, expanded) to a separate table, as it may grow in the future and we don't want to make ToolActivity too complex.

Move Editing Advice content from Online Instructions in activities to the metadata table.

Allow editing the Editing Advice straight from the planner. Use jquery_ui instead of cluetip (dispose the last one completely).

While creating a node, the Learning Design is imported just once from ZIP into DB, instead of importing it each time someone opens it in Planner. This allows less unnecessary copies of the LD and allows easier modfication of the original design.

Change the way a Teacher gets a copy of the design. When opening the template in Planner, a copy is made in common folder ("Planner preview"). When the user saves the design, the same copy is *moved* to user's folder, rather than copying it again. Futhermore, each subsequent save modifies the same LD rather than making another copy.

Options
    • -1
    • +1
    ./authoring/pedagogicalPlannerForm.jsp
  2. … 25 more files in changeset.
Sunday 12 Dec 2010
3:43 pm

Marcin Cieslak

LDEV-2577: Fixed a bug - the response after ajaxSubmit was trimmed improperly, leaving unnecessary code on the top.

Also added missing label.

Options
    • -1
    • +4
    ./authoring/pedagogicalPlannerForm.jsp
  2. … 8 more files in changeset.
3:29 pm

Marcin Cieslak

LDEV-2577: Fixed a bug preventing multiple CKEditor instances on one page to be properly reinitialized after form submit.

Options
    • -7
    • +14
    ./WEB-INF/tags/CKEditor.tag
  2. … 27 more files in changeset.
Sunday 05 Dec 2010
9:48 pm

Marcin Cieslak

LDEV-2577: Added extra safety measure preventing plain textarea from being show instead of CKEditor instance.

Options
    • -1
    • +1
    ./WEB-INF/tags/CKEditor.tag
  2. … 27 more files in changeset.
Tuesday 23 Nov 2010
7:34 pm

Marcin Cieslak

LDEV-2607: Hardcoded CKEditor width as a fix for Chrome inability to process "100%" width correctly.

Options
    • -1
    • +1
    ./WEB-INF/tags/CKEditor.tag
  2. … 26 more files in changeset.
Monday 22 Nov 2010
8:11 am

Marcin Cieslak

LDEV-2577: Set default height for CKEditor instances, as in IE it was minimal.

Options
    • -0
    • +4
    ./WEB-INF/tags/CKEditor.tag
  2. … 27 more files in changeset.
Wednesday 17 Nov 2010
11:19 pm

Marcin Cieslak

LDEV-2595: As CSS parameter "display: none" does not work in IE, the initial textarea for CKEditor has height = 0px which does the trick instead.

Options
    • -1
    • +1
    ./WEB-INF/tags/CKEditor.tag
  2. … 27 more files in changeset.
Thursday 04 Nov 2010
9:22 pm

Marcin Cieslak

LDEV-2596: Forcing CKEditor be reinitialized after AJAX form submit.

Options
    • -17
    • +27
    ./WEB-INF/tags/CKEditor.tag
  2. … 28 more files in changeset.
Tuesday 02 Nov 2010
1:26 pm

Andrey Balan

LDEV-2524 fixed jsps from HEAD branch

*it also includes fix for expanding window on adding new questions.

which is caused by CKEditor and this fix should be removed once CKeditor will start working correct

Options
    • -1
    • +1
    ./authoring/BasicContent.jsp
    • -9
    • +0
    ./authoring/editQuestionBox.jsp
    • -18
    • +2
    ./authoring/newQuestionBox.jsp
Monday 01 Nov 2010
1:20 pm

fmalikoff

Merging changes from 2.3 release branch for LDEV-2524.

Options
    • -0
    • +18
    ./authoring/editQuestionBox.jsp
    • -0
    • +25
    ./authoring/newQuestionBox.jsp
    • -2
    • +7
    ./learning/AnswersContent.jsp
    • -1
    • +4
    ./learning/CombinedAnswersContent.jsp
    • -15
    • +6
    ./learning/IndividualLearnerResults.jsp
    • -2
    • +5
    ./learning/SequentialAnswersContent.jsp
    • -0
    • +12
    ./monitoring/editQuestionBox.jsp
    • -0
    • +12
    ./monitoring/newQuestionBox.jsp
  9. … 22 more files in changeset.
11:24 am

fmalikoff

LDEV-2524 Implementing the compulsory question option. Made the question map contain a complex object rather than a single string so that we didn't have to keep adding maps every time we added more data for each question.

Options
    • -2
    • +6
    ./learning/CombinedAnswersContent.jsp
    • -15
    • +6
    ./learning/IndividualLearnerResults.jsp
    • -2
    • +5
    ./learning/SequentialAnswersContent.jsp
  4. … 1 more file in changeset.
11:22 am

fmalikoff

LDEV-2524 Implementing the compulsory question option - adding error message on screen if question not answered.

Options
    • -2
    • +7
    ./learning/AnswersContent.jsp
11:07 am

fmalikoff

LDEV-2524 Implementing the compulsory question option - adding the checkbox.

Options
    • -0
    • +9
    ./authoring/editQuestionBox.jsp
    • -0
    • +9
    ./authoring/newQuestionBox.jsp
    • -0
    • +12
    ./monitoring/editQuestionBox.jsp
    • -0
    • +12
    ./monitoring/newQuestionBox.jsp
Friday 29 Oct 2010
5:05 pm

Andrey Balan

LDEV-2568 Q&A export portfolio to include teacher's comments

*merge from lams2_3_release

Options
    • -12
    • +15
    ./export/exportportfolio.jsp
  2. … 2 more files in changeset.
1:43 am

Andrey Balan

LDEV-2568 Q&A export portfolio to include teacher's comments

Options
    • -12
    • +15
    ./export/exportportfolio.jsp
  2. … 2 more files in changeset.
Sunday 24 Oct 2010
3:36 pm

Marcin Cieslak

LDEV-2577: Readded videorecorder plugin. Readded missing contentFolderID parameter to CKEditor instances.

Options
    • -1
    • +2
    ./WEB-INF/tags/CKEditor.tag
  2. … 36 more files in changeset.
Thursday 21 Oct 2010
8:50 pm

Marcin Cieslak

LDEV-2577, LDEV-2588:

Fixed names of buttons that have changed from FCKEditor.

CKEditor are hidden until they are completely initialized.

Options
    • -1
    • +1
    ./WEB-INF/tags/CKEditor.tag
  2. … 25 more files in changeset.
Sunday 10 Oct 2010
1:46 pm

Marcin Cieslak

LDEV-2577: Removed quotation marks on "displayExpanded" option so it gets parsed correctly.

Options
    • -1
    • +1
    ./WEB-INF/tags/CKEditor.tag
  2. … 27 more files in changeset.
Wednesday 06 Oct 2010
12:09 pm

Marcin Cieslak

LDEV-2577

The new CKEditor does not have Java Integration library (yet). We have been

using it to:

a) get the tag library to create our own tag <lams:FCKeditor>

But the new CKEditor uses AJAX to get the contents, so the library is

not needed anymore.

The references to it has been deleted from every tool.

FCKEditor.tag has been rewritten to use the new syntax.

b) get a FCKEditor internal file manager by a Connector from the jar

The new CKEditor does not provide a file manager - the license became

commercial and the whole thing became a separate project, CKFinder.

There were alternatives suggested on the web:

jasfinder - http://sourceforge.net/projects/jasfinder/support

kcfinder - http://kcfinder.sunhater.com/

some other - http://www.miguelmanchego.com/2009/gestor-de-archivos-ckeditor/

but we have already nicely integrated with the old file manager. This page:

http://jacek-kromski.jogger.pl/2009/09/25/integracja-ckeditor-z-przegladarka-plikow-z-fckeditor/

in polish says how to use the file manager from the old FCKEditor.

The steps that have to be done:

- download the new CKEditor

- download the old FCKEditor

- copy the filemanager to ckeditor directory

- in the file browser/default/frmresourceslist.html, line 92 (with SetUrl call) needs to be replaced to:

window.top.opener.CKEDITOR.tools.callFunction( window.top.document.CKEditorFuncNum, fileUrl, '' );

- in the file browser/default/browser.html add in line 80:

document.CKEditorFuncNum = GetUrlParam( 'CKEditorFuncNum');

FCKeditor has been used in version 2.6.6, the last one before switching to CKEditor project.

Changes required to use newer version of Java Integration library

for FCKEditor so it was upgraded to the latest (for FCKEditor, because one for CKEditor does not exist) version 2.6.

This also required the Prototype to be upgraded to the latest 1.6.1.

The CKEditor code also needed to be changed, so if another upgrade to a newer version occurs, we need to remember to repeat these steps:

http://cksource.com/forums/viewtopic.php?f=5&t=15750

It says:

/ckeditor/plugins/link/dialogs/link.js

Changes

label:a.lang.common.target,'default':'notSet' --> label:a.lang.common.target,'default':'_blank'

label:a.lang.link.targetFrameName,'default':'' --> label:a.lang.link.targetFrameName,'default':'_blank'

It is also worth mentioning that if you include the ckeditor.js file twice in the same page, sometimes it causes trouble, thus detection in the CKEditor.tag files.

Options
    • -2
    • +2
    ./WEB-INF/lams.tld
    • -5
    • +1
    ./WEB-INF/web.xml
    • -129
    • +0
    ./WEB-INF/fckeditor/tlds/FCKeditor.tld
    • -0
    • +53
    ./WEB-INF/tags/CKEditor.tag
    • binary
    ./WEB-INF/tags/FCKEditor.tag
    • -2
    • +2
    ./authoring/BasicContent.jsp
    • -2
    • +2
    ./authoring/editQuestionBox.jsp
    • -3
    • +3
    ./authoring/newQuestionBox.jsp
    • -6
    • +6
    ./authoring/pedagogicalPlannerForm.jsp
    • -1
    • +1
    ./common/taglibs.jsp
    • -1
    • +1
    ./includes/taglibs.jsp
    • -4
    • +3
    ./learning/CombinedAnswersContent.jsp
    • -4
    • +3
    ./learning/SequentialAnswersContent.jsp
    • -2
    • +2
    ./monitoring/editQuestionBox.jsp
    • -2
    • +2
    ./monitoring/newQuestionBox.jsp
  16. … 1082 more files in changeset.
Thursday 10 Jun 2010
2:44 am

lfoxton

LDEV-2552 MErging changes with head

Options
    • -2
    • +1
    ./authoring/BasicContent.jsp
    • -1
    • +1
    ./authoring/newQuestionBox.jsp
2:42 am

lfoxton

LDEV-2552 Fixing a cognitive skills wizard bug that resizes the new question iframe when it shouldnt be resized

Options
    • -2
    • +1
    ./authoring/BasicContent.jsp
    • -1
    • +1
    ./authoring/newQuestionBox.jsp
Thursday 18 Mar 2010
1:58 pm

Andrey Balan

LDEV-2329 When editing in monitor if press the "Cancel" button, the define_later flag *does* get removed.

Options
    • -1
    • +1
    ./WEB-INF/tags/AuthoringButton.tag
  2. … 28 more files in changeset.
1:13 pm

Andrey Balan

LDEV-2329 When editing in monitor if press the "Cancel" button, the define_later flag *does* get removed.

Options
    • -1
    • +1
    ./WEB-INF/tags/AuthoringButton.tag
  2. … 28 more files in changeset.
Wednesday 20 Jan 2010
3:15 pm

Andrey Balan

LDEV-2498 merge from HEAD to lams2_3_release branch

Options
    • -1
    • +1
    ./authoring/BasicContent.jsp
3:00 pm

Andrey Balan

LDEV-2498 Increased the width for Q&A iframe

Options
    • -1
    • +1
    ./authoring/BasicContent.jsp
Monday 16 Nov 2009
3:25 am

jliew

LDEV-2459 LDEV-2462 surround i18n messages with double quotes when outputting to html or javascript

Options
    • -15
    • +15
    ./admin/config.jsp
    • -1
    • +1
    ./authoring/newQuestionBox.jsp
    • -2
    • +2
    ./includes/jsp/qaWizardCommon.jsp
  4. … 43 more files in changeset.
Friday 13 Nov 2009
4:13 am

jliew

LDEV-2459 use double quotes when enclosing i18n text in javascript

Options
    • -15
    • +15
    ./admin/config.jsp
    • -1
    • +1
    ./authoring/newQuestionBox.jsp
    • -2
    • +2
    ./includes/jsp/qaWizardCommon.jsp
    • -1
    • +1
    ./learning/AnswersContent.jsp
  5. … 44 more files in changeset.
2:41 am

jliew

LDEV-2459 use double quotes when enclosing i18n text in javascript

Options
    • -1
    • +1
    ./learning/AnswersContent.jsp
Wednesday 16 Sep 2009
10:23 am

Ernie Ghiglione

LDEV-2152: Changes to make it work with IE6

Options
    • -1
    • +3
    ./learning/IndividualLearnerResults.jsp
    • -3
    • +3
    ./learning/LearnerRep.jsp
10:21 am

Ernie Ghiglione

LDEV-2152: Changes to make it work with IE6

Options
    • -1
    • +3
    ./learning/IndividualLearnerResults.jsp
    • -3
    • +3
    ./learning/LearnerRep.jsp