lams-github / lams_common / src / java / org / lamsfoundation / lams

web

Clone Tools

Stats

Commits this week: 0
Total Committers: 21
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 14 Jan 2024
3:37 pm

Marcin Cieslak

LDEV-5438 Add timer change logs

Options
    • -1
    • +18
    ./controller/AbstractTimeLimitWebsocketServer.java
Friday 15 Dec 2023
7:05 pm

Marcin Cieslak

LDEV-5426 Switch from custom time zones to built-in Java ones

Options
    • -11
    • +9
    ./filter/AuditLogFilter.java
  2. … 40 more files in changeset.
Saturday 14 Oct 2023
2:05 pm

Marcin Cieslak

LDEV-5204 Fix leader finished detection

Also fix misleading session invalidated warnings

Options
    • -8
    • +7
    ./session/SystemSessionFilter.java
  2. … 4 more files in changeset.
Friday 23 Jun 2023
11:36 pm

Marcin Cieslak

Merge branch 'LDEV-5401' into v4.7

# Conflicts:

# lams_common/src/java/org/lamsfoundation/lams/web/controller/AbstractTimeLimitWebsocketServer.java

Options
    • -8
    • +15
    ./controller/AbstractTimeLimitWebsocketServer.java
  2. … 1 more file in changeset.
Thursday 22 Jun 2023
10:18 pm

Marcin Cieslak

LDEV-5142 Fortify time limit websocket server code to prevent NPEs

Options
    • -51
    • +43
    ./controller/AbstractTimeLimitWebsocketServer.java
  2. … 1 more file in changeset.
2:10 am

Marcin Cieslak

LDEV-5401 Add learner-triggered absolute time limit authoring and learning

Options
    • -29
    • +32
    ./controller/AbstractTimeLimitWebsocketServer.java
  2. … 16 more files in changeset.
Monday 05 Jun 2023
6:09 pm

Marcin Cieslak

LAI-5 Add menu item in authoring to open AI wizard

Options
    • -0
    • +3
    ./util/AttributeNames.java
  2. … 6 more files in changeset.
Thursday 23 Mar 2023
11:06 pm

Marcin Cieslak

LDEV-5260 Prevent EventStream retransmission from invalidating session

Event Stream, which LAMS uses for reactive communication via Flux, keeps

a line open between browser and LAMS. If this line is considered

stalled, usually because there is no interaction neither on back nor on

front end, it closes. It happens after about 5 minutes.

If in the meantime the teacher navigated to another LAMS lesson via LMS,

he/she gets reauthenticated via integrations mechanism and gets a new

HTTP session ID. This works fine and allows working on multiple

monitoring windows via LMS.

If now the stalled Event Stream sends a message to LAMS, it uses the old

session ID, not the new one. It happens even when the monitoring window

where the Event Stream was created gets closed. It is a browser

"feature".

This request with old session ID gets picked up by LAMS double login

prevention mechanism. LAMS does not allow users to be logged in to same

account on two browsers. And this Event Stream retransmission looks like

a double login. So LAMS invalidates the correct current session.

It results in teacher getting logged out from the monitoring window and

getting the login page on refresh.

The fix is just throwing an exception on Event Stream retransmission

which would otherwise invalidate the current session. It should be good

enough as the Event Stream does not need a valid response, no one is

waiting for one anymore.

Options
    • -0
    • +8
    ./session/SessionManager.java
    • -4
    • +7
    ./session/SystemSessionFilter.java
Saturday 26 Nov 2022
7:10 pm

Marcin Cieslak

LDEV-5200 Prevent invalidated session error from propagating

There seems to be a problem with Infinispan session invalidation similar

to this

https://issues.redhat.com/browse/UNDERTOW-478

We already have got a patched version, but similar problems occur. They

probably have to do with async servlet processing.

Until we upgrade WildFly we need to keep these safety measures.

Options
    • -1
    • +3
    ./session/SessionManager.java
    • -3
    • +21
    ./session/SystemSessionFilter.java
7:10 pm

Marcin Cieslak

LDEV-5200 Prevent invalidated session error from propagating

There seems to be a problem with Infinispan session invalidation similar

to this

https://issues.redhat.com/browse/UNDERTOW-478

We already have got a patched version, but similar problems occur. They

probably have to do with async servlet processing.

Until we upgrade WildFly we need to keep these safety measures.

Options
    • -1
    • +3
    ./session/SessionManager.java
    • -3
    • +21
    ./session/SystemSessionFilter.java
Thursday 24 Nov 2022
7:04 pm

Marcin Cieslak

LDEV-4408 Allow listing invalidated sessions

Options
    • -5
    • +13
    ./session/SessionManager.java
7:04 pm

Marcin Cieslak

LDEV-4408 Allow listing invalidated sessions

Options
    • -5
    • +13
    ./session/SessionManager.java
Monday 21 Nov 2022
10:30 pm

Marcin Cieslak

LDEV-5335 Fix audit logging when no user is authenticated

Options
    • -1
    • +1
    ./filter/AuditLogFilter.java
Saturday 22 Oct 2022
6:43 pm

Marcin Cieslak

LDEV-5335 Log adjustments and fixes

Options
    • -0
    • +5
    ./filter/AuditLogFilter.java
  2. … 8 more files in changeset.
Friday 14 Oct 2022
9:23 pm

Marcin Cieslak

LDEB-5335 Add structured audit logs on various admin actions

Options
    • -10
    • +71
    ./filter/AuditLogFilter.java
  2. … 22 more files in changeset.
Thursday 29 Sep 2022
1:33 am

Ernie Ghiglione

LDEV-5320 replace CR for values

As logs are parsed one line at the time, if some of these contain CRs, then these cannot be parsed properly and regexp for log monitors aren't triggered properly

Options
    • -2
    • +2
    ./filter/AuditLogFilter.java
Friday 02 Sep 2022
1:06 pm

Marcin Cieslak

Revert "LDEV-5320 Add LAMS instance information to audit logs"

This reverts commit 3db824f7e69ecba2b1e53b1060cf849cfe23ae9c.

Options
    • -7
    • +3
    ./filter/AuditLogFilter.java
Sunday 21 Aug 2022
5:37 pm

Marcin Cieslak

LDEV-5320 Add LAMS instance information to audit logs

Options
    • -3
    • +7
    ./filter/AuditLogFilter.java
Thursday 14 Jul 2022
9:50 pm

Marcin Cieslak

LDEV-5083 Prevent WF from freezing on shutdown because of unclosed Flux

Open Fluxes prevent WF from shutting down as they are threads not

managed by the server lifecycle.

Now we force complete Sinks on Spring context destroy. It closes

underlying Flux threads.

The problem is that it occurs when most Spring beans are already

destroyed. Fluxes on close want to emit a signal to front end

subscribers. Spring tries to reinitialise controllers which should send

those signals. It fails as context basically does not exist anymore.

All in all we get some harmless errors on server shutdown.

The way to avoid would be to have more control over Spring bean destroy

order which does not seem easily achievable.

Options
    • -0
    • +13
    ./filter/LamsContextLoaderListener.java
  2. … 3 more files in changeset.
Friday 08 Jul 2022
5:55 pm

Marcin Cieslak

LDEV-5320 Give more details about course roles being added and removed

This approach uses logs in controllers rather than in services.

Options
    • -36
    • +59
    ./filter/AuditLogFilter.java
  2. … 5 more files in changeset.
Tuesday 05 Jul 2022
5:09 pm

Marcin Cieslak

LDEV-5320 Rename security filter to audit filter

Options
    • -0
    • +80
    ./filter/AuditLogFilter.java
    • -80
    • +0
    ./filter/SecurityLogFilter.java
  3. … 3 more files in changeset.
Monday 04 Jul 2022
5:54 pm

Marcin Cieslak

LDEV-5320 Add security logger

It logs calls to Spring controllers in Admin module.

Options
    • -0
    • +80
    ./filter/SecurityLogFilter.java
  2. … 3 more files in changeset.
Friday 01 Apr 2022
7:02 pm

Marcin Cieslak

LDEV-5305 Discard changes made for Spring 4

For LAMS 4.7 which uses Spring 5 an upgrade to latest Spring version

will be sufficient.

Options
    • -29
    • +0
    ./filter/LamsAnnotationMethodHandlerAdapter.java
  2. … 11 more files in changeset.
6:46 pm

Marcin Cieslak

LDEV-5305 Add disallowed fields to every Spring binding

Options
    • -0
    • +29
    ./filter/LamsAnnotationMethodHandlerAdapter.java
  2. … 1 more file in changeset.
Tuesday 11 Jan 2022
7:24 pm

Marcin Cieslak

LDEV-4293 Skip session creation when displaying error page

If the error was HTTP session being stale or incorrectly invalidated, we

should not try to use the same session to display the error page. The

error page should not require a session at all.

Also if making a decision which session to invalidate in case of double

login, always invalidate the other session and not current one as

otherwise it can lead to a loop of self-invalidating sessions.

Options
    • -17
    • +6
    ./session/SessionManager.java
    • -1
    • +12
    ./session/SystemSessionFilter.java
  3. … 1 more file in changeset.
Tuesday 30 Nov 2021
5:18 am

Marcin Cieslak

LDEV-5259 Manually create parent application context

Previous attempt to reproduce BeanFactoryLocater was an overkill. A

simple singleton parent application context is sufficient.

Options
    • -24
    • +11
    ./filter/LamsContextLoaderListener.java
  2. … 45 more files in changeset.
Wednesday 24 Nov 2021
6:10 pm

Marcin Cieslak

LDEV-5259 Remove unnecessary util class

Options
    • -22
    • +0
    ./util/ApplicationContextUtil.java
Tuesday 23 Nov 2021
7:23 pm

Marcin Cieslak

LDEV-5259 Reintroduce BeanFactoryLocator mechanism back to LAMS

It was removed for Spring 5

Options
    • -0
    • +45
    ./filter/LamsContextLoaderListener.java
    • -0
    • +22
    ./util/ApplicationContextUtil.java
  3. … 57 more files in changeset.
Monday 18 Oct 2021
6:31 pm

Marcin Cieslak

LDEV-3656 Clean up invalidated session from internal tracking mapping

These session should have been removed from the mapping when

SessionListener is called. Sometimes the listener is not called due to

WildFly internal bugs. We are left with a long list of stale sessions.

We should periodically clean up the mapping. Making it happen on runtime

stats fetch is as place as any other, plus it happens periodically.

Options
    • -0
    • +14
    ./session/SessionManager.java
  2. … 1 more file in changeset.
Thursday 25 Mar 2021
1:43 am

Marcin Cieslak

LDEV-5142 Prevent an exception when returned launch date is null

Options
    • -2
    • +7
    ./controller/AbstractTimeLimitWebsocketServer.java