Clone
Tools

 

marcin cieślak <mgr.inz.marcin.cieslak@gmail.com> in lams-github

About

1,694 commits
  • Mapped user: Marcin Cieslak
  • First commit: 04 January 2020
  • Last commit: 16 January 2022
Last Week All Time
Commits: 0 1,694

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 
Sunday 16 Jan 2022
6:01 pm

Marcin Cieslak

LDEV-5277 Allow looking for lesson map via its ID for external modules

Options
    • -0
    • +2
    /lams_common/src/java/org/lamsfoundation/lams/integration/service/IIntegrationService.java
    • -1
    • +1
    /lams_common/src/java/org/lamsfoundation/lams/integration/service/IntegrationService.java
Saturday 15 Jan 2022
3:29 am

Marcin Cieslak

LDEV-5277 Allow LD tree to work with user without a session

Options
    • -0
    • +1
    /lams_central/web/WEB-INF/web.xml
    • -2
    • +2
    /lams_central/web/includes/javascript/learning-design-treeview.js
    • -8
    • +12
    /lams_central/web/includes/javascript/openUrls.js
Friday 14 Jan 2022
1:05 am

Marcin Cieslak

LDEV-5277 Confirm with user closing unsaved LD in LTI LAMS authoring

Also automatically refresh LTI content selection page on authoring close

Options
    • -0
    • +4
    /lams_central/web/authoring/authoring.jsp
    • -0
    • +17
    /lams_central/web/includes/javascript/authoring/authoringGeneral.js
    • -1
    • +2
    /lams_central/web/includes/javascript/learning-design-treeview.js
Tuesday 11 Jan 2022
7:24 pm

Marcin Cieslak

LDEV-4293 Skip session creation when displaying error page

If the error was HTTP session being stale or incorrectly invalidated, we

should not try to use the same session to display the error page. The

error page should not require a session at all.

Also if making a decision which session to invalidate in case of double

login, always invalidate the other session and not current one as

otherwise it can lead to a loop of self-invalidating sessions.

Options
    • -0
    • +1
    /lams_central/web/WEB-INF/web.xml
    • -17
    • +6
    /lams_common/src/java/org/lamsfoundation/lams/web/session/SessionManager.java
    • -1
    • +12
    /lams_common/src/java/org/lamsfoundation/lams/web/session/SystemSessionFilter.java
Saturday 23 Oct 2021
1:03 am

Marcin Cieslak

LDEV-5140 Add release marks code to cusomised Gradebook

Options
    • -99
    • +475
    /lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/service/GradebookService.java
    • -0
    • +13
    /lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/service/IGradebookFullService.java
    • -2
    • +9
    /lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/web/controller/GradebookMonitoringController.java
    • -1
    • +19
    /lams_gradebook/web/gradebookCourseMonitor.jsp
Friday 22 Oct 2021
11:54 pm

Marcin Cieslak

LDEV-5251 Add tooltip with list of students in answered questions chart

Options
    • -1
    • +1
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/dao/AssessmentResultDAO.java
    • -21
    • +22
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/dao/hibernate/AssessmentResultDAOHibernate.java
    • -4
    • +4
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java
    • -1
    • +1
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/service/IAssessmentService.java
    • -1
    • +4
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/controller/MonitoringController.java
    • -4
    • +69
    /lams_tool_assessment/web/includes/javascript/chart.js
    • -1
    • +2
    /lams_tool_assessment/web/pages/monitoring/monitoring.jsp
Thursday 21 Oct 2021
10:50 pm

Marcin Cieslak

Merge remote-tracking branch 'origin/v4.5' into LDEV-5250

Options
Wednesday 20 Oct 2021
3:43 pm

Marcin Cieslak

Merge branch 'v4.5' into LDEV-5250

Options
3:43 pm

Marcin Cieslak

LDEV-5200 Attempt to fix "large open gate" issue

A large icon sometimes gets displayed on first display of TBL monitor.

Options
    • -1
    • +1
    /lams_monitoring/web/includes/javascript/monitorLesson.js
3:07 pm

Marcin Cieslak

LDEV-4411 Add cache hits/misses per second

They are updated every 5 seconds.

Options
    • -0
    • +44
    /lams_central/src/java/org/lamsfoundation/lams/web/RuntimeStatsServlet.java
Monday 18 Oct 2021
10:42 pm

Marcin Cieslak

LDEV-4411 Allow Hibernate to choose fetch type by itself

Options
    • -5
    • +3
    /lams_common/src/java/org/lamsfoundation/lams/lesson/Lesson.java
10:42 pm

Marcin Cieslak

LDEV-4411 Make relation from Lesson to LessonClass unidirectional

Hibernate can not lazy load properties connected with OneToOne

relationship.

Options
    • -13
    • +6
    /lams_common/src/java/org/lamsfoundation/lams/lesson/LessonClass.java
    • -1
    • +0
    /lams_monitoring/src/java/org/lamsfoundation/lams/monitoring/service/MonitoringService.java
10:32 pm

Marcin Cieslak

LDEV-4411 Make relation from Evaluation to ToolActivity unidirectional

Hibernate can not lazy load properties connected with OneToOne

relationship. It means that with every fetch of ToolActivity its

ActivityEvaluation was also fetched, whether is was needed or not. It

made up even 10% of all queries sent to DB during a lesson.

By having the relationship unidirectional and fetching

ActivityEvaluation via DAO we ensure that it is fetched only when it is

needed. The code is not as nice, though.

Options
    • -59
    • +8
    /lams_central/src/java/org/lamsfoundation/lams/authoring/ObjectExtractor.java
    • -1
    • +6
    /lams_central/src/java/org/lamsfoundation/lams/authoring/service/AuthoringService.java
    • -9
    • +10
    /lams_central/src/java/org/lamsfoundation/lams/webservice/xml/LessonManagerServlet.java
    • -12
    • +10
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/ToolActivity.java
    • -2
    • +4
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/dao/IActivityDAO.java
    • -1
    • +7
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/dao/hibernate/ActivityDAO.java
    • -2
    • +4
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/dto/AuthoringActivityDTO.java
    • -3
    • +4
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/service/ExportToolContentService.java
    • -26
    • +32
    /lams_common/src/java/org/lamsfoundation/lams/tool/service/LamsCoreToolService.java
    • -4
    • +2
    /lams_common/src/java/org/lamsfoundation/lams/tool/service/LamsToolService.java
    • -1
    • +23
    /lams_common/src/java/org/lamsfoundation/lams/usermanagement/service/UserManagementService.java
    • -1
    • +3
    /lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/dto/GBActivityGridRowDTO.java
    • -16
    • +24
    /lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/service/GradebookService.java
    • -2
    • +7
    /lams_learning/src/java/org/lamsfoundation/lams/learning/service/LearnerService.java
10:29 pm

Marcin Cieslak

LDEV-4411 Do not cache native SQL queries as it causes exceptions

Options
    • -1
    • +1
    /lams_common/src/java/org/lamsfoundation/lams/security/SecurityDAO.java
6:32 pm

Marcin Cieslak

Merge branch 'v4.5' into LDEV-5250

Options
6:31 pm

Marcin Cieslak

LDEV-3656 Clean up invalidated session from internal tracking mapping

These session should have been removed from the mapping when

SessionListener is called. Sometimes the listener is not called due to

WildFly internal bugs. We are left with a long list of stale sessions.

We should periodically clean up the mapping. Making it happen on runtime

stats fetch is as place as any other, plus it happens periodically.

Options
    • -6
    • +0
    /lams_central/src/java/org/lamsfoundation/lams/web/SessionListener.java
    • -0
    • +14
    /lams_common/src/java/org/lamsfoundation/lams/web/session/SessionManager.java
Sunday 17 Oct 2021
11:46 pm

Marcin Cieslak

LDEV-4411 Remove FetchMode as it seems to trigger excessive queries

Options
    • -7
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/qb/model/QbQuestion.java
11:36 pm

Marcin Cieslak

LDEV-4411 Make cacheable queries for checking user roles

Options
    • -5
    • +5
    /lams_common/src/java/org/lamsfoundation/lams/security/SecurityDAO.java
    • -1
    • +1
    /lams_common/src/java/org/lamsfoundation/lams/usermanagement/service/UserManagementService.java
11:01 pm

Marcin Cieslak

LDEV-4411 Make Tool -> ExtServerToolAdapterMap collection lazy

Options
    • -2
    • +1
    /lams_common/src/java/org/lamsfoundation/lams/tool/Tool.java
10:53 pm

Marcin Cieslak

LDEV-5250 Remove Pedagogical Planner integration with core LAMS

Options
    • -12
    • +0
    /lams_central/src/java/org/lamsfoundation/lams/web/IndexController.java
    • -11
    • +0
    /lams_central/web/includes/javascript/ckconfig_custom.js
    • -17
    • +0
    /lams_central/web/includes/javascript/openUrls.js
    • -3
    • +0
    /lams_central/web/loadVars.jsp
    • -1
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/commonContext.xml
    • -0
    • +19
    /lams_common/src/java/org/lamsfoundation/lams/dbupdates/patch20211017.sql
    • -19
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/ToolActivity.java
    • -14
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/dto/AuthoringActivityDTO.java
    • -118
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/dto/PlannerActivityMetadataDTO.java
    • -11
    • +1
    /lams_common/src/java/org/lamsfoundation/lams/learningdesign/service/ExportToolContentService.java
    • -145
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/planner/PedagogicalPlannerActivityMetadata.java
    • -110
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/planner/PedagogicalPlannerActivitySpringForm.java
    • -11
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/tool/SystemTool.java
    • -15
    • +2
    /lams_common/src/java/org/lamsfoundation/lams/tool/Tool.java
    • -14
    • +0
    /lams_common/src/java/org/lamsfoundation/lams/usermanagement/User.java
  16. … 53 more files in changeset.
5:35 pm

Marcin Cieslak

LDEV-4078 Only sysadmin can change other users' passwords

Options
    • -12
    • +14
    /lams_admin/web/user.jsp
3:52 pm

Marcin Cieslak

LDEV-4367 Change Sass CLI parameter for newer version compability

Sass installed as Ruby gem is deprecated since March 2019. Newer

versions of Sass accept a slightly different parameter for sourcemap.

Options
    • -2
    • +2
    /lams_build/build_base.xml
Wednesday 13 Oct 2021
5:30 pm

Marcin Cieslak

LDEV-3555 Do not create LD thumbnail with incorrect read-only colouring

Options
    • -5
    • +13
    /lams_central/web/includes/javascript/authoring/authoringGeneral.js
Tuesday 12 Oct 2021
6:16 pm

Marcin Cieslak

Merge branch 'LDEV-5130' into v4.5

Options
6:16 pm

Marcin Cieslak

LDEV-4950 Remove obsolete ordering arrows in Scratchie authoring

Options
    • -12
    • +0
    /lams_tool_scratchie/web/pages/authoring/parts/itemlist.jsp
Monday 11 Oct 2021
11:28 pm

Marcin Cieslak

LDEV-4440 Reintroduce history-aware Cancel button on Edit User form

Options
    • -1
    • +1
    /lams_admin/web/user.jsp
11:21 pm

Marcin Cieslak

LDEV-4932 Add CSRF token to course manager organisation edit page

Options
    • -0
    • +1
    /lams_admin/web/organisation/courseAdminEdit.jsp
10:52 pm

Marcin Cieslak

LDEV-4540 Never copy Assessment question disclose status

Assessment questions can be disclosed on lesson level only. If they are

cloned or exported, their disclose status should be always the default,

i.e. not disclosed.

Options
    • -1
    • +2
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/model/AssessmentQuestion.java
    • -0
    • +3
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/service/AssessmentServiceImpl.java
Saturday 09 Oct 2021
10:00 pm

Marcin Cieslak

LDEV-5249 Add img-responsive class to images in CKEditor templates

Options
    • -5
    • +5
    /lams_www/web/public/ckeditor-templates/bootsnippets.js
    • -1
    • +1
    /lams_www/web/public/ckeditor-templates/htmltemplates.js
7:02 pm

Marcin Cieslak

LDEV-4411 Silence cache logs which flood LAMS log files

Options
    • -8
    • +12
    /lams_build/conf/slim/standalone.xml
    • -8
    • +12
    /lams_build/conf/standalone.xml