lams-github

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
LDEV-5397 add hidden labels for all links

Also some other minor fixes

LDEV-5397 spread change to LeaderDisplay.tag to all tools

  1. … 18 more files in changeset.
LDEV 5397 remove href="#nogo" and similar nonexistant same-page link

Due to screenreader requirements we can no longer use links having href="#target" when a page does not have this corresponding target. There are a couple of techniques instead of it:

1. links' onclick event should end with "return false;" ("false" can be replaced with anything else but true)

It applies to onclick events specified as tag attributes as well as added with Javascript or jQuery

2. turn links into <button type="button">

3. <a data-bs-toggle="collapse"> having href="#nogo" are OK. presumably as their onclick events return false;

LDEV-5397 improvements to Scratchie learner

LDEV-5397 migrate Scratchie tool to bootstrap 5

LDEV-5397 update to LeaderSelection bootstrap 5

LDEV-5407 Fix logo CSS

Merge branch 'LDEV-5407' into v4.7

LDEV-5407 Remove monitor link to return to index page for integrations

LDEV-5397 Introduce Notebook.tag

    • -0
    • +108
    /lams_admin/web/WEB-INF/tags/Notebook.tag
    • -193
    • +153
    /lams_admin/web/WEB-INF/tlds/lams/lams.tld
    • -0
    • +108
    /lams_central/web/WEB-INF/tags/Notebook.tag
    • -193
    • +153
    /lams_central/web/WEB-INF/tlds/lams/lams.tld
    • -0
    • +108
    /lams_gradebook/web/WEB-INF/tags/Notebook.tag
    • -193
    • +153
    /lams_gradebook/web/WEB-INF/tlds/lams/lams.tld
    • -0
    • +108
    /lams_learning/web/WEB-INF/tags/Notebook.tag
    • -193
    • +153
    /lams_learning/web/WEB-INF/tlds/lams/lams.tld
    • -0
    • +108
    /lams_monitoring/web/WEB-INF/tags/Notebook.tag
    • -0
    • +108
    /lams_tool_assessment/web/WEB-INF/tags/Notebook.tag
    • -0
    • +108
    /lams_tool_chat/web/WEB-INF/tags/Notebook.tag
    • -193
    • +153
    /lams_tool_chat/web/WEB-INF/tlds/lams/lams.tld
    • -0
    • +108
    /lams_tool_daco/web/WEB-INF/tags/Notebook.tag
  1. … 58 more files in changeset.
LDEV-5345 Adding and updating latest translations

  1. … 5 more files in changeset.
LDEV-5393 Make Peer Review discoverable by LTI Advantage grade transfer

The tool's max score has to be set.

LDEV-5404 Escaping funny characters that break js

- Notebook

    • -30
    • +31
    /lams_tool_notebook/web/WEB-INF/tags/AuthoringRatingAllStyleCriteria.tag
LDEV-5404 Escaping funny characters that break js

- Vote

    • -1
    • +2
    /lams_tool_vote/web/WEB-INF/tags/Page.tag
    • -1
    • +1
    /lams_tool_vote/web/common/taglibs.jsp
LDEV-5397 center leader alert

  1. … 18 more files in changeset.
LDEV-5397 further bootstrap 5 related changes

Also

* change bootstrap classes from col-*-offset-* to offset-*-

* deprecated form-group

* .hidden-xs to .d-none .d-sm-block

* .pull-left to .float-start

* .pull-right to .float-end

* add class="activity-bottom-buttons"

    • -7
    • +0
    /lams_central/web/css/_learner_base.scss
    • -91
    • +1
    /lams_central/web/css/components.scss
    • -1
    • +1
    /lams_learning/web/branching/preview.jsp
    • -1
    • +1
    /lams_tool_chat/web/pages/learning/learning.jsp
    • -1
    • +1
    /lams_tool_chat/web/pages/learning/notebook.jsp
  1. … 102 more files in changeset.
LDEV-5397 migrate LeaderSelection tool to bootstrap 5

LDEV-5397 reintroduce some older CSS rules to components.css

Also

* switch from .css to .scss

* update .ignore files

    • -68
    • +0
    /lams_central/web/css/_learner_base.scss
    • -1626
    • +0
    /lams_central/web/css/components.css
    • -0
    • +1744
    /lams_central/web/css/components.scss
    • -246
    • +0
    /lams_learning/web/css/components-learner.css
    • -0
    • +302
    /lams_learning/web/css/components-learner.scss
LDEV-5397 copy-tags across LAMS projects

    • -0
    • +48
    /lams_admin/web/WEB-INF/tags/Errors5.tag
    • -0
    • +48
    /lams_central/web/WEB-INF/tags/Errors5.tag
    • -0
    • +48
    /lams_gradebook/web/WEB-INF/tags/Errors5.tag
    • -0
    • +48
    /lams_learning/web/WEB-INF/tags/Errors5.tag
    • -0
    • +48
    /lams_monitoring/web/WEB-INF/tags/Errors5.tag
    • -0
    • +48
    /lams_tool_assessment/web/WEB-INF/tags/Errors5.tag
    • -0
    • +75
    /lams_tool_assessment/web/WEB-INF/tags/WaitForLeader.tag
    • -0
    • +48
    /lams_tool_chat/web/WEB-INF/tags/Errors5.tag
    • -0
    • +48
    /lams_tool_daco/web/WEB-INF/tags/Errors5.tag
    • -0
    • +48
    /lams_tool_doku/web/WEB-INF/tags/Errors5.tag
    • -0
    • +48
    /lams_tool_forum/web/WEB-INF/tags/Errors5.tag
    • -0
    • +48
    /lams_tool_gmap/web/WEB-INF/tags/Errors5.tag
    • -0
    • +48
    /lams_tool_images/web/WEB-INF/tags/Errors5.tag
    • -0
    • +48
    /lams_tool_imscc/web/WEB-INF/tags/Errors5.tag
    • -0
    • +48
    /lams_tool_lamc/web/WEB-INF/tags/Errors5.tag
  1. … 22 more files in changeset.
LDEV-5397 add missing function preventLearnerAutosaveFromMultipleTabs(autosaveInterval)

    • -0
    • +163
    /lams_admin/web/WEB-INF/tags/PageLearner.tag
    • -0
    • +163
    /lams_central/web/WEB-INF/tags/PageLearner.tag
    • -0
    • +163
    /lams_gradebook/web/WEB-INF/tags/PageLearner.tag
    • -0
    • +163
    /lams_learning/web/WEB-INF/tags/PageLearner.tag
    • -0
    • +163
    /lams_monitoring/web/WEB-INF/tags/PageLearner.tag
    • -0
    • +163
    /lams_tool_assessment/web/WEB-INF/tags/PageLearner.tag
    • -0
    • +163
    /lams_tool_chat/web/WEB-INF/tags/PageLearner.tag
    • -0
    • +163
    /lams_tool_daco/web/WEB-INF/tags/PageLearner.tag
    • -0
    • +163
    /lams_tool_doku/web/WEB-INF/tags/PageLearner.tag
    • -0
    • +163
    /lams_tool_forum/web/WEB-INF/tags/PageLearner.tag
    • -0
    • +163
    /lams_tool_gmap/web/WEB-INF/tags/PageLearner.tag
    • -0
    • +163
    /lams_tool_images/web/WEB-INF/tags/PageLearner.tag
    • -0
    • +163
    /lams_tool_imscc/web/WEB-INF/tags/PageLearner.tag
    • -0
    • +163
    /lams_tool_lamc/web/WEB-INF/tags/PageLearner.tag
    • -0
    • +13
    /lams_tool_laqa/web/WEB-INF/tags/PageLearner.tag
  1. … 18 more files in changeset.
LDEV-5397 migrate defineLater tag and jsps to bootstrap 5

    • -17
    • +12
    /lams_admin/web/WEB-INF/tags/DefineLater.tag
    • -17
    • +12
    /lams_central/web/WEB-INF/tags/DefineLater.tag
    • -17
    • +12
    /lams_gradebook/web/WEB-INF/tags/DefineLater.tag
    • -17
    • +12
    /lams_learning/web/WEB-INF/tags/DefineLater.tag
    • -17
    • +12
    /lams_monitoring/web/WEB-INF/tags/DefineLater.tag
    • -17
    • +12
    /lams_tool_chat/web/WEB-INF/tags/DefineLater.tag
    • -17
    • +12
    /lams_tool_daco/web/WEB-INF/tags/DefineLater.tag
    • -17
    • +12
    /lams_tool_doku/web/WEB-INF/tags/DefineLater.tag
    • -17
    • +12
    /lams_tool_forum/web/WEB-INF/tags/DefineLater.tag
    • -17
    • +12
    /lams_tool_gmap/web/WEB-INF/tags/DefineLater.tag
    • -17
    • +12
    /lams_tool_imscc/web/WEB-INF/tags/DefineLater.tag
    • -17
    • +12
    /lams_tool_lamc/web/WEB-INF/tags/DefineLater.tag
  1. … 28 more files in changeset.
LDEV-5397 Introduce WaitForLeader.tag

    • -0
    • +75
    /lams_admin/web/WEB-INF/tags/WaitForLeader.tag
    • -3
    • +15
    /lams_admin/web/WEB-INF/tlds/lams/lams.tld
    • -0
    • +75
    /lams_central/web/WEB-INF/tags/WaitForLeader.tag
    • -3
    • +15
    /lams_central/web/WEB-INF/tlds/lams/lams.tld
    • -0
    • +75
    /lams_gradebook/web/WEB-INF/tags/WaitForLeader.tag
    • -3
    • +15
    /lams_gradebook/web/WEB-INF/tlds/lams/lams.tld
    • -0
    • +75
    /lams_learning/web/WEB-INF/tags/WaitForLeader.tag
    • -3
    • +15
    /lams_learning/web/WEB-INF/tlds/lams/lams.tld
    • -0
    • +75
    /lams_monitoring/web/WEB-INF/tags/WaitForLeader.tag
    • -0
    • +75
    /lams_tool_chat/web/WEB-INF/tags/WaitForLeader.tag
    • -3
    • +15
    /lams_tool_chat/web/WEB-INF/tlds/lams/lams.tld
    • -0
    • +75
    /lams_tool_daco/web/WEB-INF/tags/WaitForLeader.tag
  1. … 54 more files in changeset.
Merge branch 'v4.7' of https://github.com/lamsfoundation/lams into v4.7

LDEV-5404 Escaping funny characters that break js

- Tasks

    • -1
    • +2
    /lams_tool_task/web/WEB-INF/tags/Page.tag
    • -1
    • +2
    /lams_tool_task/web/common/taglibs.jsp
    • -1
    • +1
    /lams_tool_task/web/pages/authoring/basic.jsp
    • -5
    • +3
    /lams_tool_task/web/pages/learning/learning.jsp
LDEV-5404 Escaping funny characters that break js

- Survey

    • -1
    • +2
    /lams_tool_survey/web/common/taglibs.jsp
LDEV-5400 Fix stale Hibernate session when fetching Flux data

LDEV-5404 Escaping funny characters that break js in tags

- LAMS Central

- LAMS Monitoring

- LAMS Learner

- Assessment

- Gradebook

- Peer Assessment

- Submit

- Scratchie

    • -1
    • +2
    /lams_central/web/WEB-INF/tags/Page.tag
    • -1
    • +2
    /lams_central/web/WEB-INF/tags/Page5.tag
    • -1
    • +2
    /lams_gradebook/web/WEB-INF/tags/Page.tag
  1. … 32 more files in changeset.
LDEV-5404 Escaping funny characters that break js

- Submit files

Note that we have to also do this for tags, something I didn't do before. So that's a pending task for all previously changed tools

    • -1
    • +1
    /lams_tool_sbmt/web/WEB-INF/tags/Page.tag
    • -0
    • +1
    /lams_tool_sbmt/web/common/taglibs.jsp
SP-9 Add learner view

SP-9 Add traffic lights indication to rating table cells.

Organise front end code.

    • -48
    • +48
    /lams_central/web/css/components.css