lams-github

Clone Tools

Stats

Commits this week: 0
Total Committers: 50
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 01 Jan 2020
2:35 am

Andrey Balan

LDEV-4932 Add CSRF to monitor and central

* Add CSRF protection to:

- Change lesson status (incl. remove)

- Remove lesson using main.jsp button

- Rename lesson

* Start using /common/taglibs.jsp in lams_central

Options
    • -0
    • +7
    /lams_central/conf/security/Owasp.CsrfGuard.properties
    • -5
    • +2
    /lams_central/web/addLesson.jsp
    • -6
    • +1
    /lams_central/web/admin.jsp
    • -7
    • +1
    /lams_central/web/authoringConfirm.jsp
    • -0
    • +8
    /lams_central/web/common/taglibs.jsp
    • -2
    • +1
    /lams_central/web/dialogCloser.jsp
    • -6
    • +1
    /lams_central/web/editLessonIntro.jsp
    • -5
    • +2
    /lams_central/web/error.jsp
    • -7
    • +2
    /lams_central/web/errorContent.jsp
    • -5
    • +1
    /lams_central/web/favoriteOrganisations.jsp
    • -7
    • +7
    /lams_central/web/includes/javascript/main.js
    • -5
    • +1
    /lams_central/web/index.jsp
    • -6
    • +4
    /lams_central/web/main.jsp
    • -8
    • +2
    /lams_central/web/outcome/outcomeEdit.jsp
    • -8
    • +3
    /lams_central/web/outcome/outcomeManage.jsp
  16. … 9 more files in changeset.
Tuesday 31 Dec 2019
11:25 am

Ernie Ghiglione

LDEV-4932 Add CSRF to central (outcomes)

Adding CSRF protection to:

- Delete outcomes

Options
    • -0
    • +1
    /lams_central/conf/security/Owasp.CsrfGuard.properties
    • -2
    • +2
    /lams_central/src/java/org/lamsfoundation/lams/web/outcome/OutcomeController.java
    • -2
    • +3
    /lams_central/web/includes/javascript/outcome.js
    • -4
    • +3
    /lams_central/web/outcome/outcomeManage.jsp
10:24 am

Ernie Ghiglione

LDEV-4932 Add CSRF for admin

- Adding CSRF to delete preview lessons

Options
    • -1
    • +1
    /lams_admin/web/cleanupPreviewLessons.jsp
    • -0
    • +1
    /lams_central/conf/security/Owasp.CsrfGuard.properties
10:06 am

Ernie Ghiglione

LDEV-4932 Adding CSRF protection to admin

- Adding user add/edit/remove/disable

Options
    • -7
    • +8
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/UserController.java
    • -1
    • +1
    /lams_admin/web/disabledusers.jsp
    • -8
    • +5
    /lams_admin/web/remove.jsp
    • -3
    • +3
    /lams_admin/web/user.jsp
    • -7
    • +3
    /lams_admin/web/usersearchlist.jsp
    • -0
    • +5
    /lams_central/conf/security/Owasp.CsrfGuard.properties
6:51 am

Andrey Balan

LDEV-4932 Secure gradebook calls with CSRF Guard

* Secure the following gradebook calls in particular:

- Release marks

- Any change in marks

- Export

* Add taglibs.jsp to gradebook project

Options
    • -0
    • +70
    /lams_gradebook/web/WEB-INF/tlds/security/csrfguard.tld
6:51 am

Andrey Balan

LDEV-4932 Secure gradebook calls with CSRF Guard

* Secure the following gradebook calls in particular:

- Release marks

- Any change in marks

- Export

* Add taglibs.jsp to gradebook project

Options
    • -0
    • +7
    /lams_central/conf/security/Owasp.CsrfGuard.properties
    • -1
    • +0
    /lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/web/controller/GradebookController.java
    • -75
    • +55
    /lams_gradebook/src/java/org/lamsfoundation/lams/gradebook/web/controller/GradebookMonitoringController.java
    • -3
    • +2
    /lams_gradebook/web/403.jsp
    • -3
    • +2
    /lams_gradebook/web/404.jsp
    • -0
    • +15
    /lams_gradebook/web/WEB-INF/web.xml
    • -0
    • +8
    /lams_gradebook/web/common/taglibs.jsp
    • -5
    • +2
    /lams_gradebook/web/error.jsp
    • -5
    • +2
    /lams_gradebook/web/errorContent.jsp
    • -5
    • +1
    /lams_gradebook/web/gradebookCourseLearner.jsp
    • -15
    • +10
    /lams_gradebook/web/gradebookCourseMonitor.jsp
    • -40
    • +51
    /lams_gradebook/web/gradebookMonitor.jsp
    • -2
    • +16
    /lams_gradebook/web/includes/javascript/blockexportbutton.js
    • -5
    • +2
    /lams_gradebook/web/msgContent.jsp
    • -1
    • +1
    /lams_tool_preview/src/java/org/lamsfoundation/lams/tool/peerreview/web/controller/AuthoringController.java
5:14 am

Andrey Balan

LDEV-4932 Secure save tool authoring with CSRF Guard

Options
    • -39
    • +64
    /lams_central/conf/security/Owasp.CsrfGuard.properties
    • -1
    • +1
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/controller/AuthoringController.java
    • -1
    • +2
    /lams_tool_assessment/web/pages/authoring/authoring.jsp
    • -1
    • +1
    /lams_tool_chat/src/java/org/lamsfoundation/lams/tool/chat/web/controller/AuthoringController.java
    • -2
    • +2
    /lams_tool_chat/web/pages/authoring/authoring.jsp
    • -10
    • +1
    /lams_tool_daco/src/java/org/lamsfoundation/lams/tool/daco/web/controller/AuthoringController.java
    • -2
    • +2
    /lams_tool_daco/web/pages/authoring/authoring.jsp
    • -11
    • +1
    /lams_tool_doku/src/java/org/lamsfoundation/lams/tool/dokumaran/web/controller/AuthoringController.java
    • -1
    • +2
    /lams_tool_doku/web/pages/authoring/authoring.jsp
    • -1
    • +2
    /lams_tool_images/web/pages/authoring/authoring.jsp
    • -10
    • +5
    /lams_tool_imscc/src/java/org/lamsfoundation/lams/tool/commonCartridge/web/controller/AuthoringController.java
    • -1
    • +2
    /lams_tool_imscc/web/pages/authoring/authoring.jsp
    • -1
    • +1
    /lams_tool_lamc/src/java/org/lamsfoundation/lams/tool/mc/web/controller/McController.java
    • -2
    • +2
    /lams_tool_lamc/web/authoring/AuthoringTabsHolder.jsp
    • -1
    • +1
    /lams_tool_laqa/src/java/org/lamsfoundation/lams/tool/qa/web/controller/QaAuthoringController.java
  16. … 28 more files in changeset.
12:34 am

Marcin Cieslak

Merge remote-tracking branch 'origin/develop' into LDEV-4745

Conflicts:

lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/service/IScratchieService.java

lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/service/ScratchieServiceImpl.java

Options
    • -10
    • +10
    /lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/service/IScratchieService.java
    • -11
    • +20
    /lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/service/ScratchieServiceImpl.java
    • -2
    • +10
    /lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/web/controller/LearningWebsocketServer.java
12:28 am

Marcin Cieslak

Merge remote-tracking branch 'origin/master' into develop

Options
12:07 am

Marcin Cieslak

Merge branch 'LDEV-4936'

Options
12:06 am

Marcin Cieslak

LDEV-4936 Fix layout for tool groups in sysadmin

Options
    • -5
    • +0
    /lams_admin/web/css/learningLibraryGroup.scss
    • -5
    • +2
    /lams_admin/web/includes/javascript/learningLibraryGroup.js
    • -0
    • +5
    /lams_admin/web/toolcontent/learningLibraryGroup.jsp
    • -34
    • +14
    /lams_admin/web/toolcontent/toolcontentlist.jsp
Monday 30 Dec 2019
10:44 pm

Ernie Ghiglione

LDEV-4932 Adding CSRF admin

Adding CSRF to delete session management

Options
    • -2
    • +2
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/SessionMaintainController.java
    • -4
    • +2
    /lams_admin/web/sessionmaintain.jsp
    • -0
    • +1
    /lams_central/conf/security/Owasp.CsrfGuard.properties
8:30 pm

Ernie Ghiglione

LDEV-4932 Adding CSRF to admin

Adding CSRF token:

- When adding/editing learning outcomes

- Adding/editing and removing themes

Options
    • -1
    • +2
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/ThemeManagementController.java
    • -3
    • +3
    /lams_admin/web/themeManagement.jsp
    • -0
    • +3
    /lams_central/conf/security/Owasp.CsrfGuard.properties
    • -2
    • +3
    /lams_central/src/java/org/lamsfoundation/lams/web/outcome/OutcomeController.java
    • -3
    • +4
    /lams_central/web/outcome/outcomeEdit.jsp
Sunday 29 Dec 2019
7:04 pm

Ernie Ghiglione

LDEV-4932 Adding CSRF Admin

Fixing policy management toggle. Adding enable/disable toggle for tool management

Options
    • -1
    • +2
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/PolicyManagementController.java
    • -3
    • +3
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/ToolContentListController.java
    • -3
    • +3
    /lams_admin/web/policies/policies.jsp
    • -9
    • +8
    /lams_admin/web/toolcontent/toolcontentlist.jsp
    • -0
    • +2
    /lams_central/conf/security/Owasp.CsrfGuard.properties
1:33 am

Ernie Ghiglione

LDEV-4931 Adding CSRF protection for LAMS Admin

Adding:

- Edit configuration

- Editing timezones

- Add/disable/enable/delete signup pages

- Add/disable/enable/delete integrated server

- Add/activate/deactivate policies

Options
    • -3
    • +4
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/ExtServerManagementController.java
    • -2
    • +2
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/LtiConsumerManagementController.java
    • -1
    • +2
    /lams_admin/src/java/org/lamsfoundation/lams/admin/web/controller/SignupManagementController.java
    • -0
    • +70
    /lams_admin/web/WEB-INF/tlds/security/csrfguard.tld
    • -4
    • +19
    /lams_admin/web/WEB-INF/web.xml
    • -2
    • +2
    /lams_admin/web/config/editconfig.jsp
    • -2
    • +2
    /lams_admin/web/integration/ltiConsumer.jsp
    • -10
    • +4
    /lams_admin/web/integration/ltiConsumerList.jsp
    • -4
    • +5
    /lams_admin/web/integration/serverlist.jsp
    • -3
    • +3
    /lams_admin/web/integration/servermaintain.jsp
    • -2
    • +2
    /lams_admin/web/loginmaintain.jsp
    • -3
    • +3
    /lams_admin/web/policies/editPolicy.jsp
    • -2
    • +2
    /lams_admin/web/signupmanagement/add.jsp
    • -3
    • +4
    /lams_admin/web/signupmanagement/list.jsp
    • -0
    • +1
    /lams_admin/web/taglibs.jsp
    • -2
    • +2
    /lams_admin/web/timezoneManagement.jsp
    • -0
    • +17
    /lams_central/conf/security/Owasp.CsrfGuard.properties
Saturday 28 Dec 2019
11:44 pm

Marcin Cieslak

Merge branch 'LDEV-4935'

Options
11:42 pm

Marcin Cieslak

LDEV-4935 Secure Scribe websockets

User gets checked if he participates in the given activity.

Options
    • -4
    • +11
    /lams_tool_scribe/src/java/org/lamsfoundation/lams/tool/scribe/web/controller/LearningWebsocketServer.java
11:42 pm

Marcin Cieslak

LDEV-4935 Secure Mindmap websockets

User gets checked if he participates in the given activity.

Options
    • -1
    • +2
    /lams_tool_mindmap/src/java/org/lamsfoundation/lams/tool/mindmap/service/IMindmapService.java
    • -16
    • +24
    /lams_tool_mindmap/src/java/org/lamsfoundation/lams/tool/mindmap/service/MindmapService.java
    • -3
    • +10
    /lams_tool_mindmap/src/java/org/lamsfoundation/lams/tool/mindmap/web/controller/LearningWebsocketServer.java
11:42 pm

Marcin Cieslak

LDEV-4935 Secure Scratchie websockets

User gets checked if he participates in the given activity.

Options
    • -3
    • +5
    /lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/dao/DAO.java
    • -25
    • +26
    /lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/service/IScratchieService.java
    • -19
    • +26
    /lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/service/ScratchieServiceImpl.java
    • -2
    • +10
    /lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/web/controller/LearningWebsocketServer.java
11:27 pm

Marcin Cieslak

LDEV-4935 Secure Leader Selection websockets

User gets checked if he participates in the given activity.

Options
    • -9
    • +6
    /lams_tool_leader/src/java/org/lamsfoundation/lams/tool/leaderselection/service/ILeaderselectionService.java
    • -7
    • +14
    /lams_tool_leader/src/java/org/lamsfoundation/lams/tool/leaderselection/service/LeaderselectionService.java
    • -3
    • +11
    /lams_tool_leader/src/java/org/lamsfoundation/lams/tool/leaderselection/web/controller/LearningWebsocketServer.java
11:18 pm

Marcin Cieslak

LDEV-4935 Secure Dokumaran websockets

User gets checked if he participates in the given activity.

Options
    • -4
    • +5
    /lams_tool_doku/src/java/org/lamsfoundation/lams/tool/dokumaran/dao/DAO.java
    • -2
    • +10
    /lams_tool_doku/src/java/org/lamsfoundation/lams/tool/dokumaran/service/DokumaranService.java
    • -28
    • +33
    /lams_tool_doku/src/java/org/lamsfoundation/lams/tool/dokumaran/service/IDokumaranService.java
    • -3
    • +11
    /lams_tool_doku/src/java/org/lamsfoundation/lams/tool/dokumaran/web/controller/LearningWebsocketServer.java
11:03 pm

Marcin Cieslak

LDEV-4935 Secure Chat (tool) websockets

User gets checked if he participates in the given activity.

Options
    • -4
    • +10
    /lams_tool_chat/src/java/org/lamsfoundation/lams/tool/chat/web/controller/LearningWebsocketServer.java
10:54 pm

Marcin Cieslak

LDEV-4935 Secure lesson chat (presence) websockets

Nickname is taken from session, not from incoming parameters. User gets

checked if he participates in the given lesson.

Simplified code, clean up.

Options
    • -69
    • +104
    /lams_learning/src/java/org/lamsfoundation/lams/learning/presence/PresenceWebsocketServer.java
    • -3
    • +3
    /lams_learning/src/java/org/lamsfoundation/lams/learning/presence/dao/IPresenceChatDAO.java
    • -5
    • +1
    /lams_learning/web/includes/javascript/presence.js
    • -2
    • +1
    /lams_learning/web/presenceChat.jsp
4:49 pm

Ernie Ghiglione

LDEV-4932 Adding CSRF to Assessment monitoring

Adding CSRF to:

- Change user marks

- Disclose correct answers

- Disclose group answers

Options
    • -0
    • +3
    /lams_central/conf/security/Owasp.CsrfGuard.properties
    • -3
    • +3
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/controller/MonitoringController.java
    • -1
    • +1
    /lams_tool_assessment/web/pages/monitoring/parts/questionsummary.jsp
    • -1
    • +1
    /lams_tool_assessment/web/pages/monitoring/parts/usersummary.jsp
    • -5
    • +9
    /lams_tool_assessment/web/pages/monitoring/summary.jsp
11:04 am

Ernie Ghiglione

LDEV-4932 Add CSRF to Scratchie monitoring

Adding CSRF for:

- Changing group marks

Options
    • -0
    • +1
    /lams_central/conf/security/Owasp.CsrfGuard.properties
    • -1
    • +1
    /lams_tool_scratchie/src/java/org/lamsfoundation/lams/tool/scratchie/web/controller/MonitoringController.java
    • -1
    • +1
    /lams_tool_scratchie/web/pages/monitoring/summary.jsp
10:08 am

Ernie Ghiglione

LDEV-4932 Add CSRF for Submit files monitoring

Adding:

- Update marks

- Release marks

- Download marks

Options
    • -0
    • +3
    /lams_central/conf/security/Owasp.CsrfGuard.properties
    • -1
    • +2
    /lams_tool_sbmt/src/java/org/lamsfoundation/lams/tool/sbmt/web/controller/MarkController.java
    • -3
    • +3
    /lams_tool_sbmt/src/java/org/lamsfoundation/lams/tool/sbmt/web/controller/MonitoringController.java
    • -3
    • +3
    /lams_tool_sbmt/web/monitoring/mark/updatemark.jsp
    • -2
    • +4
    /lams_tool_sbmt/web/monitoring/parts/summary.jsp
8:35 am

Ernie Ghiglione

LDEV-4932 Adding CSRF protecting to change scratchie user in monitor

Options
    • -0
    • +1
    /lams_central/conf/security/Owasp.CsrfGuard.properties
    • -1
    • +2
    /lams_tool_scribe/src/java/org/lamsfoundation/lams/tool/scribe/web/controller/MonitoringController.java
    • -1
    • +2
    /lams_tool_scribe/web/pages/monitoring/summary.jsp
3:24 am

Ernie Ghiglione

LDEV-4932 Adding CSRF protection to hide/show toggle open text submission for voting

Options
    • -0
    • +2
    /lams_central/conf/security/Owasp.CsrfGuard.properties
    • -15
    • +9
    /lams_tool_vote/web/monitoring/OtherTextNominationViewer.jsp
2:45 am

Andrey Balan

Merge branch 'LDEV-4932' of https://github.com/lamsfoundation/lams into LDEV-4932

# Conflicts:

# lams_central/conf/security/Owasp.CsrfGuard.properties

# lams_tool_larsrc/web/WEB-INF/web.xml

# lams_tool_leader/web/WEB-INF/web.xml

Options
    • -1
    • +9
    /lams_central/conf/security/Owasp.CsrfGuard.properties
    • -3
    • +11
    /lams_tool_larsrc/web/WEB-INF/web.xml
    • -1
    • +2
    /lams_tool_larsrc/web/common/taglibs.jsp
    • -3
    • +11
    /lams_tool_leader/web/WEB-INF/web.xml
    • -1
    • +2
    /lams_tool_leader/web/common/taglibs.jsp
2:23 am

Andrey Balan

LDEV-4932 Secure edit in monitor with CSRF Guard

* In order to secure /definelater.do path, added definelater() method to

AuthoringController to the tools missing it

* Remove unnecessary forms from monitor in Vote, NB, QA tools

Options
    • -0
    • +45
    /lams_central/conf/security/Owasp.CsrfGuard.properties
    • -1
    • +2
    /lams_tool_assessment/src/java/org/lamsfoundation/lams/tool/assessment/web/controller/AuthoringController.java
    • -13
    • +26
    /lams_tool_chat/src/java/org/lamsfoundation/lams/tool/chat/web/controller/AuthoringController.java
    • -5
    • +0
    /lams_tool_chat/src/java/org/lamsfoundation/lams/tool/chat/web/controller/MonitoringController.java
    • -7
    • +7
    /lams_tool_chat/web/pages/monitoring/editActivity.jsp
    • -1
    • +1
    /lams_tool_daco/src/java/org/lamsfoundation/lams/tool/daco/web/controller/AuthoringController.java
    • -0
    • +70
    /lams_tool_daco/web/WEB-INF/tlds/security/csrfguard.tld
    • -0
    • +15
    /lams_tool_daco/web/WEB-INF/web.xml
    • -0
    • +1
    /lams_tool_daco/web/common/taglibs.jsp
    • -5
    • +7
    /lams_tool_daco/web/pages/monitoring/editactivity.jsp
    • -1
    • +2
    /lams_tool_doku/src/java/org/lamsfoundation/lams/tool/dokumaran/web/controller/AuthoringController.java
    • -0
    • +70
    /lams_tool_doku/web/WEB-INF/tlds/security/csrfguard.tld
    • -0
    • +15
    /lams_tool_doku/web/WEB-INF/web.xml
    • -0
    • +1
    /lams_tool_doku/web/common/taglibs.jsp
    • -5
    • +7
    /lams_tool_doku/web/pages/monitoring/editactivity.jsp
  16. … 95 more files in changeset.