Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge remote-tracking branch 'origin/v4.7' into LDEV-5397

# Conflicts:

# lams_tool_sbmt/web/learner/sbmtlearner.jsp

  1. … 9 more files in changeset.
LDEV-5397 introduce submissionDeadline.tag

* switched to using this tag in all tools

* fixed a few existing issues with submissionDeadline feature in Vote and MCQ tools

  1. … 81 more files in changeset.
LDEV 5397 remove href="#nogo" and similar nonexistant same-page link

Due to screenreader requirements we can no longer use links having href="#target" when a page does not have this corresponding target. There are a couple of techniques instead of it:

1. links' onclick event should end with "return false;" ("false" can be replaced with anything else but true)

It applies to onclick events specified as tag attributes as well as added with Javascript or jQuery

2. turn links into <button type="button">

3. <a data-bs-toggle="collapse"> having href="#nogo" are OK. presumably as their onclick events return false;

  1. … 7 more files in changeset.
LDEV-5397 Introduce Notebook.tag

  1. … 72 more files in changeset.
LDEV-5397 further bootstrap 5 related changes

Also

* change bootstrap classes from col-*-offset-* to offset-*-

* deprecated form-group

* .hidden-xs to .d-none .d-sm-block

* .pull-left to .float-start

* .pull-right to .float-end

* add class="activity-bottom-buttons"

  1. … 115 more files in changeset.
LDEV-5397 migrate defineLater tag and jsps to bootstrap 5

  1. … 42 more files in changeset.
LDEV-5397 Introduce WaitForLeader.tag

  1. … 68 more files in changeset.
LDEV-5404 Escaping funny characters that break js

- Submit files

Note that we have to also do this for tags, something I didn't do before. So that's a pending task for all previously changed tools

  1. … 11 more files in changeset.
LDEV-5397 Improvements and fixes to Submit Files and Q&A tools

  1. … 7 more files in changeset.
LDEV-5397 accessibility improvements

LDEV-5397 Fixing rows as it is not longer needed in Bootstrap 5

LDEV-5397 Remove unused footer and patch up reflections

LDEV-5397 change container responsiveness to lg instead

LDEV-5397 Submit files definelater and minor adjustments.

  1. … 3 more files in changeset.
LDEV-5397 Fix notebook submit in Submit Files

LDEV-5397 Reverting to Marcin's toasts and some small alignments

LDEV-5397 Submit files adjust learner submit files list

  1. … 1 more file in changeset.
LDEV-5397 Redesigning Submit files learning UI

Still a fair amount to do. Must refactor sbmtlearner as it is very confusing now.

  1. … 3 more files in changeset.
LDEV-5397 Use rewritten alert (toast) and confirmation pop ups

  1. … 5 more files in changeset.
LDEV-5397 Fix Uppy and do adjustments to layout for Submit Files

  1. … 7 more files in changeset.
LDEV-5397 Submit Learner UI redesign

Implemented PageLearner tag, modify Alter.tag and basic functionality and warnings.

  1. … 4 more files in changeset.
LDEV-4917 Escape Uppy error message

Otherwise messages with apostrophe break file upload.

  1. … 7 more files in changeset.
Revert "LDEV-5357 Use UUIDs for file downloads"

This reverts commit 2de8f805211b6433aff4efd6fa9275a1b9933033.

  1. … 56 more files in changeset.
LDEV-5357 Use UUIDs for file downloads

  1. … 56 more files in changeset.
LDEV-5331 Add missing title and autocomplete attr to submission deadline

  1. … 18 more files in changeset.
LDEV-5298 Allow learners to continue if min uploaded files is not set

LDEV-5928 Allow learners to continue if min uploaded files is not set

LDEV-4440 Fix URL in Submit Files

LDEV-5298 Put upload form on top and uploaded file below

  1. … 1 more file in changeset.
LDEV-5298 Use Uppy with 300px height again so file names are visible