lams-github / lams_tool_sbmt

web

Clone Tools

Stats

Commits this week: 0
Total Committers: 25
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 18 Aug 2023
3:23 am

Andrey Balan

LDEV 5397 remove href="#nogo" and similar nonexistant same-page link

Due to screenreader requirements we can no longer use links having href="#target" when a page does not have this corresponding target. There are a couple of techniques instead of it:

1. links' onclick event should end with "return false;" ("false" can be replaced with anything else but true)

It applies to onclick events specified as tag attributes as well as added with Javascript or jQuery

2. turn links into <button type="button">

3. <a data-bs-toggle="collapse"> having href="#nogo" are OK. presumably as their onclick events return false;

Options
    • -2
    • +2
    ./learner/submissionDeadline.jsp
  2. … 7 more files in changeset.
Tuesday 15 Aug 2023
1:29 am

Andrey Balan

LDEV-5397 Introduce Notebook.tag

Options
    • -0
    • +108
    ./WEB-INF/tags/Notebook.tag
    • -193
    • +153
    ./WEB-INF/tlds/lams/lams.tld
    • -51
    • +9
    ./learner/notebook.jsp
  4. … 70 more files in changeset.
Sunday 13 Aug 2023
3:17 am

Andrey Balan

LDEV-5397 center leader alert

Options
    • -1
    • +1
    ./WEB-INF/tags/LeaderDisplay.tag
  2. … 32 more files in changeset.
12:36 am

Andrey Balan

LDEV-5397 further bootstrap 5 related changes

Also

* change bootstrap classes from col-*-offset-* to offset-*-

* deprecated form-group

* .hidden-xs to .d-none .d-sm-block

* .pull-left to .float-start

* .pull-right to .float-end

* add class="activity-bottom-buttons"

Options
    • -3
    • +1
    ./learner/notebook.jsp
    • -6
    • +4
    ./learner/submissionDeadline.jsp
    • -4
    • +4
    ./monitoring/mark/fileinfo.jsp
    • -1
    • +1
    ./monitoring/mark/filelist.jsp
  5. … 113 more files in changeset.
12:19 am

Andrey Balan

LDEV-5397 copy-tags across LAMS projects

Options
    • -2
    • +2
    ./WEB-INF/tags/Alert.tag
    • -6
    • +2
    ./WEB-INF/tags/Alert5.tag
  3. … 35 more files in changeset.
12:16 am

Andrey Balan

LDEV-5397 add missing function preventLearnerAutosaveFromMultipleTabs(autosaveInterval)

Options
    • -0
    • +13
    ./WEB-INF/tags/PageLearner.tag
  2. … 32 more files in changeset.
12:11 am

Andrey Balan

LDEV-5397 migrate defineLater tag and jsps to bootstrap 5

Options
    • -11
    • +12
    ./WEB-INF/tags/DefineLater.tag
    • -9
    • +2
    ./learner/definelater.jsp
  3. … 41 more files in changeset.
Saturday 12 Aug 2023
10:49 pm

Andrey Balan

LDEV-5397 Introduce WaitForLeader.tag

Options
    • -0
    • +75
    ./WEB-INF/tags/WaitForLeader.tag
    • -1
    • +5
    ./WEB-INF/tlds/lams/lams.tld
    • -51
    • +2
    ./learner/waitforleader.jsp
  4. … 66 more files in changeset.
6:44 pm

Ernie Ghiglione

LDEV-5404 Escaping funny characters that break js in tags

- LAMS Central

- LAMS Monitoring

- LAMS Learner

- Assessment

- Gradebook

- Peer Assessment

- Submit

- Scratchie

Options
    • -0
    • +1
    ./WEB-INF/tags/AuthoringButton.tag
    • -0
    • +1
    ./WEB-INF/tags/AuthoringRatingAllStyleCriteria.tag
    • -0
    • +1
    ./WEB-INF/tags/AuthoringRatingCriteria.tag
    • -0
    • +1
    ./WEB-INF/tags/Page.tag
    • -0
    • +1
    ./WEB-INF/tags/Page5.tag
  6. … 42 more files in changeset.
5:45 pm

Ernie Ghiglione

LDEV-5404 Escaping funny characters that break js

- Submit files

Note that we have to also do this for tags, something I didn't do before. So that's a pending task for all previously changed tools

Options
    • -1
    • +1
    ./WEB-INF/tags/AuthoringButton.tag
    • -30
    • +30
    ./WEB-INF/tags/AuthoringRatingAllStyleCriteria.tag
    • -4
    • +4
    ./WEB-INF/tags/AuthoringRatingCriteria.tag
    • -3
    • +4
    ./WEB-INF/tags/OutcomeAuthor.tag
    • -1
    • +1
    ./WEB-INF/tags/Page.tag
    • -1
    • +1
    ./WEB-INF/tags/Page5.tag
    • -0
    • +1
    ./common/taglibs.jsp
    • -10
    • +8
    ./learner/sbmtlearner.jsp
    • -2
    • +2
    ./monitoring/mark/allmarks.jsp
    • -2
    • +2
    ./monitoring/mark/mark.jsp
    • -3
    • +3
    ./monitoring/mark/updatemark.jsp
    • -11
    • +11
    ./monitoring/parts/summary.jsp
Monday 31 Jul 2023
12:18 pm

Marcin Cieslak

LDEV-5405 Make Popover tag work with Bootstrap both version 3 and 5

Options
    • -7
    • +7
    ./WEB-INF/tags/Popover.tag
  2. … 32 more files in changeset.
Sunday 16 Jul 2023
12:02 pm

Marcin Cieslak

Merge remote-tracking branch 'origin/LDEV-5391' into LDEV-5391

# Conflicts:

# idea_project/.idea/.name

# idea_project/.idea/runConfigurations/WildFly.xml

# lams_admin/web/WEB-INF/tags/Rating.tag

# lams_central/web/WEB-INF/tags/Rating.tag

# lams_gradebook/web/WEB-INF/tags/Rating.tag

# lams_learning/web/WEB-INF/tags/Rating.tag

# lams_monitoring/web/WEB-INF/tags/Rating.tag

# lams_tool_assessment/web/WEB-INF/tags/Rating.tag

# lams_tool_chat/web/WEB-INF/tags/Rating.tag

# lams_tool_daco/web/WEB-INF/tags/Rating.tag

# lams_tool_doku/web/WEB-INF/tags/Rating.tag

# lams_tool_doku/web/pages/authoring/advance.jsp

# lams_tool_doku/web/pages/learning/galleryWalk.jsp

# lams_tool_forum/web/WEB-INF/tags/Rating.tag

# lams_tool_gmap/web/WEB-INF/tags/Rating.tag

# lams_tool_images/web/WEB-INF/tags/Rating.tag

# lams_tool_imscc/web/WEB-INF/tags/Rating.tag

# lams_tool_lamc/web/WEB-INF/tags/Rating.tag

# lams_tool_laqa/web/WEB-INF/tags/Rating.tag

# lams_tool_larsrc/web/WEB-INF/tags/Rating.tag

# lams_tool_leader/web/WEB-INF/tags/Rating.tag

# lams_tool_mindmap/web/WEB-INF/tags/Rating.tag

# lams_tool_nb/web/WEB-INF/tags/Rating.tag

# lams_tool_notebook/web/WEB-INF/tags/Rating.tag

# lams_tool_pixlr/web/WEB-INF/tags/Rating.tag

# lams_tool_preview/.classpath

# lams_tool_preview/web/WEB-INF/tags/Rating.tag

# lams_tool_preview/web/WEB-INF/tags/StyledRating.tag

# lams_tool_sbmt/web/WEB-INF/tags/Rating.tag

# lams_tool_scratchie/web/WEB-INF/tags/Rating.tag

# lams_tool_scribe/web/WEB-INF/tags/Rating.tag

# lams_tool_spreadsheet/web/WEB-INF/tags/Rating.tag

# lams_tool_survey/web/WEB-INF/tags/Rating.tag

# lams_tool_task/web/WEB-INF/tags/Rating.tag

# lams_tool_vote/web/WEB-INF/tags/Rating.tag

# lams_tool_whiteboard/web/WEB-INF/tags/Rating.tag

# lams_tool_wiki/web/WEB-INF/tags/Rating.tag

# lams_tool_zoom/web/WEB-INF/tags/Rating.tag

# lams_www/web/WEB-INF/tags/Rating.tag

Options
    • -7
    • +11
    ./WEB-INF/tags/Rating.tag
  2. … 38 more files in changeset.
Tuesday 11 Jul 2023
8:18 am

Marcin Cieslak

LDEV-5213 Use version-dependent imports for LAMS JS files

Options
    • -1
    • +1
    ./WEB-INF/tags/AuthoringButton.tag
    • -1
    • +1
    ./WEB-INF/tags/Etherpad.tag
    • -2
    • +2
    ./WEB-INF/tags/Page.tag
    • -2
    • +2
    ./WEB-INF/tags/Page5.tag
    • -2
    • +2
    ./WEB-INF/tags/headItems.tag
    • -4
    • +2
    ./common/header.jsp
    • -2
    • +2
    ./monitoring/mark/allmarks.jsp
    • -1
    • +1
    ./monitoring/mark/mark.jsp
    • -3
    • +3
    ./monitoring/mark/updatemark.jsp
    • -1
    • +1
    ./monitoring/monitoring.jsp
  11. … 329 more files in changeset.
Monday 12 Jun 2023
7:19 am

Marcin Cieslak

LDEV-5397 Improvements and fixes to Submit Files and Q&A tools

Options
    • -163
    • +160
    ./learner/sbmtlearner.jsp
  2. … 7 more files in changeset.
Wednesday 07 Jun 2023
5:15 am

Ernie Ghiglione

LDEV-5397 accessibility improvements

Options
    • -6
    • +6
    ./learner/sbmtlearner.jsp
Sunday 04 Jun 2023
10:07 pm

Ernie Ghiglione

LDEV-5397 Fixing rows as it is not longer needed in Bootstrap 5

Options
    • -8
    • +5
    ./learner/definelater.jsp
    • -31
    • +25
    ./learner/notebook.jsp
    • -66
    • +69
    ./learner/sbmtlearner.jsp
    • -1
    • +0
    ./learner/submissionDeadline.jsp
    • -34
    • +28
    ./learner/waitforleader.jsp
Saturday 03 Jun 2023
2:33 pm

Ernie Ghiglione

LDEV-5397 Remove unused footer and patch up reflections

Options
    • -3
    • +0
    ./learner/notebook.jsp
    • -6
    • +6
    ./learner/sbmtlearner.jsp
    • -2
    • +0
    ./learner/submissionDeadline.jsp
2:22 pm

Ernie Ghiglione

LDEV-5397 change container responsiveness to lg instead

Options
    • -1
    • +1
    ./learner/notebook.jsp
2:20 pm

Ernie Ghiglione

LDEV-5397 Submit files definelater and minor adjustments.

Options
    • -13
    • +7
    ./WEB-INF/tags/DefineLater.tag
    • -23
    • +17
    ./learner/definelater.jsp
    • -2
    • +2
    ./learner/sbmtlearner.jsp
    • -1
    • +1
    ./learner/submissionDeadline.jsp
    • -1
    • +1
    ./learner/waitforleader.jsp
  6. … 2 more files in changeset.
Thursday 01 Jun 2023
9:44 pm

Marcin Cieslak

LDEV-5397 Fix notebook submit in Submit Files

Options
    • -33
    • +34
    ./learner/notebook.jsp
8:55 pm

Marcin Cieslak

LDEV-4913 Fix minimum uploads setting

Options
    • -28
    • +28
    ./authoring/advance.jsp
  2. … 2 more files in changeset.
8:36 pm

Ernie Ghiglione

LDEV-5397 Reverting to Marcin's toasts and some small alignments

Options
    • -23
    • +27
    ./learner/sbmtlearner.jsp
3:38 pm

Ernie Ghiglione

LDEV-5397 Submit files adjust learner submit files list

Options
    • -66
    • +60
    ./learner/sbmtlearner.jsp
  2. … 1 more file in changeset.
1:51 am

Ernie Ghiglione

LDEV-5397 Redesigning Submit files learning UI

Still a fair amount to do. Must refactor sbmtlearner as it is very confusing now.

Options
    • -0
    • +48
    ./WEB-INF/tags/Errors5.tag
    • -1
    • +5
    ./WEB-INF/tlds/lams/lams.tld
    • -52
    • +47
    ./learner/notebook.jsp
    • -14
    • +7
    ./learner/redirectAfterSubmit.jsp
    • -314
    • +343
    ./learner/sbmtlearner.jsp
    • -47
    • +36
    ./learner/submissionDeadline.jsp
    • -56
    • +47
    ./learner/waitforleader.jsp
  8. … 1 more file in changeset.
Wednesday 31 May 2023
11:05 pm

Ernie Ghiglione

LDEV-5397 Set appropriate aria-hidden as logo is a link

Options
    • -1
    • +1
    ./WEB-INF/tags/PageLearner.tag
9:08 pm

Marcin Cieslak

LDEV-5397 Use rewritten alert (toast) and confirmation pop ups

Options
    • -0
    • +24
    ./WEB-INF/tags/PageLearner.tag
    • -16
    • +16
    ./learner/sbmtlearner.jsp
  3. … 4 more files in changeset.
Tuesday 30 May 2023
9:21 am

Marcin Cieslak

LDEV-5397 Fix Uppy and do adjustments to layout for Submit Files

Options
    • -13
    • +14
    ./WEB-INF/tags/Alert.tag
    • -2
    • +6
    ./WEB-INF/tags/Alert5.tag
    • -1
    • +3
    ./WEB-INF/tags/PageLearner.tag
    • -3
    • +2
    ./common/header.jsp
    • -227
    • +231
    ./learner/sbmtlearner.jsp
  6. … 3 more files in changeset.
Monday 29 May 2023
11:01 pm

Ernie Ghiglione

LDEV-5397 Submit Learner UI redesign

Implemented PageLearner tag, modify Alter.tag and basic functionality and warnings.

Options
    • -13
    • +12
    ./WEB-INF/tags/Alert.tag
    • -0
    • +124
    ./WEB-INF/tags/PageLearner.tag
    • -1
    • +5
    ./WEB-INF/tlds/lams/lams.tld
    • -2
    • +1
    ./common/header.jsp
    • -52
    • +43
    ./learner/sbmtlearner.jsp
11:24 am

Marcin Cieslak

LDEV-5369 Fix Peer Review pivot rubrics results ordering

Options
    • -4
    • +3
    ./WEB-INF/tags/StyledRating.tag
  2. … 32 more files in changeset.
Thursday 25 May 2023
8:32 pm

Marcin Cieslak

LDEV-5369 Fix Peer Review pivot rubrics results ordering

Options
    • -412
    • +513
    ./WEB-INF/tags/StyledRating.tag
  2. … 32 more files in changeset.